144144 2015-04-24 02:49:00 -0700 [CSS Grid Layout] LayoutBox::hasDefiniteLogicalHeight() should consider abspos boxes as definite 2015-04-26 22:41:14 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego commit-queue esprehn+autocc glenn jfernandez kondapallykalyan svillar oldest_to_newest 1088208 0 rego 2015-04-24 02:49:00 -0700 Per spec (http://dev.w3.org/csswg/css-sizing-3/#definite): "Additionally, the size of the containing block of an absolutely positioned element is always definite with respect to that element." If height is auto, we're ignoring this condition. Related Blink issue (where this was detected on flexbox first): https://codereview.chromium.org/1081433005/ 1088209 1 251545 rego 2015-04-24 02:59:52 -0700 Created attachment 251545 Patch 1088940 2 251545 commit-queue 2015-04-26 22:41:09 -0700 Comment on attachment 251545 Patch Clearing flags on attachment: 251545 Committed r183385: <http://trac.webkit.org/changeset/183385> 1088941 3 commit-queue 2015-04-26 22:41:14 -0700 All reviewed patches have been landed. Closing bug. 251545 2015-04-24 02:59:52 -0700 2015-04-26 22:41:09 -0700 Patch bug-144144-20150424115846.patch text/plain 5397 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTgzMjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjA3ODE3YWQ1ZGVkN2Iw YTBjOGEwNzcwNDFlMjcyZTBmNjRlYTc0NC4uMGI4ODk5NGJmODI0ODUzMWExZWE1MDI5NDcxNTJl NWZhNGM1YWU4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTA0LTI0ICBNYW51 ZWwgUmVnbyBDYXNhc25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3Jp ZCBMYXlvdXRdIExheW91dEJveDo6aGFzRGVmaW5pdGVMb2dpY2FsSGVpZ2h0KCkgc2hvdWxkIGNv bnNpZGVyIGFic3BvcyBib3hlcyBhcyBkZWZpbml0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQ0MTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlIG9yZGVyIGluIGhhc0RlZmluaXRlTG9naWNh bEhlaWdodCgpIGlmcyB0byBjb25zaWRlciBkZWZpbml0ZQorICAgICAgICBhYnNvbHV0ZWx5IHBv c2l0aW9uZWQgZWxlbWVudHMuCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MtZ3JpZC1sYXlvdXQv cGVyY2VudC10cmFjay1icmVhZHRocy1yZWdhcmRpbmctY29udGFpbmVyLXNpemUuaHRtbAorCisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJCb3g6Omhhc0RlZmluaXRlTG9naWNhbEhlaWdodCk6CisKIDIwMTUtMDQtMjQgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTT1VQXSBVc2Ug YSB3ZWJraXQgc3ViZGlyZWN0b3J5IGZvciB0aGUgZGlzayBjYWNoZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCA3MDM4ZDcwZThlMTE4OWI3M2RjMzE2ZjIwMzEwYThk Zjk5NTRiZDFhLi40MjUyYzkxZDY5OGJkMjUzNzcwNWZiZjQwODA3NzczMmNmYzM3ODE5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAtNDU0Miw4ICs0NTQyLDYgQEAg Ym9vbCBSZW5kZXJCb3g6OnBlcmNlbnRhZ2VMb2dpY2FsSGVpZ2h0SXNSZXNvbHZhYmxlRnJvbUJs b2NrKGNvbnN0IFJlbmRlckJsb2NrKgogYm9vbCBSZW5kZXJCb3g6Omhhc0RlZmluaXRlTG9naWNh bEhlaWdodCgpIGNvbnN0CiB7CiAgICAgY29uc3QgTGVuZ3RoJiBsb2dpY2FsSGVpZ2h0ID0gc3R5 bGUoKS5sb2dpY2FsSGVpZ2h0KCk7Ci0gICAgaWYgKGxvZ2ljYWxIZWlnaHQuaXNJbnRyaW5zaWNP ckF1dG8oKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmIChsb2dpY2FsSGVpZ2h0Lmlz Rml4ZWQoKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgLy8gVGhlIHNpemUgb2YgdGhlIGNv bnRhaW5pbmcgYmxvY2sgb2YgYW4gYWJzb2x1dGVseSBwb3NpdGlvbmVkIGVsZW1lbnQgaXMgYWx3 YXlzIGRlZmluaXRlIHdpdGggcmVzcGVjdCB0byB0aGF0CkBAIC00NTU0LDYgKzQ1NTIsOCBAQCBi b29sIFJlbmRlckJveDo6aGFzRGVmaW5pdGVMb2dpY2FsSGVpZ2h0KCkgY29uc3QKICAgICBpZiAo aGFzT3ZlcnJpZGVDb250YWluaW5nQmxvY2tMb2dpY2FsSGVpZ2h0KCkpCiAgICAgICAgIHJldHVy biBvdmVycmlkZUNvbnRhaW5pbmdCbG9ja0NvbnRlbnRMb2dpY2FsSGVpZ2h0KCkgIT0gLTE7CiAj ZW5kaWYKKyAgICBpZiAobG9naWNhbEhlaWdodC5pc0ludHJpbnNpY09yQXV0bygpKQorICAgICAg ICByZXR1cm4gZmFsc2U7CiAKICAgICByZXR1cm4gcGVyY2VudGFnZUxvZ2ljYWxIZWlnaHRJc1Jl c29sdmFibGUodGhpcyk7CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjJkYTJhNjhmOGQ2MzJhZDA0YWE4MTllODdiNGQ1 NTA0ZDE1MDI2Ni4uMzM4MzJhZDI5N2ZhMGE4ZTRlMmU4OWFiNjk3MjU1YjBiOGJkZDQ4MiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTI0ICBNYW51ZWwgUmVnbyBDYXNhc25vdmFzICA8 cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIExheW91dEJveDo6 aGFzRGVmaW5pdGVMb2dpY2FsSGVpZ2h0KCkgc2hvdWxkIGNvbnNpZGVyIGFic3BvcyBib3hlcyBh cyBkZWZpbml0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ0MTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIG5ldyB0ZXN0IGNhc2UgdG8gY2hlY2sgYWJzb2x1dGVseSBwb3NpdGlvbmVkIGVsZW1l bnRzLgorCisgICAgICAgICogZmFzdC9jc3MtZ3JpZC1sYXlvdXQvcGVyY2VudC10cmFjay1icmVh ZHRocy1yZWdhcmRpbmctY29udGFpbmVyLXNpemUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZh c3QvY3NzLWdyaWQtbGF5b3V0L3BlcmNlbnQtdHJhY2stYnJlYWR0aHMtcmVnYXJkaW5nLWNvbnRh aW5lci1zaXplLmh0bWw6CisKIDIwMTUtMDQtMjMgIEJhc2lsZSBDbGVtZW50ICA8YmFzaWxlX2Ns ZW1lbnRAYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IGZ1bmN0aW9uIGFsbG9jYXRpb24gc2lu a2luZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvcGVyY2Vu dC10cmFjay1icmVhZHRocy1yZWdhcmRpbmctY29udGFpbmVyLXNpemUtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvcGVyY2VudC10cmFjay1icmVhZHRocy1y ZWdhcmRpbmctY29udGFpbmVyLXNpemUtZXhwZWN0ZWQudHh0CmluZGV4IDU4OTgyZmQ3OTIzOTBj NjhhNTUxNzQzM2E4NDI1MmU3MzExMmUxMGIuLjI5NDU5ZWJiYzI4NmQ5ZDQ4YWU0MGNlYWJhM2Ez ZTVkMGJiYTgxYjMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0 L3BlcmNlbnQtdHJhY2stYnJlYWR0aHMtcmVnYXJkaW5nLWNvbnRhaW5lci1zaXplLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9wZXJjZW50LXRyYWNr LWJyZWFkdGhzLXJlZ2FyZGluZy1jb250YWluZXItc2l6ZS1leHBlY3RlZC50eHQKQEAgLTQwLDMg KzQwLDExIEBAIFhYCiBYWFhYWAogWFhYCiBQQVNTCitYWAorWFhYWFgKK1hYWAorUEFTUworWFgK K1hYWFhYCitYWFgKK1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQt bGF5b3V0L3BlcmNlbnQtdHJhY2stYnJlYWR0aHMtcmVnYXJkaW5nLWNvbnRhaW5lci1zaXplLmh0 bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9wZXJjZW50LXRyYWNrLWJyZWFk dGhzLXJlZ2FyZGluZy1jb250YWluZXItc2l6ZS5odG1sCmluZGV4IDllYmY0NTcwZjA2MjllZmQ3 NjZlNDlkOTNiOWVjMzk4NTEyZDE4MjMuLjRkZjdhNjVjMTAxNjEwM2E1NmZlMTNhYzlhMTllMGVk ZDJlNWEwODkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L3Bl cmNlbnQtdHJhY2stYnJlYWR0aHMtcmVnYXJkaW5nLWNvbnRhaW5lci1zaXplLmh0bWwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvcGVyY2VudC10cmFjay1icmVhZHRocy1y ZWdhcmRpbmctY29udGFpbmVyLXNpemUuaHRtbApAQCAtMjMsNiArMjMsMTAgQEAKICAgICBoZWln aHQ6IDUwJTsKIH0KIAorLmFic29sdXRlbHlQb3NpdGlvbmVkIHsKKyAgICBwb3NpdGlvbjogYWJz b2x1dGU7Cit9CisKIC5pbmRlZmluaXRlU2l6ZSB7CiAgICAgd2lkdGg6IC13ZWJraXQtZml0LWNv bnRlbnQ7CiAgICAgaGVpZ2h0OiBhdXRvOwpAQCAtMTE0LDYgKzExOCwyMiBAQAogICAgIDwvZGl2 PgogCiAgICAgPGRpdiBjbGFzcz0iaW5kZWZpbml0ZVNpemUiPgorICAgICAgICA8ZGl2IGNsYXNz PSJncmlkIGFic29sdXRlbHlQb3NpdGlvbmVkIj4KKyAgICAgICAgICAgIDxkaXYgY2xhc3M9ImZp cnN0Um93Rmlyc3RDb2x1bW4gc2l6ZWRUb0dyaWRBcmVhIiBkYXRhLWV4cGVjdGVkLXdpZHRoPSIw IiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iMCI+WFg8L2Rpdj4KKyAgICAgICAgICAgIDxkaXYgY2xh c3M9ImZpcnN0Um93U2Vjb25kQ29sdW1uIHNpemVkVG9HcmlkQXJlYSIgZGF0YS1leHBlY3RlZC13 aWR0aD0iMCIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjAiPlhYWFhYPC9kaXY+CisgICAgICAgICAg ICA8ZGl2IGNsYXNzPSJmaXJzdFJvd1RoaXJkQ29sdW1uIHNpemVkVG9HcmlkQXJlYSIgZGF0YS1l eHBlY3RlZC13aWR0aD0iMCIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9IjAiPlhYWDwvZGl2PgorICAg ICAgICA8L2Rpdj4KKyAgICA8L2Rpdj4KKworICAgIDxkaXYgY2xhc3M9InVuY29uc3RyYWluZWRD b250YWluZXIiPgorICAgICAgICA8ZGl2IGNsYXNzPSJncmlkIGFic29sdXRlbHlQb3NpdGlvbmVk Ij4KKyAgICAgICAgICAgIDxkaXYgY2xhc3M9ImZpcnN0Um93Rmlyc3RDb2x1bW4gc2l6ZWRUb0dy aWRBcmVhIiBkYXRhLWV4cGVjdGVkLXdpZHRoPSIwIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0iMCI+ WFg8L2Rpdj4KKyAgICAgICAgICAgIDxkaXYgY2xhc3M9ImZpcnN0Um93U2Vjb25kQ29sdW1uIHNp emVkVG9HcmlkQXJlYSIgZGF0YS1leHBlY3RlZC13aWR0aD0iMCIgZGF0YS1leHBlY3RlZC1oZWln aHQ9IjAiPlhYWFhYPC9kaXY+CisgICAgICAgICAgICA8ZGl2IGNsYXNzPSJmaXJzdFJvd1RoaXJk Q29sdW1uIHNpemVkVG9HcmlkQXJlYSIgZGF0YS1leHBlY3RlZC13aWR0aD0iMCIgZGF0YS1leHBl Y3RlZC1oZWlnaHQ9IjAiPlhYWDwvZGl2PgorICAgICAgICA8L2Rpdj4KKyAgICA8L2Rpdj4KKwor ICAgIDxkaXYgY2xhc3M9ImluZGVmaW5pdGVTaXplIj4KICAgICAgICAgPGRpdiBjbGFzcz0iZ3Jp ZCBpbmRlZmluaXRlU2l6ZSI+CiAgICAgICAgICAgICA8ZGl2IGNsYXNzPSJmaXJzdFJvd0ZpcnN0 Q29sdW1uIHNpemVkVG9HcmlkQXJlYSIgZGF0YS1leHBlY3RlZC13aWR0aD0iMjAiIGRhdGEtZXhw ZWN0ZWQtaGVpZ2h0PSIxMCI+WFg8L2Rpdj4KICAgICAgICAgICAgIDxkaXYgY2xhc3M9ImZpcnN0 Um93U2Vjb25kQ29sdW1uIHNpemVkVG9HcmlkQXJlYSIgZGF0YS1leHBlY3RlZC13aWR0aD0iNTAi IGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PSIxMCI+WFhYWFg8L2Rpdj4K