<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>143907</bug_id>
          
          <creation_ts>2015-04-17 16:51:53 -0700</creation_ts>
          <short_desc>[GTK] Miscellaneous changes for msys/mingw</short_desc>
          <delta_ts>2015-05-19 01:00:45 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>420+</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>133028</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Milan Crha">mcrha</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1086489</commentid>
    <comment_count>0</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2015-04-17 16:51:53 -0700</bug_when>
    <thetext>These are the last miscellaneous changes for webkit-2.4 branch at revision 182543 I use to be able to build it in msys/mingw.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1086490</commentid>
    <comment_count>1</comment_count>
      <attachid>251073</attachid>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2015-04-17 16:54:09 -0700</bug_when>
    <thetext>Created attachment 251073
proposed wk patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095867</commentid>
    <comment_count>2</comment_count>
      <attachid>251073</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-19 00:31:10 -0700</bug_when>
    <thetext>Comment on attachment 251073
proposed wk patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251073&amp;action=review

&gt; Source/WTF/wtf/Platform.h:-615
&gt; -#include &lt;WTF/WTFHeaderDetection.h&gt;
&gt; -

What&apos;s wrong with this? I think I&apos;ve already merged the other changes as part of other commits</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095868</commentid>
    <comment_count>3</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2015-05-19 00:42:21 -0700</bug_when>
    <thetext>The #include &lt;WTF/WTFHeaderDetection.h&gt; file doesn&apos;t exists with mingw/msys builds.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095870</commentid>
    <comment_count>4</comment_count>
      <attachid>251073</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-19 00:57:52 -0700</bug_when>
    <thetext>Comment on attachment 251073
proposed wk patch

View in context: https://bugs.webkit.org/attachment.cgi?id=251073&amp;action=review

I&apos;ll merge only the autogenerated header part.

&gt;&gt; Source/WTF/wtf/Platform.h:-615
&gt;&gt; -#include &lt;WTF/WTFHeaderDetection.h&gt;
&gt;&gt; -
&gt; 
&gt; What&apos;s wrong with this? I think I&apos;ve already merged the other changes as part of other commits

Ok, this is an autogenerated header, that we don&apos;t generate, so this is valid for 2.4 branch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1095871</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2015-05-19 01:00:45 -0700</bug_when>
    <thetext>Committed to 2.4 http://trac.webkit.org/changeset/184557</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>251073</attachid>
            <date>2015-04-17 16:54:09 -0700</date>
            <delta_ts>2015-05-19 00:57:52 -0700</delta_ts>
            <desc>proposed wk patch</desc>
            <filename>wk.patch</filename>
            <type>text/plain</type>
            <size>3143</size>
            <attacher name="Milan Crha">mcrha</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAxODI5NzcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTA0LTE3ICBNaWxhbiBDcmhhICA8bWNyaGFA
cmVkaGF0LmNvbT4KKworICAgICAgICBbR1RLXSBNaXNjZWxsYW5lb3VzIGNoYW5nZXMgZm9yIG1z
eXMvbWluZ3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTE0MzkwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
ICogd3RmL0F0b21pY3MuaDoKKyAgICAgICAgKFdURjo6d2Vha0NvbXBhcmVBbmRTd2FwKToKKyAg
ICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKyAgICAgICAgKiB3dGYvdGhyZWFkcy9CaW5hcnlTZW1h
cGhvcmUuaDoKKwogMjAxNS0wMS0yMCAgWXVuUWlhbmcgU3UgIDx3enNzeXFhQGdtYWlsLmNvbT4K
IAogICAgICAgICBGaXggZmFpbGVkIHRvIGJ1aWxkIGZvciBMaW51eC9NSVBTNjRFTApJbmRleDog
U291cmNlL1dURi93dGYvQXRvbWljcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0F0
b21pY3MuaAkocmV2aXNpb24gMTgyOTcyKQorKysgU291cmNlL1dURi93dGYvQXRvbWljcy5oCSh3
b3JraW5nIGNvcHkpCkBAIC0yNjAsNyArMjYwLDcgQEAgaW5saW5lIHZvaWQgbWVtb3J5QmFycmll
ckJlZm9yZVVubG9jaygpCiBpbmxpbmUgYm9vbCB3ZWFrQ29tcGFyZUFuZFN3YXAodWludDhfdCog
bG9jYXRpb24sIHVpbnQ4X3QgZXhwZWN0ZWQsIHVpbnQ4X3QgbmV3VmFsdWUpCiB7CiAjaWYgRU5B
QkxFKENPTVBBUkVfQU5EX1NXQVApCi0jaWYgIU9TKFdJTkRPV1MpICYmIChDUFUoWDg2KSB8fCBD
UFUoWDg2XzY0KSkKKyNpZiAhQ09NUElMRVIoTVNWQykgJiYgKENQVShYODYpIHx8IENQVShYODZf
NjQpKQogICAgIHVuc2lnbmVkIGNoYXIgcmVzdWx0OwogICAgIGFzbSB2b2xhdGlsZSgKICAgICAg
ICAgImxvY2s7IGNtcHhjaGdiICUzLCAlMlxuXHQiCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9QbGF0
Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9u
IDE4Mjk3MikKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAg
LTYxMSw4ICs2MTEsNiBAQAogI2RlZmluZSBIQVZFX0FMSUdORURfTUFMTE9DIDEKICNkZWZpbmUg
SEFWRV9JU0RFQlVHR0VSUFJFU0VOVCAxCiAKLSNpbmNsdWRlIDxXVEYvV1RGSGVhZGVyRGV0ZWN0
aW9uLmg+Ci0KICNlbmRpZgogCiAjaWYgT1MoV0lORE9XUykKSW5kZXg6IFNvdXJjZS9XVEYvd3Rm
L3RocmVhZHMvQmluYXJ5U2VtYXBob3JlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYv
dGhyZWFkcy9CaW5hcnlTZW1hcGhvcmUuaAkocmV2aXNpb24gMTgyOTcyKQorKysgU291cmNlL1dU
Ri93dGYvdGhyZWFkcy9CaW5hcnlTZW1hcGhvcmUuaAkod29ya2luZyBjb3B5KQpAQCAtNDEsMTIg
KzQxLDEyIEBAIHB1YmxpYzoKICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgdm9pZCBzaWduYWwoKTsK
ICAgICBXVEZfRVhQT1JUX1BSSVZBVEUgYm9vbCB3YWl0KGRvdWJsZSBhYnNvbHV0ZVRpbWUpOwog
Ci0jaWYgT1MoV0lORE9XUykKKyNpZiBQTEFURk9STShXSU4pCiAgICAgSEFORExFIGV2ZW50KCkg
Y29uc3QgeyByZXR1cm4gbV9ldmVudDsgfQogI2VuZGlmCiAKIHByaXZhdGU6Ci0jaWYgT1MoV0lO
RE9XUykKKyNpZiBQTEFURk9STShXSU4pCiAgICAgSEFORExFIG1fZXZlbnQ7CiAjZWxzZQogICAg
IGJvb2wgbV9pc1NldDsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4Mjk3NykKKysrIFNvdXJj
ZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE1
LTA0LTE3ICBNaWxhbiBDcmhhICA8bWNyaGFAcmVkaGF0LmNvbT4KKworICAgICAgICBbR1RLXSBN
aXNjZWxsYW5lb3VzIGNoYW5nZXMgZm9yIG1zeXMvbWluZ3cKKyAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MzkwNworCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvRm9udFBsYXRm
b3JtRGF0YS5oOgorCiAyMDE1LTA0LTA4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA
aWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBDcmFzaCBpbiBET01PYmplY3RDYWNoZSB3aGVu
IGEgd3JhcHBlZCBvYmplY3Qgb3duZWQgYnkgdGhlIGNhY2hlIGlzIHVucmVmZmVkIGJ5IHRoZSB1
c2VyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250UGxhdGZvcm1E
YXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9u
dFBsYXRmb3JtRGF0YS5oCShyZXZpc2lvbiAxODI5NzIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9ncmFwaGljcy9Gb250UGxhdGZvcm1EYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTYyLDcg
KzYyLDYgQEAgdHlwZWRlZiBjb25zdCBzdHJ1Y3QgX19DVEZvbnQqIENURm9udFJlZgogI2luY2x1
ZGUgPHd0Zi90ZXh0L1N0cmluZ0ltcGwuaD4KIAogI2lmIFBMQVRGT1JNKFdJTikKLSNpbmNsdWRl
IDx3dGYvd2luL0dESU9iamVjdC5oPgogdHlwZWRlZiBzdHJ1Y3QgSEZPTlRfXyogSEZPTlQ7CiAj
ZW5kaWYKIAo=
</data>
<flag name="review"
          id="275871"
          type_id="1"
          status="+"
          setter="cgarcia"
    />
    <flag name="commit-queue"
          id="278275"
          type_id="3"
          status="-"
          setter="cgarcia"
    />
          </attachment>
      

    </bug>

</bugzilla>