143772 2015-04-15 06:34:06 -0700 [W32] GCC warns that dummy HeapStatistics has a noreturn function that returns 2017-04-24 19:07:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 133028 1 lrn1986 webkit-unassigned beidson cgarcia lrn1986 oldest_to_newest 1085467 0 lrn1986 2015-04-15 06:34:06 -0700 GCC warns that exitWithFailure is marked as noreturn, but it does return: ../webkitgtk-2.4.8/Source/JavaScriptCore/heap/HeapStatistics.cpp:135:1: warning: 'noreturn' function does return 1085562 1 250819 lrn1986 2015-04-15 10:16:19 -0700 Created attachment 250819 Fixup dummy HeapStatistics implementation GCC warns that exitWithFailure is marked as noreturn, but it does return: ../webkitgtk-2.4.8/Source/JavaScriptCore/heap/HeapStatistics.cpp:135:1: warning: 'noreturn' function does return Call exit(-1) to indicate that no, there is no returning from here. 1300815 2 250819 beidson 2017-04-24 19:07:09 -0700 Comment on attachment 250819 Fixup dummy HeapStatistics implementation This patch has been pending review since 2015 with no recent activity. It seems unlikely that it would even still apply to trunk in its current form. Clearing from the review queue. Feel free to update and resubmit if the patch is still relevant. 250819 2015-04-15 10:16:19 -0700 2017-04-24 19:07:09 -0700 Fixup dummy HeapStatistics implementation Fixup-dummy-HeapStatistics-implementation.patch text/plain 2292 lrn1986 RnJvbSA5NTQ5NjRmMjFmOGUzNDI0YWIxZGRiZGJjNTlmMWFlOGM2MTBmZDk2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IFR1ZSwg MTQgQXByIDIwMTUgMTQ6NTM6MjkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBGaXh1cCBkdW1teSBI ZWFwU3RhdGlzdGljcyBpbXBsZW1lbnRhdGlvbgoKR0NDIHdhcm5zIHRoYXQgZXhpdFdpdGhGYWls dXJlIGlzIG1hcmtlZCBhcyBub3JldHVybiwgYnV0IGl0IGRvZXMgcmV0dXJuOgouLi93ZWJraXRn dGstMi40LjgvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFN0YXRpc3RpY3MuY3BwOjEz NToxOiB3YXJuaW5nOiAnbm9yZXR1cm4nIGZ1bmN0aW9uIGRvZXMgcmV0dXJuCgpDYWxsIGV4aXQo LTEpIHRvIGluZGljYXRlIHRoYXQgbm8sIHRoZXJlIGlzIG5vIHJldHVybmluZyBmcm9tIGhlcmUu CgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNzcyCi0tLQogU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgIHwgMTcgKysrKysrKysr KysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXBTdGF0aXN0aWNzLmNwcCB8 ICAxICsKIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCmluZGV4IDBmYWZjNTAuLmZkOTZjNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpA QCAtMSw1ICsxLDIyIEBACiAyMDE1LTA0LTE1ICDQoNGD0YHQu9Cw0L0g0JjQttCx0YPQu9Cw0YLQ vtCyICA8bHJuMTk4NkBnbWFpbC5jb20+CiAKKyAgICAgICAgRml4dXAgZHVtbXkgSGVhcFN0YXRp c3RpY3MgaW1wbGVtZW50YXRpb24KKworICAgICAgICBHQ0Mgd2FybnMgdGhhdCBleGl0V2l0aEZh aWx1cmUgaXMgbWFya2VkIGFzIG5vcmV0dXJuLCBidXQgaXQgZG9lcyByZXR1cm46CisgICAgICAg IC4uL3dlYmtpdGd0ay0yLjQuOC9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwU3RhdGlz dGljcy5jcHA6MTM1OjE6IHdhcm5pbmc6ICdub3JldHVybicgZnVuY3Rpb24gZG9lcyByZXR1cm4K KworICAgICAgICBDYWxsIGV4aXQoLTEpIHRvIGluZGljYXRlIHRoYXQgbm8sIHRoZXJlIGlzIG5v IHJldHVybmluZyBmcm9tIGhlcmUuCisKKyAgICAgICAgW1czMl0gR0NDIHdhcm5zIHRoYXQgZHVt bXkgSGVhcFN0YXRpc3RpY3MgaGFzIGEgbm9yZXR1cm4gZnVuY3Rpb24gdGhhdCByZXR1cm5zCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3NzIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGhlYXAvSGVh cFN0YXRpc3RpY3MuY3BwOgorICAgICAgICAoSlNDOjpIZWFwU3RhdGlzdGljczo6ZXhpdFdpdGhG YWlsdXJlKToKKworMjAxNS0wNC0xNSAg0KDRg9GB0LvQsNC9INCY0LbQsdGD0LvQsNGC0L7QsiAg PGxybjE5ODZAZ21haWwuY29tPgorCiAgICAgICAgIFNpbGVuY2UgdGhlIHdhcm5pbmcgYWJvdXQg SlNWYWx1ZSAndicgYmVpbmcgdW5pbml0aWFsaXplZAogCiAgICAgICAgIFRoaXMgc2hvdWxkbid0 IHJlYWxseSBoYXBwZW4sIGFzIHRoZSBlbnVtZXJhdGlvbiBvbmx5IGhhcyB0d28gdmFsdWVzLApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFN0YXRpc3RpY3MuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcFN0YXRpc3RpY3MuY3BwCmluZGV4IGYy M2RlZjcuLmJhNDQxZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hl YXBTdGF0aXN0aWNzLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwU3Rh dGlzdGljcy5jcHAKQEAgLTEzMiw2ICsxMzIsNyBAQCB2b2lkIEhlYXBTdGF0aXN0aWNzOjpsb2dT dGF0aXN0aWNzKCkKIAogdm9pZCBIZWFwU3RhdGlzdGljczo6ZXhpdFdpdGhGYWlsdXJlKCkKIHsK KyAgICBleGl0KC0xKTsKIH0KIAogdm9pZCBIZWFwU3RhdGlzdGljczo6cmVwb3J0U3VjY2Vzcygp Ci0tIAoxLjguNS4z