143770 2015-04-15 06:32:36 -0700 GCC warns that JSValue v is used without initialization 2015-04-21 04:07:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 133028 1 lrn1986 webkit-unassigned cgarcia lrn1986 oldest_to_newest 1085465 0 lrn1986 2015-04-15 06:32:36 -0700 ../webkitgtk-2.4.8/Source/JavaScriptCore/runtime/JSObject.cpp: In member function 'JSC::ContiguousJSValues JSC::JSObject::genericConvertDoubleToContiguous(JSC::VM&) [with JSC::JSObject::DoubleToContiguousMode mode = (JSC::JSObject::DoubleToContiguousMode)0u; JSC::ContiguousJSValues = JSC::ContiguousData<JSC::WriteBarrier<JSC::Unknown> >]': ../webkitgtk-2.4.8/Source/JavaScriptCore/runtime/JSObject.cpp:822:17: warning: 'v' is used uninitialized in this function [-Wuninitialized] This shouldn't really happen, as the enumeration only has two values, but gcc doesn't seem to understand it. Probably because it's a template. Also, 'v' is an object, so there's an uninitialized object that participates in a '=' operator, so that could be the cause for concern as well. 1085559 1 250817 lrn1986 2015-04-15 10:12:22 -0700 Created attachment 250817 Silence the warning about JSValue 'v' being uninitialized This shouldn't really happen, as the enumeration only has two values, but gcc doesn't seem to understand it. Probably because it's a template. Also, 'v' is an object, so there's an uninitialized object that participates in a '=' operator, so that could be the cause for concern as well. Fix this by completely separating two cases at the cost of code duplication. Otherwise one would get this: ../webkitgtk-2.4.8/Source/JavaScriptCore/runtime/JSObject.cpp: In member function 'JSC::ContiguousJSValues JSC::JSObject::genericConvertDoubleToContiguous(JSC::VM&) [with JSC::JSObject::DoubleToContiguousMode mode = (JSC::JSObject::DoubleToContiguousMode)0u; JSC::ContiguousJSValues = JSC::ContiguousData<JSC::WriteBarrier<JSC::Unknown> >]': ../webkitgtk-2.4.8/Source/JavaScriptCore/runtime/JSObject.cpp:822:17: warning: 'v' is used uninitialized in this function [-Wuninitialized] 1085786 2 250817 ap 2015-04-15 18:08:53 -0700 Comment on attachment 250817 Silence the warning about JSValue 'v' being uninitialized R-, because the patch does not apply to trunk. Also, the change to switch indentation is incorrect per WebKit style. 1087036 3 lrn1986 2015-04-21 04:07:59 -0700 Maybe this could be fixed by backporting whatever code is in the trunk now? Since this patch does not apply, i'm assuming that the code changed since 2.4.x 250817 2015-04-15 10:12:22 -0700 2015-04-15 18:08:53 -0700 Silence the warning about JSValue 'v' being uninitialized Silence-the-warning-about-JSValue-v-being-uninitia.patch text/plain 4495 lrn1986 RnJvbSA2OTkwODAyMGYyMGFhYzAyMDEyZDZkZTFiMDA4MDIyNWMzM2M2OWI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IFR1ZSwg MTQgQXByIDIwMTUgMTQ6NDg6MzIgKzAwMDAKU3ViamVjdDogW1BBVENIXSBTaWxlbmNlIHRoZSB3 YXJuaW5nIGFib3V0IEpTVmFsdWUgJ3YnIGJlaW5nIHVuaW5pdGlhbGl6ZWQKClRoaXMgc2hvdWxk bid0IHJlYWxseSBoYXBwZW4sIGFzIHRoZSBlbnVtZXJhdGlvbiBvbmx5IGhhcyB0d28gdmFsdWVz LApidXQgZ2NjIGRvZXNuJ3Qgc2VlbSB0byB1bmRlcnN0YW5kIGl0LiBQcm9iYWJseSBiZWNhdXNl IGl0J3MgYSB0ZW1wbGF0ZS4KQWxzbywgJ3YnIGlzIGFuIG9iamVjdCwgc28gdGhlcmUncyBhbiB1 bmluaXRpYWxpemVkIG9iamVjdCB0aGF0IHBhcnRpY2lwYXRlcwppbiBhICc9JyBvcGVyYXRvciwg c28gdGhhdCBjb3VsZCBiZSB0aGUgY2F1c2UgZm9yIGNvbmNlcm4gYXMgd2VsbC4KCkZpeCB0aGlz IGJ5IGNvbXBsZXRlbHkgc2VwYXJhdGluZyB0d28gY2FzZXMgYXQgdGhlIGNvc3Qgb2YgY29kZSBk dXBsaWNhdGlvbi4KCk90aGVyd2lzZSBvbmUgd291bGQgZ2V0IHRoaXM6Ci4uL3dlYmtpdGd0ay0y LjQuOC9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHA6IEluIG1lbWJl ciBmdW5jdGlvbiAnSlNDOjpDb250aWd1b3VzSlNWYWx1ZXMgSlNDOjpKU09iamVjdDo6Z2VuZXJp Y0NvbnZlcnREb3VibGVUb0NvbnRpZ3VvdXMoSlNDOjpWTSYpIFt3aXRoIEpTQzo6SlNPYmplY3Q6 OkRvdWJsZVRvQ29udGlndW91c01vZGUgbW9kZSA9IChKU0M6OkpTT2JqZWN0OjpEb3VibGVUb0Nv bnRpZ3VvdXNNb2RlKTB1OyBKU0M6OkNvbnRpZ3VvdXNKU1ZhbHVlcyA9IEpTQzo6Q29udGlndW91 c0RhdGE8SlNDOjpXcml0ZUJhcnJpZXI8SlNDOjpVbmtub3duPiA+XSc6Ci4uL3dlYmtpdGd0ay0y LjQuOC9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHA6ODIyOjE3OiB3 YXJuaW5nOiAndicgaXMgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24gWy1XdW5p bml0aWFsaXplZF0KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3 NzAKLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgfCAyMyAr KysrKysrKysrKysrKysrKysrKysrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNP YmplY3QuY3BwIHwgMjAgKysrKysrKysrKysrLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMzUg aW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRl eCBmZWUyNDliLi4wZmFmYzUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwy OCBAQAogMjAxNS0wNC0xNSAg0KDRg9GB0LvQsNC9INCY0LbQsdGD0LvQsNGC0L7QsiAgPGxybjE5 ODZAZ21haWwuY29tPgogCisgICAgICAgIFNpbGVuY2UgdGhlIHdhcm5pbmcgYWJvdXQgSlNWYWx1 ZSAndicgYmVpbmcgdW5pbml0aWFsaXplZAorCisgICAgICAgIFRoaXMgc2hvdWxkbid0IHJlYWxs eSBoYXBwZW4sIGFzIHRoZSBlbnVtZXJhdGlvbiBvbmx5IGhhcyB0d28gdmFsdWVzLAorICAgICAg ICBidXQgZ2NjIGRvZXNuJ3Qgc2VlbSB0byB1bmRlcnN0YW5kIGl0LiBQcm9iYWJseSBiZWNhdXNl IGl0J3MgYSB0ZW1wbGF0ZS4KKyAgICAgICAgQWxzbywgJ3YnIGlzIGFuIG9iamVjdCwgc28gdGhl cmUncyBhbiB1bmluaXRpYWxpemVkIG9iamVjdCB0aGF0IHBhcnRpY2lwYXRlcworICAgICAgICBp biBhICc9JyBvcGVyYXRvciwgc28gdGhhdCBjb3VsZCBiZSB0aGUgY2F1c2UgZm9yIGNvbmNlcm4g YXMgd2VsbC4KKworICAgICAgICBGaXggdGhpcyBieSBjb21wbGV0ZWx5IHNlcGFyYXRpbmcgdHdv IGNhc2VzIGF0IHRoZSBjb3N0IG9mIGNvZGUgZHVwbGljYXRpb24uCisKKyAgICAgICAgT3RoZXJ3 aXNlIG9uZSB3b3VsZCBnZXQgdGhpczoKKyAgICAgICAgLi4vd2Via2l0Z3RrLTIuNC44L1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcDogSW4gbWVtYmVyIGZ1bmN0aW9u ICdKU0M6OkNvbnRpZ3VvdXNKU1ZhbHVlcyBKU0M6OkpTT2JqZWN0OjpnZW5lcmljQ29udmVydERv dWJsZVRvQ29udGlndW91cyhKU0M6OlZNJikgW3dpdGggSlNDOjpKU09iamVjdDo6RG91YmxlVG9D b250aWd1b3VzTW9kZSBtb2RlID0gKEpTQzo6SlNPYmplY3Q6OkRvdWJsZVRvQ29udGlndW91c01v ZGUpMHU7IEpTQzo6Q29udGlndW91c0pTVmFsdWVzID0gSlNDOjpDb250aWd1b3VzRGF0YTxKU0M6 OldyaXRlQmFycmllcjxKU0M6OlVua25vd24+ID5dJzoKKyAgICAgICAgLi4vd2Via2l0Z3RrLTIu NC44L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcDo4MjI6MTc6IHdh cm5pbmc6ICd2JyBpcyB1c2VkIHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbiBbLVd1bmlu aXRpYWxpemVkXQorCisgICAgICAgIEdDQyB3YXJucyB0aGF0IEpTVmFsdWUgdiBpcyB1c2VkIHdp dGhvdXQgaW5pdGlhbGl6YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0Mzc3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcnVudGltZS9KU09iamVjdC5jcHA6CisgICAgICAgIChKU0M6OkpTT2Jq ZWN0OjpnZW5lcmljQ29udmVydERvdWJsZVRvQ29udGlndW91cyk6CisKKzIwMTUtMDQtMTUgINCg 0YPRgdC70LDQvSDQmNC20LHRg9C70LDRgtC+0LIgIDxscm4xOTg2QGdtYWlsLmNvbT4KKwogICAg ICAgICBFbnN1cmUgdGhhdCBnZW5lcmF0b3Itc2NyaXB0cyBnZXQgQ0MgZnJvbSBjb25maWd1cmUK IAogICAgICAgICBWYXJpb3VzIHNjcmlwdHMgY2hlY2sgdGhlIENDIGVudmlyb25tZW50IHZhcmlh YmxlIHRvIGdldCB0aGUgY29tcGlsZXIgdG8KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTT2JqZWN0LmNwcAppbmRleCA2OTEwYjdlLi41ZjUyZmUwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCkBAIC04MjEsMTUgKzgyMSwxOSBAQCBDb250aWd1 b3VzSlNWYWx1ZXMgSlNPYmplY3Q6OmdlbmVyaWNDb252ZXJ0RG91YmxlVG9Db250aWd1b3VzKFZN JiB2bSkKICAgICAgICAgfQogICAgICAgICBKU1ZhbHVlIHY7CiAgICAgICAgIHN3aXRjaCAobW9k ZSkgewotICAgICAgICBjYXNlIEVuY29kZVZhbHVlQXNEb3VibGU6Ci0gICAgICAgICAgICB2ID0g SlNWYWx1ZShKU1ZhbHVlOjpFbmNvZGVBc0RvdWJsZSwgdmFsdWUpOwotICAgICAgICAgICAgYnJl YWs7Ci0gICAgICAgIGNhc2UgUmFnZUNvbnZlcnREb3VibGVUb1ZhbHVlOgotICAgICAgICAgICAg diA9IGpzTnVtYmVyKHZhbHVlKTsKLSAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgY2Fz ZSBFbmNvZGVWYWx1ZUFzRG91YmxlOiB7IAorICAgICAgICAgICAgICAgIEpTVmFsdWUgdiA9IEpT VmFsdWUoSlNWYWx1ZTo6RW5jb2RlQXNEb3VibGUsIHZhbHVlKTsKKyAgICAgICAgICAgICAgICBB U1NFUlQodi5pc051bWJlcigpKTsKKyAgICAgICAgICAgICAgICBjdXJyZW50QXNWYWx1ZS0+c2V0 V2l0aG91dFdyaXRlQmFycmllcih2KTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgICAgIGNhc2UgUmFnZUNvbnZlcnREb3VibGVUb1ZhbHVlOiB7CisgICAg ICAgICAgICAgICAgSlNWYWx1ZSB2ID0ganNOdW1iZXIodmFsdWUpOworICAgICAgICAgICAgICAg IEFTU0VSVCh2LmlzTnVtYmVyKCkpOworICAgICAgICAgICAgICAgIGN1cnJlbnRBc1ZhbHVlLT5z ZXRXaXRob3V0V3JpdGVCYXJyaWVyKHYpOworICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAg ICAgICAgfQogICAgICAgICB9Ci0gICAgICAgIEFTU0VSVCh2LmlzTnVtYmVyKCkpOwotICAgICAg ICBjdXJyZW50QXNWYWx1ZS0+c2V0V2l0aG91dFdyaXRlQmFycmllcih2KTsKICAgICB9CiAgICAg CiAgICAgc2V0U3RydWN0dXJlKHZtLCBTdHJ1Y3R1cmU6Om5vblByb3BlcnR5VHJhbnNpdGlvbih2 bSwgc3RydWN0dXJlKCksIEFsbG9jYXRlQ29udGlndW91cykpOwotLSAKMS44LjUuMw==