143769 2015-04-15 06:31:49 -0700 [W32] Fails to build - missing references to OpenGL context functions 2015-05-18 23:07:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 133028 1 lrn1986 webkit-unassigned cgarcia lrn1986 oldest_to_newest 1085464 0 lrn1986 2015-04-15 06:31:49 -0700 CXXLD libwebkitgtk-3.0.la ./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `GraphicsContext3DPrivate': /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `__ZN7WebCore9GLContext14sharingContextEv' /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `__ZN7WebCore9GLContext22createOffscreenContextEPS0_' ./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `platformContext': /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:84: undefined reference to `__ZN7WebCore9GLContext10getCurrentEv' Becuase GLContext.cpp is not used, which happens because it's under TARGET_X11_OR_WAYLAND condition in the GNUmakefile.list.am. 1085554 1 250816 lrn1986 2015-04-15 10:10:44 -0700 Created attachment 250816 Also use GL-related files when compiling with MinGW CXXLD libwebkitgtk-3.0.la ./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `GraphicsContext3DPrivate': /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `__ZN7WebCore9GLContext14sharingContextEv' /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `__ZN7WebCore9GLContext22createOffscreenContextEPS0_' ./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `platformContext': /src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:84: undefined reference to `__ZN7WebCore9GLContext10getCurrentEv' Becuase GLContext.cpp is not used, which happens because it's under TARGET_X11_OR_WAYLAND condition in the GNUmakefile.list.am. Move TARGET_X11_OR_WAYLAND up a bit to free up GLContext.cpp (now only protected by USE_OPENGL). 1095835 2 250816 cgarcia 2015-05-18 23:06:35 -0700 Comment on attachment 250816 Also use GL-related files when compiling with MinGW Clearing flags, committed a slightly modified version of the patch. LRN confirmed it works for him 1095836 3 cgarcia 2015-05-18 23:07:27 -0700 Committed to 2.4 http://trac.webkit.org/changeset/184544 250816 2015-04-15 10:10:44 -0700 2015-05-18 23:06:35 -0700 Also use GL-related files when compiling with MinGW Also-use-GL-related-files-when-compiling-with-MinG.patch text/plain 4657 lrn1986 RnJvbSAxZWJlM2MyNjVjMjQ5MmYzOWJiZjA2MjE2YmQ4ZWU4ZjQ1NDFkOTRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IFR1ZSwg MTQgQXByIDIwMTUgMTE6MDI6MDIgKzAwMDAKU3ViamVjdDogW1BBVENIXSBBbHNvIHVzZSBHTC1y ZWxhdGVkIGZpbGVzIHdoZW4gY29tcGlsaW5nIHdpdGggTWluR1cKCiAgQ1hYTEQgICAgbGlid2Vi a2l0Z3RrLTMuMC5sYQouLy5saWJzLy4uL3NvdXJjZS93ZWJjb3JlL3BsYXRmb3JtL2dyYXBoaWNz Ly5saWJzL2xpYnBsYXRmb3JtX2xhLWdyYXBoaWNzY29udGV4dDNkcHJpdmF0ZS5vOiBJbiBmdW5j dGlvbiBgR3JhcGhpY3NDb250ZXh0M0RQcml2YXRlJzoKL3NyYy9taW5ndy93ZWJraXRndGstMi40 LjgtMVxibGQvLi4vd2Via2l0Z3RrLTIuNC44L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0dyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHA6NTk6IHVuZGVmaW5lZCByZWZlcmVuY2Ug dG8gYF9fWk43V2ViQ29yZTlHTENvbnRleHQxNHNoYXJpbmdDb250ZXh0RXYnCi9zcmMvbWluZ3cv d2Via2l0Z3RrLTIuNC44LTFcYmxkLy4uL3dlYmtpdGd0ay0yLjQuOC9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRFByaXZhdGUuY3BwOjU5OiB1bmRlZmlu ZWQgcmVmZXJlbmNlIHRvIGBfX1pON1dlYkNvcmU5R0xDb250ZXh0MjJjcmVhdGVPZmZzY3JlZW5D b250ZXh0RVBTMF8nCi4vLmxpYnMvLi4vc291cmNlL3dlYmNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv LmxpYnMvbGlicGxhdGZvcm1fbGEtZ3JhcGhpY3Njb250ZXh0M2Rwcml2YXRlLm86IEluIGZ1bmN0 aW9uIGBwbGF0Zm9ybUNvbnRleHQnOgovc3JjL21pbmd3L3dlYmtpdGd0ay0yLjQuOC0xXGJsZC8u Li93ZWJraXRndGstMi40LjgvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp Y3NDb250ZXh0M0RQcml2YXRlLmNwcDo4NDogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgX19aTjdX ZWJDb3JlOUdMQ29udGV4dDEwZ2V0Q3VycmVudEV2JwoKQmVjdWFzZSBHTENvbnRleHQuY3BwIGlz IG5vdCB1c2VkLCB3aGljaCBoYXBwZW5zIGJlY2F1c2UgaXQncyB1bmRlcgpUQVJHRVRfWDExX09S X1dBWUxBTkQgY29uZGl0aW9uIGluIHRoZSBHTlVtYWtlZmlsZS5saXN0LmFtLgpNb3ZlIFRBUkdF VF9YMTFfT1JfV0FZTEFORCB1cCBhIGJpdCB0byBmcmVlIHVwIEdMQ29udGV4dC5jcHAgKG5vdyBv bmx5CnByb3RlY3RlZCBieSBVU0VfT1BFTkdMKS4KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNDM3NjkKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAg ICAgIHwgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvR05VbWFr ZWZpbGUubGlzdC5hbSB8IDEzICsrKysrKystLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMzIgaW5z ZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZjODdkMy4uNmY3ZDlk MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDE1LTA0LTE1ICDQoNGD0YHQu9Cw0L0g 0JjQttCx0YPQu9Cw0YLQvtCyICA8bHJuMTk4NkBnbWFpbC5jb20+CiAKKyAgICAgICAgQWxzbyB1 c2UgR0wtcmVsYXRlZCBmaWxlcyB3aGVuIGNvbXBpbGluZyB3aXRoIE1pbkdXCisKKyAgICAgICAg ICBDWFhMRCAgICBsaWJ3ZWJraXRndGstMy4wLmxhCisgICAgICAgIC4vLmxpYnMvLi4vc291cmNl L3dlYmNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvLmxpYnMvbGlicGxhdGZvcm1fbGEtZ3JhcGhpY3Nj b250ZXh0M2Rwcml2YXRlLm86IEluIGZ1bmN0aW9uIGBHcmFwaGljc0NvbnRleHQzRFByaXZhdGUn OgorICAgICAgICAvc3JjL21pbmd3L3dlYmtpdGd0ay0yLjQuOC0xXGJsZC8uLi93ZWJraXRndGst Mi40LjgvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0RQ cml2YXRlLmNwcDo1OTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgX19aTjdXZWJDb3JlOUdMQ29u dGV4dDE0c2hhcmluZ0NvbnRleHRFdicKKyAgICAgICAgL3NyYy9taW5ndy93ZWJraXRndGstMi40 LjgtMVxibGQvLi4vd2Via2l0Z3RrLTIuNC44L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0dyYXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHA6NTk6IHVuZGVmaW5lZCByZWZlcmVuY2Ug dG8gYF9fWk43V2ViQ29yZTlHTENvbnRleHQyMmNyZWF0ZU9mZnNjcmVlbkNvbnRleHRFUFMwXycK KyAgICAgICAgLi8ubGlicy8uLi9zb3VyY2Uvd2ViY29yZS9wbGF0Zm9ybS9ncmFwaGljcy8ubGli cy9saWJwbGF0Zm9ybV9sYS1ncmFwaGljc2NvbnRleHQzZHByaXZhdGUubzogSW4gZnVuY3Rpb24g YHBsYXRmb3JtQ29udGV4dCc6CisgICAgICAgIC9zcmMvbWluZ3cvd2Via2l0Z3RrLTIuNC44LTFc YmxkLy4uL3dlYmtpdGd0ay0yLjQuOC9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9H cmFwaGljc0NvbnRleHQzRFByaXZhdGUuY3BwOjg0OiB1bmRlZmluZWQgcmVmZXJlbmNlIHRvIGBf X1pON1dlYkNvcmU5R0xDb250ZXh0MTBnZXRDdXJyZW50RXYnCisKKyAgICAgICAgQmVjdWFzZSBH TENvbnRleHQuY3BwIGlzIG5vdCB1c2VkLCB3aGljaCBoYXBwZW5zIGJlY2F1c2UgaXQncyB1bmRl cgorICAgICAgICBUQVJHRVRfWDExX09SX1dBWUxBTkQgY29uZGl0aW9uIGluIHRoZSBHTlVtYWtl ZmlsZS5saXN0LmFtLgorICAgICAgICBNb3ZlIFRBUkdFVF9YMTFfT1JfV0FZTEFORCB1cCBhIGJp dCB0byBmcmVlIHVwIEdMQ29udGV4dC5jcHAgKG5vdyBvbmx5CisgICAgICAgIHByb3RlY3RlZCBi eSBVU0VfT1BFTkdMKS4KKworICAgICAgICBbVzMyXSBGYWlscyB0byBidWlsZCAtIG1pc3Npbmcg cmVmZXJlbmNlcyB0byBPcGVuR0wgY29udGV4dCBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mzc2OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAoT09QUyEpLgorCisg ICAgICAgICogR05VbWFrZWZpbGUubGlzdC5hbToKKworMjAxNS0wNC0xNSAg0KDRg9GB0LvQsNC9 INCY0LbQsdGD0LvQsNGC0L7QsiAgPGxybjE5ODZAZ21haWwuY29tPgorCiAgICAgICAgIFdvcmsg YXJvdW5kIG5hbWUgY29uZmxpY3RzIChOT19FUlJPUikKIAogICAgICAgICBJbiBmaWxlIGluY2x1 ZGVkIGZyb20gL21pbmd3L2luY2x1ZGUvX21pbmd3Lmg6MTI6MCwKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0gYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmls ZS5saXN0LmFtCmluZGV4IDIyOTU2YzcuLjQ0MzM5OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KKysrIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUu bGlzdC5hbQpAQCAtNjI2Nyw2ICs2MjY3LDEzIEBAIGlmIFRBUkdFVF9YMTFfT1JfV0FZTEFORAog cGxhdGZvcm1ndGtfc291cmNlcyArPSBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8v V2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uaCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fp cm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uY3BwCitpZiBVU0VfRUdMCit3ZWJjb3JlZ3RrX3Nv dXJjZXMgKz0gXAorCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRl eHRFR0wuY3BwIFwKKwlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250 ZXh0RUdMLmgKK2VuZGlmICMgRU5EIFVTRV9FR0wKK2VuZGlmICMgRU5EIFRBUkdFVF9YMTFfT1Jf V0FZTEFORAorCiBpZiBVU0VfT1BFTkdMCiBwbGF0Zm9ybWd0a19zb3VyY2VzICs9IFwKIAlTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HTENvbnRleHQuY3BwIFwKQEAgLTYyNzQsMTIg KzYyODEsNiBAQCBwbGF0Zm9ybWd0a19zb3VyY2VzICs9IFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuY3BwIFwKIAlTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvUmVkaXJlY3RlZFhDb21wb3NpdGVXaW5kb3cuaAogZW5kaWYgIyBFTkQg VVNFX09QRU5HTAotaWYgVVNFX0VHTAotd2ViY29yZWd0a19zb3VyY2VzICs9IFwKLQlTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmNwcCBcCi0JU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5oCi1lbmRpZiAjIEVO RCBVU0VfRUdMCi1lbmRpZiAjIEVORCBUQVJHRVRfWDExX09SX1dBWUxBTkQKIAogaWYgVEFSR0VU X1dJTjMyCiB3ZWJjb3JlX3NvdXJjZXMgKz0gXAotLSAKMS44LjUuMw==