143767 2015-04-15 06:29:55 -0700 [W32] Configure may misdetect ICU libraries 2015-05-18 10:52:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 133028 1 lrn1986 webkit-unassigned cgarcia lrn1986 oldest_to_newest 1085462 0 lrn1986 2015-04-15 06:29:55 -0700 MinGW packages tend to have .pc files these days. Use them. ICU naming and structure is complex enough to warrant this, and asking pkg-config might result in things like UNICODE_LIBS="-licui18n54 -licuuc54 -licudata54" instead of the default UNICODE_LIBS="-licui18n -licuuc" and pkg-config usually knows best. 1085549 1 250813 lrn1986 2015-04-15 10:06:41 -0700 Created attachment 250813 Try to use pkg-config to detect ICU libraries MinGW packages tend to have .pc files these days. Use them. ICU naming and structure is complex enough to warrant this, and asking pkg-config might result in things like UNICODE_LIBS="-licui18n54 -licuuc54 -licudata54" instead of the default UNICODE_LIBS="-licui18n -licuuc" and pkg-config usually knows best. 1095638 2 cgarcia 2015-05-18 10:52:41 -0700 Committed in 2.4 http://trac.webkit.org/changeset/184502 250813 2015-04-15 10:06:41 -0700 2015-05-18 10:51:45 -0700 Try to use pkg-config to detect ICU libraries Try-to-use-pkg-config-to-detect-ICU-libraries.patch text/plain 2615 lrn1986 RnJvbSA0ZGEwYTVmNzg1YWYwZmRiNTA4YjRiNzQ2ODBjM2Q1OTNmNzBjZmUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IFR1ZSwg MTQgQXByIDIwMTUgMTA6NTE6MDIgKzAwMDAKU3ViamVjdDogW1BBVENIXSBUcnkgdG8gdXNlIHBr Zy1jb25maWcgdG8gZGV0ZWN0IElDVSBsaWJyYXJpZXMKCk1pbkdXIHBhY2thZ2VzIHRlbmQgdG8g aGF2ZSAucGMgZmlsZXMgdGhlc2UgZGF5cy4gVXNlIHRoZW0uCgpJQ1UgbmFtaW5nIGFuZCBzdHJ1 Y3R1cmUgaXMgY29tcGxleCBlbm91Z2ggdG8gd2FycmFudCB0aGlzLCBhbmQgYXNraW5nCnBrZy1j b25maWcgbWlnaHQgcmVzdWx0IGluIHRoaW5ncyBsaWtlClVOSUNPREVfTElCUz0iLWxpY3VpMThu NTQgLWxpY3V1YzU0IC1saWN1ZGF0YTU0IgppbnN0ZWFkIG9mIHRoZSBkZWZhdWx0ClVOSUNPREVf TElCUz0iLWxpY3VpMThuIC1saWN1dWMiCmFuZCBwa2ctY29uZmlnIHVzdWFsbHkga25vd3MgYmVz dC4KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3NjcKLS0tCiBD aGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAyMCArKysrKysrKysrKysrKysr KysrKwogU291cmNlL2F1dG90b29scy9GaW5kRGVwZW5kZW5jaWVzLm00IHwgMTAgKysrKysrKyst LQogMiBmaWxlcyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiNzIyMDUzLi44YjVlZjdiIDEw MDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAKIDIw MTUtMDQtMTUgINCg0YPRgdC70LDQvSDQmNC20LHRg9C70LDRgtC+0LIgIDxscm4xOTg2QGdtYWls LmNvbT4KIAorICAgICAgICBUcnkgdG8gdXNlIHBrZy1jb25maWcgdG8gZGV0ZWN0IElDVSBsaWJy YXJpZXMKKworICAgICAgICBNaW5HVyBwYWNrYWdlcyB0ZW5kIHRvIGhhdmUgLnBjIGZpbGVzIHRo ZXNlIGRheXMuIFVzZSB0aGVtLgorCisgICAgICAgIElDVSBuYW1pbmcgYW5kIHN0cnVjdHVyZSBp cyBjb21wbGV4IGVub3VnaCB0byB3YXJyYW50IHRoaXMsIGFuZCBhc2tpbmcKKyAgICAgICAgcGtn LWNvbmZpZyBtaWdodCByZXN1bHQgaW4gdGhpbmdzIGxpa2UKKyAgICAgICAgVU5JQ09ERV9MSUJT PSItbGljdWkxOG41NCAtbGljdXVjNTQgLWxpY3VkYXRhNTQiCisgICAgICAgIGluc3RlYWQgb2Yg dGhlIGRlZmF1bHQKKyAgICAgICAgVU5JQ09ERV9MSUJTPSItbGljdWkxOG4gLWxpY3V1YyIKKyAg ICAgICAgYW5kIHBrZy1jb25maWcgdXN1YWxseSBrbm93cyBiZXN0LgorCisgICAgICAgIFtXMzJd IENvbmZpZ3VyZSBtYXkgbWlzZGV0ZWN0IElDVSBsaWJyYXJpZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mzc2NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2F1dG90b29scy9GaW5kRGVw ZW5kZW5jaWVzLm00OgorCisyMDE1LTA0LTE1ICDQoNGD0YHQu9Cw0L0g0JjQttCx0YPQu9Cw0YLQ vtCyICA8bHJuMTk4NkBnbWFpbC5jb20+CisKICAgICAgICAgQ2hhbmdlIE9wZW5HTCBjaGVja3Mg dG8gd29yayBvbiBXMzIsIGFkZCBsaWJvcGVuZ2wzMgogCiAgICAgICAgIEFHYWluLCB1c2UgT1Mo V0lORE9XUykgZm9yIHRoaW5ncyB0aGF0IGFyZSBXMzIgYnV0IG5vdCBuZWNlc3NhcmlseSBNU1ZD LgpkaWZmIC0tZ2l0IGEvU291cmNlL2F1dG90b29scy9GaW5kRGVwZW5kZW5jaWVzLm00IGIvU291 cmNlL2F1dG90b29scy9GaW5kRGVwZW5kZW5jaWVzLm00CmluZGV4IDNjZTNmNzYuLmEyMWU2OGQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9hdXRvdG9vbHMvRmluZERlcGVuZGVuY2llcy5tNAorKysgYi9T b3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMubTQKQEAgLTEwOSw4ICsxMDksMTQgQEAg Y2FzZSAiJGhvc3QiIGluCiAgICAgICAgIFVOSUNPREVfTElCUz0iLWxpY3Vjb3JlIgogICAgICAg ICA7OwogICAgICotKi1taW5ndyopCi0gICAgICAgIFVOSUNPREVfQ0ZMQUdTPSIiCi0gICAgICAg IFVOSUNPREVfTElCUz0iLWxpY3VpMThuIC1saWN1dWMiCisJUEtHX0NIRUNLX01PRFVMRVMoSUNV LCBpY3UtaTE4biwgLCkKKwlpZiB0ZXN0ICJ4JElDVV9MSUJTIiA9ICJ4IiA7IHRoZW4KKyAgICAg ICAgCVVOSUNPREVfQ0ZMQUdTPSIiCisgICAgICAgIAlVTklDT0RFX0xJQlM9Ii1saWN1aTE4biAt bGljdXVjIgorCWVsc2UKKyAgICAgICAgCVVOSUNPREVfQ0ZMQUdTPSIkSUNVX0NGTEFHUyIKKyAg ICAgICAgCVVOSUNPREVfTElCUz0iJElDVV9MSUJTIgorCWZpCiAgICAgICAgIEFDX0NIRUNLX0hF QURFUlMoW3VuaWNvZGUvdWNoYXIuaF0sIFtdLCBbQUNfTVNHX0VSUk9SKFtDb3VsZCBub3QgZmlu ZCBJQ1UgaGVhZGVycy5dKV0pCiAgICAgICAgIDs7CiAgICAgKikKLS0gCjEuOC41LjM=