143762 2015-04-15 06:24:07 -0700 [ANGLE][W32] Buildsystem is hardcoded for UNIX 2015-05-18 23:19:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 133028 1 lrn1986 webkit-unassigned cgarcia lrn1986 oldest_to_newest 1085457 0 lrn1986 2015-04-15 06:24:07 -0700 Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp is compiled unconditionally. 1085541 1 250807 lrn1986 2015-04-15 09:57:36 -0700 Created attachment 250807 Don't hardcode ossource_posix.cpp in the makefile Compile ossource_posix.cpp or ossource_win.cpp depending on the target. Otherwise you get an error: ../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:13:2: error: #error Trying to build a posix specific file in a non-posix build. 1095843 2 cgarcia 2015-05-18 23:19:35 -0700 Committed to 2.4 http://trac.webkit.org/changeset/184545 250807 2015-04-15 09:57:36 -0700 2015-05-18 23:18:45 -0700 Don't hardcode ossource_posix.cpp in the makefile Dont-hardcode-ossourceposixcpp-in-the-makefile.patch text/plain 2834 lrn1986 RnJvbSA2MWNmOTIyMmFhNTYzZDg2MDQxODVmZWM4ZjAwZjgxMWQwN2VhZmY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IE1vbiwg MTMgQXByIDIwMTUgMTM6NTI6MjkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBEb24ndCBoYXJkY29k ZSBvc3NvdXJjZV9wb3NpeC5jcHAgaW4gdGhlIG1ha2VmaWxlCgpDb21waWxlIG9zc291cmNlX3Bv c2l4LmNwcCBvciBvc3NvdXJjZV93aW4uY3BwIGRlcGVuZGluZyBvbiB0aGUgdGFyZ2V0LgoKT3Ro ZXJ3aXNlIHlvdSBnZXQgYW4gZXJyb3I6Ci4uL3dlYmtpdGd0ay0yLjQuOC9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvb3Nzb3VyY2VfcG9zaXguY3BwOjEzOjI6IGVycm9yOiAj ZXJyb3IgVHJ5aW5nIHRvIGJ1aWxkIGEgcG9zaXggc3BlY2lmaWMgZmlsZSBpbiBhIG5vbi1wb3Np eCBidWlsZC4KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDM3NjIK LS0tCiBTb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cgICAgICB8IDE2ICsrKysrKysr KysrKysrKysKIFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0dOVW1ha2VmaWxlLmFtIHwgIDcgKysr KysrLQogMiBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpk aWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nIGIvU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvQ2hhbmdlTG9nCmluZGV4IDY4Y2JiZWEuLjViNTg1NmMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxNS0wNC0xNSAg0KDRg9GB 0LvQsNC9INCY0LbQsdGD0LvQsNGC0L7QsiAgPGxybjE5ODZAZ21haWwuY29tPgorCisgICAgICAg IERvbid0IGhhcmRjb2RlIG9zc291cmNlX3Bvc2l4LmNwcCBpbiB0aGUgbWFrZWZpbGUKKworICAg ICAgICBDb21waWxlIG9zc291cmNlX3Bvc2l4LmNwcCBvciBvc3NvdXJjZV93aW4uY3BwIGRlcGVu ZGluZyBvbiB0aGUgdGFyZ2V0LgorCisgICAgICAgIE90aGVyd2lzZSB5b3UgZ2V0IGFuIGVycm9y OgorICAgICAgICAuLi93ZWJraXRndGstMi40LjgvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2NvbXBpbGVyL29zc291cmNlX3Bvc2l4LmNwcDoxMzoyOiBlcnJvcjogI2Vycm9yIFRyeWluZyB0 byBidWlsZCBhIHBvc2l4IHNwZWNpZmljIGZpbGUgaW4gYSBub24tcG9zaXggYnVpbGQuCisKKyAg ICAgICAgW0FOR0xFXVtXMzJdIEJ1aWxkc3lzdGVtIGlzIGhhcmRjb2RlZCBmb3IgVU5JWAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNzYyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBHTlVtYWtlZmls ZS5hbToKKwogMjAxNC0wNy0wNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxp YS5jb20+CiAKICAgICAgICAgW0dUS10gW1N0YWJsZV0gQ3Jhc2ggaW4gVFN5bWJvbFRhYmxlTGV2 ZWw6On5UU3ltYm9sVGFibGVMZXZlbCB3aXRoIEdDQyA0LjkKZGlmZiAtLWdpdCBhL1NvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL0dOVW1ha2VmaWxlLmFtIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUv R05VbWFrZWZpbGUuYW0KaW5kZXggNGMxNGFjMS4uNzA5MDRiYiAxMDA2NDQKLS0tIGEvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvR05VbWFrZWZpbGUuYW0KKysrIGIvU291cmNlL1RoaXJkUGFydHkv QU5HTEUvR05VbWFrZWZpbGUuYW0KQEAgLTgwLDcgKzgwLDYgQEAgbGliQU5HTEVfbGFfU09VUkNF UyA9IFwKIAlTb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvTU1hcC5oIFwKIAlT b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvTm9kZVNlYXJjaC5oIFwKIAlTb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvb3NpbmNsdWRlLmggXAotCVNvdXJjZS9U aGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9vc3NvdXJjZV9wb3NpeC5jcHAgXAogCVNvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9PdXRwdXRFU1NMLmNwcCBcCiAJU291cmNl L1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL091dHB1dEVTU0wuaCBcCiAJU291cmNlL1Ro aXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL091dHB1dEdMU0xCYXNlLmNwcCBcCkBAIC0xNjEs MyArMTYwLDkgQEAgbGliQU5HTEVfbGFfU09VUkNFUyA9IFwKIAlTb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9zcmMvY29tcGlsZXIvVmVyc2lvbkdMU0wuaCBcCiAJU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL3RoaXJkX3BhcnR5L2NvbXBpbGVyL0FycmF5Qm91bmRzQ2xhbXBlci5jcHAgXAogCVNv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy90aGlyZF9wYXJ0eS9jb21waWxlci9BcnJheUJvdW5k c0NsYW1wZXIuaAorCitpZiBUQVJHRVRfV0lOMzIKK2xpYkFOR0xFX2xhX1NPVVJDRVMgKz0gU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL29zc291cmNlX3dpbi5jcHAKK2Vsc2UK K2xpYkFOR0xFX2xhX1NPVVJDRVMgKz0gU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBp bGVyL29zc291cmNlX3Bvc2l4LmNwcAorZW5kaWYKLS0gCjEuOC41LjM=