143761 2015-04-15 06:23:14 -0700 [W32] GraphicsContextCairoWin.cpp fails to compile: unallowed function template partial specialization 2015-05-18 23:25:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 133028 1 lrn1986 webkit-unassigned cgarcia lrn1986 oldest_to_newest 1085456 0 lrn1986 2015-04-15 06:23:14 -0700 In file included from ../webkitgtk-2.4.8/Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp:35:0: ../webkitgtk-2.4.8/Source/WTF/wtf/win/GdiObject.h:114:58: error: function template partial specialization 'deleteObject<T>' is not allowed template<typename T> inline void deleteObject<T>(T object) ^ 1085539 1 250806 lrn1986 2015-04-15 09:56:06 -0700 Created attachment 250806 Fix deleteObject prototypte, fix header case Apparently, <T> is unneeded here: In file included from ../webkitgtk-2.4.8/Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp:35:0: ../webkitgtk-2.4.8/Source/WTF/wtf/win/GdiObject.h:114:58: error: function template partial specialization 'deleteObject<T>' is not allowed template<typename T> inline void deleteObject<T>(T object) ^ As a bonus, change GdiObject.h -> GDIObject.h (this matters when cross-compiling or when using case-sensitive filesystems on W32). 1095845 2 cgarcia 2015-05-18 23:25:20 -0700 Committed to 2.4 http://trac.webkit.org/changeset/184547 250806 2015-04-15 09:56:06 -0700 2015-04-15 10:33:37 -0700 Fix deleteObject prototypte, fix header case Fix-deleteObject-prototypte-fix-header-case.patch text/plain 5001 lrn1986 RnJvbSA1MzNmNDI2YWIxZTM1NzRlMWI2MDEzNDNhZTU0NzFkOTNjYzA1N2Q0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IE1vbiwg MTMgQXByIDIwMTUgMTI6MTE6NDcgKzAwMDAKU3ViamVjdDogW1BBVENIXSBGaXggZGVsZXRlT2Jq ZWN0IHByb3RvdHlwdGUsIGZpeCBoZWFkZXIgY2FzZQoKQXBwYXJlbnRseSwgPFQ+IGlzIHVubmVl ZGVkIGhlcmU6CgpJbiBmaWxlIGluY2x1ZGVkIGZyb20gLi4vd2Via2l0Z3RrLTIuNC44L1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRleHRDYWlyb1dpbi5j cHA6MzU6MDoKLi4vd2Via2l0Z3RrLTIuNC44L1NvdXJjZS9XVEYvd3RmL3dpbi9HZGlPYmplY3Qu aDoxMTQ6NTg6IGVycm9yOiBmdW5jdGlvbiB0ZW1wbGF0ZSBwYXJ0aWFsIHNwZWNpYWxpemF0aW9u ICdkZWxldGVPYmplY3Q8VD4nIGlzIG5vdCBhbGxvd2VkCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBp bmxpbmUgdm9pZCBkZWxldGVPYmplY3Q8VD4oVCBvYmplY3QpCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeCgpBcyBhIGJvbnVzLCBjaGFu Z2UgR2RpT2JqZWN0LmggLT4gR0RJT2JqZWN0LmggKHRoaXMgbWF0dGVycyB3aGVuCmNyb3NzLWNv bXBpbGluZyBvciB3aGVuIHVzaW5nIGNhc2Utc2Vuc2l0aXZlIGZpbGVzeXN0ZW1zIG9uIFczMiku CgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNzYxCi0tLQogU291 cmNlL1dURi9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAyMiArKysr KysrKysrKysrKysrKysrKysKIFNvdXJjZS9XVEYvd3RmL3dpbi9HRElPYmplY3QuaCAgICAgICAg ICAgICAgICAgICAgIHwgIDIgKy0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgMjMgKysrKysrKysrKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNz L3dpbi9HcmFwaGljc0NvbnRleHRDYWlyb1dpbi5jcHAgICAgICAgfCAgMiArLQogNCBmaWxlcyBj aGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggMWM1YzdlZi4u ODBiODkxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dU Ri9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNyBAQAogMjAxNS0wNC0xNSAg0KDRg9GB0LvQsNC9INCY 0LbQsdGD0LvQsNGC0L7QsiAgPGxybjE5ODZAZ21haWwuY29tPgogCisgICAgICAgIEZpeCBkZWxl dGVPYmplY3QgcHJvdG90eXB0ZSwgZml4IGhlYWRlciBjYXNlCisKKyAgICAgICAgQXBwYXJlbnRs eSwgPFQ+IGlzIHVubmVlZGVkIGhlcmU6CisKKyAgICAgICAgSW4gZmlsZSBpbmNsdWRlZCBmcm9t IC4uL3dlYmtpdGd0ay0yLjQuOC9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4v R3JhcGhpY3NDb250ZXh0Q2Fpcm9XaW4uY3BwOjM1OjA6CisgICAgICAgIC4uL3dlYmtpdGd0ay0y LjQuOC9Tb3VyY2UvV1RGL3d0Zi93aW4vR2RpT2JqZWN0Lmg6MTE0OjU4OiBlcnJvcjogZnVuY3Rp b24gdGVtcGxhdGUgcGFydGlhbCBzcGVjaWFsaXphdGlvbiAnZGVsZXRlT2JqZWN0PFQ+JyBpcyBu b3QgYWxsb3dlZAorICAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIHZvaWQgZGVs ZXRlT2JqZWN0PFQ+KFQgb2JqZWN0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXgorCisgICAgICAgIEFzIGEgYm9udXMs IGNoYW5nZSBHZGlPYmplY3QuaCAtPiBHRElPYmplY3QuaCAodGhpcyBtYXR0ZXJzIHdoZW4KKyAg ICAgICAgY3Jvc3MtY29tcGlsaW5nIG9yIHdoZW4gdXNpbmcgY2FzZS1zZW5zaXRpdmUgZmlsZXN5 c3RlbXMgb24gVzMyKS4KKworICAgICAgICBbVzMyXSBHcmFwaGljc0NvbnRleHRDYWlyb1dpbi5j cHAgZmFpbHMgdG8gY29tcGlsZTogdW5hbGxvd2VkIGZ1bmN0aW9uIHRlbXBsYXRlIHBhcnRpYWwg c3BlY2lhbGl6YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE0Mzc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogd3RmL3dpbi9HRElPYmplY3QuaDoKKyAgICAgICAgKFdURjo6ZGVsZXRlT2JqZWN0 KToKKworMjAxNS0wNC0xNSAg0KDRg9GB0LvQsNC9INCY0LbQsdGD0LvQsNGC0L7QsiAgPGxybjE5 ODZAZ21haWwuY29tPgorCiAgICAgICAgIEhhcm1vbml6ZSBiaW5hcnkgc2VtYXBob3JlIGlmZGVm cwogCiAgICAgICAgIFRoZXkgc2hvdWxkIGJlIGVpdGhlciBPUyhXSU5ET1dTKSAoaW4gd2hpY2gg Y2FzZSB3ZSdkIG5lZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3dpbi9HRElPYmplY3Qu aCBiL1NvdXJjZS9XVEYvd3RmL3dpbi9HRElPYmplY3QuaAppbmRleCBlOGIwMGJlLi40ZTAxYjNj ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvd2luL0dESU9iamVjdC5oCisrKyBiL1NvdXJj ZS9XVEYvd3RmL3dpbi9HRElPYmplY3QuaApAQCAtMTExLDcgKzExMSw3IEBAIHRlbXBsYXRlPHR5 cGVuYW1lIFQ+IGlubGluZSB2b2lkIHN3YXAoR0RJT2JqZWN0PFQ+JiBhLCBHRElPYmplY3Q8VD4m IGIpCiB9CiAKIC8vIE5lYXJseSBhbGwgR0RJIHR5cGVzIHVzZSB0aGUgc2FtZSBEZWxldGVPYmpl Y3QgY2FsbC4KLXRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSB2b2lkIGRlbGV0ZU9iamVjdDxU PihUIG9iamVjdCkKK3RlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSB2b2lkIGRlbGV0ZU9iamVj dChUIG9iamVjdCkKIHsKICAgICBpZiAob2JqZWN0KQogICAgICAgICA6OkRlbGV0ZU9iamVjdChv YmplY3QpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCmluZGV4IDdhMWExNTQuLmQ0OTIwZTcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyOCBAQAogMjAxNS0wNC0xNSAg0KDRg9GB0LvQsNC9INCY0LbQsdGD0LvQsNGC0L7QsiAg PGxybjE5ODZAZ21haWwuY29tPgogCisgICAgICAgIEZpeCBkZWxldGVPYmplY3QgcHJvdG90eXB0 ZSwgZml4IGhlYWRlciBjYXNlCisKKyAgICAgICAgQXBwYXJlbnRseSwgPFQ+IGlzIHVubmVlZGVk IGhlcmU6CisKKyAgICAgICAgSW4gZmlsZSBpbmNsdWRlZCBmcm9tIC4uL3dlYmtpdGd0ay0yLjQu OC9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250ZXh0Q2Fp cm9XaW4uY3BwOjM1OjA6CisgICAgICAgIC4uL3dlYmtpdGd0ay0yLjQuOC9Tb3VyY2UvV1RGL3d0 Zi93aW4vR2RpT2JqZWN0Lmg6MTE0OjU4OiBlcnJvcjogZnVuY3Rpb24gdGVtcGxhdGUgcGFydGlh bCBzcGVjaWFsaXphdGlvbiAnZGVsZXRlT2JqZWN0PFQ+JyBpcyBub3QgYWxsb3dlZAorICAgICAg ICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIHZvaWQgZGVsZXRlT2JqZWN0PFQ+KFQgb2Jq ZWN0KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgXgorCisgICAgICAgIEFzIGEgYm9udXMsIGNoYW5nZSBHZGlPYmplY3Qu aCAtPiBHRElPYmplY3QuaCAodGhpcyBtYXR0ZXJzIHdoZW4KKyAgICAgICAgY3Jvc3MtY29tcGls aW5nIG9yIHdoZW4gdXNpbmcgY2FzZS1zZW5zaXRpdmUgZmlsZXN5c3RlbXMgb24gVzMyKS4KKwor ICAgICAgICBbVzMyXSBHcmFwaGljc0NvbnRleHRDYWlyb1dpbi5jcHAgZmFpbHMgdG8gY29tcGls ZTogdW5hbGxvd2VkIGZ1bmN0aW9uIHRlbXBsYXRlIHBhcnRpYWwgc3BlY2lhbGl6YXRpb24KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mzc2MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cyAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29u dGV4dENhaXJvV2luLmNwcDoKKworMjAxNS0wNC0xNSAg0KDRg9GB0LvQsNC9INCY0LbQsdGD0LvQ sNGC0L7QsiAgPGxybjE5ODZAZ21haWwuY29tPgorCiAgICAgICAgIE1vdmUgZW51bSBMaW5lTGF5 b3V0UGF0aCBpbiBSZW5kZXJCbG9jawogCiAgICAgICAgIFRoaXMgcmVtb3ZlcyB0aGUgYml0Zmll bGQgaW50ZXJydXB0aW9uLCBhbGxvd2luZyBtb3JlIGVmZmljaWVudApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dENhaXJvV2lu LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9HcmFwaGljc0NvbnRl eHRDYWlyb1dpbi5jcHAKaW5kZXggMWIyZDg2NS4uM2ZiMmFjMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0dyYXBoaWNzQ29udGV4dENhaXJvV2luLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vR3JhcGhpY3NDb250 ZXh0Q2Fpcm9XaW4uY3BwCkBAIC0zMiw3ICszMiw3IEBACiAKICNpbmNsdWRlIDxjYWlyby13aW4z Mi5oPgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dFBsYXRmb3JtUHJpdmF0ZUNhaXJvLmgiCi0j aW5jbHVkZSA8d3RmL3dpbi9HZGlPYmplY3QuaD4KKyNpbmNsdWRlIDx3dGYvd2luL0dESU9iamVj dC5oPgogCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCi0tIAoxLjguNS4z