143759 2015-04-15 06:20:54 -0700 [GTK][W32] FileSystemGtk calls GetModuleHandleExA(), but does not include appropriate header 2022-03-01 02:23:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED WORKSFORME P2 Normal --- 133028 1 lrn1986 webkit-unassigned aperez bugs-noreply cgarcia commit-queue lrn1986 oldest_to_newest 1085454 0 lrn1986 2015-04-15 06:20:54 -0700 It needs to include <windows.h> 1085532 1 250804 lrn1986 2015-04-15 09:51:53 -0700 Created attachment 250804 Add missing includes to FileSystemGtk Needed for GetModuleHandleExA() & Co. 1085538 2 commit-queue 2015-04-15 09:55:11 -0700 Attachment 250804 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:12: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1085639 3 250839 lrn1986 2015-04-15 13:04:06 -0700 Created attachment 250839 Add missing includes to FileSystemGtk Needed for GetModuleHandleExA() & Co. 1095851 4 cgarcia 2015-05-18 23:36:36 -0700 Committed to 2.4 http://trac.webkit.org/changeset/184549 I'm leaving this open, since this applies to trunk as well, but for trunk I think we should probably remove the windows implementation from FileSystemGtk instead, since it's currently dead code. 1125673 5 250804 ossy 2015-09-14 11:14:14 -0700 Comment on attachment 250804 Add missing includes to FileSystemGtk Cleared Darin Adler's review+ from obsolete attachment 250804 so that this bug does not appear in http://webkit.org/pending-commit. 1846732 6 aperez 2022-02-28 12:54:23 -0800 The source has since been moved into Source/WTF/wtf/glib/FileSystemGlib.cpp which does include <windows.h> guarded by OS(WINDOWS) these days — the issue reported in this bug does no longer exist. 250804 2015-04-15 09:51:53 -0700 2015-09-14 11:14:14 -0700 Add missing includes to FileSystemGtk Add-missing-includes-to-FileSystemGtk.patch text/plain 1783 lrn1986 RnJvbSBlMjFjNDZjZjRkZjZlNzRiMzM0YTY2YWQyMGY5ZjE4NTM0MzYyOWRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IE1vbiwg MTMgQXByIDIwMTUgMDg6NDM6NTggKzAwMDAKU3ViamVjdDogW1BBVENIXSBBZGQgbWlzc2luZyBp bmNsdWRlcyB0byBGaWxlU3lzdGVtR3RrCgpOZWVkZWQgZm9yIEdldE1vZHVsZUhhbmRsZUV4QSgp ICYgQ28uCgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNzU5Ci0t LQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgIHwgMTUgKysr KysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvRmlsZVN5c3RlbUd0ay5j cHAgfCAgNCArKysrCiAyIGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKykKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggNDkyNmYzNy4uZTMzNWI2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE1 LTA0LTE1ICDQoNGD0YHQu9Cw0L0g0JjQttCx0YPQu9Cw0YLQvtCyICA8bHJuMTk4NkBnbWFpbC5j b20+CiAKKyAgICAgICAgQWRkIG1pc3NpbmcgaW5jbHVkZXMgdG8gRmlsZVN5c3RlbUd0aworCisg ICAgICAgIE5lZWRlZCBmb3IgR2V0TW9kdWxlSGFuZGxlRXhBKCkgJiBDby4KKworICAgICAgICBb R1RLXVtXMzJdIEZpbGVTeXN0ZW1HdGsgY2FsbHMgR2V0TW9kdWxlSGFuZGxlRXhBKCksIGJ1dCBk b2VzIG5vdCBpbmNsdWRlIGFwcHJvcHJpYXRlIGhlYWRlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ndGsvRmlsZVN5c3RlbUd0ay5jcHA6CisKKzIwMTUtMDQtMTUgINCg0YPR gdC70LDQvSDQmNC20LHRg9C70LDRgtC+0LIgIDxscm4xOTg2QGdtYWlsLmNvbT4KKwogICAgICAg ICBVc2UgcGlPdmVyVHdvRG91YmxlIGluc3RlYWQgb2YgTV9QSV8yCiAKICAgICAgICAgQmVjYXVz ZSBNX1BJXzIgaXMgbm90IGRlZmluZWQgZXZlcnl3aGVyZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2d0ay9GaWxlU3lzdGVtR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9GaWxlU3lzdGVtR3RrLmNwcAppbmRleCA5ZWJlY2E1Li5lNzQxZDFjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvRmlsZVN5c3RlbUd0ay5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0ZpbGVTeXN0ZW1HdGsuY3BwCkBAIC0yMyw2 ICsyMywxMCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkZpbGVTeXN0ZW0uaCIK IAorI2lmIE9TKFdJTkRPV1MpCisjaW5jbHVkZSA8d2luZG93cy5oPgorI2VuZGlmCisKICNpbmNs dWRlICJGaWxlTWV0YWRhdGEuaCIKICNpbmNsdWRlICJVVUlELmgiCiAjaW5jbHVkZSA8Z2lvL2dp by5oPgotLSAKMS44LjUuMw== 250839 2015-04-15 13:04:06 -0700 2022-03-01 02:23:19 -0800 Add missing includes to FileSystemGtk Add-missing-includes-to-FileSystemGtk.patch text/plain 1744 lrn1986 RnJvbSBjZGIxZTdmYmUxOWI4NzQwNWE4ZWQwNDZjNGFjMTY0MGU0YjFlNTFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/PUQwPUEwPUQxPTgzPUQxPTgxPUQwPUJCPUQw PUIwPUQwPUJEPTIwPUQwPTk4PUQwPUI2PUQwPUIxPz0KID0/VVRGLTg/cT89RDE9ODM9RDA9QkI9 RDA9QjA9RDE9ODI9RDA9QkU9RDA9QjI/PSA8bHJuMTk4NkBnbWFpbC5jb20+CkRhdGU6IE1vbiwg MTMgQXByIDIwMTUgMDg6NDM6NTggKzAwMDAKU3ViamVjdDogW1BBVENIXSBBZGQgbWlzc2luZyBp bmNsdWRlcyB0byBGaWxlU3lzdGVtR3RrCgpOZWVkZWQgZm9yIEdldE1vZHVsZUhhbmRsZUV4QSgp ICYgQ28uCgpodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQzNzU5Ci0t LQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgIHwgMTMgKysr KysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0ZpbGVTeXN0ZW1HdGsuY3Bw IHwgIDQgKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDQ5MjZmMzcuLjUzMDIxMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAxNS0w NC0xNSAg0KDRg9GB0LvQsNC9INCY0LbQsdGD0LvQsNGC0L7QsiAgPGxybjE5ODZAZ21haWwuY29t PgogCisgICAgICAgIEFkZCBtaXNzaW5nIGluY2x1ZGVzIHRvIEZpbGVTeXN0ZW1HdGsKKworICAg ICAgICBOZWVkZWQgZm9yIEdldE1vZHVsZUhhbmRsZUV4QSgpICYgQ28uCisKKyAgICAgICAgW0dU S11bVzMyXSBGaWxlU3lzdGVtR3RrIGNhbGxzIEdldE1vZHVsZUhhbmRsZUV4QSgpLCBidXQgZG9l cyBub3QgaW5jbHVkZSBhcHByb3ByaWF0ZSBoZWFkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE0Mzc1OQorCisgICAgICAgIFJldmlld2VkIGJ5IERh cmluIEFkbGVyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvRmlsZVN5c3RlbUd0ay5jcHA6CisK KzIwMTUtMDQtMTUgINCg0YPRgdC70LDQvSDQmNC20LHRg9C70LDRgtC+0LIgIDxscm4xOTg2QGdt YWlsLmNvbT4KKwogICAgICAgICBVc2UgcGlPdmVyVHdvRG91YmxlIGluc3RlYWQgb2YgTV9QSV8y CiAKICAgICAgICAgQmVjYXVzZSBNX1BJXzIgaXMgbm90IGRlZmluZWQgZXZlcnl3aGVyZS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9GaWxlU3lzdGVtR3RrLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9GaWxlU3lzdGVtR3RrLmNwcAppbmRleCA5ZWJl Y2E1Li5lNzQxZDFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvRmls ZVN5c3RlbUd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0ZpbGVTeXN0 ZW1HdGsuY3BwCkBAIC0yMyw2ICsyMywxMCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1 ZGUgIkZpbGVTeXN0ZW0uaCIKIAorI2lmIE9TKFdJTkRPV1MpCisjaW5jbHVkZSA8d2luZG93cy5o PgorI2VuZGlmCisKICNpbmNsdWRlICJGaWxlTWV0YWRhdGEuaCIKICNpbmNsdWRlICJVVUlELmgi CiAjaW5jbHVkZSA8Z2lvL2dpby5oPgotLSAKMS44LjUuMw==