143170 2015-03-27 18:39:08 -0700 parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind 2015-03-27 21:03:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 140491 1 rniwa rniwa fpizlo ggaren joepeck rniwa saam oldest_to_newest 1080844 0 rniwa 2015-03-27 18:39:08 -0700 parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind 1080846 1 249632 rniwa 2015-03-27 18:42:48 -0700 Created attachment 249632 Cleanup 1080847 2 249632 rniwa 2015-03-27 18:43:47 -0700 Comment on attachment 249632 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=249632&action=review > Source/JavaScriptCore/ChangeLog:9 > + since both base and derived default constructors should be using a 8-bit string. That is, two string literals we have in BuiltinExecutables::createDefaultConstructor. 1080871 3 249632 benjamin 2015-03-27 20:05:32 -0700 Comment on attachment 249632 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=249632&action=review > Source/JavaScriptCore/parser/Parser.h:1009 > + ASSERT(defaultConstructorKind == ConstructorKind::None); ASSERT -> ASSERT_WITH_MESSAGE. 1080876 4 rniwa 2015-03-27 21:03:31 -0700 Committed r182102: <http://trac.webkit.org/changeset/182102> 249632 2015-03-27 18:42:48 -0700 2015-03-27 20:05:32 -0700 Cleanup bug-143170-20150327184208.patch text/plain 1439 rniwa SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgyMDk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTAzLTI3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAg IHBhcnNlIGRvZXNuJ3QgaW5pdGlhbGl6ZSB0aGUgMTYtYml0IHZlcnNpb24gb2YgdGhlIEpTQyBw YXJzZXIgd2l0aCBkZWZhdWx0Q29uc3RydWN0b3JLaW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDMxNzAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBc3NlcnQgdGhhdCB3ZSBuZXZlciB1c2UgMTYtYml0 IHZlcnNpb24gb2YgdGhlIHBhcnNlciB0byBwYXJzZSBhIGRlZmF1bHQgY29uc3RydWN0b3IKKyAg ICAgICAgc2luY2UgYm90aCBiYXNlIGFuZCBkZXJpdmVkIGRlZmF1bHQgY29uc3RydWN0b3JzIHNo b3VsZCBiZSB1c2luZyBhIDgtYml0IHN0cmluZy4KKworICAgICAgICAqIHBhcnNlci9QYXJzZXIu aDoKKyAgICAgICAgKEpTQzo6cGFyc2UpOgorCiAyMDE1LTAzLTI3ICBNaWNoYWVsIFNhYm9mZiAg PG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBmbGFrZXkgZGZnLWludDhhcnJheS5q cyBhbmQgZGZnLWludDE2YXJyYXkuanMgdGVzdHMgZm9yIEFSTTY0CkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9wYXJzZXIvUGFyc2VyLmgJKHJldmlzaW9uIDE4MjA4OSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEwMDYsNiArMTAw Niw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxQYXJzZWROb2RlPiBwYXJzZSgKICAgICAgICAgfQogICAg ICAgICByZXR1cm4gcmVzdWx0OwogICAgIH0KKyAgICBBU1NFUlQoZGVmYXVsdENvbnN0cnVjdG9y S2luZCA9PSBDb25zdHJ1Y3RvcktpbmQ6Ok5vbmUpOwogICAgIFBhcnNlcjxMZXhlcjxVQ2hhcj4+ IHBhcnNlcih2bSwgc291cmNlLCBwYXJhbWV0ZXJzLCBuYW1lLCBidWlsdGluTW9kZSwgc3RyaWN0 TW9kZSwgY29kZVR5cGUpOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxQYXJzZWROb2RlPiByZXN1bHQg PSBwYXJzZXIucGFyc2U8UGFyc2VkTm9kZT4oZXJyb3IpOwogICAgIGlmIChwb3NpdGlvbkJlZm9y ZUxhc3ROZXdsaW5lKQo=