142983 2015-03-23 14:30:41 -0700 [Seccomp] Set appropriate filters when trapping syscalls by default 2015-07-27 22:27:10 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 140072 1 mcatanzaro mcatanzaro mcatanzaro zan oldest_to_newest 1079434 0 mcatanzaro 2015-03-23 14:30:41 -0700 If we trap syscalls by default, we must not manually set any filters to trap anything, since it will fail causing us to crash. But also, there are some things we must allow unconditionally even when trapping by default, for the broker to work. sigreturn, obviously, and brk. 1079436 1 249275 mcatanzaro 2015-03-23 14:34:19 -0700 Created attachment 249275 [Linux] Seccomp Filters: Set appropriate filters when trapping by default 1111299 2 mcatanzaro 2015-07-22 09:04:42 -0700 I think it would be nicer to use RELEASE_ASSERT_NOT_REACHED() rather than CRASH() here (note they are synonyms), but the existing code uses CRASH() so I picked that for consistency. 1112434 3 249275 zan 2015-07-27 10:26:19 -0700 Comment on attachment 249275 [Linux] Seccomp Filters: Set appropriate filters when trapping by default View in context: https://bugs.webkit.org/attachment.cgi?id=249275&action=review > Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:105 > + Action result = static_cast<Action>(value); Is converting to Action here required? 1112525 4 mcatanzaro 2015-07-27 15:14:25 -0700 (In reply to comment #3) > > Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:105 > > + Action result = static_cast<Action>(value); > > Is converting to Action here required? Thanks. Yes: ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:105:12: error: cannot initialize a variable of type 'WebKit::SeccompFilters::Action' with an lvalue of type 'uint32_t' (aka 'unsigned int') Action result = value; ^ ~~~~~ 1112527 5 mcatanzaro 2015-07-27 15:20:22 -0700 Committed r187455: <http://trac.webkit.org/changeset/187455> 1112673 6 zan 2015-07-27 22:27:10 -0700 (In reply to comment #4) > (In reply to comment #3) > > > Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:105 > > > + Action result = static_cast<Action>(value); > > > > Is converting to Action here required? > > Thanks. Yes: > > ../../Source/WebKit2/Shared/linux/SeccompFilters/SeccompFilters.cpp:105:12: > error: cannot initialize a variable of type 'WebKit::SeccompFilters::Action' > with an lvalue of type 'uint32_t' (aka 'unsigned int') > Action result = value; > ^ ~~~~~ What I meant was using the uint32_t variable directly in the switch conditional. At the second passing, I now see you have to return an Action value, so you'd have to cast it to the Action type in the return statement at the latest. 249275 2015-03-23 14:34:19 -0700 2015-07-27 10:26:19 -0700 [Linux] Seccomp Filters: Set appropriate filters when trapping by default bug-142983-20150323163343.patch text/plain 6250 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTgxODI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDlkNmJiMjE3NzE0NzI1 OTYwNDllYWQ5NGJjOGJmMDU0ODBiZTNmYy4uYTgyMjQyZmE5ODBkNzBkOTY1MGU5NzczNjUyMDQ0 ZDJlYWYzMWZjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE1LTAzLTIzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbU2VjY29t cF0gU2V0IGFwcHJvcHJpYXRlIGZpbHRlcnMgd2hlbiB0cmFwcGluZyBzeXNjYWxscyBieSBkZWZh dWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDI5 ODMKKworICAgICAgICBJZiB3ZSB0cmFwIHN5c2NhbGxzIGJ5IGRlZmF1bHQsIHdlIG11c3Qgbm90 IHNldCBzZXBhcmF0ZSBmaWx0ZXJzIHRvIHRyYXAKKyAgICAgICAgYW55dGhpbmcgaGVyZSwgc2lu Y2UgaXQgd2lsbCBmYWlsIGNhdXNpbmcgdXMgdG8gY3Jhc2guCisKKyAgICAgICAgQnV0IGFsc28s IHRoZXJlIGFyZSBzb21lIHRoaW5ncyB3ZSBtdXN0IGFsbG93IHVuY29uZGl0aW9uYWxseSBldmVu IHdoZW4KKyAgICAgICAgdHJhcHBpbmcgYnkgZGVmYXVsdC4gc2lncmV0dXJuLCBvYnZpb3VzbHku IEFsc28sIGxldCdzIHdoaXRlbGlzdCBicmsKKyAgICAgICAgaGVyZSBpbnN0ZWFkIG9mIGluIHBs YXRmb3JtLXNwZWNpZmljIGNvZGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU2VjY29tcEJyb2tl ci5jcHA6CisgICAgICAgIChXZWJLaXQ6OlNlY2NvbXBCcm9rZXI6OmxhdW5jaFByb2Nlc3MpOiBE b24ndCB0cmFwIHNpZ3Byb2NtYXNrIG9yIHNpZ2FjdGlvbiB1bmxlc3MgYWxsb3cgaXMKKyAgICAg ICAgdGhlIGRlZmF1bHQgYWN0aW9uLiBBbHNvLCBhbGxvdyBzaWdyZXR1cm4gYW5kIGJyayBpcyBh bGxvdyBpcyBub3QgdGhlIGRlZmF1bHQuCisgICAgICAgICogU2hhcmVkL2xpbnV4L1NlY2NvbXBG aWx0ZXJzL1NlY2NvbXBGaWx0ZXJzLmNwcDogQWRkZWQKKyAgICAgICAgKFdlYktpdDo6U2VjY29t cEZpbHRlcnM6OmRlZmF1bHRBY3Rpb24pOgorICAgICAgICAqIFNoYXJlZC9saW51eC9TZWNjb21w RmlsdGVycy9TZWNjb21wRmlsdGVycy5oOiBBZGRlZCBkZWZhdWx0QWN0aW9uCisKKzIwMTUtMDMt MjMgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAg IFtTZWNjb21wXSBBZGQgaGVscGVycyB0byBnZXQgWERHIGJhc2UgZGlyZWN0b3J5IGxvY2F0aW9u cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTQyOTgy CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9saW51eC9TZWNjb21wRmlsdGVy cy9TZWNjb21wQnJva2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9saW51eC9TZWNjb21w RmlsdGVycy9TZWNjb21wQnJva2VyLmNwcAppbmRleCAwMjFlYmM4MWExNzllODM1Y2NlZGU3YTk5 NDlhMTFhZWI4MzUzNTNjLi5jYWNhMmRjZTk2MGZiOTAwMmQyYjViZTAzMDllODQ3Yjk4ZWFmMDI3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMv U2VjY29tcEJyb2tlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2xpbnV4L1NlY2Nv bXBGaWx0ZXJzL1NlY2NvbXBCcm9rZXIuY3BwCkBAIC0yNjgsMjcgKzI2OCwzOSBAQCB2b2lkIFNl Y2NvbXBCcm9rZXI6OmxhdW5jaFByb2Nlc3MoU2VjY29tcEZpbHRlcnMqIGZpbHRlcnMsIGNvbnN0 IFN5c2NhbGxQb2xpY3kmCiAgICAgaWYgKGluaXRpYWxpemVkKQogICAgICAgICByZXR1cm47CiAK LSAgICAvLyBUaGUgc2lncHJvY21hc2sgZmlsdGVycyBiZWxsb3cgYXJlIG5lZWRlZCB0byB0cmFw IHNpZ3Byb2NtYXNrKCkKLSAgICAvLyBzbyB3ZSBjYW4gcHJldmVudCB0aGUgcnVubmluZyBwcm9j ZXNzZXMgZnJvbSBibG9ja2luZyBTSUdTWVMuCi0gICAgZmlsdGVycy0+YWRkUnVsZSgic2lncHJv Y21hc2siLCBTZWNjb21wRmlsdGVyczo6VHJhcCwKLSAgICAgICAgMCwgU2VjY29tcEZpbHRlcnM6 OkVxdWFsLCBTSUdfQkxPQ0ssCi0gICAgICAgIDEsIFNlY2NvbXBGaWx0ZXJzOjpOb3RFcXVhbCwg MCk7Ci0gICAgZmlsdGVycy0+YWRkUnVsZSgic2lncHJvY21hc2siLCBTZWNjb21wRmlsdGVyczo6 VHJhcCwKLSAgICAgICAgMCwgU2VjY29tcEZpbHRlcnM6OkVxdWFsLCBTSUdfU0VUTUFTSywKLSAg ICAgICAgMSwgU2VjY29tcEZpbHRlcnM6Ok5vdEVxdWFsLCAwKTsKLSAgICBmaWx0ZXJzLT5hZGRS dWxlKCJydF9zaWdwcm9jbWFzayIsIFNlY2NvbXBGaWx0ZXJzOjpUcmFwLAotICAgICAgICAwLCBT ZWNjb21wRmlsdGVyczo6RXF1YWwsIFNJR19CTE9DSywKLSAgICAgICAgMSwgU2VjY29tcEZpbHRl cnM6Ok5vdEVxdWFsLCAwKTsKLSAgICBmaWx0ZXJzLT5hZGRSdWxlKCJydF9zaWdwcm9jbWFzayIs IFNlY2NvbXBGaWx0ZXJzOjpUcmFwLAotICAgICAgICAwLCBTZWNjb21wRmlsdGVyczo6RXF1YWws IFNJR19TRVRNQVNLLAotICAgICAgICAxLCBTZWNjb21wRmlsdGVyczo6Tm90RXF1YWwsIDApOwot Ci0gICAgLy8gVGhlIHNpZ2FjdGlvbiBmaWx0ZXJzIGJlbGxvdyBhcmUgbmVlZGVkIHRvIHRyYXAg c2lnYWN0aW9uKCkKLSAgICAvLyBzbyB3ZSBjYW4gcHJldmVudCB0aGUgcnVubmluZyBwcm9jZXNz ZXMgZnJvbSBoYW5kbGluZyBTSUdTWVMuCi0gICAgZmlsdGVycy0+YWRkUnVsZSgic2lnYWN0aW9u IiwgU2VjY29tcEZpbHRlcnM6OlRyYXAsCi0gICAgICAgIDAsIFNlY2NvbXBGaWx0ZXJzOjpFcXVh bCwgU0lHU1lTKTsKLSAgICBmaWx0ZXJzLT5hZGRSdWxlKCJydF9zaWdhY3Rpb24iLCBTZWNjb21w RmlsdGVyczo6VHJhcCwKLSAgICAgICAgMCwgU2VjY29tcEZpbHRlcnM6OkVxdWFsLCBTSUdTWVMp OworICAgIGlmIChmaWx0ZXJzLT5kZWZhdWx0QWN0aW9uKCkgPT0gU2VjY29tcEZpbHRlcnM6OkFs bG93KSB7CisgICAgICAgIC8vIFRoZSBzaWdwcm9jbWFzayBmaWx0ZXJzIGJlbGxvdyBhcmUgbmVl ZGVkIHRvIHRyYXAgc2lncHJvY21hc2soKQorICAgICAgICAvLyBzbyB3ZSBjYW4gcHJldmVudCB0 aGUgcnVubmluZyBwcm9jZXNzZXMgZnJvbSBibG9ja2luZyBTSUdTWVMuCisgICAgICAgIGZpbHRl cnMtPmFkZFJ1bGUoInNpZ3Byb2NtYXNrIiwgU2VjY29tcEZpbHRlcnM6OlRyYXAsCisgICAgICAg ICAgICAwLCBTZWNjb21wRmlsdGVyczo6RXF1YWwsIFNJR19CTE9DSywKKyAgICAgICAgICAgIDEs IFNlY2NvbXBGaWx0ZXJzOjpOb3RFcXVhbCwgMCk7CisgICAgICAgIGZpbHRlcnMtPmFkZFJ1bGUo InNpZ3Byb2NtYXNrIiwgU2VjY29tcEZpbHRlcnM6OlRyYXAsCisgICAgICAgICAgICAwLCBTZWNj b21wRmlsdGVyczo6RXF1YWwsIFNJR19TRVRNQVNLLAorICAgICAgICAgICAgMSwgU2VjY29tcEZp bHRlcnM6Ok5vdEVxdWFsLCAwKTsKKyAgICAgICAgZmlsdGVycy0+YWRkUnVsZSgicnRfc2lncHJv Y21hc2siLCBTZWNjb21wRmlsdGVyczo6VHJhcCwKKyAgICAgICAgICAgIDAsIFNlY2NvbXBGaWx0 ZXJzOjpFcXVhbCwgU0lHX0JMT0NLLAorICAgICAgICAgICAgMSwgU2VjY29tcEZpbHRlcnM6Ok5v dEVxdWFsLCAwKTsKKyAgICAgICAgZmlsdGVycy0+YWRkUnVsZSgicnRfc2lncHJvY21hc2siLCBT ZWNjb21wRmlsdGVyczo6VHJhcCwKKyAgICAgICAgICAgIDAsIFNlY2NvbXBGaWx0ZXJzOjpFcXVh bCwgU0lHX1NFVE1BU0ssCisgICAgICAgICAgICAxLCBTZWNjb21wRmlsdGVyczo6Tm90RXF1YWws IDApOworCisgICAgICAgIC8vIFRoZSBzaWdhY3Rpb24gZmlsdGVycyBiZWxsb3cgYXJlIG5lZWRl ZCB0byB0cmFwIHNpZ2FjdGlvbigpCisgICAgICAgIC8vIHNvIHdlIGNhbiBwcmV2ZW50IHRoZSBy dW5uaW5nIHByb2Nlc3NlcyBmcm9tIGhhbmRsaW5nIFNJR1NZUy4KKyAgICAgICAgZmlsdGVycy0+ YWRkUnVsZSgic2lnYWN0aW9uIiwgU2VjY29tcEZpbHRlcnM6OlRyYXAsCisgICAgICAgICAgICAw LCBTZWNjb21wRmlsdGVyczo6RXF1YWwsIFNJR1NZUyk7CisgICAgICAgIGZpbHRlcnMtPmFkZFJ1 bGUoInJ0X3NpZ2FjdGlvbiIsIFNlY2NvbXBGaWx0ZXJzOjpUcmFwLAorICAgICAgICAgICAgMCwg U2VjY29tcEZpbHRlcnM6OkVxdWFsLCBTSUdTWVMpOworICAgIH0KKworICAgIGlmIChmaWx0ZXJz LT5kZWZhdWx0QWN0aW9uKCkgIT0gU2VjY29tcEZpbHRlcnM6OkFsbG93KSB7CisgICAgICAgIC8v IE5lZWRlZCBmb3IgdGhlIFNJR1NZUyBoYW5kbGVyIHRvIHdvcmsuCisgICAgICAgIGZpbHRlcnMt PmFkZFJ1bGUoInNpZ3JldHVybiIsIFNlY2NvbXBGaWx0ZXJzOjpBbGxvdyk7CisgICAgICAgIGZp bHRlcnMtPmFkZFJ1bGUoInJ0X3NpZ3JldHVybiIsIFNlY2NvbXBGaWx0ZXJzOjpBbGxvdyk7CisK KyAgICAgICAgLy8gTmVlZGVkIGJ5IG1hbGxvYyBhbmQgZnJlZS4gV2UgbXVzdCBuZXZlciB0cmFw IGEgc3lzY2FsbCBpbnNpZGUgZWl0aGVyCisgICAgICAgIC8vIGJlY2F1c2Ugd2UgbmVlZCB0aGVt IGluIG91ciBTSUdTWVMgaGFuZGxlciBhbmQgdGhleSBhcmUgbm9ucmVlbnRyYW50LgorICAgICAg ICBmaWx0ZXJzLT5hZGRSdWxlKCJicmsiLCBTZWNjb21wRmlsdGVyczo6QWxsb3cpOworICAgIH0K IAogICAgIFNlY2NvbXBCcm9rZXIgc2VjY29tcEJyb2tlcjsKICAgICBzZWNjb21wQnJva2VyLnNl dFN5c2NhbGxQb2xpY3kocG9saWN5KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9saW51eC9TZWNjb21wRmlsdGVycy9TZWNjb21wRmlsdGVycy5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU2VjY29tcEZpbHRlcnMuY3BwCmluZGV4IDRm OTBkMzI0YmNhNDE3MjdlNmJjMTE3ODFhYTM2ZTk1YTc0ZTU2OTMuLjYyMTZkZmQzM2U0MTM1NzAz ZWVjZTU4NzYzZWNjNTNkNjJlZDg0NWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJl ZC9saW51eC9TZWNjb21wRmlsdGVycy9TZWNjb21wRmlsdGVycy5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvU2hhcmVkL2xpbnV4L1NlY2NvbXBGaWx0ZXJzL1NlY2NvbXBGaWx0ZXJzLmNwcApAQCAt OTYsNiArOTYsMjMgQEAgdm9pZCBTZWNjb21wRmlsdGVyczo6aW5pdGlhbGl6ZSgpCiAgICAgbV9p bml0aWFsaXplZCA9IHRydWU7CiB9CiAKK1NlY2NvbXBGaWx0ZXJzOjpBY3Rpb24gU2VjY29tcEZp bHRlcnM6OmRlZmF1bHRBY3Rpb24oKSBjb25zdAoreworICAgIHVpbnQzMl90IHZhbHVlOworICAg IGlmIChzZWNjb21wX2F0dHJfZ2V0KG1fY29udGV4dCwgU0NNUF9GTFRBVFJfQUNUX0RFRkFVTFQs ICZ2YWx1ZSkgPT0gLTEpCisgICAgICAgIENSQVNIKCk7CisKKyAgICBBY3Rpb24gcmVzdWx0ID0g c3RhdGljX2Nhc3Q8QWN0aW9uPih2YWx1ZSk7CisgICAgc3dpdGNoIChyZXN1bHQpIHsKKyAgICBj YXNlIEFsbG93OgorICAgIGNhc2UgS2lsbDoKKyAgICBjYXNlIFRyYXA6CisgICAgICAgIHJldHVy biByZXN1bHQ7CisgICAgfQorCisgICAgQ1JBU0goKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2Vi S2l0CiAKICNlbmRpZiAvLyBFTkFCTEUoU0VDQ09NUF9GSUxURVJTKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvU2hhcmVkL2xpbnV4L1NlY2NvbXBGaWx0ZXJzL1NlY2NvbXBGaWx0ZXJzLmgg Yi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU2VjY29tcEZpbHRl cnMuaAppbmRleCAxZTZhYjE1NGM0NTc0YjEzNzIzMTljMWMyMDVhNjRlZWFhZDgxZWQ4Li5mN2Rm ZTlmM2Y5YzVhODRhYzNlMGEyYjU5MzEzOGNmNTExNGViMDA4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU2VjY29tcEZpbHRlcnMuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbGludXgvU2VjY29tcEZpbHRlcnMvU2VjY29tcEZpbHRl cnMuaApAQCAtNTksNiArNTksOCBAQCBwdWJsaWM6CiAKICAgICB2b2lkIGluaXRpYWxpemUoKTsK IAorICAgIEFjdGlvbiBkZWZhdWx0QWN0aW9uKCkgY29uc3Q7CisKIHByaXZhdGU6CiAgICAgdmly dHVhbCB2b2lkIHBsYXRmb3JtSW5pdGlhbGl6ZSgpIHsgfQogCg==