142531 2015-03-10 05:43:55 -0700 [Win] 17 different JSC tests started to fail in DST 2015-03-11 00:02:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=138303 https://bugs.webkit.org/show_bug.cgi?id=139123 P2 Normal --- 1 ossy bfulgham achristensen benjamin bfulgham cdumez cmarcelo commit-queue ggaren mark.lam ossy peavo roger_fong oldest_to_newest 1075950 0 ossy 2015-03-10 05:43:55 -0700 Since daylight saving time is started in CA, 17 different date tests started to fail on Windows bots. (Apple Windows + WinCairo) jsc-layout-tests.yaml/js/script-tests/date-parse-comments-test.js.layout jsc-layout-tests.yaml/js/script-tests/date-parse-test.js.layout jsc-layout-tests.yaml/js/script-tests/date-set-to-nan.js.layout mozilla-tests.yaml/ecma/Date/15.9.3.1-1.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.3.1-2.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.3.1-3.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.3.1-4.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.3.1-5.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.3.2-1.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.3.2-2.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.3.2-3.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.3.2-4.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.3.2-5.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.4.2-1.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.5.26-1.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.5.27-1.js.mozilla mozilla-tests.yaml/ecma/Date/15.9.5.30-1.js.mozilla similar bugs: bug138303 and bug139123 1076043 1 peavo 2015-03-10 13:04:10 -0700 This might be wrong, but I get zero stress test failures, with the diff below. It seems the documentation for GetTimeZoneInformation can be interpreted as the DST bias is already included in the bias member. Maybe someone can confirm? Index: DateMath.cpp =================================================================== --- DateMath.cpp (revisjon 181279) +++ DateMath.cpp (arbeidskopi) @@ -369,11 +369,7 @@ if (rc == TIME_ZONE_ID_INVALID) return 0; - int32_t bias = 0; - if (rc == TIME_ZONE_ID_DAYLIGHT) - bias = timeZoneInformation.Bias + timeZoneInformation.DaylightBias; - else if (rc == TIME_ZONE_ID_STANDARD || rc == TIME_ZONE_ID_UNKNOWN) - bias = timeZoneInformation.Bias + timeZoneInformation.StandardBias; + int32_t bias = timeZoneInformation.Bias; return -bias * 60 * 1000; #else 1076057 2 achristensen 2015-03-10 13:33:24 -0700 I think you're right. Put up a patch and let Brent double check it. He wrote the code in question about 6 months ago, probably last time daylight savings time changed. 1076068 3 248354 peavo 2015-03-10 13:54:34 -0700 Created attachment 248354 Patch 1076076 4 bfulgham 2015-03-10 14:13:30 -0700 (In reply to comment #2) > I think you're right. Put up a patch and let Brent double check it. He > wrote the code in question about 6 months ago, probably last time daylight > savings time changed. I don't think this is right. The calculation was working properly while we were in DST, so at the very least I would expect the 'correct' code to still do the Bias calculation including the "DaylightBias" value. According to <https://msdn.microsoft.com/en-us/library/windows/desktop/ms725481(v=vs.85).aspx>, StandardBias is normally zero. So "timeZoneInformation.Bias + timeZoneInformation.StandardBias" during standard time is equivalent to "timeZoneInformation.Bias". 1076085 5 achristensen 2015-03-10 14:32:45 -0700 Well the current calculation is wrong right now. I wish there were an easy way to test this without waiting 6 months to see how things change. We should test this in Arizona, too :) 1076152 6 bfulgham 2015-03-10 17:48:19 -0700 (In reply to comment #5) > Well the current calculation is wrong right now. I wish there were an easy > way to test this without waiting 6 months to see how things change. We > should test this in Arizona, too :) The current calculation is failing because 'GetTimeZoneInformation' is returning TIME_ZONE_ID_DAYLIGHT, instead of TIME_ZONE_ID_STANDARD. The date that DST ends varies from year-to-year. Apparently this didn't get updated on Windows, or maybe the function I'm calling isn't smart enough to account for this. According to MSDN, there is another function (in Vista and newer) that should do the right thing. I'll have to 'soft link' to it, since we don't know what OS we are running on, but that might fix it. I'll give it a try and see. 1076177 7 248384 bfulgham 2015-03-10 19:07:21 -0700 Created attachment 248384 Patch 1076179 8 248385 bfulgham 2015-03-10 19:09:08 -0700 Created attachment 248385 Patch 1076184 9 248385 cdumez 2015-03-10 19:15:24 -0700 Comment on attachment 248385 Patch r=me 1076192 10 bfulgham 2015-03-10 19:34:29 -0700 Committed r181360: <http://trac.webkit.org/changeset/181360> 1076263 11 peavo 2015-03-11 00:02:55 -0700 (In reply to comment #6) > (In reply to comment #5) > > Well the current calculation is wrong right now. I wish there were an easy > > way to test this without waiting 6 months to see how things change. We > > should test this in Arizona, too :) > > The current calculation is failing because 'GetTimeZoneInformation' is > returning TIME_ZONE_ID_DAYLIGHT, instead of TIME_ZONE_ID_STANDARD. > > The date that DST ends varies from year-to-year. Apparently this didn't get > updated on Windows, or maybe the function I'm calling isn't smart enough to > account for this. > > According to MSDN, there is another function (in Vista and newer) that > should do the right thing. I'll have to 'soft link' to it, since we don't > know what OS we are running on, but that might fix it. > > I'll give it a try and see. Great :) I thought DST already had started in the US (8. of March), but I guess that was not the case :) 248354 2015-03-10 13:54:34 -0700 2015-03-10 19:07:00 -0700 Patch bug-142531-20150310225400.patch text/plain 1443 peavo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODEzNDUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE1LTAzLTEwICBQZXIgQXJuZSBWb2xsYW4gIDxw ZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luXSAxNyBkaWZmZXJlbnQgSlNDIHRlc3Rz IHN0YXJ0ZWQgdG8gZmFpbCBpbiBEU1QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0MjUzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFRoZSBEU1QgYmlhcyBzZWVtIHRvIGJlIGluY2x1ZGVkIGluIHRoZSBC aWFzIG1lbWJlciBvZiB0aGUgVElNRV9aT05FX0lORk9STUFUSU9OCisgICAgICAgIHN0cnVjdHVy ZSwgc28gd2Ugb25seSBuZWVkIHRvIHRha2UgdGhlIEJpYXMgbWVtYmVyIGludG8gYWNjb3VudC4K KworICAgICAgICAqIHd0Zi9EYXRlTWF0aC5jcHA6CisgICAgICAgIChXVEY6OmNhbGN1bGF0ZVVU Q09mZnNldCk6CisKIDIwMTUtMDMtMTAgIFNhaWQgQWJvdS1IYWxsYXdhICA8c2Fib3VoYWxsYXdh QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgUGFzc1JlZlB0ciBmcm9tIHN2Zy9wcm9wZXJ0 aWVzIGNsYXNzZXMuCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9EYXRlTWF0aC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dURi93dGYvRGF0ZU1hdGguY3BwCShyZXZpc2lvbiAxODEyODMpCisrKyBT b3VyY2UvV1RGL3d0Zi9EYXRlTWF0aC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2OSwxMSArMzY5 LDcgQEAgc3RhdGljIGludDMyX3QgY2FsY3VsYXRlVVRDT2Zmc2V0KCkKICAgICBpZiAocmMgPT0g VElNRV9aT05FX0lEX0lOVkFMSUQpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgaW50MzJfdCBi aWFzID0gMDsKLSAgICBpZiAocmMgPT0gVElNRV9aT05FX0lEX0RBWUxJR0hUKQotICAgICAgICBi aWFzID0gdGltZVpvbmVJbmZvcm1hdGlvbi5CaWFzICsgdGltZVpvbmVJbmZvcm1hdGlvbi5EYXls aWdodEJpYXM7Ci0gICAgZWxzZSBpZiAocmMgPT0gVElNRV9aT05FX0lEX1NUQU5EQVJEIHx8IHJj ID09IFRJTUVfWk9ORV9JRF9VTktOT1dOKQotICAgICAgICBiaWFzID0gdGltZVpvbmVJbmZvcm1h dGlvbi5CaWFzICsgdGltZVpvbmVJbmZvcm1hdGlvbi5TdGFuZGFyZEJpYXM7CisgICAgaW50MzJf dCBiaWFzID0gdGltZVpvbmVJbmZvcm1hdGlvbi5CaWFzOwogCiAgICAgcmV0dXJuIC1iaWFzICog NjAgKiAxMDAwOwogI2Vsc2UK 248384 2015-03-10 19:07:21 -0700 2015-03-10 19:09:03 -0700 Patch bug-142531-20150310191620.patch text/plain 3751 bfulgham SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODEzNTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAzLTEwICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIDE3IGRpZmZlcmVudCBKU0MgdGVzdHMg c3RhcnRlZCB0byBmYWlsIGluIERTVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQyNTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIHN0b2NrICdHZXRUaW1lWm9uZUluZm9ybWF0aW9uJyBjYWxsIGRv ZXMgbm90IGFsd2F5cyBtYXRjaCB0aGUgYWN0dWFsIERheWxpZ2h0CisgICAgICAgIFNhdmluZ3Mg Y2FsZW5kYXIuIFRoaXMgcmVzdWx0cyBpbiBhIHBlcmlvZCBvZiB0aW1lIHdoZW4gdGhlc2UgdGVz dHMgZmFpbC4KKworICAgICAgICBJZiBhdmFpbGFibGUsIHdlIHNob3VsZCB0YWtlIGFkdmFudGFn ZSBvZiB0aGUgbmV3ICdHZXRUaW1lWm9uZUluZm9ybWF0aW9uRm9yWWVhcicsCisgICAgICAgIHdo aWNoIGFjY2Vzc2VzIGEgZHluYW1pYyBjYWxlbmRhciBvZiBEU1QgZGF0ZXMsIHdoaWNoIGlzIHBy ZXN1bWJhYmx5IHVwZGF0ZWQgYnkKKyAgICAgICAgTWljcm9zb2Z0IGZyb20geWVhci10by15ZWFy LgorCisgICAgICAgICogd3RmL0RhdGVNYXRoLmNwcDoKKyAgICAgICAgKFdURjo6dGltZVpvbmVJ bmZvcm1hdGlvbkZvclllYXJGdW5jdGlvbik6IE5ldyBmdW5jdGlvbiB0byBjb25kaXRpb25hbGx5 IGFjY2VzcworICAgICAgICBzb21lIFZpc3RhIChhbmQgbmV3ZXIpIGZ1bmN0aW9uYWxpdHkuCisg ICAgICAgIChXVEY6OmNhbGN1bGF0ZVVUQ09mZnNldCk6IENhbGwgbmV3IGZ1bmN0aW9uIChpZiBh dmFpbGFibGUpIHRvIGNhbGN1bGF0ZSBwcm9wZXIgVVRDCisgICAgICAgIHRpbWUgb2Zmc2V0Lgor CiAyMDE1LTAzLTEwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVXNlIHVuc2lnbmVkIGZvciBIYXNoU2V0IHNpemUuCkluZGV4OiBTb3VyY2Uv V1RGL3d0Zi9EYXRlTWF0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvRGF0ZU1h dGguY3BwCShyZXZpc2lvbiAxODEzNDUpCisrKyBTb3VyY2UvV1RGL3d0Zi9EYXRlTWF0aC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTksNyArOSw2IEBACiAgKiBNYXJjaCAzMSwgMTk5OC4KICAqCiAg KiBUaGUgSW5pdGlhbCBEZXZlbG9wZXIgb2YgdGhlIE9yaWdpbmFsIENvZGUgaXMKLSAqIE5ldHNj YXBlIENvbW11bmljYXRpb25zIENvcnBvcmF0aW9uLgogICogUG9ydGlvbnMgY3JlYXRlZCBieSB0 aGUgSW5pdGlhbCBEZXZlbG9wZXIgYXJlIENvcHlyaWdodCAoQykgMTk5OAogICogdGhlIEluaXRp YWwgRGV2ZWxvcGVyLiBBbGwgUmlnaHRzIFJlc2VydmVkLgogICoKQEAgLTM2MSwxOSArMzYwLDUy IEBAIGludCBlcXVpdmFsZW50WWVhckZvckRTVChpbnQgeWVhcikKICAgICByZXR1cm4geWVhcjsK IH0KIAorI2lmIE9TKFdJTkRPV1MpCit0eXBlZGVmIEJPT0woV0lOQVBJKiBjYWxsR2V0VGltZVpv bmVJbmZvcm1hdGlvbkZvclllYXJfdCkoVVNIT1JULCBQRFlOQU1JQ19USU1FX1pPTkVfSU5GT1JN QVRJT04sIExQVElNRV9aT05FX0lORk9STUFUSU9OKTsKKworc3RhdGljIGNhbGxHZXRUaW1lWm9u ZUluZm9ybWF0aW9uRm9yWWVhcl90IHRpbWVab25lSW5mb3JtYXRpb25Gb3JZZWFyRnVuY3Rpb24o KQoreworICAgIHN0YXRpYyBjYWxsR2V0VGltZVpvbmVJbmZvcm1hdGlvbkZvclllYXJfdCBnZXRU aW1lWm9uZUluZm9ybWF0aW9uRm9yWWVhciA9IG51bGxwdHI7CisKKyAgICBpZiAoZ2V0VGltZVpv bmVJbmZvcm1hdGlvbkZvclllYXIpCisgICAgICAgIHJldHVybiBnZXRUaW1lWm9uZUluZm9ybWF0 aW9uRm9yWWVhcjsKKworICAgIEhNT0RVTEUgbW9kdWxlID0gOjpHZXRNb2R1bGVIYW5kbGVXKEwi a2VybmVsMzIuZGxsIik7CisgICAgaWYgKCFtb2R1bGUpCisgICAgICAgIHJldHVybiBudWxscHRy OworCisgICAgZ2V0VGltZVpvbmVJbmZvcm1hdGlvbkZvclllYXIgPSByZWludGVycHJldF9jYXN0 PGNhbGxHZXRUaW1lWm9uZUluZm9ybWF0aW9uRm9yWWVhcl90Pig6OkdldFByb2NBZGRyZXNzKG1v ZHVsZSwgIkdldFRpbWVab25lSW5mb3JtYXRpb25Gb3JZZWFyIikpOworCisgICAgcmV0dXJuIGdl dFRpbWVab25lSW5mb3JtYXRpb25Gb3JZZWFyOworfQorI2VuZGlmCisKIHN0YXRpYyBpbnQzMl90 IGNhbGN1bGF0ZVVUQ09mZnNldCgpCiB7CiAjaWYgT1MoV0lORE9XUykKICAgICBUSU1FX1pPTkVf SU5GT1JNQVRJT04gdGltZVpvbmVJbmZvcm1hdGlvbjsKLSAgICBEV09SRCByYyA9IDo6R2V0VGlt ZVpvbmVJbmZvcm1hdGlvbigmdGltZVpvbmVJbmZvcm1hdGlvbik7Ci0gICAgaWYgKHJjID09IFRJ TUVfWk9ORV9JRF9JTlZBTElEKQotICAgICAgICByZXR1cm4gMDsKKyAgICBEV09SRCByYyA9IDA7 CisKKyAgICBpZiAoY2FsbEdldFRpbWVab25lSW5mb3JtYXRpb25Gb3JZZWFyX3QgdGltZVpvbmVG dW5jdGlvbiA9IHRpbWVab25lSW5mb3JtYXRpb25Gb3JZZWFyRnVuY3Rpb24oKSkgeworICAgICAg ICAvLyBJZiBhdmFpbGFibGUsIHVzZSB0aGUgV2luZG93cyBBUEkgY2FsbCB0aGF0IHRha2VzIGlu dG8gYWNjb3VudCB0aGUgdmFyeWluZyBEU1QgZnJvbQorICAgICAgICAvLyB5ZWFyIHRvIHllYXIu CisgICAgICAgIFNZU1RFTVRJTUUgc3lzdGVtVGltZTsKKyAgICAgICAgOjpHZXRTeXN0ZW1UaW1l KCZzeXN0ZW1UaW1lKTsKKyAgICAgICAgcmMgPSB0aW1lWm9uZUZ1bmN0aW9uKHN5c3RlbVRpbWUu d1llYXIsIG51bGxwdHIsICZ0aW1lWm9uZUluZm9ybWF0aW9uKTsKKyAgICAgICAgaWYgKHJjID09 IFRJTUVfWk9ORV9JRF9JTlZBTElEKQorICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgfSBlbHNl IHsKKyAgICAgICAgcmMgPSA6OkdldFRpbWVab25lSW5mb3JtYXRpb24oJnRpbWVab25lSW5mb3Jt YXRpb24pOworICAgICAgICBpZiAocmMgPT0gVElNRV9aT05FX0lEX0lOVkFMSUQpCisgICAgICAg ICAgICByZXR1cm4gMDsKKyAgICB9CisKKyAgICBpbnQzMl90IGJpYXMgPSB0aW1lWm9uZUluZm9y bWF0aW9uLkJpYXM7CiAKLSAgICBpbnQzMl90IGJpYXMgPSAwOwogICAgIGlmIChyYyA9PSBUSU1F X1pPTkVfSURfREFZTElHSFQpCi0gICAgICAgIGJpYXMgPSB0aW1lWm9uZUluZm9ybWF0aW9uLkJp YXMgKyB0aW1lWm9uZUluZm9ybWF0aW9uLkRheWxpZ2h0QmlhczsKKyAgICAgICAgYmlhcyArPSB0 aW1lWm9uZUluZm9ybWF0aW9uLkRheWxpZ2h0QmlhczsKICAgICBlbHNlIGlmIChyYyA9PSBUSU1F X1pPTkVfSURfU1RBTkRBUkQgfHwgcmMgPT0gVElNRV9aT05FX0lEX1VOS05PV04pCi0gICAgICAg IGJpYXMgPSB0aW1lWm9uZUluZm9ybWF0aW9uLkJpYXMgKyB0aW1lWm9uZUluZm9ybWF0aW9uLlN0 YW5kYXJkQmlhczsKKyAgICAgICAgYmlhcyArPSB0aW1lWm9uZUluZm9ybWF0aW9uLlN0YW5kYXJk QmlhczsKIAogICAgIHJldHVybiAtYmlhcyAqIDYwICogMTAwMDsKICNlbHNlCg== 248385 2015-03-10 19:09:08 -0700 2015-03-10 19:15:24 -0700 Patch bug-142531-20150310191806.patch text/plain 3499 bfulgham SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxODEzNTcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE1LTAzLTEwICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIDE3IGRpZmZlcmVudCBKU0MgdGVzdHMg c3RhcnRlZCB0byBmYWlsIGluIERTVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTQyNTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhlIHN0b2NrICdHZXRUaW1lWm9uZUluZm9ybWF0aW9uJyBjYWxsIGRv ZXMgbm90IGFsd2F5cyBtYXRjaCB0aGUgYWN0dWFsIERheWxpZ2h0CisgICAgICAgIFNhdmluZ3Mg Y2FsZW5kYXIuIFRoaXMgcmVzdWx0cyBpbiBhIHBlcmlvZCBvZiB0aW1lIHdoZW4gdGhlc2UgdGVz dHMgZmFpbC4KKworICAgICAgICBJZiBhdmFpbGFibGUsIHdlIHNob3VsZCB0YWtlIGFkdmFudGFn ZSBvZiB0aGUgbmV3ICdHZXRUaW1lWm9uZUluZm9ybWF0aW9uRm9yWWVhcicsCisgICAgICAgIHdo aWNoIGFjY2Vzc2VzIGEgZHluYW1pYyBjYWxlbmRhciBvZiBEU1QgZGF0ZXMsIHdoaWNoIGlzIHBy ZXN1bWJhYmx5IHVwZGF0ZWQgYnkKKyAgICAgICAgTWljcm9zb2Z0IGZyb20geWVhci10by15ZWFy LgorCisgICAgICAgICogd3RmL0RhdGVNYXRoLmNwcDoKKyAgICAgICAgKFdURjo6dGltZVpvbmVJ bmZvcm1hdGlvbkZvclllYXJGdW5jdGlvbik6IE5ldyBmdW5jdGlvbiB0byBjb25kaXRpb25hbGx5 IGFjY2VzcworICAgICAgICBzb21lIFZpc3RhIChhbmQgbmV3ZXIpIGZ1bmN0aW9uYWxpdHkuCisg ICAgICAgIChXVEY6OmNhbGN1bGF0ZVVUQ09mZnNldCk6IENhbGwgbmV3IGZ1bmN0aW9uIChpZiBh dmFpbGFibGUpIHRvIGNhbGN1bGF0ZSBwcm9wZXIgVVRDCisgICAgICAgIHRpbWUgb2Zmc2V0Lgor CiAyMDE1LTAzLTEwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVXNlIHVuc2lnbmVkIGZvciBIYXNoU2V0IHNpemUuCkluZGV4OiBTb3VyY2Uv V1RGL3d0Zi9EYXRlTWF0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvRGF0ZU1h dGguY3BwCShyZXZpc2lvbiAxODEzNDUpCisrKyBTb3VyY2UvV1RGL3d0Zi9EYXRlTWF0aC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTM2MSwxOSArMzYxLDUyIEBAIGludCBlcXVpdmFsZW50WWVhckZv ckRTVChpbnQgeWVhcikKICAgICByZXR1cm4geWVhcjsKIH0KIAorI2lmIE9TKFdJTkRPV1MpCit0 eXBlZGVmIEJPT0woV0lOQVBJKiBjYWxsR2V0VGltZVpvbmVJbmZvcm1hdGlvbkZvclllYXJfdCko VVNIT1JULCBQRFlOQU1JQ19USU1FX1pPTkVfSU5GT1JNQVRJT04sIExQVElNRV9aT05FX0lORk9S TUFUSU9OKTsKKworc3RhdGljIGNhbGxHZXRUaW1lWm9uZUluZm9ybWF0aW9uRm9yWWVhcl90IHRp bWVab25lSW5mb3JtYXRpb25Gb3JZZWFyRnVuY3Rpb24oKQoreworICAgIHN0YXRpYyBjYWxsR2V0 VGltZVpvbmVJbmZvcm1hdGlvbkZvclllYXJfdCBnZXRUaW1lWm9uZUluZm9ybWF0aW9uRm9yWWVh ciA9IG51bGxwdHI7CisKKyAgICBpZiAoZ2V0VGltZVpvbmVJbmZvcm1hdGlvbkZvclllYXIpCisg ICAgICAgIHJldHVybiBnZXRUaW1lWm9uZUluZm9ybWF0aW9uRm9yWWVhcjsKKworICAgIEhNT0RV TEUgbW9kdWxlID0gOjpHZXRNb2R1bGVIYW5kbGVXKEwia2VybmVsMzIuZGxsIik7CisgICAgaWYg KCFtb2R1bGUpCisgICAgICAgIHJldHVybiBudWxscHRyOworCisgICAgZ2V0VGltZVpvbmVJbmZv cm1hdGlvbkZvclllYXIgPSByZWludGVycHJldF9jYXN0PGNhbGxHZXRUaW1lWm9uZUluZm9ybWF0 aW9uRm9yWWVhcl90Pig6OkdldFByb2NBZGRyZXNzKG1vZHVsZSwgIkdldFRpbWVab25lSW5mb3Jt YXRpb25Gb3JZZWFyIikpOworCisgICAgcmV0dXJuIGdldFRpbWVab25lSW5mb3JtYXRpb25Gb3JZ ZWFyOworfQorI2VuZGlmCisKIHN0YXRpYyBpbnQzMl90IGNhbGN1bGF0ZVVUQ09mZnNldCgpCiB7 CiAjaWYgT1MoV0lORE9XUykKICAgICBUSU1FX1pPTkVfSU5GT1JNQVRJT04gdGltZVpvbmVJbmZv cm1hdGlvbjsKLSAgICBEV09SRCByYyA9IDo6R2V0VGltZVpvbmVJbmZvcm1hdGlvbigmdGltZVpv bmVJbmZvcm1hdGlvbik7Ci0gICAgaWYgKHJjID09IFRJTUVfWk9ORV9JRF9JTlZBTElEKQotICAg ICAgICByZXR1cm4gMDsKKyAgICBEV09SRCByYyA9IDA7CisKKyAgICBpZiAoY2FsbEdldFRpbWVa b25lSW5mb3JtYXRpb25Gb3JZZWFyX3QgdGltZVpvbmVGdW5jdGlvbiA9IHRpbWVab25lSW5mb3Jt YXRpb25Gb3JZZWFyRnVuY3Rpb24oKSkgeworICAgICAgICAvLyBJZiBhdmFpbGFibGUsIHVzZSB0 aGUgV2luZG93cyBBUEkgY2FsbCB0aGF0IHRha2VzIGludG8gYWNjb3VudCB0aGUgdmFyeWluZyBE U1QgZnJvbQorICAgICAgICAvLyB5ZWFyIHRvIHllYXIuCisgICAgICAgIFNZU1RFTVRJTUUgc3lz dGVtVGltZTsKKyAgICAgICAgOjpHZXRTeXN0ZW1UaW1lKCZzeXN0ZW1UaW1lKTsKKyAgICAgICAg cmMgPSB0aW1lWm9uZUZ1bmN0aW9uKHN5c3RlbVRpbWUud1llYXIsIG51bGxwdHIsICZ0aW1lWm9u ZUluZm9ybWF0aW9uKTsKKyAgICAgICAgaWYgKHJjID09IFRJTUVfWk9ORV9JRF9JTlZBTElEKQor ICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgfSBlbHNlIHsKKyAgICAgICAgcmMgPSA6OkdldFRp bWVab25lSW5mb3JtYXRpb24oJnRpbWVab25lSW5mb3JtYXRpb24pOworICAgICAgICBpZiAocmMg PT0gVElNRV9aT05FX0lEX0lOVkFMSUQpCisgICAgICAgICAgICByZXR1cm4gMDsKKyAgICB9CisK KyAgICBpbnQzMl90IGJpYXMgPSB0aW1lWm9uZUluZm9ybWF0aW9uLkJpYXM7CiAKLSAgICBpbnQz Ml90IGJpYXMgPSAwOwogICAgIGlmIChyYyA9PSBUSU1FX1pPTkVfSURfREFZTElHSFQpCi0gICAg ICAgIGJpYXMgPSB0aW1lWm9uZUluZm9ybWF0aW9uLkJpYXMgKyB0aW1lWm9uZUluZm9ybWF0aW9u LkRheWxpZ2h0QmlhczsKKyAgICAgICAgYmlhcyArPSB0aW1lWm9uZUluZm9ybWF0aW9uLkRheWxp Z2h0QmlhczsKICAgICBlbHNlIGlmIChyYyA9PSBUSU1FX1pPTkVfSURfU1RBTkRBUkQgfHwgcmMg PT0gVElNRV9aT05FX0lEX1VOS05PV04pCi0gICAgICAgIGJpYXMgPSB0aW1lWm9uZUluZm9ybWF0 aW9uLkJpYXMgKyB0aW1lWm9uZUluZm9ybWF0aW9uLlN0YW5kYXJkQmlhczsKKyAgICAgICAgYmlh cyArPSB0aW1lWm9uZUluZm9ybWF0aW9uLlN0YW5kYXJkQmlhczsKIAogICAgIHJldHVybiAtYmlh cyAqIDYwICogMTAwMDsKICNlbHNlCg==