141556 2015-02-12 23:37:10 -0800 [BMalloc] Add a FIXME comment for memory alignas 2020-10-19 13:01:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim ap commit-queue ggaren ossy pmx17782 vivekjkumar266 oldest_to_newest 1068860 0 gyuyoung.kim 2015-02-12 23:37:10 -0800 SSIA 1068861 1 246512 gyuyoung.kim 2015-02-12 23:38:35 -0800 Created attachment 246512 Patch 1068867 2 246512 ossy 2015-02-13 00:39:44 -0800 Comment on attachment 246512 Patch rs=me 1068878 3 246512 commit-queue 2015-02-13 01:43:34 -0800 Comment on attachment 246512 Patch Clearing flags on attachment: 246512 Committed r180037: <http://trac.webkit.org/changeset/180037> 1068879 4 commit-queue 2015-02-13 01:43:38 -0800 All reviewed patches have been landed. Closing bug. 1068949 5 ggaren 2015-02-13 10:38:11 -0800 I don't think it's useful to put a FIXME next to every compiler workaround. The main problem with a compiler workaround is that it makes the code more verbose and cluttered. Adding a FIXME makes it even more verbose and cluttered. 1069299 6 gyuyoung.kim 2015-02-15 01:13:32 -0800 (In reply to comment #5) > I don't think it's useful to put a FIXME next to every compiler workaround. > The main problem with a compiler workaround is that it makes the code more > verbose and cluttered. Adding a FIXME makes it even more verbose and > cluttered. I see. I will try not to add unnecessary FIXME. When this workaround is not needed anymore, I will remove it. 246512 2015-02-12 23:38:35 -0800 2015-02-13 01:43:34 -0800 Patch bug-141556-20150213163834.patch text/plain 2219 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTgwMDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggYmVjZWM5OWVlNDkyZTc2 NjUzMjE2OTZiNDAzNjVjNDg0ZjZjZDg3Mi4uMDVkZjk0Y2U0ZDNjNzJmOGZjNGM3MTU4Y2FjMjg3 ODdiNjA3YWY4YyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTAyLTEyICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0JNYWxsb2Nd IEFkZCBhIEZJWE1FIGNvbW1lbnQgZm9yIG1lbW9yeSBhbGlnbmFzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDE1NTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJtYWxsb2MvQ2h1bmsuaDogQWRkIGEg RklYTUUgY29tbWVudC4KKyAgICAgICAgKiBibWFsbG9jL0xhcmdlQ2h1bmsuaDogZGl0dG8uCisK IDIwMTUtMDItMTEgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAg ICAgICBibWFsbG9jIGJ1aWxkZml4IG9uIDMyIGJpdCBMaW51eCAoeDg2L0FSTSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQ2h1bmsuaCBiL1NvdXJjZS9ibWFsbG9jL2JtYWxs b2MvQ2h1bmsuaAppbmRleCBkZTFiZGZmZWMyY2NiNGM1MmRjMDdjYjViNmI1MmY5ZDQ5YzA3ZTc0 Li4xNDVjOWZhODU0MGE4MTI2MjMyMGNmN2I2Zjk0MDZlN2I3OTYzODdjIDEwMDY0NAotLS0gYS9T b3VyY2UvYm1hbGxvYy9ibWFsbG9jL0NodW5rLmgKKysrIGIvU291cmNlL2JtYWxsb2MvYm1hbGxv Yy9DaHVuay5oCkBAIC02Myw2ICs2Myw4IEBAIHByaXZhdGU6CiAKICAgICAvLyBBbGlnbiB0byB2 bVBhZ2VTaXplIHRvIGF2b2lkIHNoYXJpbmcgcGh5c2ljYWwgcGFnZXMgd2l0aCBtZXRhZGF0YS4K ICAgICAvLyBPdGhlcndpc2UsIHdlJ2xsIGNvbmZ1c2UgdGhlIHNjYXZlbmdlciBpbnRvIHRyeWlu ZyB0byBzY2F2ZW5nZSBtZXRhZGF0YS4KKyAgICAvLyBGSVhNRTogQmVsb3cgI2lmZGVmIHdvcmth cm91bmQgZml4IHNob3VsZCBiZSByZW1vdmVkIGFmdGVyIGFsbCBsaW51eCBiYXNlZCBwb3J0cyBi dW1wCisgICAgLy8gb3duIGdjYyB2ZXJzaW9uLiBTZWUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE0MDE2MiNjODcKICNpZiBCUExBVEZPUk0oSU9TKQogICAgIGNoYXIg bV9tZW1vcnlbXSBfX2F0dHJpYnV0ZV9fKChhbGlnbmVkKDE2Mzg0KSkpOwogICAgIHN0YXRpY19h c3NlcnQodm1QYWdlU2l6ZSA9PSAxNjM4NCwgInZtUGFnZVNpemUgYW5kIGFsaWdubWVudCBtdXN0 IGJlIHNhbWUiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvTGFyZ2VDaHVu ay5oIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9MYXJnZUNodW5rLmgKaW5kZXggYTY1MTVjOTVi MDcxMTVjY2UxZWM0NmMzNTBhNWEwZmVkM2YwZjJjNC4uODYzM2JiMDk4NzcxMTg1MGM1MmMxNzkz YWRiODg2NTk4YjkxN2UzNCAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9MYXJn ZUNodW5rLmgKKysrIGIvU291cmNlL2JtYWxsb2MvYm1hbGxvYy9MYXJnZUNodW5rLmgKQEAgLTY3 LDYgKzY3LDggQEAgcHJpdmF0ZToKIAogICAgIC8vIEFsaWduIHRvIHZtUGFnZVNpemUgdG8gYXZv aWQgc2hhcmluZyBwaHlzaWNhbCBwYWdlcyB3aXRoIG1ldGFkYXRhLgogICAgIC8vIE90aGVyd2lz ZSwgd2UnbGwgY29uZnVzZSB0aGUgc2NhdmVuZ2VyIGludG8gdHJ5aW5nIHRvIHNjYXZlbmdlIG1l dGFkYXRhLgorICAgIC8vIEZJWE1FOiBCZWxvdyAjaWZkZWYgd29ya2Fyb3VuZCBmaXggc2hvdWxk IGJlIHJlbW92ZWQgYWZ0ZXIgYWxsIGxpbnV4IGJhc2VkIHBvcnRzIGJ1bXAKKyAgICAvLyBvd24g Z2NjIHZlcnNpb24uIFNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQwMTYyI2M4NwogI2lmIEJQTEFURk9STShJT1MpCiAgICAgY2hhciBtX21lbW9yeVtdIF9fYXR0 cmlidXRlX18oKGFsaWduZWQoMTYzODQpKSk7CiAgICAgc3RhdGljX2Fzc2VydCh2bVBhZ2VTaXpl ID09IDE2Mzg0LCAidm1QYWdlU2l6ZSBhbmQgYWxpZ25tZW50IG11c3QgYmUgc2FtZSIpOwo=