141172 2015-02-02 14:28:52 -0800 run-perf-tests: allow to specify a wrapper command. 2015-02-03 10:21:20 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez commit-queue glenn ossy rniwa oldest_to_newest 1066224 0 clopez 2015-02-02 14:28:52 -0800 run-webkit-tests allows to specify a wrapper command for debugging purposes. $ Tools/Scripts/run-webkit-tests --help|grep -i wrappe -A1 --wrapper=WRAPPER wrapper command to insert before invocations of DumpRenderTree; option is split on whitespace before running. (Example: --wrapper='valgrind --smc- check=all') run-perf-tests should allow the same. 1066238 1 245903 clopez 2015-02-02 14:44:21 -0800 Created attachment 245903 Patch 1066378 2 245903 rniwa 2015-02-02 22:43:42 -0800 Comment on attachment 245903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245903&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:226 > + "DumpRenderTree or WTR; option is split on whitespace before " Please spell out WebKitTestRunner. > Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:137 > + "DumpRenderTree or WTR; option is split on whitespace before " Ditto. 1066481 3 clopez 2015-02-03 10:21:20 -0800 Committed r179553: <http://trac.webkit.org/changeset/179553> 245903 2015-02-02 14:44:21 -0800 2015-02-02 22:43:42 -0800 Patch bug-141172-20150202234430.patch text/plain 2860 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NTAwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWUxZjA1M2I1ZWUxNzY0OTJlY2JlZGEwYjY1YWYxYWMz YjUzZmJkMS4uNDMwMDIyODNiNDA4MjU1MDZmY2EzYzUxMzE1ZTI0N2RjMzA4NjZkNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTAyLTAyICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIHJ1bi1wZXJmLXRlc3RzOiBhbGxvdyB0byBzcGVjaWZ5IGEgd3Jh cHBlciBjb21tYW5kLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTQxMTcyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5 OgorICAgICAgICAocGFyc2VfYXJncyk6IFVwZGF0ZSB0ZXh0IHRvIGluZGljYXRlIGlzIGFsc28g dmFsaWQgZm9yIFdUUi4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rl c3RzL3BlcmZ0ZXN0c3J1bm5lci5weToKKyAgICAgICAgKFBlcmZUZXN0c1J1bm5lci5fcGFyc2Vf YXJncyk6IEFkZCB3cmFwcGVyIGNvbW1hbmQuCisKIDIwMTUtMDItMDIgIFNhYW0gQmFyYXRpICA8 c2FhbWJhcmF0aTFAZ21haWwuY29tPgogCiAgICAgICAgIENyZWF0ZSB0ZXN0cyBmb3IgSlNDJ3Mg Q29udHJvbCBGbG93IFByb2ZpbGVyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQppbmRleCBiNDc2ZWIyYjkwZDJmNzU1 YTdhM2I5NDE4NzdiMWExZWJhMGRiZGMzLi44MDg2YTBiZDVjMmFkMjkxOGU2NmY0NjE4M2U0NzU1 MWQyNWU2ZDUwIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTIyMyw3ICsyMjMsNyBAQCBkZWYgcGFyc2Vf YXJncyhhcmdzKToKICAgICAgICAgICAgIGhlbHA9IkRvIGV2ZXJ5dGhpbmcgYnV0IGFjdHVhbGx5 IHJ1biB0aGUgdGVzdHMgb3IgdXBsb2FkIHJlc3VsdHMuIiksCiAgICAgICAgIG9wdHBhcnNlLm1h a2Vfb3B0aW9uKCItLXdyYXBwZXIiLAogICAgICAgICAgICAgaGVscD0id3JhcHBlciBjb21tYW5k IHRvIGluc2VydCBiZWZvcmUgaW52b2NhdGlvbnMgb2YgIgotICAgICAgICAgICAgICAgICAiRHVt cFJlbmRlclRyZWU7IG9wdGlvbiBpcyBzcGxpdCBvbiB3aGl0ZXNwYWNlIGJlZm9yZSAiCisgICAg ICAgICAgICAgICAgICJEdW1wUmVuZGVyVHJlZSBvciBXVFI7IG9wdGlvbiBpcyBzcGxpdCBvbiB3 aGl0ZXNwYWNlIGJlZm9yZSAiCiAgICAgICAgICAgICAgICAgICJydW5uaW5nLiAoRXhhbXBsZTog LS13cmFwcGVyPSd2YWxncmluZCAtLXNtYy1jaGVjaz1hbGwnKSIpLAogICAgICAgICBvcHRwYXJz ZS5tYWtlX29wdGlvbigiLWkiLCAiLS1pZ25vcmUtdGVzdHMiLCBhY3Rpb249ImFwcGVuZCIsIGRl ZmF1bHQ9W10sCiAgICAgICAgICAgICBoZWxwPSJkaXJlY3RvcmllcyBvciB0ZXN0IHRvIGlnbm9y ZSAobWF5IHNwZWNpZnkgbXVsdGlwbGUgdGltZXMpIiksCmRpZmYgLS1naXQgYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3BlcmZvcm1hbmNlX3Rlc3RzL3BlcmZ0ZXN0c3J1bm5lci5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5Cmlu ZGV4IDExMTJiZjdlODY1OTk2ZmQ3YWIxY2JiZjI3M2VjNDI4MWQzNDJjZTUuLjEzMWFhYTIwNmU4 NDFiYWRhNDAxOGQ3MjAzMDEzNWM2YmM5MTA4MGIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvcGVyZm9ybWFuY2VfdGVzdHMvcGVyZnRlc3RzcnVubmVyLnB5CkBA IC0xMzIsNiArMTMyLDEwIEBAIGNsYXNzIFBlcmZUZXN0c1J1bm5lcihvYmplY3QpOgogICAgICAg ICAgICAgICAgIGhlbHA9IlNwZWNpZnkgbnVtYmVyIG9mIHRpbWVzIHRvIHJ1biB0ZXN0IHNldCAo ZGVmYXVsdDogMSkuIiksCiAgICAgICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLS10ZXN0 LXJ1bm5lci1jb3VudCIsIGRlZmF1bHQ9LTEsIHR5cGU9ImludCIsCiAgICAgICAgICAgICAgICAg aGVscD0iU3BlY2lmeSBudW1iZXIgb2YgdGltZXMgdG8gaW52b2tlIHRlc3QgcnVubmVyIGZvciBl YWNoIHBlcmZvcm1hbmNlIHRlc3QuIiksCisgICAgICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlv bigiLS13cmFwcGVyIiwKKyAgICAgICAgICAgICAgICBoZWxwPSJ3cmFwcGVyIGNvbW1hbmQgdG8g aW5zZXJ0IGJlZm9yZSBpbnZvY2F0aW9ucyBvZiAiCisgICAgICAgICAgICAgICAgICJEdW1wUmVu ZGVyVHJlZSBvciBXVFI7IG9wdGlvbiBpcyBzcGxpdCBvbiB3aGl0ZXNwYWNlIGJlZm9yZSAiCisg ICAgICAgICAgICAgICAgICJydW5uaW5nLiAoRXhhbXBsZTogLS13cmFwcGVyPSd2YWxncmluZCAt LXNtYy1jaGVjaz1hbGwnKSIpLAogICAgICAgICAgICAgXQogICAgICAgICByZXR1cm4gb3B0cGFy c2UuT3B0aW9uUGFyc2VyKG9wdGlvbl9saXN0PShwZXJmX29wdGlvbl9saXN0KSkucGFyc2VfYXJn cyhhcmdzKQogCg==