141152 2015-02-02 03:59:38 -0800 [webkitpy] Add platform specific Skipped file mechanism for performance tests 2015-02-04 10:07:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 1 ossy ossy commit-queue glenn gyuyoung.kim ossy rniwa oldest_to_newest 1066068 0 ossy 2015-02-02 03:59:38 -0800 Now there is only one skipped file for performance tests: PerformanceTests/Skipped. But EFL needs a platform specific one to be able to skip Canvas/reuse.html - bug139812 1066069 1 245867 ossy 2015-02-02 04:04:06 -0800 Created attachment 245867 Patch With this patch we can skip tests for platform ios,mac,win,gtk and efl. I don't want to add nested platforms as LayoutTests has. 1066070 2 245868 ossy 2015-02-02 04:10:13 -0800 Created attachment 245868 Patch Moved _expectations_from_skipped_files function into skipped_perf_tests, because it isn't used anywhere else. 1066380 3 245868 rniwa 2015-02-02 22:48:53 -0800 Comment on attachment 245868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245868&action=review > Tools/Scripts/webkitpy/port/base.py:692 > + skipped_file_paths = [self.perf_tests_dir(), self._filesystem.join(self.perf_tests_dir(), 'platform', self.port_name)] > for search_path in skipped_file_paths: Instead of adding a seprate file, can we add a modifier like [EFL] test-name as done in test expectations? 1066381 4 ossy 2015-02-02 23:17:24 -0800 (In reply to comment #3) > Comment on attachment 245868 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=245868&action=review > > > Tools/Scripts/webkitpy/port/base.py:692 > > + skipped_file_paths = [self.perf_tests_dir(), self._filesystem.join(self.perf_tests_dir(), 'platform', self.port_name)] > > for search_path in skipped_file_paths: > > Instead of adding a seprate file, can we add a modifier like [EFL] test-name > as done in test expectations? Unfortunately no, because PerformanceTests/Skipped file has the simple old style Skipped file syntax, which doesn't support any modifier. _tests_from_skipped_file_contents omits only commented lines, other lines are interpreted as test names: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py?rev=179134#L678 I don't want to implement a sophisticated mechanism for performance tests similar to TestExpectations. I would like to have a workaround until bug139812 is fixed not to have to swith off the EFL performance bot. 1066505 5 rniwa 2015-02-03 11:15:22 -0800 (In reply to comment #4) > > Unfortunately no, because PerformanceTests/Skipped file has the simple > old style Skipped file syntax, which doesn't support any modifier. > _tests_from_skipped_file_contents omits only commented lines, other > lines are interpreted as test names: > http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base. > py?rev=179134#L678 There’s no need to limit ourselves to that format. > I don't want to implement a sophisticated mechanism for performance tests > similar to TestExpectations. I would like to have a workaround until > bug139812 is fixed not to have to swith off the EFL performance bot. I don’t like this approach because it introdues “platform” directory, which is otherwise useless. 1066519 6 245951 rniwa 2015-02-03 11:53:01 -0800 Created attachment 245951 Adds the support for platform modifier 1066777 7 245951 ossy 2015-02-04 02:34:57 -0800 Comment on attachment 245951 Adds the support for platform modifier View in context: https://bugs.webkit.org/attachment.cgi?id=245951&action=review LGTM, r=me with some nits. > Tools/Scripts/webkitpy/port/base.py:710 > + line_number = 1 > + tests_to_skip = [] > + for line in skipped_file_contents.split('\n'): We don't need explicit line numbering, enumerate solves this task: for line_number, line in enumerate(skipped_file_contents.split('\n')): > Tools/Scripts/webkitpy/port/base.py:713 > + _log.error("Synatx error at line %d in %s: %s" % (line_number, filename, line)) typo: Synatx -> Syntax 1066780 8 ossy 2015-02-04 03:34:57 -0800 (In reply to comment #7) > We don't need explicit line numbering, enumerate solves this task: > for line_number, line in enumerate(skipped_file_contents.split('\n')): + start=1 argument for enumerate 1066851 9 rniwa 2015-02-04 10:07:08 -0800 Committed r179610: <http://trac.webkit.org/changeset/179610> 245867 2015-02-02 04:04:06 -0800 2015-02-02 04:10:06 -0800 Patch bug-141152-20150202040414.patch text/plain 4001 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NDc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmU1ZmUyNDk1YTU4YzM4MTI2MDI3NWQ3MDU1YzA5Mjhj YTllMDM3ZC4uNzc3ODk3MGYyZGE0OWE4MWJiZDg0NmJlMjg4MTZhMzVhNmViNGNjYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTAyLTAyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW3dlYmtpdHB5XSBBZGQgcGxhdGZvcm0gc3BlY2lmaWMgU2tpcHBlZCBmaWxlIG1l Y2hhbmlzbSBmb3IgcGVyZm9ybWFuY2UgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTE1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHk6Cisg ICAgICAgIChQb3J0LnNraXBwZWRfcGVyZl90ZXN0cyk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9wb3J0L2Jhc2VfdW5pdHRlc3QucHk6CisgICAgICAgIChQb3J0VGVzdC50ZXN0X3NraXBw ZWRfcGVyZl90ZXN0cyk6CisKIDIwMTUtMDItMDIgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu emFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIE1pbmlCcm93c2VyIHNob3VsZCBjbG9z ZSBpdHNlbGYgb24gQ3RybCtXIG9yIEN0cmwrUQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2Jhc2UucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5w eQppbmRleCBjODA0NTU1OWQzNzZhNWE5NDUzNjc0ZDc5ZjhlMTA0ZWE4ZWU1NTU5Li4zYmFiMTk5 YWFhYzIwMTU5NzM3NTQ2NGZlMmVlMDQ2OGUxODZmNjVhIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvYmFzZS5weQpAQCAtNjk5LDcgKzY5OSw3IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKIAogICAg IEBtZW1vaXplZAogICAgIGRlZiBza2lwcGVkX3BlcmZfdGVzdHMoc2VsZik6Ci0gICAgICAgIHJl dHVybiBzZWxmLl9leHBlY3RhdGlvbnNfZnJvbV9za2lwcGVkX2ZpbGVzKFtzZWxmLnBlcmZfdGVz dHNfZGlyKCldKQorICAgICAgICByZXR1cm4gc2VsZi5fZXhwZWN0YXRpb25zX2Zyb21fc2tpcHBl ZF9maWxlcyhbc2VsZi5wZXJmX3Rlc3RzX2RpcigpLCBzZWxmLl9maWxlc3lzdGVtLmpvaW4oc2Vs Zi5wZXJmX3Rlc3RzX2RpcigpLCAncGxhdGZvcm0nLCBzZWxmLnBvcnRfbmFtZSldKQogCiAgICAg ZGVmIHNraXBzX3BlcmZfdGVzdChzZWxmLCB0ZXN0X25hbWUpOgogICAgICAgICBmb3IgdGVzdF9v cl9jYXRlZ29yeSBpbiBzZWxmLnNraXBwZWRfcGVyZl90ZXN0cygpOgpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2VfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvYmFzZV91bml0dGVzdC5weQppbmRleCA2ZjdhYjNmN2RiOTEyYTBlN2Mz YTUyYWRlZTY5NzJiMTljYjc2YjEyLi4wNDZmZjZlOWMwYTIzNGE5ZTZjNGI4NTJhOTg3M2FjYzE3 YzBhOGM0IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZV91bml0 dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZV91bml0dGVzdC5w eQpAQCAtMTM1LDcgKzEzNSw4IEBAIGNsYXNzIFBvcnRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK ICAgICAgICAgc2VsZi5hc3NlcnRJbignY3NzMi4xJywgZGlycykKIAogICAgIGRlZiB0ZXN0X3Nr aXBwZWRfcGVyZl90ZXN0cyhzZWxmKToKLSAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KCkK KyAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KHBvcnRfbmFtZT0nZm9vJykKKyAgICAgICAg cG9ydC5wb3J0X25hbWUgPSAnZm9vJwogCiAgICAgICAgIGRlZiBhZGRfdGV4dF9maWxlKGRpcm5h bWUsIGZpbGVuYW1lLCBjb250ZW50PSdzb21lIGNvbnRlbnQnKToKICAgICAgICAgICAgIGRpcm5h bWUgPSBwb3J0Lmhvc3QuZmlsZXN5c3RlbS5qb2luKHBvcnQucGVyZl90ZXN0c19kaXIoKSwgZGly bmFtZSkKQEAgLTE0OCw3ICsxNDksOCBAQCBjbGFzcyBQb3J0VGVzdCh1bml0dGVzdC5UZXN0Q2Fz ZSk6CiAgICAgICAgIGFkZF90ZXh0X2ZpbGUoJ2luc3BlY3Rvci9yZXNvdXJjZXMnLCAncmVzb3Vy Y2VfZmlsZS5odG1sJykKICAgICAgICAgYWRkX3RleHRfZmlsZSgndW5zdXBwb3J0ZWQnLCAndW5z dXBwb3J0ZWRfdGVzdDIuaHRtbCcpCiAgICAgICAgIGFkZF90ZXh0X2ZpbGUoJycsICdTa2lwcGVk JywgJ1xuJy5qb2luKFsnTGF5b3V0JywgJycsICdTdW5TcGlkZXInLCAnU3VwcG9ydGVkL3NvbWUt dGVzdC5odG1sJ10pKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHBvcnQuc2tpcHBlZF9wZXJm X3Rlc3RzKCksIFsnTGF5b3V0JywgJ1N1blNwaWRlcicsICdTdXBwb3J0ZWQvc29tZS10ZXN0Lmh0 bWwnXSkKKyAgICAgICAgYWRkX3RleHRfZmlsZSgncGxhdGZvcm0vZm9vJywgJ1NraXBwZWQnLCAn U2tpcHBlZC10ZXN0LWZvci1wbGF0Zm9ybS1mb29cbicpCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwocG9ydC5za2lwcGVkX3BlcmZfdGVzdHMoKSwgWydMYXlvdXQnLCAnU3VuU3BpZGVyJywgJ1N1 cHBvcnRlZC9zb21lLXRlc3QuaHRtbCcsICdTa2lwcGVkLXRlc3QtZm9yLXBsYXRmb3JtLWZvbydd KQogCiAgICAgZGVmIHRlc3RfZ2V0X29wdGlvbl9fc2V0KHNlbGYpOgogICAgICAgICBvcHRpb25z LCBhcmdzID0gb3B0cGFyc2UuT3B0aW9uUGFyc2VyKCkucGFyc2VfYXJncyhbXSkKZGlmZiAtLWdp dCBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZDA4MDhjY2NiNDI5YWM5ZDFiNTEwMWZkOGEzOTljMGZmZWFlNGFhNi4uMTRkZjhl MTc5YzMzMDJiNzkxYWY3YzM4NGY4Y2M3OTFjYjZmY2M0NyAxMDA2NDQKLS0tIGEvUGVyZm9ybWFu Y2VUZXN0cy9DaGFuZ2VMb2cKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNS0wMi0wMiAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFt3ZWJraXRweV0gQWRkIHBsYXRmb3JtIHNwZWNpZmljIFNraXBwZWQg ZmlsZSBtZWNoYW5pc20gZm9yIHBlcmZvcm1hbmNlIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDExNTIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Ta2lwcGVkOiBBZGRl ZCBhbmQgc2tpcCBDYW52YXMvcmV1c2UuaHRtbCBkdWUgdG8gYnVnMTM5ODEyLgorCiAyMDE1LTAx LTI4ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAg ICAgUG9vciBwZXJmb3JtYW5jZSBvbiBJRSdzIENoYWxrYm9hcmQgYmVuY2htYXJrLgpkaWZmIC0t Z2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9wbGF0Zm9ybS9lZmwvU2tpcHBlZCBiL1BlcmZvcm1hbmNl VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDI3NzIwOWQ0OWNjOWU5OTFk OGE4YzMxZTQ5MWM4YzQxODllZDE5MwotLS0gL2Rldi9udWxsCisrKyBiL1BlcmZvcm1hbmNlVGVz dHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKQEAgLTAsMCArMSwzIEBACisjIFJFR1JFU1NJT04oMTc2 NjA5KTogTWVtb3J5IGxlYWsgaW4gQ2FudmFzL3JldXNlLmh0bWwgcGVyZm9ybWFuY2UgdGVzdAor IyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5ODEyCitDYW52YXMv cmV1c2UuaHRtbAo= 245868 2015-02-02 04:10:13 -0800 2015-02-03 11:52:58 -0800 Patch bug-141152-20150202041020.patch text/plain 4612 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc5NDc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmU1ZmUyNDk1YTU4YzM4MTI2MDI3NWQ3MDU1YzA5Mjhj YTllMDM3ZC4uNzc3ODk3MGYyZGE0OWE4MWJiZDg0NmJlMjg4MTZhMzVhNmViNGNjYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE1LTAyLTAyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW3dlYmtpdHB5XSBBZGQgcGxhdGZvcm0gc3BlY2lmaWMgU2tpcHBlZCBmaWxlIG1l Y2hhbmlzbSBmb3IgcGVyZm9ybWFuY2UgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE0MTE1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHk6Cisg ICAgICAgIChQb3J0LnNraXBwZWRfcGVyZl90ZXN0cyk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9wb3J0L2Jhc2VfdW5pdHRlc3QucHk6CisgICAgICAgIChQb3J0VGVzdC50ZXN0X3NraXBw ZWRfcGVyZl90ZXN0cyk6CisKIDIwMTUtMDItMDIgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu emFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIE1pbmlCcm93c2VyIHNob3VsZCBjbG9z ZSBpdHNlbGYgb24gQ3RybCtXIG9yIEN0cmwrUQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2Jhc2UucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5w eQppbmRleCBjODA0NTU1OWQzNzZhNWE5NDUzNjc0ZDc5ZjhlMTA0ZWE4ZWU1NTU5Li44ZTlkZWNj ZjgxOGNjOGQ2YTUzNDc5NzIzOTU3YjAyNDlkYTMyNmFiIDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvYmFzZS5weQpAQCAtNjg1LDggKzY4NSwxMCBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAg ICAgICAgICB0ZXN0c190b19za2lwLmFwcGVuZChsaW5lKQogICAgICAgICByZXR1cm4gdGVzdHNf dG9fc2tpcAogCi0gICAgZGVmIF9leHBlY3RhdGlvbnNfZnJvbV9za2lwcGVkX2ZpbGVzKHNlbGYs IHNraXBwZWRfZmlsZV9wYXRocyk6CisgICAgQG1lbW9pemVkCisgICAgZGVmIHNraXBwZWRfcGVy Zl90ZXN0cyhzZWxmKToKICAgICAgICAgdGVzdHNfdG9fc2tpcCA9IFtdCisgICAgICAgIHNraXBw ZWRfZmlsZV9wYXRocyA9IFtzZWxmLnBlcmZfdGVzdHNfZGlyKCksIHNlbGYuX2ZpbGVzeXN0ZW0u am9pbihzZWxmLnBlcmZfdGVzdHNfZGlyKCksICdwbGF0Zm9ybScsIHNlbGYucG9ydF9uYW1lKV0K ICAgICAgICAgZm9yIHNlYXJjaF9wYXRoIGluIHNraXBwZWRfZmlsZV9wYXRoczoKICAgICAgICAg ICAgIGZpbGVuYW1lID0gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHNlbGYuX3dlYmtpdF9iYXNlbGlu ZV9wYXRoKHNlYXJjaF9wYXRoKSwgIlNraXBwZWQiKQogICAgICAgICAgICAgaWYgbm90IHNlbGYu X2ZpbGVzeXN0ZW0uZXhpc3RzKGZpbGVuYW1lKToKQEAgLTY5NywxMCArNjk5LDYgQEAgY2xhc3Mg UG9ydChvYmplY3QpOgogICAgICAgICAgICAgdGVzdHNfdG9fc2tpcC5leHRlbmQoc2VsZi5fdGVz dHNfZnJvbV9za2lwcGVkX2ZpbGVfY29udGVudHMoc2tpcHBlZF9maWxlX2NvbnRlbnRzKSkKICAg ICAgICAgcmV0dXJuIHRlc3RzX3RvX3NraXAKIAotICAgIEBtZW1vaXplZAotICAgIGRlZiBza2lw cGVkX3BlcmZfdGVzdHMoc2VsZik6Ci0gICAgICAgIHJldHVybiBzZWxmLl9leHBlY3RhdGlvbnNf ZnJvbV9za2lwcGVkX2ZpbGVzKFtzZWxmLnBlcmZfdGVzdHNfZGlyKCldKQotCiAgICAgZGVmIHNr aXBzX3BlcmZfdGVzdChzZWxmLCB0ZXN0X25hbWUpOgogICAgICAgICBmb3IgdGVzdF9vcl9jYXRl Z29yeSBpbiBzZWxmLnNraXBwZWRfcGVyZl90ZXN0cygpOgogICAgICAgICAgICAgaWYgdGVzdF9v cl9jYXRlZ29yeSA9PSB0ZXN0X25hbWU6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvYmFzZV91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9i YXNlX3VuaXR0ZXN0LnB5CmluZGV4IDZmN2FiM2Y3ZGI5MTJhMGU3YzNhNTJhZGVlNjk3MmIxOWNi NzZiMTIuLjA0NmZmNmU5YzBhMjM0YTllNmM0Yjg1MmE5ODczYWNjMTdjMGE4YzQgMTAwNzU1Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5CisrKyBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5CkBAIC0xMzUsNyArMTM1 LDggQEAgY2xhc3MgUG9ydFRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBzZWxmLmFz c2VydEluKCdjc3MyLjEnLCBkaXJzKQogCiAgICAgZGVmIHRlc3Rfc2tpcHBlZF9wZXJmX3Rlc3Rz KHNlbGYpOgotICAgICAgICBwb3J0ID0gc2VsZi5tYWtlX3BvcnQoKQorICAgICAgICBwb3J0ID0g c2VsZi5tYWtlX3BvcnQocG9ydF9uYW1lPSdmb28nKQorICAgICAgICBwb3J0LnBvcnRfbmFtZSA9 ICdmb28nCiAKICAgICAgICAgZGVmIGFkZF90ZXh0X2ZpbGUoZGlybmFtZSwgZmlsZW5hbWUsIGNv bnRlbnQ9J3NvbWUgY29udGVudCcpOgogICAgICAgICAgICAgZGlybmFtZSA9IHBvcnQuaG9zdC5m aWxlc3lzdGVtLmpvaW4ocG9ydC5wZXJmX3Rlc3RzX2RpcigpLCBkaXJuYW1lKQpAQCAtMTQ4LDcg KzE0OSw4IEBAIGNsYXNzIFBvcnRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgYWRk X3RleHRfZmlsZSgnaW5zcGVjdG9yL3Jlc291cmNlcycsICdyZXNvdXJjZV9maWxlLmh0bWwnKQog ICAgICAgICBhZGRfdGV4dF9maWxlKCd1bnN1cHBvcnRlZCcsICd1bnN1cHBvcnRlZF90ZXN0Mi5o dG1sJykKICAgICAgICAgYWRkX3RleHRfZmlsZSgnJywgJ1NraXBwZWQnLCAnXG4nLmpvaW4oWydM YXlvdXQnLCAnJywgJ1N1blNwaWRlcicsICdTdXBwb3J0ZWQvc29tZS10ZXN0Lmh0bWwnXSkpCi0g ICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwocG9ydC5za2lwcGVkX3BlcmZfdGVzdHMoKSwgWydMYXlv dXQnLCAnU3VuU3BpZGVyJywgJ1N1cHBvcnRlZC9zb21lLXRlc3QuaHRtbCddKQorICAgICAgICBh ZGRfdGV4dF9maWxlKCdwbGF0Zm9ybS9mb28nLCAnU2tpcHBlZCcsICdTa2lwcGVkLXRlc3QtZm9y LXBsYXRmb3JtLWZvb1xuJykKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0LnNraXBwZWRf cGVyZl90ZXN0cygpLCBbJ0xheW91dCcsICdTdW5TcGlkZXInLCAnU3VwcG9ydGVkL3NvbWUtdGVz dC5odG1sJywgJ1NraXBwZWQtdGVzdC1mb3ItcGxhdGZvcm0tZm9vJ10pCiAKICAgICBkZWYgdGVz dF9nZXRfb3B0aW9uX19zZXQoc2VsZik6CiAgICAgICAgIG9wdGlvbnMsIGFyZ3MgPSBvcHRwYXJz ZS5PcHRpb25QYXJzZXIoKS5wYXJzZV9hcmdzKFtdKQpkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VU ZXN0cy9DaGFuZ2VMb2cgYi9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxvZwppbmRleCBkMDgwOGNj Y2I0MjlhYzlkMWI1MTAxZmQ4YTM5OWMwZmZlYWU0YWE2Li4xNGRmOGUxNzljMzMwMmI3OTFhZjdj Mzg0ZjhjYzc5MWNiNmZjYzQ3IDEwMDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxv ZworKysgYi9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE1 LTAyLTAyICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAg W3dlYmtpdHB5XSBBZGQgcGxhdGZvcm0gc3BlY2lmaWMgU2tpcHBlZCBmaWxlIG1lY2hhbmlzbSBm b3IgcGVyZm9ybWFuY2UgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE0MTE1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL1NraXBwZWQ6IEFkZGVkIGFuZCBza2lwIENhbnZh cy9yZXVzZS5odG1sIGR1ZSB0byBidWcxMzk4MTIuCisKIDIwMTUtMDEtMjggIFNhaWQgQWJvdS1I YWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KIAogICAgICAgICBQb29yIHBlcmZvcm1h bmNlIG9uIElFJ3MgQ2hhbGtib2FyZCBiZW5jaG1hcmsuCmRpZmYgLS1naXQgYS9QZXJmb3JtYW5j ZVRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIvUGVyZm9ybWFuY2VUZXN0cy9wbGF0Zm9ybS9l ZmwvU2tpcHBlZApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kMjc3MjA5ZDQ5Y2M5ZTk5MWQ4YThjMzFlNDkxYzhjNDE4 OWVkMTkzCi0tLSAvZGV2L251bGwKKysrIGIvUGVyZm9ybWFuY2VUZXN0cy9wbGF0Zm9ybS9lZmwv U2tpcHBlZApAQCAtMCwwICsxLDMgQEAKKyMgUkVHUkVTU0lPTigxNzY2MDkpOiBNZW1vcnkgbGVh ayBpbiBDYW52YXMvcmV1c2UuaHRtbCBwZXJmb3JtYW5jZSB0ZXN0CisjIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk4MTIKK0NhbnZhcy9yZXVzZS5odG1sCg== 245951 2015-02-03 11:53:01 -0800 2015-02-04 02:34:57 -0800 Adds the support for platform modifier bug-141152-20150203115301.patch text/plain 3627 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3OTU1OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE1LTAyLTAzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFt3ZWJraXRweV0gQWRkIHBsYXRmb3JtIHNwZWNpZmljIFNraXBwZWQgZmlsZSBt ZWNoYW5pc20gZm9yIHBlcmZvcm1hbmNlIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDExNTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBTdXBwb3J0IGEgdGVzdC1leHBlY3RhdGlvbi1saWtlIHN5 bnRheCBpbiBwZXJmb3JtYW5jZSB0ZXN0cycgc2tpcHBlZCBmaWxlcy4KKyAgICAgICAgZS5nLiBb TWFjXSBQYXJzZWQvQmFkVGVzdC5odG1sIHdpbGwgc2tpcCBQYXJzZWQvQmFkVGVzdC5odG1sIG9u IE1hYyBwb3J0cy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5Ogor ICAgICAgICAoUG9ydC5za2lwcGVkX3BlcmZfdGVzdHMpOiBJbXBsZW1lbnRlZCB0aGUgc3ludGF4 IHN1cHBvcnQgYnkgYSByZWd1bGFyIGV4cHJlc3Npb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3BvcnQvYmFzZV91bml0dGVzdC5weToKKyAgICAgICAgKFBvcnRUZXN0LnRlc3Rfc2tp cHBlZF9wZXJmX3Rlc3RzKTogVGVzdCB0aGUgbmV3IHN5bnRheC4KKwogMjAxNS0wMi0wMyAgQnJl bnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBVbnJldmll d2VkIHRlc3QgZml4LgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkJKHJldmlz aW9uIDE3OTMyOCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNlLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC02OTksNyArNjk5LDI3IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKIAogICAg IEBtZW1vaXplZAogICAgIGRlZiBza2lwcGVkX3BlcmZfdGVzdHMoc2VsZik6Ci0gICAgICAgIHJl dHVybiBzZWxmLl9leHBlY3RhdGlvbnNfZnJvbV9za2lwcGVkX2ZpbGVzKFtzZWxmLnBlcmZfdGVz dHNfZGlyKCldKQorICAgICAgICBmaWxlbmFtZSA9IHNlbGYuX2ZpbGVzeXN0ZW0uam9pbihzZWxm LnBlcmZfdGVzdHNfZGlyKCksICJTa2lwcGVkIikKKyAgICAgICAgaWYgbm90IHNlbGYuX2ZpbGVz eXN0ZW0uZXhpc3RzKGZpbGVuYW1lKToKKyAgICAgICAgICAgIF9sb2cuZGVidWcoIlNraXBwZWQg ZG9lcyBub3QgZXhpc3Q6ICVzIiAlIGZpbGVuYW1lKQorICAgICAgICAgICAgcmV0dXJuIFtdCisK KyAgICAgICAgc2tpcHBlZF9maWxlX2NvbnRlbnRzID0gc2VsZi5fZmlsZXN5c3RlbS5yZWFkX3Rl eHRfZmlsZShmaWxlbmFtZSkKKyAgICAgICAgbGluZV9udW1iZXIgPSAxCisgICAgICAgIHRlc3Rz X3RvX3NraXAgPSBbXQorICAgICAgICBmb3IgbGluZSBpbiBza2lwcGVkX2ZpbGVfY29udGVudHMu c3BsaXQoJ1xuJyk6CisgICAgICAgICAgICBtYXRjaCA9IHJlLm1hdGNoKHInXlxzKihcWyg/UDxw bGF0Zm9ybXM+W1x3IF0qPylcXSk/XHMqKD9QPHRlc3Q+W1x3XC1cL1wuXSs/KT9ccyooP1A8Y29t bWVudD5cIy4qKT8kJywgbGluZSkKKyAgICAgICAgICAgIGlmIG5vdCBtYXRjaDoKKyAgICAgICAg ICAgICAgICBfbG9nLmVycm9yKCJTeW5hdHggZXJyb3IgYXQgbGluZSAlZCBpbiAlczogJXMiICUg KGxpbmVfbnVtYmVyLCBmaWxlbmFtZSwgbGluZSkpCisgICAgICAgICAgICBlbHNlOgorICAgICAg ICAgICAgICAgIHBsYXRmb3JtX25hbWVzID0gZmlsdGVyKGxhbWJkYSB0b2tlbjogdG9rZW4sIG1h dGNoLmdyb3VwKCdwbGF0Zm9ybXMnKS5sb3dlcigpLnNwbGl0KCcgJykpIGlmIG1hdGNoLmdyb3Vw KCdwbGF0Zm9ybXMnKSBlbHNlIFtdCisgICAgICAgICAgICAgICAgdGVzdF9uYW1lID0gbWF0Y2gu Z3JvdXAoJ3Rlc3QnKQorICAgICAgICAgICAgICAgIGlmIHRlc3RfbmFtZSBhbmQgKG5vdCBwbGF0 Zm9ybV9uYW1lcyBvciBzZWxmLnBvcnRfbmFtZSBpbiBwbGF0Zm9ybV9uYW1lcyBvciBzZWxmLl9u YW1lIGluIHBsYXRmb3JtX25hbWVzKToKKyAgICAgICAgICAgICAgICAgICAgdGVzdHNfdG9fc2tp cC5hcHBlbmQodGVzdF9uYW1lKQorCisgICAgICAgICAgICBsaW5lX251bWJlciArPSAxCisKKyAg ICAgICAgcmV0dXJuIHRlc3RzX3RvX3NraXAKIAogICAgIGRlZiBza2lwc19wZXJmX3Rlc3Qoc2Vs ZiwgdGVzdF9uYW1lKToKICAgICAgICAgZm9yIHRlc3Rfb3JfY2F0ZWdvcnkgaW4gc2VsZi5za2lw cGVkX3BlcmZfdGVzdHMoKToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9iYXNl X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9i YXNlX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAxNzkzMjgpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvYmFzZV91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTQ3LDggKzE0Nyw4 IEBAIGNsYXNzIFBvcnRUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgYWRkX3RleHRf ZmlsZSgnaW5zcGVjdG9yJywgJ3Rlc3QyLmh0bWwnKQogICAgICAgICBhZGRfdGV4dF9maWxlKCdp bnNwZWN0b3IvcmVzb3VyY2VzJywgJ3Jlc291cmNlX2ZpbGUuaHRtbCcpCiAgICAgICAgIGFkZF90 ZXh0X2ZpbGUoJ3Vuc3VwcG9ydGVkJywgJ3Vuc3VwcG9ydGVkX3Rlc3QyLmh0bWwnKQotICAgICAg ICBhZGRfdGV4dF9maWxlKCcnLCAnU2tpcHBlZCcsICdcbicuam9pbihbJ0xheW91dCcsICcnLCAn U3VuU3BpZGVyJywgJ1N1cHBvcnRlZC9zb21lLXRlc3QuaHRtbCddKSkKLSAgICAgICAgc2VsZi5h c3NlcnRFcXVhbChwb3J0LnNraXBwZWRfcGVyZl90ZXN0cygpLCBbJ0xheW91dCcsICdTdW5TcGlk ZXInLCAnU3VwcG9ydGVkL3NvbWUtdGVzdC5odG1sJ10pCisgICAgICAgIGFkZF90ZXh0X2ZpbGUo JycsICdTa2lwcGVkJywgJ1xuJy5qb2luKFsnTGF5b3V0JywgJycsICdTdW5TcGlkZXInLCAnU3Vw cG9ydGVkL3NvbWUtdGVzdC5odG1sJywgJ1tFeG90aWNQb3J0XSBVbnNraXBwZWRUZXN0Lmh0bWwn LCAnW2Jhc2Vwb3J0XSBTa2lwcGVkVGVzdC5odG1sJ10pKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFsKHBvcnQuc2tpcHBlZF9wZXJmX3Rlc3RzKCksIFsnTGF5b3V0JywgJ1N1blNwaWRlcicsICdT dXBwb3J0ZWQvc29tZS10ZXN0Lmh0bWwnLCAnU2tpcHBlZFRlc3QuaHRtbCddKQogCiAgICAgZGVm IHRlc3RfZ2V0X29wdGlvbl9fc2V0KHNlbGYpOgogICAgICAgICBvcHRpb25zLCBhcmdzID0gb3B0 cGFyc2UuT3B0aW9uUGFyc2VyKCkucGFyc2VfYXJncyhbXSkK