140287 2015-01-09 00:53:57 -0800 [Regression] [GStreamer] Video player sets system volume to 100% 2015-07-08 07:13:05 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED WORKSFORME https://bugs.webkit.org/show_bug.cgi?id=145609 https://bugs.webkit.org/show_bug.cgi?id=140358 http://www.w3.org/2010/05/video/mediaevents.html P2 Major --- 1 calvaris webkit-unassigned adachan allan.jensen bugzilla calvaris commit-queue eocanha eric.carlson esprehn+autocc glenn gustavo jer.noble jonathon menard mrobinson patrakov pnormand oldest_to_newest 1060099 0 calvaris 2015-01-09 00:53:57 -0800 +++ This bug was initially created as a clone of Bug #118974 +++ +++ This bug was initially created as a clone of Bug #54140 +++ This is back as a consequence of fixing bug 137305. I guess this time we should end up creating a test so that this doesn't regress anymore. The proper fix would be reverting my original patch and fix it by using the new Browsers API at Pulseaudio but for that we need to have it implemented there and adapted in GStreamer, so I guess we'll have to fix this the same way again without breaking bug 137305. We'd appreciate if Ada could provide info about which test covers her fix so that we ensure we don't break anything again. 1060116 1 calvaris 2015-01-09 03:17:13 -0800 This is being talked in Epiphany's bugzilla at https://bugzilla.gnome.org/show_bug.cgi?id=675217 1060142 2 jer.noble 2015-01-09 08:43:15 -0800 (In reply to comment #0) > +++ This bug was initially created as a clone of Bug #118974 +++ > > +++ This bug was initially created as a clone of Bug #54140 +++ > > This is back as a consequence of fixing bug 137305. I guess this time we > should end up creating a test so that this doesn't regress anymore. > > The proper fix would be reverting my original patch and fix it by using the > new Browsers API at Pulseaudio but for that we need to have it implemented > there and adapted in GStreamer, so I guess we'll have to fix this the same > way again without breaking bug 137305. We'd appreciate if Ada could provide > info about which test covers her fix so that we ensure we don't break > anything again. The original change broke a WebKitAPI test, which I don't believe are run as a part of normal EWS or post-commit tests. But they can be run manually with: `run-api-tests WebKit2.WKPageIsPlayingAudio` 1060170 3 adachan 2015-01-09 10:29:17 -0800 There is no layout test for https://bugs.webkit.org/show_bug.cgi?id=137305, since there's no simple way to test whether the page has really been muted. The way I tested the fix for https://bugs.webkit.org/show_bug.cgi?id=137305 was just with this simple html page: <div id=target style="border: solid;"> <video src="http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_r640-9cie.mov" autoplay controls></video> </div> And then call WKPageSetMuted(pageRef, true) and make sure the page is indeed silent. 1060559 4 calvaris 2015-01-12 07:45:53 -0800 I couldn't reproduce the bug so I am closing it.