139347 2014-12-06 13:05:24 -0800 [Mac] DumpRenderTree sets storage directory incorrectly 2014-12-19 14:28:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 138958 1 ap ap bfulgham commit-queue dino mitz simon.fraser oldest_to_newest 1053058 0 ap 2014-12-06 13:05:24 -0800 Storage tests are flaky in WebKit1, because DumpRenderTree effectively makes all parallel processes use the same temporary directory. I hope that this fix will address increased appcache test flakiness that started this week, when I changed DRT to delete appcache between tests - this made sqlite race for access to ApplicationCache.db a lot more than before. 1053059 1 242724 ap 2014-12-06 13:11:10 -0800 Created attachment 242724 proposed fix 1053061 2 ap 2014-12-06 13:22:11 -0800 I'm now trying to remember if we needed to set standard defaults in order to make frameworks that use CFPreferences work... 1053064 3 242724 ap 2014-12-06 13:27:42 -0800 Comment on attachment 242724 proposed fix Bummer. http://trac.webkit.org/changeset/158652 says: -------------- Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults and CFPreferencesCopyAppValue family of functions, it doesn't work with CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...). -------------- So, we should use NSArgumentDomain only for per instance preferences. 1053065 4 242726 ap 2014-12-06 13:35:03 -0800 Created attachment 242726 proposed fix Looking at WebKit1 code, we have a bunch of unfortunate special cases that bypass WebPreferences, and use NSUserDefaults directly. WebKitKerningAndLigaturesEnabledByDefaultDefaultsKey is read and written by WebView, so it's global per process identifier, and cannot be different in different WebViews or in parallel DumpRenderTrees. Same thing with these ones, which are further complicated due to interactions between WebKit and AppKit preferences: [webView setContinuousSpellCheckingEnabled:YES]; [webView setAutomaticQuoteSubstitutionEnabled:NO]; [webView setAutomaticLinkDetectionEnabled:NO]; [webView setAutomaticDashSubstitutionEnabled:NO]; [webView setAutomaticTextReplacementEnabled:NO]; [webView setAutomaticSpellingCorrectionEnabled:YES]; [webView setGrammarCheckingEnabled:YES]; 1053074 5 242726 commit-queue 2014-12-06 15:52:03 -0800 Comment on attachment 242726 proposed fix Clearing flags on attachment: 242726 Committed r176917: <http://trac.webkit.org/changeset/176917> 1053075 6 commit-queue 2014-12-06 15:52:06 -0800 All reviewed patches have been landed. Closing bug. 242724 2014-12-06 13:11:10 -0800 2014-12-06 13:35:03 -0800 proposed fix DRTUserDefaults.txt text/plain 1367 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NjkxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTEyLTA2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtNYWNdIER1bXBSZW5kZXJUcmVlIHNldHMgc3RvcmFnZSBkaXJlY3Rvcnkg aW5jb3JyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzOTM0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tOiAoc2V0RGVmYXVsdHNU b0NvbnNpc3RlbnRWYWx1ZXNGb3JUZXN0aW5nKToKKyAgICAgICAgRG9uJ3QgdXNlIHVzZXIgZGVm YXVsdHMgdG8gcGFzcyBwZXItaW5zdGFuY2UgcGF0aHMsIGFzIHVzZXIgZGVmYXVsdHMgYXJlIHNo YXJlZAorICAgICAgICBhY3Jvc3MgYWxsIGluc3RhbmNlcy4KKwogMjAxNC0xMi0wNSAgQ2hyaXMg RmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBJIGNhbm5vdCBh Y3RpdmF0ZSBsaW5rcyBvbiB0aGUgbW9iaWxlIHZlcnNpb24gb2YgbmV3cy5nb29nbGUuY29tCklu ZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCShyZXZpc2lv biAxNzY5MDMpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0J KHdvcmtpbmcgY29weSkKQEAgLTk0OSw3ICs5NDksNyBAQCBzdGF0aWMgdm9pZCBzZXREZWZhdWx0 c1RvQ29uc2lzdGVudFZhbHVlCiAgICAgICAgIFdlYktpdExvY2FsQ2FjaGVEZWZhdWx0c0tleTog W2xpYnJhcnlQYXRoIHN0cmluZ0J5QXBwZW5kaW5nUGF0aENvbXBvbmVudDpAIkxvY2FsQ2FjaGUi XQogICAgIH07CiAKLSAgICBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBz ZXRWYWx1ZXNGb3JLZXlzV2l0aERpY3Rpb25hcnk6ZGljdF07CisgICAgW1tOU1VzZXJEZWZhdWx0 cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gc2V0Vm9sYXRpbGVEb21haW46ZGljdCBmb3JOYW1lOk5T QXJndW1lbnREb21haW5dOwogfQogCiBzdGF0aWMgdm9pZCBydW5UaHJlYWQodm9pZCogYXJnKQo= 242726 2014-12-06 13:35:03 -0800 2014-12-06 15:52:03 -0800 proposed fix DRTUserDefaults.txt text/plain 2522 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NjkxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTEyLTA2ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFtNYWNdIER1bXBSZW5kZXJUcmVlIHNldHMgc3RvcmFnZSBkaXJlY3Rvcnkg aW5jb3JyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzOTM0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tOiAoc2V0RGVmYXVsdHNU b0NvbnNpc3RlbnRWYWx1ZXNGb3JUZXN0aW5nKToKKyAgICAgICAgRG9uJ3QgdXNlIHVzZXIgZGVm YXVsdHMgdG8gcGFzcyBwZXItaW5zdGFuY2UgcGF0aHMsIGFzIHVzZXIgZGVmYXVsdHMgYXJlIHNo YXJlZAorICAgICAgICBhY3Jvc3MgYWxsIGluc3RhbmNlcy4KKwogMjAxNC0xMi0wNSAgQ2hyaXMg RmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBJIGNhbm5vdCBh Y3RpdmF0ZSBsaW5rcyBvbiB0aGUgbW9iaWxlIHZlcnNpb24gb2YgbmV3cy5nb29nbGUuY29tCklu ZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCShyZXZpc2lv biAxNzY5MDMpCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW0J KHdvcmtpbmcgY29weSkKQEAgLTc5Miw5ICs3OTIsNiBAQCBzdGF0aWMgdm9pZCBkZXN0cm95V2Vi Vmlld0FuZE9mZnNjcmVlbldpCiAKIHN0YXRpYyBOU1N0cmluZyAqbGlicmFyeVBhdGhGb3JEdW1w UmVuZGVyVHJlZSgpCiB7Ci0gICAgLy9GSVhNRTogVGhpcyBtYXkgbm90IGJlIHN1ZmZpY2llbnQg dG8gcHJldmVudCBpbnRlcmFjdGlvbnMvY3Jhc2hlcwotICAgIC8vd2hlbiBydW5uaW5nIG1vcmUg dGhhbiBvbmUgY29weSBvZiBEdW1wUmVuZGVyVHJlZS4KLSAgICAvL1NlZSBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA5MDYKICAgICBjaGFyKiBkdW1wUmVuZGVyVHJl ZVRlbXAgPSBnZXRlbnYoIkRVTVBSRU5ERVJUUkVFX1RFTVAiKTsKICAgICBpZiAoZHVtcFJlbmRl clRyZWVUZW1wKQogICAgICAgICByZXR1cm4gW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1bHRNYW5hZ2Vy XSBzdHJpbmdXaXRoRmlsZVN5c3RlbVJlcHJlc2VudGF0aW9uOmR1bXBSZW5kZXJUcmVlVGVtcCBs ZW5ndGg6c3RybGVuKGR1bXBSZW5kZXJUcmVlVGVtcCldOwpAQCAtOTQ0LDEyICs5NDEsMTcgQEAg c3RhdGljIHZvaWQgc2V0RGVmYXVsdHNUb0NvbnNpc3RlbnRWYWx1ZQogICAgICAgICBAIk5TT3Zl cmxheVNjcm9sbGVyc0VuYWJsZWQiOiBATk8sCiAgICAgICAgIEAiQXBwbGVTaG93U2Nyb2xsQmFy cyI6IEAiQWx3YXlzIiwKICAgICAgICAgQCJOU0J1dHRvbkFuaW1hdGlvbnNFbmFibGVkIjogQE5P LCAvLyBJZGVhbGx5LCB3ZSBzaG91bGQgZmluZCBhIHdheSB0byB0ZXN0IGFuaW1hdGlvbnMsIGJ1 dCBmb3Igbm93LCBtYWtlIHN1cmUgdGhhdCB0aGUgZHVtcGVkIHNuYXBzaG90IG1hdGNoZXMgYWN0 dWFsIHN0YXRlLgorICAgIH07CisKKyAgICBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRl ZmF1bHRzXSBzZXRWYWx1ZXNGb3JLZXlzV2l0aERpY3Rpb25hcnk6ZGljdF07CisKKyAgICBOU0Rp Y3Rpb25hcnkgKnByb2Nlc3NJbnN0YW5jZURlZmF1bHRzID0gQHsKICAgICAgICAgV2ViRGF0YWJh c2VEaXJlY3RvcnlEZWZhdWx0c0tleTogW2xpYnJhcnlQYXRoIHN0cmluZ0J5QXBwZW5kaW5nUGF0 aENvbXBvbmVudDpAIkRhdGFiYXNlcyJdLAogICAgICAgICBXZWJTdG9yYWdlRGlyZWN0b3J5RGVm YXVsdHNLZXk6IFtsaWJyYXJ5UGF0aCBzdHJpbmdCeUFwcGVuZGluZ1BhdGhDb21wb25lbnQ6QCJM b2NhbFN0b3JhZ2UiXSwKICAgICAgICAgV2ViS2l0TG9jYWxDYWNoZURlZmF1bHRzS2V5OiBbbGli cmFyeVBhdGggc3RyaW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OkAiTG9jYWxDYWNoZSJdCiAg ICAgfTsKIAotICAgIFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIHNldFZh bHVlc0ZvcktleXNXaXRoRGljdGlvbmFyeTpkaWN0XTsKKyAgICBbW05TVXNlckRlZmF1bHRzIHN0 YW5kYXJkVXNlckRlZmF1bHRzXSBzZXRWb2xhdGlsZURvbWFpbjpwcm9jZXNzSW5zdGFuY2VEZWZh dWx0cyBmb3JOYW1lOk5TQXJndW1lbnREb21haW5dOwogfQogCiBzdGF0aWMgdm9pZCBydW5UaHJl YWQodm9pZCogYXJnKQo=