138428 2014-11-05 09:14:28 -0800 [GTK] Run layout tests using the network process 2014-11-12 06:23:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 138460 138500 138501 1 cgarcia webkit-unassigned andersca ap clopez commit-queue gustavo ossy oldest_to_newest 1046488 0 cgarcia 2014-11-05 09:14:28 -0800 Shared secondary process is the default in the GTK+ port, but we should run the tests using the network process to ensure everything works with the network process. In the future, the shared secondary process model might be a special case of multiple processes with 1 as maximum number of processes, but always using the network process. 1046489 1 241031 cgarcia 2014-11-05 09:16:19 -0800 Created attachment 241031 Patch 1046756 2 cgarcia 2014-11-06 00:47:39 -0800 Committed r175690: <http://trac.webkit.org/changeset/175690> 1046773 3 commit-queue 2014-11-06 02:26:46 -0800 Re-opened since this is blocked by bug 138460 1047279 4 cgarcia 2014-11-08 02:51:52 -0800 Let's try again now :-) 1047280 5 cgarcia 2014-11-08 02:53:27 -0800 Committed r175776: <http://trac.webkit.org/changeset/175776> 1047281 6 cgarcia 2014-11-08 03:50:10 -0800 Ok, no more crashes, but there are still some more failures, most of them are http tests. I'll look at those in detail and will try to fix them without rolling this out again. 1047298 7 clopez 2014-11-08 11:29:54 -0800 (In reply to comment #6) > Ok, no more crashes, but there are still some more failures, most of them > are http tests. I'll look at those in detail and will try to fix them > without rolling this out again. This (r175776) has caused +60 new failures: r175775 -> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4067 r175776 -> https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/4064 1047356 8 ap 2014-11-08 20:29:20 -0800 One big reason for these failures is that shared workers are disabled in multiple web process mode. Another one that I'm particularly interested in is http/tests/xmlhttprequest/cross-origin-cookie-storage.html. It looks like I independently broke this test on Mac a few revisions later. We'll need to see what's going on there. 1047374 9 ap 2014-11-08 22:34:24 -0800 > Another one that I'm particularly interested in is > http/tests/xmlhttprequest/cross-origin-cookie-storage.html. Turns out that it's simply because testRunner.setAlwaysAcceptCookies is not implemented with NetworkProcess. The test used to pass on Mac by mistake, due to having a cookie leak from a previous test. I disabled it on Mac. 1047380 10 cgarcia 2014-11-09 02:06:01 -0800 (In reply to comment #7) > (In reply to comment #6) > > Ok, no more crashes, but there are still some more failures, most of them > > are http tests. I'll look at those in detail and will try to fix them > > without rolling this out again. > > This (r175776) has caused +60 new failures: I know, and I said that I'll look at those in detail and I'll try to fix them without rolling it out. If I can't figure out how to fix the failures, I'll roll this out, don't worry. > r175775 -> > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20%28Tests%29/builds/4067 > > r175776 -> > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20%28Tests%29/builds/4064 1048146 11 cgarcia 2014-11-12 06:23:55 -0800 (In reply to comment #8) > One big reason for these failures is that shared workers are disabled in > multiple web process mode. Thanks, I've just skipped the shared workers tests in r176019 241031 2014-11-05 09:16:19 -0800 2014-11-05 10:11:34 -0800 Patch wk-tests-network-process.diff text/plain 1838 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4Y2Jj ZmZmLi44ZjRjYTQ0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTQtMTEtMDUgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIFJ1biBsYXlvdXQgdGVzdHMg dXNpbmcgdGhlIG5ldHdvcmsgcHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM4NDI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2hhcmVkIHNlY29uZGFyeSBwcm9jZXNzIGlzIHRoZSBkZWZhdWx0 IGluIHRoZSBHVEsrIHBvcnQsIGJ1dCB3ZQorICAgICAgICBzaG91bGQgcnVuIHRoZSB0ZXN0cyB1 c2luZyB0aGUgbmV0d29yayBwcm9jZXNzIHRvIGVuc3VyZQorICAgICAgICBldmVyeXRoaW5nIHdv cmtzIHdpdGggdGhlIG5ldHdvcmsgcHJvY2Vzcy4gSW4gdGhlIGZ1dHVyZSwgdGhlCisgICAgICAg IHNoYXJlZCBzZWNvbmRhcnkgcHJvY2VzcyBtb2RlbCBtaWdodCBiZSBhIHNwZWNpYWwgY2FzZSBv ZiBtdWx0aXBsZQorICAgICAgICBwcm9jZXNzZXMgd2l0aCAxIGFzIG1heGltdW0gbnVtYmVyIG9m IHByb2Nlc3NlcywgYnV0IGFsd2F5cyB1c2luZworICAgICAgICB0aGUgbmV0d29yayBwcm9jZXNz LgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHA6CisgICAg ICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjppbml0aWFsaXplKToKKworMjAxNC0xMS0wNSAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10g QWRkIFdlYktpdFdlYlJlc291cmNlOjpmYWlsZWQtd2l0aC10bHMtZXJyb3JzIHNpZ25hbAogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM3ODYyCiAKZGlm ZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdENvbnRyb2xsZXIuY3BwIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKaW5kZXggMDk2NjA2NS4uZGNk ZTA1YSAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5j cHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0Q29udHJvbGxlci5jcHAKQEAgLTMz Miw3ICszMzIsNyBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjppbml0aWFsaXplKGludCBhcmdjLCBj b25zdCBjaGFyKiBhcmd2W10pCiAgICAgbV9jb250ZXh0ID0gYWRvcHRXSyhXS0NvbnRleHRDcmVh dGVXaXRoQ29uZmlndXJhdGlvbihjb25maWd1cmF0aW9uLmdldCgpKSk7CiAgICAgbV9nZW9sb2Nh dGlvblByb3ZpZGVyID0gc3RkOjptYWtlX3VuaXF1ZTxHZW9sb2NhdGlvblByb3ZpZGVyTW9jaz4o bV9jb250ZXh0LmdldCgpKTsKIAotI2lmIFBMQVRGT1JNKElPUykgfHwgKFBMQVRGT1JNKE1BQykg JiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+IDEwODApCisjaWYgUExBVEZPUk0o SU9TKSB8fCAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID4gMTA4MCkgfHwgUExBVEZPUk0oR1RLKQogICAgIFdLQ29udGV4dFNldFVzZXNOZXR3b3JrUHJv Y2VzcyhtX2NvbnRleHQuZ2V0KCksIHRydWUpOwogICAgIFdLQ29udGV4dFNldFByb2Nlc3NNb2Rl bChtX2NvbnRleHQuZ2V0KCksIGtXS1Byb2Nlc3NNb2RlbE11bHRpcGxlU2Vjb25kYXJ5UHJvY2Vz c2VzKTsKICNlbmRpZgo=