<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138402</bug_id>
          
          <creation_ts>2014-11-04 19:50:54 -0800</creation_ts>
          <short_desc>Use std::unique_ptr in JSClassRef and JSCallbackObject</short_desc>
          <delta_ts>2014-11-23 18:25:59 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>128007</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Gyuyoung Kim">gyuyoung.kim</reporter>
          <assigned_to name="Gyuyoung Kim">gyuyoung.kim</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1046359</commentid>
    <comment_count>0</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-11-04 19:50:54 -0800</bug_when>
    <thetext>SSIA</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046360</commentid>
    <comment_count>1</comment_count>
      <attachid>240999</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-11-04 19:51:36 -0800</bug_when>
    <thetext>Created attachment 240999
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046549</commentid>
    <comment_count>2</comment_count>
      <attachid>240999</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2014-11-05 11:45:28 -0800</bug_when>
    <thetext>Comment on attachment 240999
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046662</commentid>
    <comment_count>3</comment_count>
      <attachid>240999</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-05 17:21:47 -0800</bug_when>
    <thetext>Comment on attachment 240999
Patch

Clearing flags on attachment: 240999

Committed r175651: &lt;http://trac.webkit.org/changeset/175651&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046663</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-05 17:21:50 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240999</attachid>
            <date>2014-11-04 19:51:36 -0800</date>
            <delta_ts>2014-11-05 17:21:47 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-138402-20141105125145.patch</filename>
            <type>text/plain</type>
            <size>4042</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl
OTkzZGZhMzNlZjYzOTNiYTZlMjAwZmNiNzc5MTQyNWI4N2MxODk0Li5mYjQ4MWIxY2I2YjVmNDU1
ZGI2ZjgyODI2OTNhODAzOWE1MzUwNWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNSBAQAorMjAxNC0xMS0wNCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1
bmcuY29tPgorCisgICAgICAgIFVzZSBzdGQ6OnVuaXF1ZV9wdHIgaW4gSlNDbGFzc1JlZiBhbmQg
SlNDYWxsYmFja09iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTM4NDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgKiBBUEkvSlNDYWxsYmFja09iamVjdC5oOiBVc2Ugc3RkOjp1bmlxdWVfcHRyIGlu
c3RlYWQgb2YgT3duUHRyfFBhc3NPd25QdHIuCisgICAgICAgIChKU0M6OkpTQ2FsbGJhY2tPYmpl
Y3REYXRhOjpzZXRQcml2YXRlUHJvcGVydHkpOiBkaXR0by4KKyAgICAgICAgKiBBUEkvSlNDbGFz
c1JlZi5jcHA6IGRpdHRvLgorICAgICAgICAqIEFQSS9KU0NsYXNzUmVmLmg6IGRpdHRvLgorCiAy
MDE0LTExLTA0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAg
ICAgV2ViIEluc3BlY3RvcjogUGF1c2Ugb24gZXhjZXB0aW9ucyBzaG91bGQgc2hvdyB0aGUgYWN0
dWFsIGV4Y2VwdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0Nh
bGxiYWNrT2JqZWN0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tPYmpl
Y3QuaAppbmRleCAxZTBkMDcyYjk1YjI0ODk1YWFhYWY2ODAzMDVkOTcxNmFkMmZjYzM5Li42OTli
YzQ0NDY2NDExMjNlYjkxOTM1ZTA2ZDQzYTg4NDdiN2NhNTU1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tPYmplY3QuaAorKysgYi9Tb3VyY2UvSmF2YVNj
cmlwdENvcmUvQVBJL0pTQ2FsbGJhY2tPYmplY3QuaApAQCAtNTYsNyArNTYsNyBAQCBzdHJ1Y3Qg
SlNDYWxsYmFja09iamVjdERhdGEgOiBXZWFrSGFuZGxlT3duZXIgewogICAgIHZvaWQgc2V0UHJp
dmF0ZVByb3BlcnR5KFZNJiB2bSwgSlNDZWxsKiBvd25lciwgY29uc3QgSWRlbnRpZmllciYgcHJv
cGVydHlOYW1lLCBKU1ZhbHVlIHZhbHVlKQogICAgIHsKICAgICAgICAgaWYgKCFtX3ByaXZhdGVQ
cm9wZXJ0aWVzKQotICAgICAgICAgICAgbV9wcml2YXRlUHJvcGVydGllcyA9IGFkb3B0UHRyKG5l
dyBKU1ByaXZhdGVQcm9wZXJ0eU1hcCk7CisgICAgICAgICAgICBtX3ByaXZhdGVQcm9wZXJ0aWVz
ID0gc3RkOjptYWtlX3VuaXF1ZTxKU1ByaXZhdGVQcm9wZXJ0eU1hcD4oKTsKICAgICAgICAgbV9w
cml2YXRlUHJvcGVydGllcy0+c2V0UHJpdmF0ZVByb3BlcnR5KHZtLCBvd25lciwgcHJvcGVydHlO
YW1lLCB2YWx1ZSk7CiAgICAgfQogICAgIApAQCAtMTA4LDcgKzEwOCw3IEBAIHN0cnVjdCBKU0Nh
bGxiYWNrT2JqZWN0RGF0YSA6IFdlYWtIYW5kbGVPd25lciB7CiAgICAgICAgIHR5cGVkZWYgSGFz
aE1hcDxSZWZQdHI8U3RyaW5nSW1wbD4sIFdyaXRlQmFycmllcjxVbmtub3duPiwgSWRlbnRpZmll
clJlcEhhc2g+IFByaXZhdGVQcm9wZXJ0eU1hcDsKICAgICAgICAgUHJpdmF0ZVByb3BlcnR5TWFw
IG1fcHJvcGVydHlNYXA7CiAgICAgfTsKLSAgICBPd25QdHI8SlNQcml2YXRlUHJvcGVydHlNYXA+
IG1fcHJpdmF0ZVByb3BlcnRpZXM7CisgICAgc3RkOjp1bmlxdWVfcHRyPEpTUHJpdmF0ZVByb3Bl
cnR5TWFwPiBtX3ByaXZhdGVQcm9wZXJ0aWVzOwogICAgIHZpcnR1YWwgdm9pZCBmaW5hbGl6ZShI
YW5kbGU8VW5rbm93bj4sIHZvaWQqKSBvdmVycmlkZTsKIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDbGFzc1JlZi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQVBJL0pTQ2xhc3NSZWYuY3BwCmluZGV4IDQ1MjQxMmUzM2Y1ZjNlZTc2Y2QxMWU5MzQyYWY3
OTgzNzgxMDAwOGEuLmUzNTQ3ZDJmNWQzY2QwNDIzY2JiNDVhMmYxMzhjNzQ3NGVhZGJiOWUgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDbGFzc1JlZi5jcHAKKysrIGIv
U291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NsYXNzUmVmLmNwcApAQCAtNjIsNyArNjIsNyBA
QCBPcGFxdWVKU0NsYXNzOjpPcGFxdWVKU0NsYXNzKGNvbnN0IEpTQ2xhc3NEZWZpbml0aW9uKiBk
ZWZpbml0aW9uLCBPcGFxdWVKU0NsYXNzKgogICAgIGluaXRpYWxpemVUaHJlYWRpbmcoKTsKIAog
ICAgIGlmIChjb25zdCBKU1N0YXRpY1ZhbHVlKiBzdGF0aWNWYWx1ZSA9IGRlZmluaXRpb24tPnN0
YXRpY1ZhbHVlcykgewotICAgICAgICBtX3N0YXRpY1ZhbHVlcyA9IGFkb3B0UHRyKG5ldyBPcGFx
dWVKU0NsYXNzU3RhdGljVmFsdWVzVGFibGUpOworICAgICAgICBtX3N0YXRpY1ZhbHVlcyA9IHN0
ZDo6bWFrZV91bmlxdWU8T3BhcXVlSlNDbGFzc1N0YXRpY1ZhbHVlc1RhYmxlPigpOwogICAgICAg
ICB3aGlsZSAoc3RhdGljVmFsdWUtPm5hbWUpIHsKICAgICAgICAgICAgIFN0cmluZyB2YWx1ZU5h
bWUgPSBTdHJpbmc6OmZyb21VVEY4KHN0YXRpY1ZhbHVlLT5uYW1lKTsKICAgICAgICAgICAgIGlm
ICghdmFsdWVOYW1lLmlzTnVsbCgpKQpAQCAtNzIsNyArNzIsNyBAQCBPcGFxdWVKU0NsYXNzOjpP
cGFxdWVKU0NsYXNzKGNvbnN0IEpTQ2xhc3NEZWZpbml0aW9uKiBkZWZpbml0aW9uLCBPcGFxdWVK
U0NsYXNzKgogICAgIH0KIAogICAgIGlmIChjb25zdCBKU1N0YXRpY0Z1bmN0aW9uKiBzdGF0aWNG
dW5jdGlvbiA9IGRlZmluaXRpb24tPnN0YXRpY0Z1bmN0aW9ucykgewotICAgICAgICBtX3N0YXRp
Y0Z1bmN0aW9ucyA9IGFkb3B0UHRyKG5ldyBPcGFxdWVKU0NsYXNzU3RhdGljRnVuY3Rpb25zVGFi
bGUpOworICAgICAgICBtX3N0YXRpY0Z1bmN0aW9ucyA9IHN0ZDo6bWFrZV91bmlxdWU8T3BhcXVl
SlNDbGFzc1N0YXRpY0Z1bmN0aW9uc1RhYmxlPigpOwogICAgICAgICB3aGlsZSAoc3RhdGljRnVu
Y3Rpb24tPm5hbWUpIHsKICAgICAgICAgICAgIFN0cmluZyBmdW5jdGlvbk5hbWUgPSBTdHJpbmc6
OmZyb21VVEY4KHN0YXRpY0Z1bmN0aW9uLT5uYW1lKTsKICAgICAgICAgICAgIGlmICghZnVuY3Rp
b25OYW1lLmlzTnVsbCgpKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K
U0NsYXNzUmVmLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ2xhc3NSZWYuaAppbmRl
eCA5MjZmMDgyYmY5MTc2NjA2ZjM2ZTUyMDkzZThjYzVkMzliZDkyZWJiLi5kMjk4YTE2MTljOTY2
Y2RlYWFjNjA5OWZkOTI0OTgyNWIzN2Q1YzBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQVBJL0pTQ2xhc3NSZWYuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pT
Q2xhc3NSZWYuaApAQCAtMTIwLDggKzEyMCw4IEBAIHByaXZhdGU6CiAKICAgICAvLyBTdHJpbmdz
IGluIHRoZXNlIGRhdGEgbWVtYmVycyBzaG91bGQgbm90IGJlIHB1dCBpbnRvIGFueSBBdG9taWNT
dHJpbmdUYWJsZS4KICAgICBTdHJpbmcgbV9jbGFzc05hbWU7Ci0gICAgT3duUHRyPE9wYXF1ZUpT
Q2xhc3NTdGF0aWNWYWx1ZXNUYWJsZT4gbV9zdGF0aWNWYWx1ZXM7Ci0gICAgT3duUHRyPE9wYXF1
ZUpTQ2xhc3NTdGF0aWNGdW5jdGlvbnNUYWJsZT4gbV9zdGF0aWNGdW5jdGlvbnM7CisgICAgc3Rk
Ojp1bmlxdWVfcHRyPE9wYXF1ZUpTQ2xhc3NTdGF0aWNWYWx1ZXNUYWJsZT4gbV9zdGF0aWNWYWx1
ZXM7CisgICAgc3RkOjp1bmlxdWVfcHRyPE9wYXF1ZUpTQ2xhc3NTdGF0aWNGdW5jdGlvbnNUYWJs
ZT4gbV9zdGF0aWNGdW5jdGlvbnM7CiB9OwogCiAjZW5kaWYgLy8gSlNDbGFzc1JlZl9oCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>