<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>138395</bug_id>
          
          <creation_ts>2014-11-04 18:10:29 -0800</creation_ts>
          <short_desc>Use std::unique_ptr in CodeBlock class</short_desc>
          <delta_ts>2014-11-23 18:25:59 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>128007</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Gyuyoung Kim">gyuyoung.kim</reporter>
          <assigned_to name="Gyuyoung Kim">gyuyoung.kim</assigned_to>
          <cc>buildbot</cc>
    
    <cc>commit-queue</cc>
    
    <cc>rniwa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1046328</commentid>
    <comment_count>0</comment_count>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-11-04 18:10:29 -0800</bug_when>
    <thetext>SSIA</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046330</commentid>
    <comment_count>1</comment_count>
      <attachid>240993</attachid>
    <who name="Gyuyoung Kim">gyuyoung.kim</who>
    <bug_when>2014-11-04 18:11:25 -0800</bug_when>
    <thetext>Created attachment 240993
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046757</commentid>
    <comment_count>2</comment_count>
      <attachid>240993</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-06 00:50:32 -0800</bug_when>
    <thetext>Comment on attachment 240993
Patch

Clearing flags on attachment: 240993

Committed r175691: &lt;http://trac.webkit.org/changeset/175691&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1046758</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-11-06 00:50:36 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240993</attachid>
            <date>2014-11-04 18:11:25 -0800</date>
            <delta_ts>2014-11-06 00:50:32 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-138395-20141105111135.patch</filename>
            <type>text/plain</type>
            <size>4981</size>
            <attacher name="Gyuyoung Kim">gyuyoung.kim</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTc1NTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl
OTkzZGZhMzNlZjYzOTNiYTZlMjAwZmNiNzc5MTQyNWI4N2MxODk0Li4yZGRjMGU4NWE0OTI2ZmQx
ZjEzZDA5NTE3YTk2MDBiMGRhOGRlYTEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxNC0xMS0wNCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1
bmcuY29tPgorCisgICAgICAgIFVzZSBzdGQ6OnVuaXF1ZV9wdHIgaW4gQ29kZUJsb2NrIGNsYXNz
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzgzOTUK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVj
b2RlL0NvZGVCbG9jay5oOiBVc2Ugc3RkOjp1bmlxdWVfcHRyLgorICAgICAgICAoSlNDOjpDb2Rl
QmxvY2s6OnNldEpJVENvZGVNYXApOgorICAgICAgICAqIGppdC9Db21wYWN0SklUQ29kZU1hcC5o
OiBVc2Ugc3RkOjp1bmlxdWVfcHRyIGluc3RlYWQgb2YgT3duUHRyfFBhc3NPd25QdHIuCisgICAg
ICAgIChKU0M6OkNvbXBhY3RKSVRDb2RlTWFwOjpDb21wYWN0SklUQ29kZU1hcCk6CisgICAgICAg
IChKU0M6OkNvbXBhY3RKSVRDb2RlTWFwOjpFbmNvZGVyOjpmaW5pc2gpOiBVc2Ugc3RkOjp1bmlx
dWVfcHRyIGluc3RlYWQgb2YgUGFzc093blB0ci4KKwogMjAxNC0xMS0wNCAgSm9zZXBoIFBlY29y
YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFBhdXNl
IG9uIGV4Y2VwdGlvbnMgc2hvdWxkIHNob3cgdGhlIGFjdHVhbCBleGNlcHRpb24KZGlmZiAtLWdp
dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaCBiL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAppbmRleCA2NjBhNWM0ZTYxMmQ3OTVm
NDgzYzhjZDZlODhmZDU5OWNmYjg0OGQ2Li4xOGQ3OGEwYzY5NWU0YzcxNWZkYjE4M2E5Mjg3OGRk
OGQ3Yzg2YmE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29k
ZUJsb2NrLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5o
CkBAIC0yMzksOSArMjM5LDkgQEAgcHVibGljOgogCiAgICAgdm9pZCBsaW5rSW5jb21pbmdDYWxs
KEV4ZWNTdGF0ZSogY2FsbGVyRnJhbWUsIExMSW50Q2FsbExpbmtJbmZvKik7CiAKLSAgICB2b2lk
IHNldEpJVENvZGVNYXAoUGFzc093blB0cjxDb21wYWN0SklUQ29kZU1hcD4gaml0Q29kZU1hcCkK
KyAgICB2b2lkIHNldEpJVENvZGVNYXAoc3RkOjp1bmlxdWVfcHRyPENvbXBhY3RKSVRDb2RlTWFw
PiBqaXRDb2RlTWFwKQogICAgIHsKLSAgICAgICAgbV9qaXRDb2RlTWFwID0gaml0Q29kZU1hcDsK
KyAgICAgICAgbV9qaXRDb2RlTWFwID0gV1RGOjptb3ZlKGppdENvZGVNYXApOwogICAgIH0KICAg
ICBDb21wYWN0SklUQ29kZU1hcCogaml0Q29kZU1hcCgpCiAgICAgewpAQCAtMTA1NCw3ICsxMDU0
LDcgQEAgcHJpdmF0ZToKICAgICBCYWc8Q2FsbExpbmtJbmZvPiBtX2NhbGxMaW5rSW5mb3M7CiAg
ICAgU2VudGluZWxMaW5rZWRMaXN0PENhbGxMaW5rSW5mbywgQmFzaWNSYXdTZW50aW5lbE5vZGU8
Q2FsbExpbmtJbmZvPj4gbV9pbmNvbWluZ0NhbGxzOwogI2VuZGlmCi0gICAgT3duUHRyPENvbXBh
Y3RKSVRDb2RlTWFwPiBtX2ppdENvZGVNYXA7CisgICAgc3RkOjp1bmlxdWVfcHRyPENvbXBhY3RK
SVRDb2RlTWFwPiBtX2ppdENvZGVNYXA7CiAjaWYgRU5BQkxFKERGR19KSVQpCiAgICAgLy8gVGhp
cyBpcyByZWxldmFudCB0byBub24tREZHIGNvZGUgYmxvY2tzIHRoYXQgc2VydmUgYXMgdGhlIHBy
b2ZpbGVkIGNvZGUgYmxvY2sKICAgICAvLyBmb3IgREZHIGNvZGUgYmxvY2tzLgpkaWZmIC0tZ2l0
IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9Db21wYWN0SklUQ29kZU1hcC5oIGIvU291cmNl
L0phdmFTY3JpcHRDb3JlL2ppdC9Db21wYWN0SklUQ29kZU1hcC5oCmluZGV4IDM3Y2JiMjRmZTJm
MmNiYjM0OGVkYzQ3MDEzOTdmZDg5MTQzMGY1MDEuLmQ1ZWFhNDA3MmJhMjkzNWUyZjU1NjYwNjg0
YWEyN2FmODYyMWM4MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQ29t
cGFjdEpJVENvZGVNYXAuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NvbXBhY3RK
SVRDb2RlTWFwLmgKQEAgLTMyLDggKzMyLDYgQEAKICNpbmNsdWRlIDx3dGYvQXNzZXJ0aW9ucy5o
PgogI2luY2x1ZGUgPHd0Zi9GYXN0TWFsbG9jLmg+CiAjaW5jbHVkZSA8d3RmL0Zhc3RNYWxsb2Mu
aD4KLSNpbmNsdWRlIDx3dGYvT3duUHRyLmg+Ci0jaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIuaD4K
ICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CiAKIG5hbWVzcGFjZSBKU0MgewpAQCAtNDcsNyArNDUs
NyBAQCBuYW1lc3BhY2UgSlNDIHsKIC8vIENvbXBhY3RKSVRDb2RlTWFwOjpFbmNvZGVyIGVuY29k
ZXIobWFwKTsKIC8vIGVuY29kZXIuYXBwZW5kKGEsIGIpOwogLy8gZW5jb2Rlci5hcHBlbmQoYywg
ZCk7IC8vIHByZWNvbmRpdGlvbnM6IGMgPj0gYSwgZCA+PSBiCi0vLyBPd25QdHI8Q29tcGFjdEpJ
VENvZGVNYXA+IG1hcCA9IGVuY29kZXIuZmluaXNoKCk7CisvLyBhdXRvIG1hcCA9IGVuY29kZXIu
ZmluaXNoKCk7CiAvLwogLy8gQXQgc29tZSBsYXRlciB0aW1lOgogLy8KQEAgLTgwLDYgKzc4LDE2
IEBAIHN0cnVjdCBCeXRlY29kZUFuZE1hY2hpbmVPZmZzZXQgewogY2xhc3MgQ29tcGFjdEpJVENv
ZGVNYXAgewogICAgIFdURl9NQUtFX0ZBU1RfQUxMT0NBVEVEOwogcHVibGljOgorICAgIENvbXBh
Y3RKSVRDb2RlTWFwKHVpbnQ4X3QqIGJ1ZmZlciwgdW5zaWduZWQgc2l6ZSwgdW5zaWduZWQgbnVt
YmVyT2ZFbnRyaWVzKQorICAgICAgICA6IG1fYnVmZmVyKGJ1ZmZlcikKKyNpZiAhQVNTRVJUX0RJ
U0FCTEVECisgICAgICAgICwgbV9zaXplKHNpemUpCisjZW5kaWYKKyAgICAgICAgLCBtX251bWJl
ck9mRW50cmllcyhudW1iZXJPZkVudHJpZXMpCisgICAgeworICAgICAgICBVTlVTRURfUEFSQU0o
c2l6ZSk7CisgICAgfQorCiAgICAgfkNvbXBhY3RKSVRDb2RlTWFwKCkKICAgICB7CiAgICAgICAg
IGlmIChtX2J1ZmZlcikKQEAgLTk0LDE2ICsxMDIsNiBAQCBwdWJsaWM6CiAgICAgdm9pZCBkZWNv
ZGUoVmVjdG9yPEJ5dGVjb2RlQW5kTWFjaGluZU9mZnNldD4mIHJlc3VsdCkgY29uc3Q7CiAgICAg
CiBwcml2YXRlOgotICAgIENvbXBhY3RKSVRDb2RlTWFwKHVpbnQ4X3QqIGJ1ZmZlciwgdW5zaWdu
ZWQgc2l6ZSwgdW5zaWduZWQgbnVtYmVyT2ZFbnRyaWVzKQotICAgICAgICA6IG1fYnVmZmVyKGJ1
ZmZlcikKLSNpZiAhQVNTRVJUX0RJU0FCTEVECi0gICAgICAgICwgbV9zaXplKHNpemUpCi0jZW5k
aWYKLSAgICAgICAgLCBtX251bWJlck9mRW50cmllcyhudW1iZXJPZkVudHJpZXMpCi0gICAgewot
ICAgICAgICBVTlVTRURfUEFSQU0oc2l6ZSk7Ci0gICAgfQotICAgIAogICAgIHVpbnQ4X3QgYXQo
dW5zaWduZWQgaW5kZXgpIGNvbnN0CiAgICAgewogICAgICAgICBBU1NFUlQoaW5kZXggPCBtX3Np
emUpOwpAQCAtMTM4LDggKzEzNiw4IEBAIHB1YmxpYzoKICAgICAgICAgCiAgICAgICAgIHZvaWQg
ZW5zdXJlQ2FwYWNpdHlGb3IodW5zaWduZWQgbnVtYmVyT2ZFbnRyaWVzVG9BZGQpOwogICAgICAg
ICB2b2lkIGFwcGVuZCh1bnNpZ25lZCBieXRlY29kZUluZGV4LCB1bnNpZ25lZCBtYWNoaW5lQ29k
ZU9mZnNldCk7Ci0gICAgICAgIFBhc3NPd25QdHI8Q29tcGFjdEpJVENvZGVNYXA+IGZpbmlzaCgp
OwotICAgICAgICAKKyAgICAgICAgc3RkOjp1bmlxdWVfcHRyPENvbXBhY3RKSVRDb2RlTWFwPiBm
aW5pc2goKTsKKwogICAgIHByaXZhdGU6CiAgICAgICAgIHZvaWQgYXBwZW5kQnl0ZSh1aW50OF90
IHZhbHVlKTsKICAgICAgICAgdm9pZCBlbmNvZGVOdW1iZXIodWludDMyX3QgdmFsdWUpOwpAQCAt
MjEyLDE4ICsyMTAsMTggQEAgaW5saW5lIHZvaWQgQ29tcGFjdEpJVENvZGVNYXA6OkVuY29kZXI6
OmFwcGVuZCh1bnNpZ25lZCBieXRlY29kZUluZGV4LCB1bnNpZ25lZAogICAgIG1fbnVtYmVyT2ZF
bnRyaWVzKys7CiB9CiAKLWlubGluZSBQYXNzT3duUHRyPENvbXBhY3RKSVRDb2RlTWFwPiBDb21w
YWN0SklUQ29kZU1hcDo6RW5jb2Rlcjo6ZmluaXNoKCkKK2lubGluZSBzdGQ6OnVuaXF1ZV9wdHI8
Q29tcGFjdEpJVENvZGVNYXA+IENvbXBhY3RKSVRDb2RlTWFwOjpFbmNvZGVyOjpmaW5pc2goKQog
ewogICAgIG1fY2FwYWNpdHkgPSBtX3NpemU7CiAgICAgbV9idWZmZXIgPSBzdGF0aWNfY2FzdDx1
aW50OF90Kj4oZmFzdFJlYWxsb2MobV9idWZmZXIsIG1fY2FwYWNpdHkpKTsKLSAgICBPd25QdHI8
Q29tcGFjdEpJVENvZGVNYXA+IHJlc3VsdCA9IGFkb3B0UHRyKG5ldyBDb21wYWN0SklUQ29kZU1h
cChtX2J1ZmZlciwgbV9zaXplLCBtX251bWJlck9mRW50cmllcykpOworICAgIGF1dG8gcmVzdWx0
ID0gc3RkOjptYWtlX3VuaXF1ZTxDb21wYWN0SklUQ29kZU1hcD4obV9idWZmZXIsIG1fc2l6ZSwg
bV9udW1iZXJPZkVudHJpZXMpOwogICAgIG1fYnVmZmVyID0gMDsKICAgICBtX3NpemUgPSAwOwog
ICAgIG1fY2FwYWNpdHkgPSAwOwogICAgIG1fbnVtYmVyT2ZFbnRyaWVzID0gMDsKICAgICBtX3By
ZXZpb3VzQnl0ZWNvZGVJbmRleCA9IDA7CiAgICAgbV9wcmV2aW91c01hY2hpbmVDb2RlT2Zmc2V0
ID0gMDsKLSAgICByZXR1cm4gcmVzdWx0LnJlbGVhc2UoKTsKKyAgICByZXR1cm4gcmVzdWx0Owog
fQogICAgICAgICAKIGlubGluZSB2b2lkIENvbXBhY3RKSVRDb2RlTWFwOjpFbmNvZGVyOjphcHBl
bmRCeXRlKHVpbnQ4X3QgdmFsdWUpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>