137973 2014-10-22 11:31:13 -0700 Disable Linux-specific code in a Windows build 2015-04-10 11:56:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137488 1 mcrha webkit-unassigned bfulgham cgarcia commit-queue joepeck timothy oldest_to_newest 1043508 0 mcrha 2014-10-22 11:31:13 -0700 The used functions are not available under windows, but it can be built otherwise, thus, in a price of a lighter functionality, disable the code under Windows. Please let me know, if I missed anything. 1043509 1 240283 mcrha 2014-10-22 11:32:34 -0700 Created attachment 240283 proposed wk patch 1044331 2 240283 benjamin 2014-10-27 14:08:29 -0700 Comment on attachment 240283 proposed wk patch I don't really see the point. We optimize binary size for ARM, it does not really matter for Windows. If there is no negative side effect, we can leave the code as it is. Adding #ifdefs is adding complexity to the codebase. 1044724 3 mcrha 2014-10-29 00:08:39 -0700 The functions being "commented out" are Linux specific, they are not available under windows (mine mingw/msys build environment). Having them available/enabled is not about binary size, it's about being able to build the source file at all, for a price of a less functionality being provided in the windows builds (no stacktraces). 1044779 4 240283 joepeck 2014-10-29 10:51:42 -0700 Comment on attachment 240283 proposed wk patch View in context: https://bugs.webkit.org/attachment.cgi?id=240283&action=review > Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:47 > +#if !PLATFORM(WIN) In wtf/Assertions.cpp they use: #if OS(DARWIN) || (OS(LINUX) && !defined(__UCLIBC__)) ... #endif I would be fine with doing that here. 1045515 5 240788 mcrha 2014-11-01 10:05:44 -0700 Created attachment 240788 proposed wk patch ][ You are right, that works too. 1045785 6 240788 joepeck 2014-11-03 11:01:19 -0800 Comment on attachment 240788 proposed wk patch ][ View in context: https://bugs.webkit.org/attachment.cgi?id=240788&action=review > Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:172 > +#endif Do you also need: #else UNUSED_PARAM(callStack); #endif To avoid other warnings? 1045973 7 240906 mcrha 2014-11-03 20:47:43 -0800 Created attachment 240906 proposed wk patch ]I[ Nice, I didn't know you've a macro for it. I noticed the warning, but there are shown more other from various places when I compile the code on Windows, thus I didn't pay attention to it. My fault, I'm sorry for that. 1056641 8 bfulgham 2014-12-17 17:23:05 -0800 Joe, it looks like the changes you requested are in the patch. Is this okay to take now? 1084005 9 240906 joepeck 2015-04-09 11:35:34 -0700 Comment on attachment 240906 proposed wk patch ]I[ View in context: https://bugs.webkit.org/attachment.cgi?id=240906&action=review > Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:152 > +#if OS(DARWIN) || (OS(LINUX) && !defined(__UCLIBC__)) Based on wtf/Assertions.cpp, which has: #if OS(DARWIN) || OS(LINUX) # if PLATFORM(GTK) # if defined(__GLIBC__) && !defined(__UCLIBC__) # define WTF_USE_BACKTRACE_SYMBOLS 1 # endif # else # define WTF_USE_DLADDR 1 # endif #endif This should probably be: #if OS(DARWIN) || (OS(LINUX) && !PLATFORM(GTK)) Same up above in the includes. Do you agree? > Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp:177 > + UNUSED_PARAM(callStack); Nit: Too much indentation. 1084174 10 250497 mcrha 2015-04-09 20:15:56 -0700 Created attachment 250497 proposed wk patch IV Updated webkit patch with the suggested changes applied. I agree with both. 1084180 11 mcrha 2015-04-09 20:25:32 -0700 (In reply to comment #9) > This should probably be: > > #if OS(DARWIN) || (OS(LINUX) && !PLATFORM(GTK)) > > Same up above in the includes. Do you agree? Hmm, thinking of it, this will disable backtraces for any GTK platform build, not only for those which do not support it, like those not having dlfcn.h and execinfo.h. 1084334 12 joepeck 2015-04-10 10:53:03 -0700 (In reply to comment #10) > Created attachment 250497 [details] > proposed wk patch IV > > Updated webkit patch with the suggested changes applied. I agree with both. (In reply to comment #11) > (In reply to comment #9) > > This should probably be: > > > > #if OS(DARWIN) || (OS(LINUX) && !PLATFORM(GTK)) > > > > Same up above in the includes. Do you agree? > > Hmm, thinking of it, this will disable backtraces for any GTK platform > build, not only for those which do not support it, like those not having > dlfcn.h and execinfo.h. I believe this code is only reachable through ENABLE_REMOTE_INSPECTOR so it really doesn't matter ;) 1084335 13 250497 joepeck 2015-04-10 10:53:31 -0700 Comment on attachment 250497 proposed wk patch IV r=me 1084355 14 250497 commit-queue 2015-04-10 11:56:51 -0700 Comment on attachment 250497 proposed wk patch IV Clearing flags on attachment: 250497 Committed r182636: <http://trac.webkit.org/changeset/182636> 1084356 15 commit-queue 2015-04-10 11:56:56 -0700 All reviewed patches have been landed. Closing bug. 240283 2014-10-22 11:32:34 -0700 2014-11-01 10:05:44 -0700 proposed wk patch wk.patch text/plain 1963 mcrha ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDM3MzNkYTkuLjQ4NGE5NDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEwLTIyICBNaWxhbiBDcmhhICA8 bWNyaGFAcmVkaGF0LmNvbT4KKworICAgICAgICBEaXNhYmxlIExpbnV4LXNwZWNpZmljIGNvZGUg aW4gYSBXaW5kb3dzIGJ1aWxkLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM3OTcz Pi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGlu c3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAo SW5zcGVjdG9yOjpKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OmFwcGVuZEFQSUJh Y2t0cmFjZSk6CisKIDIwMTQtMTAtMjEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgog CiAgICAgICAgIFJlbW92ZSBlcnJvbmVvdXMgY2FuVXNlSklUKCkgaW4gdGhlIGludHJpbnNpY3Mg dmVyc2lvbiBvZiBKSVRUaHVua3M6Omhvc3RGdW5jdGlvblN0dWIoKS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250 cm9sbGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmpl Y3RJbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCAzNDNmNjRhLi44MGRjNDYyIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVj dG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9K U0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC00NCw4ICs0NCwxMCBAQAog I2luY2x1ZGUgIlNjcmlwdENhbGxTdGFjay5oIgogI2luY2x1ZGUgIlNjcmlwdENhbGxTdGFja0Zh Y3RvcnkuaCIKICNpbmNsdWRlIDxjeHhhYmkuaD4KKyNpZiAhUExBVEZPUk0oV0lOKQogI2luY2x1 ZGUgPGRsZmNuLmg+CiAjaW5jbHVkZSA8ZXhlY2luZm8uaD4KKyNlbmRpZgogCiAjaWYgRU5BQkxF KFJFTU9URV9JTlNQRUNUT1IpCiAjaW5jbHVkZSAiSlNHbG9iYWxPYmplY3REZWJ1Z2dhYmxlLmgi CkBAIC0xMjUsNiArMTI3LDcgQEAgdm9pZCBKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xs ZXI6OmRpc3BhdGNoTWVzc2FnZUZyb21Gcm9udGVuZChjb25zdCBTdHJpbmcKIAogdm9pZCBKU0ds b2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OmFwcGVuZEFQSUJhY2t0cmFjZShTY3JpcHRD YWxsU3RhY2sqIGNhbGxTdGFjaykKIHsKKyNpZiAhUExBVEZPUk0oV0lOKQogICAgIHN0YXRpYyBj b25zdCBpbnQgZnJhbWVzVG9TaG93ID0gMzE7CiAgICAgc3RhdGljIGNvbnN0IGludCBmcmFtZXNU b1NraXAgPSAzOyAvLyBXVEZHZXRCYWNrdHJhY2UsIGFwcGVuZEFQSUJhY2t0cmFjZSwgcmVwb3J0 QVBJRXhjZXB0aW9uLgogCkBAIC0xNDgsNiArMTUxLDcgQEAgdm9pZCBKU0dsb2JhbE9iamVjdElu c3BlY3RvckNvbnRyb2xsZXI6OmFwcGVuZEFQSUJhY2t0cmFjZShTY3JpcHRDYWxsU3RhY2sqIGNh bGwKICAgICAgICAgICAgIGNhbGxTdGFjay0+YXBwZW5kKFNjcmlwdENhbGxGcmFtZShBU0NJSUxp dGVyYWwoIj8iKSwgQVNDSUlMaXRlcmFsKCJbbmF0aXZlIGNvZGVdIiksIDAsIDApKTsKICAgICAg ICAgZnJlZShjeGFEZW1hbmdsZWQpOwogICAgIH0KKyNlbmRpZgogfQogCiB2b2lkIEpTR2xvYmFs T2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlcjo6cmVwb3J0QVBJRXhjZXB0aW9uKEV4ZWNTdGF0ZSog ZXhlYywgSlNWYWx1ZSBleGNlcHRpb24pCg== 240788 2014-11-01 10:05:44 -0700 2014-11-03 20:47:43 -0800 proposed wk patch ][ wk.patch text/plain 2001 mcrha ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGJlNjc1MzMuLmIzNjg4OWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTExLTAxICBNaWxhbiBDcmhhICA8 bWNyaGFAcmVkaGF0LmNvbT4KKworICAgICAgICBEaXNhYmxlIExpbnV4LXNwZWNpZmljIGNvZGUg aW4gYSBXaW5kb3dzIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzc5NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGluc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIu Y3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xs ZXI6OmFwcGVuZEFQSUJhY2t0cmFjZSk6CisKIDIwMTQtMTEtMDEgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04oQ01ha2UpOiBN YWtlIGl0IHBvc3NpYmxlIHRvIGJ1aWxkIHdpdGhvdXQgaW50cm9zcGVjdGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3Rv ckNvbnRyb2xsZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9KU0dsb2Jh bE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwCmluZGV4IDQ4ZDNmYjkuLmYxMTEzZjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJ bnNwZWN0b3JDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVj dG9yL0pTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlci5jcHAKQEAgLTQ2LDggKzQ2LDEw IEBACiAjaW5jbHVkZSA8d3RmL1N0b3B3YXRjaC5oPgogCiAjaW5jbHVkZSA8Y3h4YWJpLmg+Cisj aWYgT1MoREFSV0lOKSB8fCAoT1MoTElOVVgpICYmICFkZWZpbmVkKF9fVUNMSUJDX18pKQogI2lu Y2x1ZGUgPGRsZmNuLmg+CiAjaW5jbHVkZSA8ZXhlY2luZm8uaD4KKyNlbmRpZgogCiAjaWYgRU5B QkxFKFJFTU9URV9JTlNQRUNUT1IpCiAjaW5jbHVkZSAiSlNHbG9iYWxPYmplY3REZWJ1Z2dhYmxl LmgiCkBAIC0xNDMsNiArMTQ1LDcgQEAgdm9pZCBKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRy b2xsZXI6OmRpc3BhdGNoTWVzc2FnZUZyb21Gcm9udGVuZChjb25zdCBTdHJpbmcKIAogdm9pZCBK U0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OmFwcGVuZEFQSUJhY2t0cmFjZShTY3Jp cHRDYWxsU3RhY2sqIGNhbGxTdGFjaykKIHsKKyNpZiBPUyhEQVJXSU4pIHx8IChPUyhMSU5VWCkg JiYgIWRlZmluZWQoX19VQ0xJQkNfXykpCiAgICAgc3RhdGljIGNvbnN0IGludCBmcmFtZXNUb1No b3cgPSAzMTsKICAgICBzdGF0aWMgY29uc3QgaW50IGZyYW1lc1RvU2tpcCA9IDM7IC8vIFdURkdl dEJhY2t0cmFjZSwgYXBwZW5kQVBJQmFja3RyYWNlLCByZXBvcnRBUElFeGNlcHRpb24uCiAKQEAg LTE2Niw2ICsxNjksNyBAQCB2b2lkIEpTR2xvYmFsT2JqZWN0SW5zcGVjdG9yQ29udHJvbGxlcjo6 YXBwZW5kQVBJQmFja3RyYWNlKFNjcmlwdENhbGxTdGFjayogY2FsbAogICAgICAgICAgICAgY2Fs bFN0YWNrLT5hcHBlbmQoU2NyaXB0Q2FsbEZyYW1lKEFTQ0lJTGl0ZXJhbCgiPyIpLCBBU0NJSUxp dGVyYWwoIltuYXRpdmUgY29kZV0iKSwgMCwgMCkpOwogICAgICAgICBmcmVlKGN4YURlbWFuZ2xl ZCk7CiAgICAgfQorI2VuZGlmCiB9CiAKIHZvaWQgSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250 cm9sbGVyOjpyZXBvcnRBUElFeGNlcHRpb24oRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIGV4Y2Vw dGlvbikK 240906 2014-11-03 20:47:43 -0800 2015-04-09 20:15:56 -0700 proposed wk patch ]I[ wk.patch text/plain 2043 mcrha ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDZmMzgyYTIuLjU3ZWVkNzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTExLTAzICBNaWxhbiBDcmhhICA8 bWNyaGFAcmVkaGF0LmNvbT4KKworICAgICAgICBEaXNhYmxlIExpbnV4LXNwZWNpZmljIGNvZGUg aW4gYSBXaW5kb3dzIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzc5NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGluc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIu Y3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xs ZXI6OmFwcGVuZEFQSUJhY2t0cmFjZSk6CisKIDIwMTQtMTEtMDMgIE1pY2hhZWwgU2Fib2ZmICA8 bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHNjb3BlIHJlbGF0ZWQgc2xvdyBw YXRoIGNvZGUgdG8gdXNlIHNjb3BlIHJlZ2lzdGVyIGFkZGVkIHRvIG9wY29kZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0 b3JDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9i YWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCA3N2FlNDY0Li4yZjljYjBmIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0 SW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC00Niw4ICs0Niwx MCBAQAogI2luY2x1ZGUgPHd0Zi9TdG9wd2F0Y2guaD4KIAogI2luY2x1ZGUgPGN4eGFiaS5oPgor I2lmIE9TKERBUldJTikgfHwgKE9TKExJTlVYKSAmJiAhZGVmaW5lZChfX1VDTElCQ19fKSkKICNp bmNsdWRlIDxkbGZjbi5oPgogI2luY2x1ZGUgPGV4ZWNpbmZvLmg+CisjZW5kaWYKIAogI2lmIEVO QUJMRShSRU1PVEVfSU5TUEVDVE9SKQogI2luY2x1ZGUgIkpTR2xvYmFsT2JqZWN0RGVidWdnYWJs ZS5oIgpAQCAtMTQ3LDYgKzE0OSw3IEBAIHZvaWQgSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250 cm9sbGVyOjpkaXNwYXRjaE1lc3NhZ2VGcm9tRnJvbnRlbmQoY29uc3QgU3RyaW5nCiAKIHZvaWQg SlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyOjphcHBlbmRBUElCYWNrdHJhY2UoU2Ny aXB0Q2FsbFN0YWNrKiBjYWxsU3RhY2spCiB7CisjaWYgT1MoREFSV0lOKSB8fCAoT1MoTElOVVgp ICYmICFkZWZpbmVkKF9fVUNMSUJDX18pKQogICAgIHN0YXRpYyBjb25zdCBpbnQgZnJhbWVzVG9T aG93ID0gMzE7CiAgICAgc3RhdGljIGNvbnN0IGludCBmcmFtZXNUb1NraXAgPSAzOyAvLyBXVEZH ZXRCYWNrdHJhY2UsIGFwcGVuZEFQSUJhY2t0cmFjZSwgcmVwb3J0QVBJRXhjZXB0aW9uLgogCkBA IC0xNzAsNiArMTczLDkgQEAgdm9pZCBKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6 OmFwcGVuZEFQSUJhY2t0cmFjZShTY3JpcHRDYWxsU3RhY2sqIGNhbGwKICAgICAgICAgICAgIGNh bGxTdGFjay0+YXBwZW5kKFNjcmlwdENhbGxGcmFtZShBU0NJSUxpdGVyYWwoIj8iKSwgQVNDSUlM aXRlcmFsKCJbbmF0aXZlIGNvZGVdIiksIDAsIDApKTsKICAgICAgICAgZnJlZShjeGFEZW1hbmds ZWQpOwogICAgIH0KKyNlbHNlCisgICAgICAgIFVOVVNFRF9QQVJBTShjYWxsU3RhY2spOworI2Vu ZGlmCiB9CiAKIHZvaWQgSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyOjpyZXBvcnRB UElFeGNlcHRpb24oRXhlY1N0YXRlKiBleGVjLCBKU1ZhbHVlIGV4Y2VwdGlvbikK 250497 2015-04-09 20:15:56 -0700 2015-04-10 11:56:51 -0700 proposed wk patch IV wk.patch text/plain 2027 mcrha ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDZmMzgyYTIuLjU3ZWVkNzIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTExLTAzICBNaWxhbiBDcmhhICA8 bWNyaGFAcmVkaGF0LmNvbT4KKworICAgICAgICBEaXNhYmxlIExpbnV4LXNwZWNpZmljIGNvZGUg aW4gYSBXaW5kb3dzIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzc5NzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGluc3BlY3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIu Y3BwOgorICAgICAgICAoSW5zcGVjdG9yOjpKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xs ZXI6OmFwcGVuZEFQSUJhY2t0cmFjZSk6CisKIDIwMTQtMTEtMDMgIE1pY2hhZWwgU2Fib2ZmICA8 bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIHNjb3BlIHJlbGF0ZWQgc2xvdyBw YXRoIGNvZGUgdG8gdXNlIHNjb3BlIHJlZ2lzdGVyIGFkZGVkIHRvIG9wY29kZXMKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9iYWxPYmplY3RJbnNwZWN0 b3JDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSlNHbG9i YWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCA3N2FlNDY0Li4yZjljYjBmIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0pTR2xvYmFsT2JqZWN0 SW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl Y3Rvci9KU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC00Niw4ICs0Niwx MCBAQAogI2luY2x1ZGUgPHd0Zi9TdG9wd2F0Y2guaD4KIAogI2luY2x1ZGUgPGN4eGFiaS5oPgor I2lmIE9TKERBUldJTikgfHwgKE9TKExJTlVYKSAmJiAhUExBVEZPUk0oR1RLKSkKICNpbmNsdWRl IDxkbGZjbi5oPgogI2luY2x1ZGUgPGV4ZWNpbmZvLmg+CisjZW5kaWYKIAogI2lmIEVOQUJMRShS RU1PVEVfSU5TUEVDVE9SKQogI2luY2x1ZGUgIkpTR2xvYmFsT2JqZWN0RGVidWdnYWJsZS5oIgpA QCAtMTQ3LDYgKzE0OSw3IEBAIHZvaWQgSlNHbG9iYWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVy OjpkaXNwYXRjaE1lc3NhZ2VGcm9tRnJvbnRlbmQoY29uc3QgU3RyaW5nCiAKIHZvaWQgSlNHbG9i YWxPYmplY3RJbnNwZWN0b3JDb250cm9sbGVyOjphcHBlbmRBUElCYWNrdHJhY2UoU2NyaXB0Q2Fs bFN0YWNrKiBjYWxsU3RhY2spCiB7CisjaWYgT1MoREFSV0lOKSB8fCAoT1MoTElOVVgpICYmICFQ TEFURk9STShHVEspKQogICAgIHN0YXRpYyBjb25zdCBpbnQgZnJhbWVzVG9TaG93ID0gMzE7CiAg ICAgc3RhdGljIGNvbnN0IGludCBmcmFtZXNUb1NraXAgPSAzOyAvLyBXVEZHZXRCYWNrdHJhY2Us IGFwcGVuZEFQSUJhY2t0cmFjZSwgcmVwb3J0QVBJRXhjZXB0aW9uLgogCkBAIC0xNzAsNiArMTcz LDkgQEAgdm9pZCBKU0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OmFwcGVuZEFQSUJh Y2t0cmFjZShTY3JpcHRDYWxsU3RhY2sqIGNhbGwKICAgICAgICAgICAgIGNhbGxTdGFjay0+YXBw ZW5kKFNjcmlwdENhbGxGcmFtZShBU0NJSUxpdGVyYWwoIj8iKSwgQVNDSUlMaXRlcmFsKCJbbmF0 aXZlIGNvZGVdIiksIDAsIDApKTsKICAgICAgICAgZnJlZShjeGFEZW1hbmdsZWQpOwogICAgIH0K KyNlbHNlCisgICAgVU5VU0VEX1BBUkFNKGNhbGxTdGFjayk7CisjZW5kaWYKIH0KIAogdm9pZCBK U0dsb2JhbE9iamVjdEluc3BlY3RvckNvbnRyb2xsZXI6OnJlcG9ydEFQSUV4Y2VwdGlvbihFeGVj U3RhdGUqIGV4ZWMsIEpTVmFsdWUgZXhjZXB0aW9uKQo=