137970 2014-10-22 11:16:26 -0700 [GTK] RenderThemeGtk::mediaControlsScript() is not defined when VIDEO is disabled 2014-10-23 00:17:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137488 1 mcrha webkit-unassigned cgarcia commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1043501 0 mcrha 2014-10-22 11:16:26 -0700 When the VIDEO is disabled the RenderThemeGtk::mediaControlsScript() is not defined in the header file, thus also its body should not be compiled. 1043502 1 240281 mcrha 2014-10-22 11:18:42 -0700 Created attachment 240281 proposed wk patch 1043688 2 240281 cgarcia 2014-10-22 23:05:12 -0700 Comment on attachment 240281 proposed wk patch View in context: https://bugs.webkit.org/attachment.cgi?id=240281&action=review > Source/WebCore/ChangeLog:5 > + RenderThemeGtk::mediaControlsScript() is not defined when > + VIDEO is disabled. > + <https://webkit.org/b/137970>. Do not split the bug title line, are you using prepareChangelog script to generate the changelog entries? 1043694 3 mcrha 2014-10-22 23:35:36 -0700 Yes, I use the script, I only thought the line it too long, at least with compare of the other changelog entries, thus I wrapped it. I will resend the patch with unwrapped line. 1043695 4 240334 mcrha 2014-10-22 23:38:37 -0700 Created attachment 240334 proposed wk patch with no line wrap in the ChangeLog 1043707 5 240334 commit-queue 2014-10-23 00:17:53 -0700 Comment on attachment 240334 proposed wk patch with no line wrap in the ChangeLog Clearing flags on attachment: 240334 Committed r175095: <http://trac.webkit.org/changeset/175095> 1043708 6 commit-queue 2014-10-23 00:17:59 -0700 All reviewed patches have been landed. Closing bug. 240281 2014-10-22 11:18:42 -0700 2014-10-22 23:38:37 -0700 proposed wk patch wk.patch text/plain 1382 mcrha ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNmM0MjExLi5mZTEwNjFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTQtMTAtMjIgIE1pbGFuIENyaGEgIDxtY3JoYUByZWRoYXQuY29tPgorCisgICAgICAg IFJlbmRlclRoZW1lR3RrOjptZWRpYUNvbnRyb2xzU2NyaXB0KCkgaXMgbm90IGRlZmluZWQgd2hl bgorICAgICAgICBWSURFTyBpcyBkaXNhYmxlZC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzEzNzk3MD4uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3BwOgorCiAyMDE0LTEwLTIyICBTaGl2 YWt1bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgWE1MSHR0cFJlcXVl c3Qgc2hvdWxkIHN1cHBvcnQgYXR0cmlidXRlIHJlc3BvbnNlVVJMIGFzIHBlciBsYXRlc3QgWEhS IHNwZWMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVH dGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lR3RrLmNwcAppbmRl eCA2NmVkYWVlLi5hZTA2YmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyVGhlbWVHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJU aGVtZUd0ay5jcHAKQEAgLTE2NjMsNiArMTY2Myw3IEBAIFN0cmluZyBSZW5kZXJUaGVtZUd0azo6 ZmlsZUxpc3ROYW1lRm9yV2lkdGgoY29uc3QgRmlsZUxpc3QqIGZpbGVMaXN0LCBjb25zdCBGb250 CiAgICAgcmV0dXJuIFN0cmluZ1RydW5jYXRvcjo6Y2VudGVyVHJ1bmNhdGUoc3RyaW5nLCB3aWR0 aCwgZm9udCwgU3RyaW5nVHJ1bmNhdG9yOjpFbmFibGVSb3VuZGluZ0hhY2tzKTsKIH0KIAorI2lm IEVOQUJMRShWSURFTykKIFN0cmluZyBSZW5kZXJUaGVtZUd0azo6bWVkaWFDb250cm9sc1Njcmlw dCgpCiB7CiAgICAgU3RyaW5nQnVpbGRlciBzY3JpcHRCdWlsZGVyOwpAQCAtMTY3MSw2ICsxNjcy LDcgQEAgU3RyaW5nIFJlbmRlclRoZW1lR3RrOjptZWRpYUNvbnRyb2xzU2NyaXB0KCkKICAgICBz Y3JpcHRCdWlsZGVyLmFwcGVuZChtZWRpYUNvbnRyb2xzR3RrSmF2YVNjcmlwdCwgc2l6ZW9mKG1l ZGlhQ29udHJvbHNHdGtKYXZhU2NyaXB0KSk7CiAgICAgcmV0dXJuIHNjcmlwdEJ1aWxkZXIudG9T dHJpbmcoKTsKIH0KKyNlbmRpZiAvLyBFTkFCTEUoVklERU8pCiAKICNlbmRpZiAvLyBHVEtfQVBJ X1ZFUlNJT05fMgogfQo= 240334 2014-10-22 23:38:37 -0700 2014-10-23 00:17:53 -0700 proposed wk patch with no line wrap in the ChangeLog wk.patch text/plain 1420 mcrha ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjMGJlZGRiLi40MTAwMzBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMTAtMjIgIE1pbGFuIENyaGEgIDxtY3JoYUByZWRoYXQuY29tPgorCisgICAgICAg IFJlbmRlclRoZW1lR3RrOjptZWRpYUNvbnRyb2xzU2NyaXB0KCkgaXMgbm90IGRlZmluZWQgd2hl biBWSURFTyBpcyBkaXNhYmxlZC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzNzk3 MD4uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3BwOgorCiAyMDE0LTEwLTIyICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFRvZ2dsaW5nIG92ZXJm bG93OnNjcm9sbCB0byBoaWRkZW4gb24gZWxlbWVudCB3aXRoIC13ZWJraXQtb3ZlcmZsb3ctc2Ny b2xsaW5nOnRvdWNoIGNhbiBjYXVzZSBjaGlsZHJlbiB0byBkaXNhcHBlYXIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUd0ay5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3BwCmluZGV4IDY2ZWRhZWUuLmFlMDZiZDAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUd0ay5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lR3RrLmNwcApAQCAtMTY2 Myw2ICsxNjYzLDcgQEAgU3RyaW5nIFJlbmRlclRoZW1lR3RrOjpmaWxlTGlzdE5hbWVGb3JXaWR0 aChjb25zdCBGaWxlTGlzdCogZmlsZUxpc3QsIGNvbnN0IEZvbnQKICAgICByZXR1cm4gU3RyaW5n VHJ1bmNhdG9yOjpjZW50ZXJUcnVuY2F0ZShzdHJpbmcsIHdpZHRoLCBmb250LCBTdHJpbmdUcnVu Y2F0b3I6OkVuYWJsZVJvdW5kaW5nSGFja3MpOwogfQogCisjaWYgRU5BQkxFKFZJREVPKQogU3Ry aW5nIFJlbmRlclRoZW1lR3RrOjptZWRpYUNvbnRyb2xzU2NyaXB0KCkKIHsKICAgICBTdHJpbmdC dWlsZGVyIHNjcmlwdEJ1aWxkZXI7CkBAIC0xNjcxLDYgKzE2NzIsNyBAQCBTdHJpbmcgUmVuZGVy VGhlbWVHdGs6Om1lZGlhQ29udHJvbHNTY3JpcHQoKQogICAgIHNjcmlwdEJ1aWxkZXIuYXBwZW5k KG1lZGlhQ29udHJvbHNHdGtKYXZhU2NyaXB0LCBzaXplb2YobWVkaWFDb250cm9sc0d0a0phdmFT Y3JpcHQpKTsKICAgICByZXR1cm4gc2NyaXB0QnVpbGRlci50b1N0cmluZygpOwogfQorI2VuZGlm IC8vIEVOQUJMRShWSURFTykKIAogI2VuZGlmIC8vIEdUS19BUElfVkVSU0lPTl8yCiB9Cg==