<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137969</bug_id>
          
          <creation_ts>2014-10-22 11:09:54 -0700</creation_ts>
          <short_desc>Do not include GraphicsContext3D.h when 3D_GRAPHICS is not used</short_desc>
          <delta_ts>2014-10-22 23:45:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>137488</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Milan Crha">mcrha</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dino</cc>
    
    <cc>d-r</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>roger_fong</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1043498</commentid>
    <comment_count>0</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-10-22 11:09:54 -0700</bug_when>
    <thetext>The GraphicsContext3D.h includes ShaderLang.h, which might not be always available during the build time, thus better to not include GraphicsContext3D.h when the 3D_GRAPHICS is not used.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043499</commentid>
    <comment_count>1</comment_count>
      <attachid>240280</attachid>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-10-22 11:12:56 -0700</bug_when>
    <thetext>Created attachment 240280
proposed wk patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043699</commentid>
    <comment_count>2</comment_count>
      <attachid>240280</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-22 23:45:48 -0700</bug_when>
    <thetext>Comment on attachment 240280
proposed wk patch

Clearing flags on attachment: 240280

Committed r175088: &lt;http://trac.webkit.org/changeset/175088&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043700</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-22 23:45:54 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240280</attachid>
            <date>2014-10-22 11:12:56 -0700</date>
            <delta_ts>2014-10-22 23:45:48 -0700</delta_ts>
            <desc>proposed wk patch</desc>
            <filename>wk.patch</filename>
            <type>text/plain</type>
            <size>1103</size>
            <attacher name="Milan Crha">mcrha</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCBjNmM0MjExLi5hZDE0N2ZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTQtMTAtMjIgIE1pbGFuIENyaGEgIDxtY3JoYUByZWRoYXQuY29tPgorCisgICAgICAg
IERvIG5vdCBpbmNsdWRlIEdyYXBoaWNzQ29udGV4dDNELmggd2hlbiAzRF9HUkFQSElDUyBpcyBu
b3QgdXNlZC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzNzk2OT4uCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw
aGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcDoKKwogMjAxNC0xMC0yMiAgU2hp
dmFrdW1hciBKTSAgPHNoaXZhLmptQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFhNTEh0dHBSZXF1
ZXN0IHNob3VsZCBzdXBwb3J0IGF0dHJpYnV0ZSByZXNwb25zZVVSTCBhcyBwZXIgbGF0ZXN0IFhI
UiBzcGVjLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fp
cm8vR3JhcGhpY3NDb250ZXh0M0RDYWlyby5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n
cmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcAppbmRleCAxNGIxOThjLi5i
MTBmY2FjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWly
by9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y
bS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHQzRENhaXJvLmNwcApAQCAtMjYsOSArMjYs
OSBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKLSNpbmNsdWRlICJHcmFwaGljc0NvbnRl
eHQzRC5oIgogCiAjaWYgVVNFKDNEX0dSQVBISUNTKQorI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4
dDNELmgiCiAKICNpbmNsdWRlICJDYWlyb1V0aWxpdGllcy5oIgogI2luY2x1ZGUgIkdyYXBoaWNz
Q29udGV4dDNEUHJpdmF0ZS5oIgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>