137966 2014-10-22 10:47:08 -0700 profiler/ProfileNode.h: Prefix isnan with std 2014-10-22 23:54:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137488 1 mcrha webkit-unassigned commit-queue oldest_to_newest 1043487 0 mcrha 2014-10-22 10:47:08 -0700 I build webkit under mingw/msys ans the isnan() cannot be found there, because it's defined in std:: nasmespace. A similar change had been done in Source/JavaScriptCore/profiler/ProfileGenerator.cpp recently too. 1043490 1 240277 mcrha 2014-10-22 10:53:16 -0700 Created attachment 240277 proposed wk patch 1043701 2 240277 commit-queue 2014-10-22 23:54:10 -0700 Comment on attachment 240277 proposed wk patch Clearing flags on attachment: 240277 Committed r175089: <http://trac.webkit.org/changeset/175089> 1043702 3 commit-queue 2014-10-22 23:54:12 -0700 All reviewed patches have been landed. Closing bug. 240277 2014-10-22 10:53:16 -0700 2014-10-22 23:54:10 -0700 proposed wk patch wk.patch text/plain 1539 mcrha ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDM3MzNkYTkuLjc2NTkwMDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEwLTIyICBNaWxhbiBDcmhhICA8 bWNyaGFAcmVkaGF0LmNvbT4KKworICAgICAgICBQcmVmaXggaXNuYW4oKSB3aXRoIHN0ZDo6Lgor ICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM3OTY2Pi4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHByb2ZpbGVyL1Byb2ZpbGVOb2RlLmg6 CisgICAgICAgIChKU0M6OlByb2ZpbGVOb2RlOjpDYWxsOjpzZXRTdGFydFRpbWUpOgorICAgICAg ICAoSlNDOjpQcm9maWxlTm9kZTo6Q2FsbDo6c2V0RWxhcHNlZFRpbWUpOgorCiAyMDE0LTEwLTIx ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgZXJyb25l b3VzIGNhblVzZUpJVCgpIGluIHRoZSBpbnRyaW5zaWNzIHZlcnNpb24gb2YgSklUVGh1bmtzOjpo b3N0RnVuY3Rpb25TdHViKCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcHJv ZmlsZXIvUHJvZmlsZU5vZGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wcm9maWxlci9Qcm9m aWxlTm9kZS5oCmluZGV4IGRlYTkxMzcuLjlhYzU1NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9wcm9maWxlci9Qcm9maWxlTm9kZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9wcm9maWxlci9Qcm9maWxlTm9kZS5oCkBAIC02NSwxNCArNjUsMTQgQEAgbmFtZXNwYWNl IEpTQyB7CiAgICAgICAgICAgICBkb3VibGUgc3RhcnRUaW1lKCkgY29uc3QgeyByZXR1cm4gbV9z dGFydFRpbWU7IH0KICAgICAgICAgICAgIHZvaWQgc2V0U3RhcnRUaW1lKGRvdWJsZSB0aW1lKQog ICAgICAgICAgICAgewotICAgICAgICAgICAgICAgIEFTU0VSVF9BUkcodGltZSwgdGltZSA+PSAw LjAgfHwgaXNuYW4odGltZSkpOworICAgICAgICAgICAgICAgIEFTU0VSVF9BUkcodGltZSwgdGlt ZSA+PSAwLjAgfHwgc3RkOjppc25hbih0aW1lKSk7CiAgICAgICAgICAgICAgICAgbV9zdGFydFRp bWUgPSB0aW1lOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBkb3VibGUgZWxhcHNlZFRp bWUoKSBjb25zdCB7IHJldHVybiBtX2VsYXBzZWRUaW1lOyB9CiAgICAgICAgICAgICB2b2lkIHNl dEVsYXBzZWRUaW1lKGRvdWJsZSB0aW1lKQogICAgICAgICAgICAgewotICAgICAgICAgICAgICAg IEFTU0VSVF9BUkcodGltZSwgdGltZSA+PSAwLjAgfHwgaXNuYW4odGltZSkpOworICAgICAgICAg ICAgICAgIEFTU0VSVF9BUkcodGltZSwgdGltZSA+PSAwLjAgfHwgc3RkOjppc25hbih0aW1lKSk7 CiAgICAgICAgICAgICAgICAgbV9lbGFwc2VkVGltZSA9IHRpbWU7CiAgICAgICAgICAgICB9CiAK