137873 2014-10-20 03:43:28 -0700 MacroAssemblerX86Common.cpp should be built on Windows too 2014-10-20 10:03:24 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 137807 1 ossy ossy bfulgham commit-queue ggaren mark.lam oliver ossy oldest_to_newest 1042772 0 ossy 2014-10-20 03:43:28 -0700 MacroAssemblerX86Common.cpp should be built on Windows too 1042773 1 240106 ossy 2014-10-20 03:43:51 -0700 Created attachment 240106 Patch 1042775 2 ossy 2014-10-20 04:00:26 -0700 The goal of this bug report to add MacroAssemblerX86Common.cpp properly to the Windows build system to fix the build in bug137807 . I think ClInclude for this cpp was only a typo, when this file was added to the trunk - http://trac.webkit.org/changeset/153162/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj Additionally it was added to the filter file as ClCompile - http://trac.webkit.org/changeset/153162/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters But it was changed back to ClInclude in http://trac.webkit.org/changeset/153343/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters 1042832 3 240106 bfulgham 2014-10-20 09:24:36 -0700 Comment on attachment 240106 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240106&action=review Thanks for catching this. r=me. > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:308 > + <ClCompile Include="..\assembler\MacroAssemblerX86Common.cpp" /> This was definitely a mistake made by someone manually copying/pasting the project file. 1042853 4 240106 commit-queue 2014-10-20 10:03:20 -0700 Comment on attachment 240106 Patch Clearing flags on attachment: 240106 Committed r174887: <http://trac.webkit.org/changeset/174887> 1042854 5 commit-queue 2014-10-20 10:03:24 -0700 All reviewed patches have been landed. Closing bug. 240106 2014-10-20 03:43:51 -0700 2014-10-20 10:03:20 -0700 Patch bug-137873-20141020124356.patch text/plain 2599 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0ODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh YTAxOGE0YWU5ODdlYmQ1OGIxNTIzZTZiYTA0NDhjOTQ3NTc3ODZjLi4wNzRjMThkMTA2Y2FkZDJm ZWNjY2NhODE5YjI1ODYyYWQ1ODg2OTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNC0xMC0yMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIE1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmNwcCBzaG91bGQgYmUgYnVp bHQgb24gV2luZG93cyB0b28KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEzNzg3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogSmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZS52Y3hwcm9q OgorICAgICAgICAqIEphdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNjcmlwdENvcmUudmN4cHJv ai5maWx0ZXJzOgorCiAyMDE0LTEwLTE4ICBCcmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5n dG9uLmVkdT4KIAogICAgICAgICBXZWIgUmVwbGF5OiBjb2RlIGdlbmVyYXRvciBzaG91bGRuJ3Qg Y29tcGxhaW4gYWJvdXQgZW51bXMgd2l0aG91dCBhIHN0b3JhZ2UgdHlwZSBpZiB0aGV5IGFyZSBp biBhbiBlbmNsb3Npbmcgc2NvcGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9K YXZhU2NyaXB0Q29yZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlLnZjeHByb2ogYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZS52Y3hwcm9q CmluZGV4IGE4Y2M0NTJjYjVkMzVjZDQwMDdiNjIyNzMzZmEyODk1YTc2OThiMTEuLjcxZjMwMDg5 MTc2NTc0MTJkN2RiNjAzZjQwYjk0MDgwZmZhMzU3ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlLnZjeHByb2oK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNj cmlwdENvcmUudmN4cHJvagpAQCAtMzA1LDcgKzMwNSw3IEBACiAgICAgPENsQ29tcGlsZSBJbmNs dWRlPSIuLlxhc3NlbWJsZXJcTGlua0J1ZmZlci5jcHAiIC8+CiAgICAgPENsQ29tcGlsZSBJbmNs dWRlPSIuLlxhc3NlbWJsZXJcTWFjcm9Bc3NlbWJsZXIuY3BwIiAvPgogICAgIDxDbEluY2x1ZGUg SW5jbHVkZT0iLi5cQVBJXEpTQ1Rlc3RSdW5uZXJVdGlscy5oIiAvPgotICAgIDxDbEluY2x1ZGUg SW5jbHVkZT0iLi5cYXNzZW1ibGVyXE1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmNwcCIgLz4KKyAg ICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGFzc2VtYmxlclxNYWNyb0Fzc2VtYmxlclg4NkNvbW1v bi5jcHAiIC8+CiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxiaW5kaW5nc1xTY3JpcHRGdW5j dGlvbkNhbGwuY3BwIiAvPgogICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5cYmluZGluZ3NcU2Ny aXB0T2JqZWN0LmNwcCIgLz4KICAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGJpbmRpbmdzXFNj cmlwdFZhbHVlLmNwcCIgLz4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZh U2NyaXB0Q29yZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlLnZjeHByb2ouZmlsdGVycyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlLnZj eHByb2ouZmlsdGVycwppbmRleCAwNDljZTBhZmM0NGY1ZTkzZjFiY2Q5ZGIwN2UzYjliYTA1YjRj ODhlLi4wYjQ5MTg0ZDUyZTU2NjQ1OWRmODFlNWRhMTFkYmUwMmE2ZDJiNGFmIDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUudmN4cHJvai9KYXZhU2NyaXB0 Q29yZS52Y3hwcm9qLmZpbHRlcnMKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHRDb3JlLnZjeHByb2ovSmF2YVNjcmlwdENvcmUudmN4cHJvai5maWx0ZXJzCkBAIC0zMDMzLDkg KzMwMzMsOSBAQAogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5ccnVudGltZVxWTUVudHJ5U2Nv cGUuaCI+CiAgICAgICA8RmlsdGVyPnJ1bnRpbWU8L0ZpbHRlcj4KICAgICA8L0NsSW5jbHVkZT4K LSAgICA8Q2xJbmNsdWRlIEluY2x1ZGU9Ii4uXGFzc2VtYmxlclxNYWNyb0Fzc2VtYmxlclg4NkNv bW1vbi5jcHAiPgorICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5cYXNzZW1ibGVyXE1hY3JvQXNz ZW1ibGVyWDg2Q29tbW9uLmNwcCI+CiAgICAgICA8RmlsdGVyPmFzc2VtYmxlcjwvRmlsdGVyPgot ICAgIDwvQ2xJbmNsdWRlPgorICAgIDwvQ2xDb21waWxlPgogICAgIDxDbEluY2x1ZGUgSW5jbHVk ZT0iLi5ccnVudGltZVxJbnRlbmRlZFN0cnVjdHVyZUNoYWluLmgiPgogICAgICAgPEZpbHRlcj5y dW50aW1lPC9GaWx0ZXI+CiAgICAgPC9DbEluY2x1ZGU+Cg==