137809 2014-10-17 00:11:26 -0700 Use WTF::move() instead of std::move() to help ensure move semantics in JavaScriptCore 2014-11-23 18:25:59 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128007 1 gyuyoung.kim gyuyoung.kim commit-queue ossy oldest_to_newest 1042316 0 gyuyoung.kim 2014-10-17 00:11:26 -0700 There are still some use of std::move() in JavaScriptCore. 1042317 1 240002 gyuyoung.kim 2014-10-17 00:12:50 -0700 Created attachment 240002 Patch 1042335 2 240002 ossy 2014-10-17 02:18:41 -0700 Comment on attachment 240002 Patch r=me It seems they are from the ftlopt branch merge, I assume we didn't have style checker for this that time. 1042346 3 240002 commit-queue 2014-10-17 02:54:14 -0700 Comment on attachment 240002 Patch Clearing flags on attachment: 240002 Committed r174815: <http://trac.webkit.org/changeset/174815> 1042347 4 commit-queue 2014-10-17 02:54:17 -0700 All reviewed patches have been landed. Closing bug. 240002 2014-10-17 00:12:50 -0700 2014-10-17 02:54:14 -0700 Patch bug-137809-20141017161254.patch text/plain 3130 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0ODA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj NTVmNDk2NjI1MjhjNTNiMjIyNjIyOTA5MzI1YjdiYzhmOTI2ZDg4Li5iYTllNjNlMTVmNTZjM2Fm OWRhZTlhY2UyNmM4MTE3MWNmMDY5NTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNC0xMC0xNyAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFVzZSBXVEY6Om1vdmUoKSBpbnN0ZWFkIG9mIHN0ZDo6bW92ZSgp IHRvIGhlbHAgZW5zdXJlIG1vdmUgc2VtYW50aWNzIGluIEphdmFTY3JpcHRDb3JlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzc4MDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdWJzdGl0dXRpb24gb2Yg V1RGOjptb3ZlKCkgZm9yIHN0ZDo6bW92ZSgpLiBDbGVhbiB1cCBzdGQ6Om1vdmUoKSBpbiBKYXZh U2NyaXB0Q29yZS4KKworICAgICAgICAqIGJ5dGVjb2RlL0dldEJ5SWRTdGF0dXMuY3BwOgorICAg ICAgICAoSlNDOjpHZXRCeUlkU3RhdHVzOjpjb21wdXRlRm9yU3R1YkluZm8pOgorICAgICAgICAq IGJ5dGVjb2RlL1B1dEJ5SWRTdGF0dXMuY3BwOgorICAgICAgICAoSlNDOjpQdXRCeUlkU3RhdHVz Ojpjb21wdXRlRm9yU3R1YkluZm8pOgorICAgICAgICAqIGJ5dGVjb2RlL1B1dEJ5SWRWYXJpYW50 LmNwcDoKKyAgICAgICAgKEpTQzo6UHV0QnlJZFZhcmlhbnQ6OnNldHRlcik6CisKIDIwMTQtMTAt MTUgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBVc2UgYSBzaW5n bGUgYWxsb2NhdGlvbiBmb3IgdGhlIEFyZ3VtZW50cyBvYmplY3QKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9HZXRCeUlkU3RhdHVzLmNwcCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9HZXRCeUlkU3RhdHVzLmNwcAppbmRleCAzNTZjZmFjZDdmN2Qz MTZmZTBmZjAwMTBhNjIwZWU0YTc0ZDgzYjQzLi4xMTMzNDdhNWM0YTgxM2JjNmM4NDdmMDBiZTE0 ZmY4YTI0Y2JjNTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv R2V0QnlJZFN0YXR1cy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0dl dEJ5SWRTdGF0dXMuY3BwCkBAIC0yMDEsNyArMjAxLDcgQEAgR2V0QnlJZFN0YXR1cyBHZXRCeUlk U3RhdHVzOjpjb21wdXRlRm9yU3R1YkluZm8oCiAgICAgICAgICAgICAgICAgIAogICAgICAgICAg ICAgICAgIEdldEJ5SWRWYXJpYW50IHZhcmlhbnQoCiAgICAgICAgICAgICAgICAgICAgIFN0cnVj dHVyZVNldChzdHJ1Y3R1cmUpLCBjb21wbGV4R2V0U3RhdHVzLm9mZnNldCgpLCBjb21wbGV4R2V0 U3RhdHVzLmNoYWluKCksCi0gICAgICAgICAgICAgICAgICAgIHN0ZDo6bW92ZShjYWxsTGlua1N0 YXR1cykpOworICAgICAgICAgICAgICAgICAgICBXVEY6Om1vdmUoY2FsbExpbmtTdGF0dXMpKTsK ICAgICAgICAgICAgICAgICAgCiAgICAgICAgICAgICAgICAgaWYgKCFyZXN1bHQuYXBwZW5kVmFy aWFudCh2YXJpYW50KSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEdldEJ5SWRTdGF0dXMo c2xvd1BhdGhTdGF0ZSwgdHJ1ZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvZGUvUHV0QnlJZFN0YXR1cy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvUHV0QnlJZFN0YXR1cy5jcHAKaW5kZXggNzVjZjJmMTQ0M2IwN2YxYzkwODg2ZGRhNjJlMmM0 MDI0ZTJhZTk1OS4uZjJhYzE4YzYzYTJiOWEyZjZlNDU3ODRkYmY1NmYxOTU4MjFhMGI3MiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1B1dEJ5SWRTdGF0dXMuY3Bw CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9QdXRCeUlkU3RhdHVzLmNwcApA QCAtMjQ5LDcgKzI0OSw3IEBAIFB1dEJ5SWRTdGF0dXMgUHV0QnlJZFN0YXR1czo6Y29tcHV0ZUZv clN0dWJJbmZvKAogICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgdmFy aWFudCA9IFB1dEJ5SWRWYXJpYW50OjpzZXR0ZXIoCiAgICAgICAgICAgICAgICAgICAgICAgICBz dHJ1Y3R1cmUsIGNvbXBsZXhHZXRTdGF0dXMub2Zmc2V0KCksIGNvbXBsZXhHZXRTdGF0dXMuY2hh aW4oKSwKLSAgICAgICAgICAgICAgICAgICAgICAgIHN0ZDo6bW92ZShjYWxsTGlua1N0YXR1cykp OworICAgICAgICAgICAgICAgICAgICAgICAgV1RGOjptb3ZlKGNhbGxMaW5rU3RhdHVzKSk7CiAg ICAgICAgICAgICAgICAgfSB9CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUHV0QnlJZFZhcmlh bnQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1B1dEJ5SWRWYXJpYW50LmNw cAppbmRleCBjYWE4MmExODJmNDQxMmU0NGU0NDgwYzQyOTQyYTc4ODBjZjRjMDRkLi5lOWQxMGRm NjczYjVkOWQ3YTA4MmFkODllZTMwNjNmOGE0MWJlN2U3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYnl0ZWNvZGUvUHV0QnlJZFZhcmlhbnQuY3BwCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ieXRlY29kZS9QdXRCeUlkVmFyaWFudC5jcHAKQEAgLTg4LDcgKzg4LDcgQEAg UHV0QnlJZFZhcmlhbnQgUHV0QnlJZFZhcmlhbnQ6OnNldHRlcigKICAgICAgICAgcmVzdWx0Lm1f YWx0ZXJuYXRlQmFzZSA9IGNoYWluLT50ZXJtaW5hbFByb3RvdHlwZSgpOwogICAgIH0KICAgICBy ZXN1bHQubV9vZmZzZXQgPSBvZmZzZXQ7Ci0gICAgcmVzdWx0Lm1fY2FsbExpbmtTdGF0dXMgPSBz dGQ6Om1vdmUoY2FsbExpbmtTdGF0dXMpOworICAgIHJlc3VsdC5tX2NhbGxMaW5rU3RhdHVzID0g V1RGOjptb3ZlKGNhbGxMaW5rU3RhdHVzKTsKICAgICByZXR1cm4gcmVzdWx0OwogfQogCg==