<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>137807</bug_id>
          
          <creation_ts>2014-10-16 23:18:43 -0700</creation_ts>
          <short_desc>Move JSC::MacroAssemblerX86Common::s_sse2CheckState definition to the right place</short_desc>
          <delta_ts>2014-10-21 22:54:13 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>137873</dependson>
          <blocked>137488</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Milan Crha">mcrha</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>commit-queue</cc>
    
    <cc>oliver</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1042304</commentid>
    <comment_count>0</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-10-16 23:18:43 -0700</bug_when>
    <thetext>The Source/JavaScriptCore/jit/JIT.cpp defines JSC::MacroAssemblerX86Common::s_sse2CheckState with a comment:
&gt; // This probably does not belong here; adding here for now as a quick Windows build fix.
and it really is not, because with disabled JIT the variable is not defined and the build breaks.

The right (or better place) for it is MacroAssembler.cpp, just beside another static variable definition.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042305</commentid>
    <comment_count>1</comment_count>
      <attachid>239999</attachid>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-10-16 23:20:12 -0700</bug_when>
    <thetext>Created attachment 239999
proposed patch

Just move the variable definition, as noted above.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042340</commentid>
    <comment_count>2</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-10-17 02:30:20 -0700</bug_when>
    <thetext>It was originally introduced in https://trac.webkit.org/changeset/43789.
cc-ing Gavin as the author and Oliver as the reviewer of the patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042344</commentid>
    <comment_count>3</comment_count>
      <attachid>239999</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-10-17 02:40:19 -0700</bug_when>
    <thetext>Comment on attachment 239999
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239999&amp;action=review

&gt; Source/JavaScriptCore/assembler/MacroAssembler.cpp:38
&gt; +#if CPU(X86) &amp;&amp; !OS(MAC_OS_X)
&gt; +MacroAssemblerX86Common::SSE2CheckState MacroAssemblerX86Common::s_sse2CheckState = NotCheckedSSE2;
&gt; +#endif
&gt; +

Why don&apos;t we move it into MacroAssemblerX86Common.cpp? It is only used inside MacroAssemblerX86Common.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042345</commentid>
    <comment_count>4</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-10-17 02:49:04 -0700</bug_when>
    <thetext>You are right, that&apos;s even better place. I didn&apos;t notice it being compiled on my machine (overlooked it), I noticed the MacroAssembler.cpp only, thus picked it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042398</commentid>
    <comment_count>5</comment_count>
      <attachid>239999</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2014-10-17 10:39:26 -0700</bug_when>
    <thetext>Comment on attachment 239999
proposed patch

I agree: Best to use X86Common.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042755</commentid>
    <comment_count>6</comment_count>
      <attachid>240101</attachid>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-10-20 01:44:55 -0700</bug_when>
    <thetext>Created attachment 240101
proposed patch ][

Move the chunk into MacroAssemblerX86Common.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042774</commentid>
    <comment_count>7</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-10-20 03:50:08 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; Created attachment 240101 [details]
&gt; proposed patch ][
&gt; 
&gt; Move the chunk into MacroAssemblerX86Common.cpp

The Windows EWS is unhappy. It seems MacroAssemblerX86Common.cpp isn&apos;t built
on Windows at all due to a typo here:
http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj#L308

I filed a new bug report to make this source build on Windows too: bug137873</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042785</commentid>
    <comment_count>8</comment_count>
      <attachid>240111</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-10-20 04:54:07 -0700</bug_when>
    <thetext>Created attachment 240111
patch for EWS

checking if the original patch + bug137873 make Windows EWS happy</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042786</commentid>
    <comment_count>9</comment_count>
      <attachid>240101</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-10-20 04:56:26 -0700</bug_when>
    <thetext>Comment on attachment 240101
proposed patch ][

r- now due to missing changelog.

Please add a changelog entry with Tools/Scripts/prepare-changelog
and upload the patch once the fix in bug137873 landed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042927</commentid>
    <comment_count>10</comment_count>
      <attachid>240138</attachid>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-10-20 12:31:08 -0700</bug_when>
    <thetext>Created attachment 240138
proposed patch ]I[

Version ][ with added ChangeLog entry.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043138</commentid>
    <comment_count>11</comment_count>
      <attachid>240138</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-10-21 01:21:48 -0700</bug_when>
    <thetext>Comment on attachment 240138
proposed patch ]I[

View in context: https://bugs.webkit.org/attachment.cgi?id=240138&amp;action=review

r=me

&gt; Source/JavaScriptCore/ChangeLog:6
&gt; +        Reviewed by Csaba OsztrogonÃ¡c.

You shouldn&apos;t have add my name manually here,
commit queue automatically relaces ooops before landing.

(And what if anyone else would like to review the patch?)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043145</commentid>
    <comment_count>12</comment_count>
      <attachid>240138</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-21 01:57:21 -0700</bug_when>
    <thetext>Comment on attachment 240138
proposed patch ]I[

Clearing flags on attachment: 240138

Committed r174933: &lt;http://trac.webkit.org/changeset/174933&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043146</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-10-21 01:57:26 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043216</commentid>
    <comment_count>14</comment_count>
    <who name="Milan Crha">mcrha</who>
    <bug_when>2014-10-21 10:28:34 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; You shouldn&apos;t have add my name manually here,
&gt; commit queue automatically relaces ooops before landing.
&gt; 
&gt; (And what if anyone else would like to review the patch?)

That was just a wild guess. I&apos;m new in the WebKit commit process, my first ChangeLog entry I can remember.

May I keep all three OOPS unchanged there? One was for a short description, another one for a bug link (the third was the aforementioned reviewer).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1043219</commentid>
    <comment_count>15</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-10-21 10:32:42 -0700</bug_when>
    <thetext>(In reply to comment #14)
&gt; (In reply to comment #11)
&gt; &gt; You shouldn&apos;t have add my name manually here,
&gt; &gt; commit queue automatically relaces ooops before landing.
&gt; &gt; 
&gt; &gt; (And what if anyone else would like to review the patch?)
&gt; 
&gt; That was just a wild guess. I&apos;m new in the WebKit commit process, my first
&gt; ChangeLog entry I can remember.
&gt; 
&gt; May I keep all three OOPS unchanged there? One was for a short description,
&gt; another one for a bug link (the third was the aforementioned reviewer).

You can find the details here:
http://www.webkit.org/coding/contributing.html</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>239999</attachid>
            <date>2014-10-16 23:20:12 -0700</date>
            <delta_ts>2014-10-20 01:44:55 -0700</delta_ts>
            <desc>proposed patch</desc>
            <filename>wk.patch</filename>
            <type>text/plain</type>
            <size>1198</size>
            <attacher name="Milan Crha">mcrha</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXIuY3Bw
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl
bWJsZXIuY3BwCShyZXZpc2lvbiAxNzQ3NDIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz
ZW1ibGVyL01hY3JvQXNzZW1ibGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIsNiArMzIsMTAg
QEAKIAogY29uc3QgZG91YmxlIE1hY3JvQXNzZW1ibGVyOjp0d29Ub1RoZTMyID0gKGRvdWJsZSkw
eDEwMDAwMDAwMHVsbDsKIAorI2lmIENQVShYODYpICYmICFPUyhNQUNfT1NfWCkKK01hY3JvQXNz
ZW1ibGVyWDg2Q29tbW9uOjpTU0UyQ2hlY2tTdGF0ZSBNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbjo6
c19zc2UyQ2hlY2tTdGF0ZSA9IE5vdENoZWNrZWRTU0UyOworI2VuZGlmCisKIH0gLy8gbmFtZXNw
YWNlIEpTQwogCiAjZW5kaWYgLy8gRU5BQkxFKEFTU0VNQkxFUikKSW5kZXg6IFNvdXJjZS9KYXZh
U2NyaXB0Q29yZS9qaXQvSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvaml0L0pJVC5jcHAJKHJldmlzaW9uIDE3NDc0MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9qaXQvSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksMTIgKzI5LDYgQEAKIAogI2luY2x1
ZGUgIkpJVC5oIgogCi0vLyBUaGlzIHByb2JhYmx5IGRvZXMgbm90IGJlbG9uZyBoZXJlOyBhZGRp
bmcgaGVyZSBmb3Igbm93IGFzIGEgcXVpY2sgV2luZG93cyBidWlsZCBmaXguCi0jaWYgRU5BQkxF
KEFTU0VNQkxFUikgJiYgQ1BVKFg4NikgJiYgIU9TKE1BQ19PU19YKQotI2luY2x1ZGUgIk1hY3Jv
QXNzZW1ibGVyLmgiCi1KU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpTU0UyQ2hlY2tTdGF0
ZSBKU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpzX3NzZTJDaGVja1N0YXRlID0gTm90Q2hl
Y2tlZFNTRTI7Ci0jZW5kaWYKLQogI2luY2x1ZGUgIkFyaXR5Q2hlY2tGYWlsUmV0dXJuVGh1bmtz
LmgiCiAjaW5jbHVkZSAiQ29kZUJsb2NrLmgiCiAjaW5jbHVkZSAiREZHQ2FwYWJpbGl0aWVzLmgi
Cg==
</data>
<flag name="review"
          id="264747"
          type_id="1"
          status="-"
          setter="ggaren"
    />
    <flag name="commit-queue"
          id="264748"
          type_id="3"
          status="-"
          setter="ggaren"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240101</attachid>
            <date>2014-10-20 01:44:55 -0700</date>
            <delta_ts>2014-10-20 12:31:08 -0700</delta_ts>
            <desc>proposed patch ][</desc>
            <filename>wk.patch</filename>
            <type>text/plain</type>
            <size>1224</size>
            <attacher name="Milan Crha">mcrha</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZD
b21tb24uY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09DQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl
ci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5jcHAJKHJldmlzaW9uIDE3NDc0MikNCisrKyBTb3Vy
Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmNwcAko
d29ya2luZyBjb3B5KQ0KQEAgLTc4LDYgKzc4LDEwIEBADQogCiAjZW5kaWYgLy8gVVNFKE1BU01f
UFJPQkUpCiAKKyNpZiBDUFUoWDg2KSAmJiAhT1MoTUFDX09TX1gpCitNYWNyb0Fzc2VtYmxlclg4
NkNvbW1vbjo6U1NFMkNoZWNrU3RhdGUgTWFjcm9Bc3NlbWJsZXJYODZDb21tb246OnNfc3NlMkNo
ZWNrU3RhdGUgPSBOb3RDaGVja2VkU1NFMjsKKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBKU0MK
IAogI2VuZGlmIC8vIEVOQUJMRShBU1NFTUJMRVIpICYmIChDUFUoWDg2KSB8fCBDUFUoWDg2XzY0
KSkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcA0KPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K
LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAkocmV2aXNpb24gMTc0NzQyKQ0K
KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAkod29ya2luZyBjb3B5KQ0KQEAg
LTI5LDEyICsyOSw2IEBADQogCiAjaW5jbHVkZSAiSklULmgiCiAKLS8vIFRoaXMgcHJvYmFibHkg
ZG9lcyBub3QgYmVsb25nIGhlcmU7IGFkZGluZyBoZXJlIGZvciBub3cgYXMgYSBxdWljayBXaW5k
b3dzIGJ1aWxkIGZpeC4KLSNpZiBFTkFCTEUoQVNTRU1CTEVSKSAmJiBDUFUoWDg2KSAmJiAhT1Mo
TUFDX09TX1gpCi0jaW5jbHVkZSAiTWFjcm9Bc3NlbWJsZXIuaCIKLUpTQzo6TWFjcm9Bc3NlbWJs
ZXJYODZDb21tb246OlNTRTJDaGVja1N0YXRlIEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZDb21tb246
OnNfc3NlMkNoZWNrU3RhdGUgPSBOb3RDaGVja2VkU1NFMjsKLSNlbmRpZgotCiAjaW5jbHVkZSAi
QXJpdHlDaGVja0ZhaWxSZXR1cm5UaHVua3MuaCIKICNpbmNsdWRlICJDb2RlQmxvY2suaCIKICNp
bmNsdWRlICJERkdDYXBhYmlsaXRpZXMuaCIK
</data>
<flag name="review"
          id="264867"
          type_id="1"
          status="-"
          setter="ossy"
    />
    <flag name="commit-queue"
          id="264868"
          type_id="3"
          status="-"
          setter="ossy"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240111</attachid>
            <date>2014-10-20 04:54:07 -0700</date>
            <delta_ts>2014-10-20 05:35:09 -0700</delta_ts>
            <desc>patch for EWS</desc>
            <filename>1.patch</filename>
            <type>text/plain</type>
            <size>2912</size>
            <attacher name="Csaba Osztrogonác">ossy</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3hwcm9q
L0phdmFTY3JpcHRDb3JlLnZjeHByb2ogYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlw
dENvcmUudmN4cHJvai9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qCmluZGV4IGE4Y2M0NTIuLjcxZjMw
MDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3hw
cm9qL0phdmFTY3JpcHRDb3JlLnZjeHByb2oKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0ph
dmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNjcmlwdENvcmUudmN4cHJvagpAQCAtMzA1LDcgKzMw
NSw3IEBACiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxhc3NlbWJsZXJcTGlua0J1ZmZlci5j
cHAiIC8+CiAgICAgPENsQ29tcGlsZSBJbmNsdWRlPSIuLlxhc3NlbWJsZXJcTWFjcm9Bc3NlbWJs
ZXIuY3BwIiAvPgogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5cQVBJXEpTQ1Rlc3RSdW5uZXJV
dGlscy5oIiAvPgotICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5cYXNzZW1ibGVyXE1hY3JvQXNz
ZW1ibGVyWDg2Q29tbW9uLmNwcCIgLz4KKyAgICA8Q2xDb21waWxlIEluY2x1ZGU9Ii4uXGFzc2Vt
YmxlclxNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5jcHAiIC8+CiAgICAgPENsQ29tcGlsZSBJbmNs
dWRlPSIuLlxiaW5kaW5nc1xTY3JpcHRGdW5jdGlvbkNhbGwuY3BwIiAvPgogICAgIDxDbENvbXBp
bGUgSW5jbHVkZT0iLi5cYmluZGluZ3NcU2NyaXB0T2JqZWN0LmNwcCIgLz4KICAgICA8Q2xDb21w
aWxlIEluY2x1ZGU9Ii4uXGJpbmRpbmdzXFNjcmlwdFZhbHVlLmNwcCIgLz4KZGlmZiAtLWdpdCBh
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qL0phdmFTY3JpcHRD
b3JlLnZjeHByb2ouZmlsdGVycyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y
ZS52Y3hwcm9qL0phdmFTY3JpcHRDb3JlLnZjeHByb2ouZmlsdGVycwppbmRleCAwNDljZTBhLi4w
YjQ5MTg0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUu
dmN4cHJvai9KYXZhU2NyaXB0Q29yZS52Y3hwcm9qLmZpbHRlcnMKKysrIGIvU291cmNlL0phdmFT
Y3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnZjeHByb2ovSmF2YVNjcmlwdENvcmUudmN4cHJvai5m
aWx0ZXJzCkBAIC0zMDMzLDkgKzMwMzMsOSBAQAogICAgIDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5c
cnVudGltZVxWTUVudHJ5U2NvcGUuaCI+CiAgICAgICA8RmlsdGVyPnJ1bnRpbWU8L0ZpbHRlcj4K
ICAgICA8L0NsSW5jbHVkZT4KLSAgICA8Q2xJbmNsdWRlIEluY2x1ZGU9Ii4uXGFzc2VtYmxlclxN
YWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5jcHAiPgorICAgIDxDbENvbXBpbGUgSW5jbHVkZT0iLi5c
YXNzZW1ibGVyXE1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmNwcCI+CiAgICAgICA8RmlsdGVyPmFz
c2VtYmxlcjwvRmlsdGVyPgotICAgIDwvQ2xJbmNsdWRlPgorICAgIDwvQ2xDb21waWxlPgogICAg
IDxDbEluY2x1ZGUgSW5jbHVkZT0iLi5ccnVudGltZVxJbnRlbmRlZFN0cnVjdHVyZUNoYWluLmgi
PgogICAgICAgPEZpbHRlcj5ydW50aW1lPC9GaWx0ZXI+CiAgICAgPC9DbEluY2x1ZGU+CmRpZmYg
LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2
Q29tbW9uLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs
ZXJYODZDb21tb24uY3BwCmluZGV4IDBmYWIwNWYuLjQzZmU3M2EgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uY3BwCisr
KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21t
b24uY3BwCkBAIC03OCw2ICs3OCwxMCBAQCB2b2lkIE1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpQ
cm9iZUNvbnRleHQ6OmR1bXAoY29uc3QgY2hhciogaW5kZW50YXRpb24pCiAKICNlbmRpZiAvLyBV
U0UoTUFTTV9QUk9CRSkKIAorI2lmIENQVShYODYpICYmICFPUyhNQUNfT1NfWCkKK01hY3JvQXNz
ZW1ibGVyWDg2Q29tbW9uOjpTU0UyQ2hlY2tTdGF0ZSBNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbjo6
c19zc2UyQ2hlY2tTdGF0ZSA9IE5vdENoZWNrZWRTU0UyOworI2VuZGlmCisKIH0gLy8gbmFtZXNw
YWNlIEpTQwogCiAjZW5kaWYgLy8gRU5BQkxFKEFTU0VNQkxFUikgJiYgKENQVShYODYpIHx8IENQ
VShYODZfNjQpKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuY3Bw
IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVQuY3BwCmluZGV4IDY1MTZjYzQuLmE4Njk3
MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAorKysgYi9T
b3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVC5jcHAKQEAgLTI5LDEyICsyOSw2IEBACiAKICNp
bmNsdWRlICJKSVQuaCIKIAotLy8gVGhpcyBwcm9iYWJseSBkb2VzIG5vdCBiZWxvbmcgaGVyZTsg
YWRkaW5nIGhlcmUgZm9yIG5vdyBhcyBhIHF1aWNrIFdpbmRvd3MgYnVpbGQgZml4LgotI2lmIEVO
QUJMRShBU1NFTUJMRVIpICYmIENQVShYODYpICYmICFPUyhNQUNfT1NfWCkKLSNpbmNsdWRlICJN
YWNyb0Fzc2VtYmxlci5oIgotSlNDOjpNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbjo6U1NFMkNoZWNr
U3RhdGUgSlNDOjpNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbjo6c19zc2UyQ2hlY2tTdGF0ZSA9IE5v
dENoZWNrZWRTU0UyOwotI2VuZGlmCi0KICNpbmNsdWRlICJBcml0eUNoZWNrRmFpbFJldHVyblRo
dW5rcy5oIgogI2luY2x1ZGUgIkNvZGVCbG9jay5oIgogI2luY2x1ZGUgIkRGR0NhcGFiaWxpdGll
cy5oIgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>240138</attachid>
            <date>2014-10-20 12:31:08 -0700</date>
            <delta_ts>2014-10-21 01:57:21 -0700</delta_ts>
            <desc>proposed patch ]I[</desc>
            <filename>wk.patch</filename>
            <type>text/plain</type>
            <size>1882</size>
            <attacher name="Milan Crha">mcrha</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0OTAwKQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA
CisyMDE0LTEwLTIwICBNaWxhbiBDcmhhICA8bWNyaGFAcmVkaGF0LmNvbT4KKworICAgICAgICBN
b3ZlIEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZDb21tb246OnNfc3NlMkNoZWNrU3RhdGUgZGVmaW5p
dGlvbiB0byBNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5jcHAuCisgICAgICAgIDxodHRwczovL3dl
YmtpdC5vcmcvYi8xMzc4MDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ3NhYmEgT3N6dHJvZ29u
w6FjLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmNwcDoK
KyAgICAgICAgKiBqaXQvSklULmNwcDoKKwogMjAxNC0xMC0yMCAgQnJlbnQgRnVsZ2hhbSAgPGJm
dWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBVbnJldmlld2VkIGJ1aWxkIGZpeC4K
SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZD
b21tb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv
TWFjcm9Bc3NlbWJsZXJYODZDb21tb24uY3BwCShyZXZpc2lvbiAxNzQ5MDApCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmNwcAkod29y
a2luZyBjb3B5KQpAQCAtNzgsNiArNzgsMTAgQEAgdm9pZCBNYWNyb0Fzc2VtYmxlclg4NkNvbW1v
bjo6UHJvYmVDb250ZQogCiAjZW5kaWYgLy8gVVNFKE1BU01fUFJPQkUpCiAKKyNpZiBDUFUoWDg2
KSAmJiAhT1MoTUFDX09TX1gpCitNYWNyb0Fzc2VtYmxlclg4NkNvbW1vbjo6U1NFMkNoZWNrU3Rh
dGUgTWFjcm9Bc3NlbWJsZXJYODZDb21tb246OnNfc3NlMkNoZWNrU3RhdGUgPSBOb3RDaGVja2Vk
U1NFMjsKKyNlbmRpZgorCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAogI2VuZGlmIC8vIEVOQUJMRShB
U1NFTUJMRVIpICYmIChDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KSkKSW5kZXg6IFNvdXJjZS9KYXZh
U2NyaXB0Q29yZS9qaXQvSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvaml0L0pJVC5jcHAJKHJldmlzaW9uIDE3NDkwMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS9qaXQvSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksMTIgKzI5LDYgQEAKIAogI2luY2x1
ZGUgIkpJVC5oIgogCi0vLyBUaGlzIHByb2JhYmx5IGRvZXMgbm90IGJlbG9uZyBoZXJlOyBhZGRp
bmcgaGVyZSBmb3Igbm93IGFzIGEgcXVpY2sgV2luZG93cyBidWlsZCBmaXguCi0jaWYgRU5BQkxF
KEFTU0VNQkxFUikgJiYgQ1BVKFg4NikgJiYgIU9TKE1BQ19PU19YKQotI2luY2x1ZGUgIk1hY3Jv
QXNzZW1ibGVyLmgiCi1KU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpTU0UyQ2hlY2tTdGF0
ZSBKU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjpzX3NzZTJDaGVja1N0YXRlID0gTm90Q2hl
Y2tlZFNTRTI7Ci0jZW5kaWYKLQogI2luY2x1ZGUgIkFyaXR5Q2hlY2tGYWlsUmV0dXJuVGh1bmtz
LmgiCiAjaW5jbHVkZSAiQ29kZUJsb2NrLmgiCiAjaW5jbHVkZSAiREZHQ2FwYWJpbGl0aWVzLmgi
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>