137736 2014-10-15 01:38:47 -0700 Use std::unique_ptr for CachedResource 2014-11-23 18:25:59 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128007 1 gyuyoung.kim gyuyoung.kim commit-queue japhet oldest_to_newest 1041823 0 gyuyoung.kim 2014-10-15 01:38:47 -0700 SSIA 1041824 1 239858 gyuyoung.kim 2014-10-15 01:39:56 -0700 Created attachment 239858 Patch 1041870 2 239858 darin 2014-10-15 09:38:21 -0700 Comment on attachment 239858 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=239858&action=review OK to do this, but please use make_unique. > Source/WebCore/loader/cache/CachedResource.cpp:517 > + std::unique_ptr<CachedResourceCallback> callback = m_clientsAwaitingCallback.take(client); I’d suggest using auto here instead of writing out the type. > Source/WebCore/loader/cache/CachedResource.h:271 > + static std::unique_ptr<CachedResourceCallback> schedule(CachedResource* resource, CachedResourceClient* client) { return std::unique_ptr<CachedResourceCallback>(new CachedResourceCallback(resource, client)); } This should use make_unique, not an explicit constructor and new. 1042027 3 239913 gyuyoung.kim 2014-10-15 18:26:26 -0700 Created attachment 239913 Patch for landing 1042028 4 gyuyoung.kim 2014-10-15 18:27:05 -0700 (In reply to comment #2) > (From update of attachment 239858 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=239858&action=review > > OK to do this, but please use make_unique. > > > Source/WebCore/loader/cache/CachedResource.cpp:517 > > + std::unique_ptr<CachedResourceCallback> callback = m_clientsAwaitingCallback.take(client); > > I’d suggest using auto here instead of writing out the type. > > > Source/WebCore/loader/cache/CachedResource.h:271 > > + static std::unique_ptr<CachedResourceCallback> schedule(CachedResource* resource, CachedResourceClient* client) { return std::unique_ptr<CachedResourceCallback>(new CachedResourceCallback(resource, client)); } > > This should use make_unique, not an explicit constructor and new. Ok, Fixed. 1042060 5 239913 commit-queue 2014-10-15 20:57:29 -0700 Comment on attachment 239913 Patch for landing Clearing flags on attachment: 239913 Committed r174758: <http://trac.webkit.org/changeset/174758> 1042061 6 commit-queue 2014-10-15 20:57:32 -0700 All reviewed patches have been landed. Closing bug. 239858 2014-10-15 01:39:56 -0700 2014-10-15 18:26:20 -0700 Patch bug-137736-20141015174000.patch text/plain 3289 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWYwN2FkMTI0MzVjNjJj M2Q2ZTc4OThjZDk0M2E2NmU1ZWVhZGRhNy4uM2U0N2Y1YTdmYjFlOGJjOTZjZDMxYjBhYTZkOWU5 NGE3YWFiYTMxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEwLTE1ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgVXNlIHN0ZDo6 dW5pcXVlX3B0ciBmb3IgQ2FjaGVkUmVzb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzczNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgor CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcDogVXNlIHN0ZDo6dW5p cXVlX3B0ciBpbnN0ZWFkIG9mIFBhc3NPd25QdHJ8T3duUHRyLgorICAgICAgICAoV2ViQ29yZTo6 Q2FjaGVkUmVzb3VyY2U6OnJlbW92ZUNsaWVudCk6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0Nh Y2hlZFJlc291cmNlLmg6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRSZXNvdXJjZTo6Q2FjaGVk UmVzb3VyY2VDYWxsYmFjazo6c2NoZWR1bGUpOgorCiAyMDE0LTEwLTE0ICBHeXV5b3VuZyBLaW0g IDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgQ2xlYW4gdXAgdW5uZWNlc3Nh cnkgUGFzc093blB0ci5oIGluY2x1c2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNo ZS9DYWNoZWRSZXNvdXJjZS5jcHAKaW5kZXggMDBjMzBmMGQ1NTkwZjNkMGNlYzU4NTRhMDJhOWVl OWViOGI1ZjA2ZC4uOWMyZjMzYzRkNWZiOTk0OGU1NzgyYzA3OTI1ZWVkOGYzZGZlZDU2ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCkBAIC01 MTQsMTEgKzUxNCwxMSBAQCBib29sIENhY2hlZFJlc291cmNlOjphZGRDbGllbnRUb1NldChDYWNo ZWRSZXNvdXJjZUNsaWVudCogY2xpZW50KQogCiB2b2lkIENhY2hlZFJlc291cmNlOjpyZW1vdmVD bGllbnQoQ2FjaGVkUmVzb3VyY2VDbGllbnQqIGNsaWVudCkKIHsKLSAgICBPd25QdHI8Q2FjaGVk UmVzb3VyY2VDYWxsYmFjaz4gY2FsbGJhY2sgPSBtX2NsaWVudHNBd2FpdGluZ0NhbGxiYWNrLnRh a2UoY2xpZW50KTsKKyAgICBzdGQ6OnVuaXF1ZV9wdHI8Q2FjaGVkUmVzb3VyY2VDYWxsYmFjaz4g Y2FsbGJhY2sgPSBtX2NsaWVudHNBd2FpdGluZ0NhbGxiYWNrLnRha2UoY2xpZW50KTsKICAgICBp ZiAoY2FsbGJhY2spIHsKICAgICAgICAgQVNTRVJUKCFtX2NsaWVudHMuY29udGFpbnMoY2xpZW50 KSk7CiAgICAgICAgIGNhbGxiYWNrLT5jYW5jZWwoKTsKLSAgICAgICAgY2FsbGJhY2suY2xlYXIo KTsKKyAgICAgICAgY2FsbGJhY2sgPSBudWxscHRyOwogICAgIH0gZWxzZSB7CiAgICAgICAgIEFT U0VSVChtX2NsaWVudHMuY29udGFpbnMoY2xpZW50KSk7CiAgICAgICAgIG1fY2xpZW50cy5yZW1v dmUoY2xpZW50KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNo ZWRSZXNvdXJjZS5oIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNl LmgKaW5kZXggYmUzMmViYzYxMzk3MDUwYjU1MDc2MThhOTc5NmE3OWQxMTc0MTFhNy4uYmFjYmVm YmRkMGI2ZWQwYmY3YTNjODQwYTA4ZTMxOGVkOGU1YTc2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmgKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmgKQEAgLTM1LDcgKzM1LDYgQEAKICNpbmNsdWRl IDx0aW1lLmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hDb3VudGVkU2V0Lmg+CiAjaW5jbHVkZSA8d3Rm L0hhc2hTZXQuaD4KLSNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1R5cGVD YXN0cy5oPgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZT dHJpbmcuaD4KQEAgLTI2OSw3ICsyNjgsNyBAQCBwcm90ZWN0ZWQ6CiAKICAgICBjbGFzcyBDYWNo ZWRSZXNvdXJjZUNhbGxiYWNrIHsKICAgICBwdWJsaWM6Ci0gICAgICAgIHN0YXRpYyBQYXNzT3du UHRyPENhY2hlZFJlc291cmNlQ2FsbGJhY2s+IHNjaGVkdWxlKENhY2hlZFJlc291cmNlKiByZXNv dXJjZSwgQ2FjaGVkUmVzb3VyY2VDbGllbnQqIGNsaWVudCkgeyByZXR1cm4gYWRvcHRQdHIobmV3 IENhY2hlZFJlc291cmNlQ2FsbGJhY2socmVzb3VyY2UsIGNsaWVudCkpOyB9CisgICAgICAgIHN0 YXRpYyBzdGQ6OnVuaXF1ZV9wdHI8Q2FjaGVkUmVzb3VyY2VDYWxsYmFjaz4gc2NoZWR1bGUoQ2Fj aGVkUmVzb3VyY2UqIHJlc291cmNlLCBDYWNoZWRSZXNvdXJjZUNsaWVudCogY2xpZW50KSB7IHJl dHVybiBzdGQ6OnVuaXF1ZV9wdHI8Q2FjaGVkUmVzb3VyY2VDYWxsYmFjaz4obmV3IENhY2hlZFJl c291cmNlQ2FsbGJhY2socmVzb3VyY2UsIGNsaWVudCkpOyB9CiAgICAgICAgIHZvaWQgY2FuY2Vs KCk7CiAgICAgcHJpdmF0ZToKICAgICAgICAgQ2FjaGVkUmVzb3VyY2VDYWxsYmFjayhDYWNoZWRS ZXNvdXJjZSosIENhY2hlZFJlc291cmNlQ2xpZW50Kik7CkBAIC0yNzksNyArMjc4LDcgQEAgcHJv dGVjdGVkOgogICAgICAgICBDYWNoZWRSZXNvdXJjZUNsaWVudCogbV9jbGllbnQ7CiAgICAgICAg IFRpbWVyPENhY2hlZFJlc291cmNlQ2FsbGJhY2s+IG1fY2FsbGJhY2tUaW1lcjsKICAgICB9Owot ICAgIEhhc2hNYXA8Q2FjaGVkUmVzb3VyY2VDbGllbnQqLCBPd25QdHI8Q2FjaGVkUmVzb3VyY2VD YWxsYmFjaz4+IG1fY2xpZW50c0F3YWl0aW5nQ2FsbGJhY2s7CisgICAgSGFzaE1hcDxDYWNoZWRS ZXNvdXJjZUNsaWVudCosIHN0ZDo6dW5pcXVlX3B0cjxDYWNoZWRSZXNvdXJjZUNhbGxiYWNrPj4g bV9jbGllbnRzQXdhaXRpbmdDYWxsYmFjazsKIAogICAgIFJlc291cmNlUmVxdWVzdCBtX3Jlc291 cmNlUmVxdWVzdDsKICAgICBTZXNzaW9uSUQgbV9zZXNzaW9uSUQ7Cg== 239913 2014-10-15 18:26:26 -0700 2014-10-15 20:57:29 -0700 Patch for landing bug-137736-20141016102630.patch text/plain 3430 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc0NzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTM4ZmIyZjk5NjJlZTUx MjA3OTFmMDFlZGJmMjQwMzI3MDc5YWJkMi4uOGZhN2VlZTNmNzAxYzhjMjdhYWFiNGI5OTVmYjU3 NTAwOWE1NWZkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTEwLTE1ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgVXNlIHN0ZDo6 dW5pcXVlX3B0ciBmb3IgQ2FjaGVkUmVzb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzczNgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisg ICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcDogVXNlIHN0ZDo6dW5pcXVl X3B0ciBpbnN0ZWFkIG9mIFBhc3NPd25QdHJ8T3duUHRyLgorICAgICAgICAoV2ViQ29yZTo6Q2Fj aGVkUmVzb3VyY2U6OnJlbW92ZUNsaWVudCk6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hl ZFJlc291cmNlLmg6IFNldCBjdG9yIGZyb20gcHJpdmF0ZSB0byBwdWJsaWMuCisgICAgICAgIChX ZWJDb3JlOjpDYWNoZWRSZXNvdXJjZTo6Q2FjaGVkUmVzb3VyY2VDYWxsYmFjazo6c2NoZWR1bGUp OgorCiAyMDE0LTEwLTE1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAg ICAgW01hY10gRml4IGluZWZmaWNpZW5jaWVzIGluIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3Jt TGF6eUluaXQoSW5pdExldmVsKSAtIFBhcnQgMgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv bG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9j YWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKaW5kZXggMDBjMzBmMGQ1NTkwZjNkMGNlYzU4NTRhMDJh OWVlOWViOGI1ZjA2ZC4uN2Y0ZmE1YTUwNDY0MjEzMGZmOTJlMTM4N2Y3NmFlMjBmNThiY2I4NiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCkBA IC01MTQsMTEgKzUxNCwxMSBAQCBib29sIENhY2hlZFJlc291cmNlOjphZGRDbGllbnRUb1NldChD YWNoZWRSZXNvdXJjZUNsaWVudCogY2xpZW50KQogCiB2b2lkIENhY2hlZFJlc291cmNlOjpyZW1v dmVDbGllbnQoQ2FjaGVkUmVzb3VyY2VDbGllbnQqIGNsaWVudCkKIHsKLSAgICBPd25QdHI8Q2Fj aGVkUmVzb3VyY2VDYWxsYmFjaz4gY2FsbGJhY2sgPSBtX2NsaWVudHNBd2FpdGluZ0NhbGxiYWNr LnRha2UoY2xpZW50KTsKKyAgICBhdXRvIGNhbGxiYWNrID0gbV9jbGllbnRzQXdhaXRpbmdDYWxs YmFjay50YWtlKGNsaWVudCk7CiAgICAgaWYgKGNhbGxiYWNrKSB7CiAgICAgICAgIEFTU0VSVCgh bV9jbGllbnRzLmNvbnRhaW5zKGNsaWVudCkpOwogICAgICAgICBjYWxsYmFjay0+Y2FuY2VsKCk7 Ci0gICAgICAgIGNhbGxiYWNrLmNsZWFyKCk7CisgICAgICAgIGNhbGxiYWNrID0gbnVsbHB0cjsK ICAgICB9IGVsc2UgewogICAgICAgICBBU1NFUlQobV9jbGllbnRzLmNvbnRhaW5zKGNsaWVudCkp OwogICAgICAgICBtX2NsaWVudHMucmVtb3ZlKGNsaWVudCk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuaCBiL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oCmluZGV4IGJlMzJlYmM2MTM5NzA1MGI1NTA3NjE4 YTk3OTZhNzlkMTE3NDExYTcuLmY0MGRkODk2ZTQ4ZTQxMzA2ODIxOGE4NGRhNjFkOTIzZWIyMjVh ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJj ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5oCkBA IC0zNSw3ICszNSw2IEBACiAjaW5jbHVkZSA8dGltZS5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoQ291 bnRlZFNldC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+Ci0jaW5jbHVkZSA8d3RmL093blB0 ci5oPgogI2luY2x1ZGUgPHd0Zi9UeXBlQ2FzdHMuaD4KICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+ CiAjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CkBAIC0yNjksMTcgKzI2OCwxOCBAQCBw cm90ZWN0ZWQ6CiAKICAgICBjbGFzcyBDYWNoZWRSZXNvdXJjZUNhbGxiYWNrIHsKICAgICBwdWJs aWM6Ci0gICAgICAgIHN0YXRpYyBQYXNzT3duUHRyPENhY2hlZFJlc291cmNlQ2FsbGJhY2s+IHNj aGVkdWxlKENhY2hlZFJlc291cmNlKiByZXNvdXJjZSwgQ2FjaGVkUmVzb3VyY2VDbGllbnQqIGNs aWVudCkgeyByZXR1cm4gYWRvcHRQdHIobmV3IENhY2hlZFJlc291cmNlQ2FsbGJhY2socmVzb3Vy Y2UsIGNsaWVudCkpOyB9CisgICAgICAgIENhY2hlZFJlc291cmNlQ2FsbGJhY2soQ2FjaGVkUmVz b3VyY2UqLCBDYWNoZWRSZXNvdXJjZUNsaWVudCopOworCisgICAgICAgIHN0YXRpYyBzdGQ6OnVu aXF1ZV9wdHI8Q2FjaGVkUmVzb3VyY2VDYWxsYmFjaz4gc2NoZWR1bGUoQ2FjaGVkUmVzb3VyY2Uq IHJlc291cmNlLCBDYWNoZWRSZXNvdXJjZUNsaWVudCogY2xpZW50KSB7IHJldHVybiBzdGQ6Om1h a2VfdW5pcXVlPENhY2hlZFJlc291cmNlQ2FsbGJhY2s+KHJlc291cmNlLCBjbGllbnQpOyB9CiAg ICAgICAgIHZvaWQgY2FuY2VsKCk7CiAgICAgcHJpdmF0ZToKLSAgICAgICAgQ2FjaGVkUmVzb3Vy Y2VDYWxsYmFjayhDYWNoZWRSZXNvdXJjZSosIENhY2hlZFJlc291cmNlQ2xpZW50Kik7CiAgICAg ICAgIHZvaWQgdGltZXJGaXJlZChUaW1lcjxDYWNoZWRSZXNvdXJjZUNhbGxiYWNrPiYpOwogCiAg ICAgICAgIENhY2hlZFJlc291cmNlKiBtX3Jlc291cmNlOwogICAgICAgICBDYWNoZWRSZXNvdXJj ZUNsaWVudCogbV9jbGllbnQ7CiAgICAgICAgIFRpbWVyPENhY2hlZFJlc291cmNlQ2FsbGJhY2s+ IG1fY2FsbGJhY2tUaW1lcjsKICAgICB9OwotICAgIEhhc2hNYXA8Q2FjaGVkUmVzb3VyY2VDbGll bnQqLCBPd25QdHI8Q2FjaGVkUmVzb3VyY2VDYWxsYmFjaz4+IG1fY2xpZW50c0F3YWl0aW5nQ2Fs bGJhY2s7CisgICAgSGFzaE1hcDxDYWNoZWRSZXNvdXJjZUNsaWVudCosIHN0ZDo6dW5pcXVlX3B0 cjxDYWNoZWRSZXNvdXJjZUNhbGxiYWNrPj4gbV9jbGllbnRzQXdhaXRpbmdDYWxsYmFjazsKIAog ICAgIFJlc291cmNlUmVxdWVzdCBtX3Jlc291cmNlUmVxdWVzdDsKICAgICBTZXNzaW9uSUQgbV9z ZXNzaW9uSUQ7Cg==