137310 2014-10-01 13:46:07 -0700 Object allocation sinking is broken for escaping sites in loops 2014-10-01 14:46:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 137315 1 fpizlo fpizlo barraclough commit-queue ggaren mark.lam mhahnenb msaboff oliver sam oldest_to_newest 1038632 0 fpizlo 2014-10-01 13:46:07 -0700 I tried to do this clever forward-flow based materialization point placement, and I messed up loops. 1038634 1 239046 fpizlo 2014-10-01 13:47:03 -0700 Created attachment 239046 the patch 1038637 2 239046 msaboff 2014-10-01 13:53:01 -0700 Comment on attachment 239046 the patch r=me 1038656 3 239046 commit-queue 2014-10-01 14:34:21 -0700 Comment on attachment 239046 the patch Clearing flags on attachment: 239046 Committed r174173: <http://trac.webkit.org/changeset/174173> 1038657 4 commit-queue 2014-10-01 14:34:25 -0700 All reviewed patches have been landed. Closing bug. 239046 2014-10-01 13:47:03 -0700 2014-10-01 14:34:21 -0700 the patch blah.patch text/plain 3017 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc0MTY2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE0LTEwLTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg T2JqZWN0IGFsbG9jYXRpb24gc2lua2luZyBpcyBicm9rZW4gZm9yIGVzY2FwaW5nIHNpdGVzIGlu IGxvb3BzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MzczMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIEkgdHJpZWQgdG8gZG8gdGhpcyBjbGV2ZXIgZm9yd2FyZC1mbG93IGJhc2VkIG1hdGVy aWFsaXphdGlvbiBwb2ludCBwbGFjZW1lbnQsIGFuZCBJIG1lc3NlZCB1cCBsb29wcy4gRGlzYWJs aW5nCisgICAgICAgIHRoZSBwaGFzZSBmb3Igbm93IGFuZCBsYW5kaW5nIGEgdGVzdCB0byBkZW1v bnN0cmF0ZSB3aGF0IGl0IGdvaW5nIG9uLgorCisgICAgICAgICogZGZnL0RGR1BsYW4uY3BwOgor ICAgICAgICAoSlNDOjpERkc6OlBsYW46OmNvbXBpbGVJblRocmVhZEltcGwpOgorICAgICAgICAq IHJ1bnRpbWUvT3B0aW9ucy5oOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9vYmplY3QtZXNjYXBl cy1pbi1sb29wLmpzOiBBZGRlZC4KKyAgICAgICAgKGZvbyk6CisgICAgICAgIChiYXIpOgorCiAy MDE0LTEwLTAxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgZml4IDMyLWJpdC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH UGxhbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFu LmNwcAkocmV2aXNpb24gMTc0MTEzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQ bGFuLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI5LDggKzMyOSwxMCBAQCBQbGFuOjpDb21waWxh dGlvblBhdGggUGxhbjo6Y29tcGlsZUluVGhyCiAgICAgICAgIHBlcmZvcm1QaGFudG9tQ2Fub25p Y2FsaXphdGlvbihkZmcpOyAvLyBSZWR1Y2UgdGhlIGdyYXBoIHNpemUgYSBsb3QuCiAgICAgICAg IGNoYW5nZWQgPSBmYWxzZTsKICAgICAgICAgY2hhbmdlZCB8PSBwZXJmb3JtU3RyZW5ndGhSZWR1 Y3Rpb24oZGZnKTsKLSAgICAgICAgY2hhbmdlZCB8PSBwZXJmb3JtQ3JpdGljYWxFZGdlQnJlYWtp bmcoZGZnKTsKLSAgICAgICAgY2hhbmdlZCB8PSBwZXJmb3JtT2JqZWN0QWxsb2NhdGlvblNpbmtp bmcoZGZnKTsKKyAgICAgICAgaWYgKE9wdGlvbnM6OmVuYWJsZU9iamVjdEFsbG9jYXRpb25TaW5r aW5nKCkpIHsKKyAgICAgICAgICAgIGNoYW5nZWQgfD0gcGVyZm9ybUNyaXRpY2FsRWRnZUJyZWFr aW5nKGRmZyk7CisgICAgICAgICAgICBjaGFuZ2VkIHw9IHBlcmZvcm1PYmplY3RBbGxvY2F0aW9u U2lua2luZyhkZmcpOworICAgICAgICB9CiAgICAgICAgIGlmIChjaGFuZ2VkKSB7CiAgICAgICAg ICAgICAvLyBTdGF0ZS1hdC10YWlsIGFuZCBzdGF0ZS1hdC1oZWFkIHdpbGwgYmUgaW52YWxpZCBp ZiB3ZSBkaWQgc3RyZW5ndGggcmVkdWN0aW9uIHNpbmNlCiAgICAgICAgICAgICAvLyBpdCBtaWdo dCBpbmNyZWFzZSBsaXZlIHJhbmdlcy4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL09wdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgJKHJldmlzaW9uIDE3NDExMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL09wdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMTc4LDYgKzE3OCw3IEBAIHR5cGVk ZWYgY29uc3QgY2hhciogb3B0aW9uU3RyaW5nOwogICAgIHYoYm9vbCwgZW5hYmxlQ2FsbEVkZ2VQ cm9maWxpbmcsIHRydWUpIFwKICAgICB2KHVuc2lnbmVkLCBmcmVxdWVudENhbGxUaHJlc2hvbGQs IDIpIFwKICAgICB2KGJvb2wsIG9wdGltaXplTmF0aXZlQ2FsbHMsIGZhbHNlKSBcCisgICAgdihi b29sLCBlbmFibGVPYmplY3RBbGxvY2F0aW9uU2lua2luZywgZmFsc2UpIFwKICAgICBcCiAgICAg dihib29sLCBlbmFibGVDb25jdXJyZW50SklULCB0cnVlKSBcCiAgICAgdih1bnNpZ25lZCwgbnVt YmVyT2ZERkdDb21waWxlclRocmVhZHMsIGNvbXB1dGVOdW1iZXJPZldvcmtlclRocmVhZHMoMiwg MikgLSAxKSBcCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL29iamVj dC1lc2NhcGVzLWluLWxvb3AuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L3Rlc3RzL3N0cmVzcy9vYmplY3QtZXNjYXBlcy1pbi1sb29wLmpzCShyZXZpc2lvbiAwKQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9vYmplY3QtZXNjYXBlcy1pbi1sb29w LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTcgQEAKK2Z1bmN0aW9uIGZvbyhwKSB7Cisg ICAgdmFyIG8gPSB7fTsKKyAgICBpZiAocCkgeworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8 IDEwMDsgKytpKQorICAgICAgICAgICAgYmFyKG8pOworICAgIH0KKyAgICByZXR1cm4gNDI7Cit9 CisKK2Z1bmN0aW9uIGJhcigpIHsKK30KKworbm9JbmxpbmUoZm9vKTsKK25vSW5saW5lKGJhcik7 CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDAwOyArK2kpCisgICAgZm9vKHRydWUpOwo=