137305 2014-10-01 11:25:29 -0700 Calling WebCore::Page::setMediaVolume(0) does not mute videos as expected 2014-10-21 17:19:22 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 adachan adachan adachan bshafiei calvaris commit-queue eric.carlson esprehn+autocc glenn gyuyoung.kim jer.noble philipj pnormand sergio webkit-bug-importer oldest_to_newest 1038599 0 adachan 2014-10-01 11:25:29 -0700 I have a simple test page with a video element in it: <div id=target style="border: solid;"> <video src="http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_r640-9cie.mov" autoplay controls></video> </div> I set the page's media volume to 0 with WKPageSetMediaVolume(0). But I can still hear the video playing. Looking at HTMLMediaElement::updateVolume(), it looks like the volume multiplier is only applied if m_volumeInitialized is true, and in this case it's not. 1041012 1 webkit-bug-importer 2014-10-10 13:32:55 -0700 <rdar://problem/18614742> 1043223 2 adachan 2014-10-21 10:42:50 -0700 Looks like this was broken in http://trac.webkit.org/changeset/154970. 1043235 3 eric.carlson 2014-10-21 11:20:30 -0700 Removing the "if (m_volumeInitialized)" check in HTMLMediaElement::updateVolume will fix this problem, and I don't *think* it will change the GStreamer behavior because MediaPlayerPrivateGStreamerBase::setStreamVolumeElement does nothing unless m_volumeInitialized is true (HTMLMediaElement::mediaPlayerPlatformVolumeConfigurationRequired). 1043275 4 pnormand 2014-10-21 14:03:11 -0700 Sorry for the breakage :( Looking at r154970 too, I agree with Eric that it should be enough to remove the "if (m_volumeInitialized)" test from ::updateVolume() 1043292 5 240225 adachan 2014-10-21 15:48:46 -0700 Created attachment 240225 Patch Please let me know if there's a way to write a test for this. 1043313 6 eric.carlson 2014-10-21 17:04:59 -0700 (In reply to comment #5) > Created attachment 240225 [details] > Patch > > Please let me know if there's a way to write a test for this. > I don't think there is a way to add a test for this change, because any problems will only happen to users of the GTK port with some versions of pulse audio. You might be able to add a test for Page::setMediaVolume to ensure that it isn't broken in the future, but that will require fairly invasive changes so I am not sure it is worth while. 1043317 7 adachan 2014-10-21 17:19:22 -0700 Eric and Philippe: thanks for your help! Committed: http://trac.webkit.org/changeset/175003 240225 2014-10-21 15:48:46 -0700 2014-10-21 15:56:01 -0700 Patch 0001-Calling-WebCore-Page-setMediaVolume-0-does-not-mute-.patch text/plain 2563 adachan RnJvbSBmMDA1ZjZlNmRhZWQzZGEyNGJlOWZkMzFkYzIyNmVlOGE4OGExNzhlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGEgQ2hhbiA8YWRhY2hhbkBhcHBsZS5jb20+CkRhdGU6IFR1 ZSwgMjEgT2N0IDIwMTQgMTU6NDc6MjYgLTA3MDAKU3ViamVjdDogW1BBVENIXSBDYWxsaW5nIFdl YkNvcmU6OlBhZ2U6OnNldE1lZGlhVm9sdW1lKDApIGRvZXMgbm90IG11dGUgdmlkZW9zCiBhcyBl eHBlY3RlZC4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNzMwNQoK UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpUaGlzIHdhcyBicm9rZW4gaW4gaHR0cDovL3Ry YWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTU0OTcwLiBUbyBmaXggdGhpcyAoYnV0IG5vdCBicmVh awpHU3RyZWFtZXIpLCByZW1vdmUgdGhlICJpZiAobV92b2x1bWVJbml0aWFsaXplZCkiIGNoZWNr IGJlZm9yZSB1cGRhdGluZyB0aGUgTWVkaWFQbGF5ZXIncwp2b2x1bWUgdG8gdGhlIHZhbHVlIG11 bHRpcGxpZWQgd2l0aCB0aGUgUGFnZSdzIG1lZGlhVm9sdW1lLiBUaGlzIHNob3VsZCBub3QgYWZm ZWN0IEdTdHJlYW1lcidzCmJlaGF2aW9yIGJlY2F1c2UgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyQmFzZTo6c2V0U3RyZWFtVm9sdW1lRWxlbWVudCBkb2VzIG5vdGhpbmcgdW5sZXNzCm1fdm9s dW1lSW5pdGlhbGl6ZWQgaXMgdHJ1ZS4KCiogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnVwZGF0ZVZvbHVtZSk6Ci0tLQogU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8IDE2ICsrKysrKysrKysrKysrKysKIFNvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgfCAgMyArLS0KIDIgZmlsZXMgY2hh bmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODM2 YmI3Ny4uNzc4MGVjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEwLTIxICBB ZGEgQ2hhbiAgPGFkYWNoYW5AYXBwbGUuY29tPgorCisgICAgICAgIENhbGxpbmcgV2ViQ29yZTo6 UGFnZTo6c2V0TWVkaWFWb2x1bWUoMCkgZG9lcyBub3QgbXV0ZSB2aWRlb3MgYXMgZXhwZWN0ZWQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzczMDUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdh cyBicm9rZW4gaW4gaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTU0OTcwLiBUbyBm aXggdGhpcyAoYnV0IG5vdCBicmVhaworICAgICAgICBHU3RyZWFtZXIpLCByZW1vdmUgdGhlICJp ZiAobV92b2x1bWVJbml0aWFsaXplZCkiIGNoZWNrIGJlZm9yZSB1cGRhdGluZyB0aGUgTWVkaWFQ bGF5ZXIncworICAgICAgICB2b2x1bWUgdG8gdGhlIHZhbHVlIG11bHRpcGxpZWQgd2l0aCB0aGUg UGFnZSdzIG1lZGlhVm9sdW1lLiBUaGlzIHNob3VsZCBub3QgYWZmZWN0IEdTdHJlYW1lcidzCisg ICAgICAgIGJlaGF2aW9yIGJlY2F1c2UgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6 c2V0U3RyZWFtVm9sdW1lRWxlbWVudCBkb2VzIG5vdGhpbmcgdW5sZXNzCisgICAgICAgIG1fdm9s dW1lSW5pdGlhbGl6ZWQgaXMgdHJ1ZS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVWb2x1bWUp OgorCiAyMDE0LTEwLTIxICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTjogR29vZ2xlIFNlYXJjaCAobW9iaWxlKSB2aWRlbyB0aHVtYm5haWxzIGFy ZSB0b28gbGFyZ2UuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVs ZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRl eCAxZGFhYjE4Li4yMDRkMjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxN ZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAKQEAgLTQ0NzcsOCArNDQ3Nyw3IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6dXBkYXRl Vm9sdW1lKCkKICAgICAgICAgfQogCiAgICAgICAgIG1fcGxheWVyLT5zZXRNdXRlZChzaG91bGRN dXRlKTsKLSAgICAgICAgaWYgKG1fdm9sdW1lSW5pdGlhbGl6ZWQpCi0gICAgICAgICAgICBtX3Bs YXllci0+c2V0Vm9sdW1lKG1fdm9sdW1lICogdm9sdW1lTXVsdGlwbGllcik7CisgICAgICAgIG1f cGxheWVyLT5zZXRWb2x1bWUobV92b2x1bWUgKiB2b2x1bWVNdWx0aXBsaWVyKTsKICAgICB9CiAK ICAgICBpZiAoaGFzTWVkaWFDb250cm9scygpKQotLSAKMS45LjMgKEFwcGxlIEdpdC01MCkKCg==