136841 2014-09-15 15:02:46 -0700 Implement cap height in SimpleFontDataWin to enable initial-letter support for Windows 2014-09-22 11:35:37 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 136484 1 roger_fong bfulgham bfulgham commit-queue hyatt jonlee mmaxfield roger_fong webkit-bug-importer oldest_to_newest 1035322 0 roger_fong 2014-09-15 15:02:46 -0700 In https://bugs.webkit.org/show_bug.cgi?id=136484 initial-letter support was enabled for Mac and iOS but not the other platforms. In order to enable we have to implement the cap height logic in SimpleFontDataWin. Until then, skipping all initial-letter tests 1036257 1 bfulgham 2014-09-19 17:52:59 -0700 I'm testing a patch for this. Easy fix. 1036566 2 238489 bfulgham 2014-09-22 11:28:17 -0700 Created attachment 238489 Patch 1036567 3 webkit-bug-importer 2014-09-22 11:29:24 -0700 <rdar://problem/18415046> 1036568 4 238489 hyatt 2014-09-22 11:32:47 -0700 Comment on attachment 238489 Patch r=me 1036569 5 bfulgham 2014-09-22 11:35:37 -0700 Committed r173840: <http://trac.webkit.org/changeset/173840> 238489 2014-09-22 11:28:17 -0700 2014-09-22 11:32:47 -0700 Patch bug-136841-20140922113029.patch text/plain 1988 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Mzc4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA5LTE5ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFtXaW5dIEltcGxlbWVudCBj YXAgaGVpZ2h0IGluIFNpbXBsZUZvbnREYXRhV2luIHRvIGVuYWJsZSBpbml0aWFsLWxldHRlciBz dXBwb3J0IGZvciBXaW5kb3dzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM2ODQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vU2ltcGxlRm9udERhdGFDR1dpbi5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTaW1wbGVGb250RGF0YTo6cGxhdGZvcm1Jbml0KTogQWRk IG1pc3NpbmcgY2FsbHMgdG8gc2V0IHVwIG91ciBmb250cy4KKwogMjAxNC0wOS0xOSAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIE1pbmltaXplIHZpcnR1YWwgZnVu Y3Rpb24gY2FsbHMgaW4gTWFya3VwQWNjdW11bGF0b3IKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3dpbi9TaW1wbGVGb250RGF0YUNHV2luLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vU2ltcGxlRm9udERhdGFDR1dp bi5jcHAJKHJldmlzaW9uIDE3Mzc3NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3dpbi9TaW1wbGVGb250RGF0YUNHV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjIsMTAg KzYyLDEyIEBAIHZvaWQgU2ltcGxlRm9udERhdGE6OnBsYXRmb3JtSW5pdCgpCiAgICAgaW50IGlB c2NlbnQgPSBDR0ZvbnRHZXRBc2NlbnQoZm9udCk7CiAgICAgaW50IGlEZXNjZW50ID0gQ0dGb250 R2V0RGVzY2VudChmb250KTsKICAgICBpbnQgaUxpbmVHYXAgPSBDR0ZvbnRHZXRMZWFkaW5nKGZv bnQpOworICAgIGludCBpQ2FwSGVpZ2h0ID0gQ0dGb250R2V0Q2FwSGVpZ2h0KGZvbnQpOwogICAg IHVuc2lnbmVkIHVuaXRzUGVyRW0gPSBDR0ZvbnRHZXRVbml0c1BlckVtKGZvbnQpOwogICAgIGZs b2F0IHBvaW50U2l6ZSA9IG1fcGxhdGZvcm1EYXRhLnNpemUoKTsKICAgICBmbG9hdCBmQXNjZW50 ID0gc2NhbGVFbVRvVW5pdHMoaUFzY2VudCwgdW5pdHNQZXJFbSkgKiBwb2ludFNpemU7CiAgICAg ZmxvYXQgZkRlc2NlbnQgPSAtc2NhbGVFbVRvVW5pdHMoaURlc2NlbnQsIHVuaXRzUGVyRW0pICog cG9pbnRTaXplOworICAgIGZsb2F0IGZDYXBIZWlnaHQgPSBzY2FsZUVtVG9Vbml0cyhpQ2FwSGVp Z2h0LCB1bml0c1BlckVtKSAqIHBvaW50U2l6ZTsKICAgICBmbG9hdCBmTGluZUdhcCA9IHNjYWxl RW1Ub1VuaXRzKGlMaW5lR2FwLCB1bml0c1BlckVtKSAqIHBvaW50U2l6ZTsKIAogICAgIGlmICgh aXNDdXN0b21Gb250KCkpIHsKQEAgLTgyLDYgKzg0LDcgQEAgdm9pZCBTaW1wbGVGb250RGF0YTo6 cGxhdGZvcm1Jbml0KCkKIAogICAgIG1fZm9udE1ldHJpY3Muc2V0QXNjZW50KGZBc2NlbnQpOwog ICAgIG1fZm9udE1ldHJpY3Muc2V0RGVzY2VudChmRGVzY2VudCk7CisgICAgbV9mb250TWV0cmlj cy5zZXRDYXBIZWlnaHQoZkNhcEhlaWdodCk7CiAgICAgbV9mb250TWV0cmljcy5zZXRMaW5lR2Fw KGZMaW5lR2FwKTsKICAgICBtX2ZvbnRNZXRyaWNzLnNldExpbmVTcGFjaW5nKGxyb3VuZGYoZkFz Y2VudCkgKyBscm91bmRmKGZEZXNjZW50KSArIGxyb3VuZGYoZkxpbmVHYXApKTsKIAo=