136363 2014-08-29 04:35:09 -0700 [JSC] Some JSC stress tests are dependent on the machine time zone. 2018-06-13 17:37:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=186612 P2 Normal --- 138303 1 clopez clopez commit-queue dbates dpino fpizlo mhahnenb mrobinson msaboff ossy sun.shin wingo oldest_to_newest 1032142 0 clopez 2014-08-29 04:35:09 -0700 I have noticed that some of the JSC stress tests fail if your timezone is not PDT (At least on the GTK port, didn't tested other ports). They pass all OK if your timezone is PDT: $ export TZ="US/Pacific" $ Tools/Scripts/run-javascriptcore-tests --release --gtk --no-build [...] 9887/9887 Results for JSC stress tests: 0 failures found. OK. But some fail if you have another timezone: $ export TZ="Europe/Madrid" $ Tools/Scripts/run-javascriptcore-tests --release --gtk --no-build [...] 9887/9887 (failed 4) ** The following JSC stress test failures have been introduced: mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-baseline mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-dfg-eager-no-cjit-validate-phases mozilla-tests.yaml/ecma_3/Date/15.9.5.6.js.mozilla-llint Results for JSC stress tests: 4 failures found. To workaround this, maybe we can just export the environment variable TZ to US/Pacific on the script run-javascriptcore-tests ? 1032146 1 wingo 2014-08-29 05:35:37 -0700 (In reply to comment #0) > I have noticed that some of the JSC stress tests fail if your timezone is not PDT (At least on the GTK port, didn't tested other ports). Yep, a long-standing bug present in these tests since they were imported from Mozilla. Note that these aren't the main tests for JSC -- those are in LayoutTests. > To workaround this, maybe we can just export the environment variable TZ to US/Pacific on the script run-javascriptcore-tests ? Sure, sounds like a good idea to me. 1032147 2 ossy 2014-08-29 05:44:16 -0700 It is a very old bug: bug4930 . The workaround for us was always to set TZ to Apple time zone if you want to run JSC tests. :) +1 for adding this workaround if nobody wants to fix the buggy test. 1032148 3 ossy 2014-08-29 05:53:44 -0700 Adding $ENV{TZ}="US/Pacific"; to run-javascriptcore-tests works for me, feel free to create a patch for it. 1032151 4 237347 clopez 2014-08-29 06:30:48 -0700 Created attachment 237347 Patch 1032152 5 237347 ossy 2014-08-29 06:32:43 -0700 Comment on attachment 237347 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=237347&action=review > Tools/Scripts/run-javascriptcore-tests:237 > + # Some tests fail if the time zone is not set to US/Pacific (<https://webkit.org/b/136363>) > + $ENV{TZ}="US/Pacific"; We can apply this if we only run the mozilla tests for some reason. 1032155 6 clopez 2014-08-29 06:43:25 -0700 (In reply to comment #5) > (From update of attachment 237347 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=237347&action=review > > > Tools/Scripts/run-javascriptcore-tests:237 > > + # Some tests fail if the time zone is not set to US/Pacific (<https://webkit.org/b/136363>) > > + $ENV{TZ}="US/Pacific"; > > We can apply this if we only run the mozilla tests for some reason. Not sure if I understand what you mean. Exporting it inside: if ($runMozilla) { [...] } Don't fixes the issue. 1032156 7 clopez 2014-08-29 06:44:31 -0700 Also, running "Tools/Scripts/run-javascriptcore-tests [...] --no-jsc-stress" don't fails 1032157 8 ossy 2014-08-29 06:47:12 -0700 I meant Tools/Scripts/run-javascriptcore-tests --no-jsc-stress case should be workarounded too, not only the stress test case. 1032183 9 clopez 2014-08-29 10:08:19 -0700 I see. There are some mozilla test skipped due to this issue with the timezone. See r99580 <http://trac.webkit.org/r99580>. I have tested to unskip them and they fail only with a non US/Pacific timezone, but pass on US/Pacific. I'm going to unskip this tests and set the TZ environment variable on the main body of the script. 1032185 10 237355 clopez 2014-08-29 10:26:16 -0700 Created attachment 237355 Patch 1032203 11 237355 commit-queue 2014-08-29 11:15:45 -0700 Comment on attachment 237355 Patch Clearing flags on attachment: 237355 Committed r173116: <http://trac.webkit.org/changeset/173116> 1032204 12 commit-queue 2014-08-29 11:15:49 -0700 All reviewed patches have been landed. Closing bug. 237347 2014-08-29 06:30:48 -0700 2014-08-29 10:26:09 -0700 Patch bug-136363-20140829153040.patch text/plain 1544 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMTEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWZiMDVhYTUwOTJmNjFmNTNmNTY0ZDc0M2UyN2FiMWI4 ZTY0Y2UxZS4uNzM0NWQ0YWQ3ZmE0N2QwYWMxOTg4ZWZiNjcwMzEyZTUyMWY4OWM3MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE0LTA4LTI5ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtKU0NdIFNvbWUgSlNDIHN0cmVzcyB0ZXN0cyBhcmUgZGVwZW5k ZW50IG9uIHRoZSBtYWNoaW5lIHRpbWUgem9uZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNjM2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6 IEV4cG9ydCBUWiBlbnZpcm9ubWVudCB2YXJpYWJsZSB0byBVUy9QYWNpZmljLgorCiAyMDE0LTA4 LTI5ICBFdmEgQmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+ CiAKICAgICAgICAgW0VGTF0gUmVtb3ZlIG5vbiBDb29yZGluYXRlZCBHcmFwaGljcyBjb2RlIHBh dGggZnJvbSBjbWFrZSBidWlsZCBzeXN0ZW0gYWZ0ZXIgcjE0MjE2OQpkaWZmIC0tZ2l0IGEvVG9v bHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1q YXZhc2NyaXB0Y29yZS10ZXN0cwppbmRleCBlMDU4NTlkYzdkYTdhY2I5ZWEzN2FjMThlZjc4MmM1 ODQ0Zjg0ZDdlLi44N2Y4NjVlZGM1ZGQ3OGI2NWFmODk5YzZkNmRiMDIwY2U3YjM1ODgxIDEwMDc1 NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cworKysgYi9Ub29s cy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwpAQCAtMjMzLDYgKzIzMyw4IEBAIG15 ICRqc2NTdHJlc3NSZXN1bHRzRGlyID0gJHByb2R1Y3REaXIgLiAiL2pzYy1zdHJlc3MtcmVzdWx0 cyI7CiBpZiAoJHJ1bkpTQ1N0cmVzcykgewogICAgICMgU2V0IExBTkcgZW52aXJvbm1lbnQgdmFy aWFibGUgc28gdGhlIHN0cmVzcyB0ZXN0cyB3aWxsIHdvcmsgd2l0aCBuZXdlciBydWJ5ICg8cmRh cjovL3Byb2JsZW0vMTUwMTA3MDU+KQogICAgICRFTlZ7TEFOR309ImVuX1VTLlVURi04IjsKKyAg ICAjIFNvbWUgdGVzdHMgZmFpbCBpZiB0aGUgdGltZSB6b25lIGlzIG5vdCBzZXQgdG8gVVMvUGFj aWZpYyAoPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzNjM2Mz4pCisgICAgJEVOVntUWn09IlVTL1Bh Y2lmaWMiOwogICAgIG15IEBqc2NTdHJlc3NEcml2ZXJDbWQgPSAoCiAgICAgICAgICIvdXNyL2Jp bi9lbnYiLCAicnVieSIsICJUb29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzIiwKICAg ICAgICAgIi1qIiwganNjUGF0aCgkcHJvZHVjdERpciksICItbyIsICRqc2NTdHJlc3NSZXN1bHRz RGlyLAo= 237355 2014-08-29 10:26:16 -0700 2014-08-29 11:15:44 -0700 Patch bug-136363-20140829192609.patch text/plain 2023 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMTEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWZiMDVhYTUwOTJmNjFmNTNmNTY0ZDc0M2UyN2FiMWI4 ZTY0Y2UxZS4uYzBmYmIxNGI5MTYzYzBkZTNjZDU0MjYxY2IzMjI4Y2EwMGYxNWRiZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA4LTI5ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtKU0NdIFNvbWUgSlNDIHRlc3RzIGFyZSBkZXBlbmRlbnQgb24g dGhlIG1hY2hpbmUgdGltZSB6b25lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM2MzYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czogRXhwb3J0 IFRaIGVudmlyb25tZW50IHZhcmlhYmxlIHRvIFVTL1BhY2lmaWMuCisgICAgICAgIFVuc2tpcCB0 aGUgdGVzdHMgdGhhdCB3ZXJlIHNraXBwZWQgb24gcjk5NTgwLgorCiAyMDE0LTA4LTI5ICBFdmEg QmFsYXpzZmFsdmkgIDxldmFiLnUtc3plZ2VkQHBhcnRuZXIuc2Ftc3VuZy5jb20+CiAKICAgICAg ICAgW0VGTF0gUmVtb3ZlIG5vbiBDb29yZGluYXRlZCBHcmFwaGljcyBjb2RlIHBhdGggZnJvbSBj bWFrZSBidWlsZCBzeXN0ZW0gYWZ0ZXIgcjE0MjE2OQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0 Y29yZS10ZXN0cwppbmRleCBlMDU4NTlkYzdkYTdhY2I5ZWEzN2FjMThlZjc4MmM1ODQ0Zjg0ZDdl Li5iYTIwNzRjNThmYTRmMGVjODc2OGM4NjZiNTNmOGIwOGFlOWU2MDQzIDEwMDc1NQotLS0gYS9U b29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cworKysgYi9Ub29scy9TY3JpcHRz L3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwpAQCAtNTQsMTEgKzU0LDYgQEAgbXkgQHRlc3RzVG9T a2lwID0gKAogICAgICMgZWNtYV8zL0RhdGUvMTUuOS41LjcuanMgZmFpbHMgb24gTWFjIChidXQg bm90IFdpbmRvd3MpIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yNTE2 MQogICAgICJlY21hXzMvRGF0ZS8xNS45LjUuNi5qcyIsCiAgICAgImVjbWFfMy9EYXRlLzE1Ljku NS43LmpzIiwKLSAgICAjIFRoZXNlIHRocmVlIGZhaWwgb24gTGludXggaW4gY2VydGFpbiB0aW1l IHpvbmVzLCBhdCBjZXJ0YWluIHRpbWVzCi0gICAgIyBvZiB0aGUgeWVhciAoISk6IGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03MTM3MQotICAgICJlY21hL0RhdGUvMTUu OS41LjE0LmpzIiwKLSAgICAiZWNtYS9EYXRlLzE1LjkuNS4zMS0xLmpzIiwKLSAgICAiZWNtYS9E YXRlLzE1LjkuNS4zNC0xLmpzIiwKICk7CiAKIG15ICRqc0RyaXZlckFyZ3MgPSAiLUwgIiAuIGpv aW4oIiAiLCBAdGVzdHNUb1NraXApOwpAQCAtMTQ5LDYgKzE0NCw3IEBAIGlmICghZGVmaW5lZCgk cm9vdCkgJiYgJGJ1aWxkSlNDKSB7CiBteSAkcHJvZHVjdERpciA9IGpzY1Byb2R1Y3REaXIoKTsK ICRFTlZ7RFlMRF9GUkFNRVdPUktfUEFUSH0gPSAkcHJvZHVjdERpcjsKICRFTlZ7SlNDX3RpbWVv dXR9ID0gNjAgdW5sZXNzICRFTlZ7SlNDX3RpbWVvdXR9OyAjIFNldCBhIDYwIHNlY29uZCB0aW1l b3V0IG9uIGFsbCBqc2MgdGVzdHMgKGlmIGVudmlyb25tZW50IHZhcmlhYmxlIG5vdCBkZWZpbmVk IGFscmVhZHkpLgorJEVOVntUWn09IlVTL1BhY2lmaWMiOyAjIFNvbWUgdGVzdHMgZmFpbCBpZiB0 aGUgdGltZSB6b25lIGlzIG5vdCBzZXQgdG8gVVMvUGFjaWZpYyAoPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzEzNjM2Mz4pCiBzZXRQYXRoRm9yUnVubmluZ1dlYktpdEFwcChcJUVOVikgaWYgaXNDeWd3 aW4oKTsKIAogc3ViIHRlc3RhcGlQYXRoKCQpCg==