<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>134375</bug_id>
          
          <creation_ts>2014-06-26 18:30:27 -0700</creation_ts>
          <short_desc>The user pressing a button on a gamepad should cause gamepads to become visible to all NavigatorGamepads</short_desc>
          <delta_ts>2022-03-01 02:53:19 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>134076</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Brady Eidson">beidson</reporter>
          <assigned_to name="Brady Eidson">beidson</assigned_to>
          <cc>dino</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1018827</commentid>
    <comment_count>0</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-06-26 18:30:27 -0700</bug_when>
    <thetext>The user pressing a button on a gamepad should cause gamepads to become visible to all NavigatorGamepads</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018888</commentid>
    <comment_count>1</comment_count>
      <attachid>233967</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-06-26 23:01:22 -0700</bug_when>
    <thetext>Created attachment 233967
Patch v1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018890</commentid>
    <comment_count>2</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-06-26 23:02:39 -0700</bug_when>
    <thetext>Ignore the can&apos;t-buildness that EWS sees - In my tree this patch is built on previous patches.  I will pass it through EWS before landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1018989</commentid>
    <comment_count>3</comment_count>
      <attachid>233967</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2014-06-27 09:59:09 -0700</bug_when>
    <thetext>Comment on attachment 233967
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=233967&amp;action=review

&gt; Source/WebCore/Modules/gamepad/GamepadManager.cpp:81
&gt; +        const Vector&lt;PlatformGamepad*&gt;&amp; platformGamepads = GamepadProvider::shared().platformGamepads();

Seems like a good place to use auto, although maybe Alexey wouldn’t agree.

&gt; Source/WebCore/Modules/gamepad/GamepadManager.cpp:82
&gt; +        for (unsigned i = 0; i &lt; platformGamepads.size(); ++i) {

Normally it’s an anti-pattern to actually call size each time through. My own preference is to put it into a local variable named size, either inside the for or just before it:

    for (unsigned i = 0, size = platformGamepads.size(); i &lt; size; ++i)

&gt; Source/WebCore/platform/mac/HIDGamepadProvider.cpp:85
&gt; +    , m_inputNotificationTimer(this, &amp;HIDGamepadProvider::inputNotificationTimerFired)

Consider the new style Timer that uses a function/lambda instead of a pointer to member function.

&gt; Source/WebCore/platform/mac/HIDGamepadProvider.cpp:215
&gt; +    if (!m_inputNotificationTimer.isActive())
&gt; +        m_inputNotificationTimer.startOneShot(InputNotificationDelay);

A why comment would be good here to explain why the isActive check. We want to delay from the time of the first input, not postpone when we get additional input, I assume.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1019083</commentid>
    <comment_count>4</comment_count>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2014-06-27 14:12:02 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/170553</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>233967</attachid>
            <date>2014-06-26 23:01:22 -0700</date>
            <delta_ts>2022-03-01 02:53:19 -0800</delta_ts>
            <desc>Patch v1</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>8138</size>
            <attacher name="Brady Eidson">beidson</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA2NmQ5ZjI1Li40YmQzYTU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDEgKzEsMzAg
QEAKKzIwMTQtMDYtMjYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg
ICAgIFRoZSB1c2VyIHByZXNzaW5nIGEgYnV0dG9uIG9uIGEgZ2FtZXBhZCBzaG91bGQgY2F1c2Ug
Z2FtZXBhZHMgdG8gYmVjb21lIHZpc2libGUgdG8gYWxsIE5hdmlnYXRvckdhbWVwYWRzLgorICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0Mzc1CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3Rz
IChOb3QgeWV0IGEgdGVzdGVkIGNvbmZpZykKKworICAgICAgICAqIE1vZHVsZXMvZ2FtZXBhZC9H
YW1lcGFkTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHYW1lcGFkTWFuYWdlcjo6cGxh
dGZvcm1HYW1lcGFkQ29ubmVjdGVkKTogQWxzbyBjYWxsIHRvIG1ha2VHYW1lcGFkc1Zpc2liaWxl
VG9CbGluZE5hdmlnYXRvcnMuCisgICAgICAgIChXZWJDb3JlOjpHYW1lcGFkTWFuYWdlcjo6cGxh
dGZvcm1HYW1lcGFkRGlzY29ubmVjdGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkdhbWVwYWRNYW5h
Z2VyOjpwbGF0Zm9ybUdhbWVwYWRJbnB1dEFjdGl2aXR5KTogQ2FsbCBtYWtlR2FtZXBhZHNWaXNp
YmlsZVRvQmxpbmROYXZpZ2F0b3JzLgorICAgICAgICAoV2ViQ29yZTo6R2FtZXBhZE1hbmFnZXI6
Om1ha2VHYW1lcGFkc1Zpc2liaWxlVG9CbGluZE5hdmlnYXRvcnMpOiBXYWxrIHRocm91Z2ggZWFj
aCBibGluZCBuYXZpZ2F0b3IKKyAgICAgICAgICBub3RpZnlpbmcgaXQgb2YgZWFjaCBjb25uZWN0
ZWQgR2FtZXBhZC4KKyAgICAgICAgKFdlYkNvcmU6OkdhbWVwYWRNYW5hZ2VyOjpyZWdpc3Rlck5h
dmlnYXRvcik6IEFsc28gYWRkIHRvIHRoZSBibGluZCBuYXZpZ2F0b3Igc2V0LgorICAgICAgICAo
V2ViQ29yZTo6R2FtZXBhZE1hbmFnZXI6OnVucmVnaXN0ZXJOYXZpZ2F0b3IpOiBBbHNvIHJlbW92
ZSBmcm9tIHRoZSBibGluZCBuYXZpZ2F0b3Igc2V0LgorICAgICAgICAqIE1vZHVsZXMvZ2FtZXBh
ZC9HYW1lcGFkTWFuYWdlci5oOgorCisgICAgICAgICogcGxhdGZvcm0vR2FtZXBhZFByb3ZpZGVy
Q2xpZW50Lmg6IEFkZGVkIHBsYXRmb3JtR2FtZXBhZElucHV0QWN0aXZpdHkKKworICAgICAgICAq
IHBsYXRmb3JtL21hYy9ISURHYW1lcGFkUHJvdmlkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6
SElER2FtZXBhZFByb3ZpZGVyOjpISURHYW1lcGFkUHJvdmlkZXIpOgorICAgICAgICAoV2ViQ29y
ZTo6SElER2FtZXBhZFByb3ZpZGVyOjp2YWx1ZXNDaGFuZ2VkKTogU2V0IHRoZSBpbnB1dCBub3Rp
ZmljYXRpb24gdGltZXIgd2hpY2ggd2lsbCBub3RpZnkgdGhlIGNsaWVudHMKKyAgICAgICAgICB0
aGF0IGEgYnV0dG9uIHdhcyBwcmVzc2VkLgorICAgICAgICAoV2ViQ29yZTo6SElER2FtZXBhZFBy
b3ZpZGVyOjppbnB1dE5vdGlmaWNhdGlvblRpbWVyRmlyZWQpOiBQZXJmb3JtIHRoYXQgbm90aWZp
Y2F0aW9uLgorICAgICAgICAgKiBwbGF0Zm9ybS9tYWMvSElER2FtZXBhZFByb3ZpZGVyLmg6CisK
IDIwMTQtMDYtMjYgIEJhbGF6cyBLZWxlbWVuICA8Yi5rZWxlbWVuQHNhbXN1bmcuY29tPgogCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVwYWQvR2FtZXBhZE1hbmFnZXIu
Y3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nYW1lcGFkL0dhbWVwYWRNYW5hZ2VyLmNwcApp
bmRleCA4MzQ3NWJhLi5mNDQxNjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz
L2dhbWVwYWQvR2FtZXBhZE1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv
Z2FtZXBhZC9HYW1lcGFkTWFuYWdlci5jcHAKQEAgLTQ4LDE4ICs0OCw0NCBAQCBHYW1lcGFkTWFu
YWdlcjo6R2FtZXBhZE1hbmFnZXIoKQogCiB2b2lkIEdhbWVwYWRNYW5hZ2VyOjpwbGF0Zm9ybUdh
bWVwYWRDb25uZWN0ZWQodW5zaWduZWQgaW5kZXgpCiB7Ci0gICAgZm9yIChhdXRvJiBuYXZpZ2F0
b3IgOiBtX25hdmlnYXRvcnMpCi0gICAgICAgIG5hdmlnYXRvci0+Z2FtZXBhZENvbm5lY3RlZChp
bmRleCk7CisgICAgZm9yIChhdXRvJiBuYXZpZ2F0b3IgOiBtX25hdmlnYXRvcnMpIHsKKyAgICAg
ICAgaWYgKCFtX2dhbWVwYWRCbGluZE5hdmlnYXRvcnMuY29udGFpbnMobmF2aWdhdG9yKSkKKyAg
ICAgICAgICAgIG5hdmlnYXRvci0+Z2FtZXBhZENvbm5lY3RlZChpbmRleCk7CiAKLSAgICAvLyBG
SVhNRTogRmlyZSBjb25uZWN0ZWQgZXZlbnQgdG8gYWxsIHBhZ2VzIHdpdGggbGlzdGVuZXJzLgor
ICAgICAgICAvLyBGSVhNRTogRmlyZSBjb25uZWN0ZWQgZXZlbnQgdG8gYWxsIHBhZ2VzIHdpdGgg
bGlzdGVuZXJzLgorICAgIH0KKworICAgIG1ha2VHYW1lcGFkc1Zpc2liaWxlVG9CbGluZE5hdmln
YXRvcnMoKTsKIH0KIAogdm9pZCBHYW1lcGFkTWFuYWdlcjo6cGxhdGZvcm1HYW1lcGFkRGlzY29u
bmVjdGVkKHVuc2lnbmVkIGluZGV4KQogewotICAgIC8vIEZJWE1FOiBGaXJlIGRpc2Nvbm5lY3Rl
ZCBldmVudCB0byBhbGwgcGFnZXMgd2l0aCBsaXN0ZW5lcnMuCisgICAgZm9yIChhdXRvJiBuYXZp
Z2F0b3IgOiBtX25hdmlnYXRvcnMpIHsKKyAgICAgICAgaWYgKCFtX2dhbWVwYWRCbGluZE5hdmln
YXRvcnMuY29udGFpbnMobmF2aWdhdG9yKSkKKyAgICAgICAgICAgIG5hdmlnYXRvci0+Z2FtZXBh
ZERpc2Nvbm5lY3RlZChpbmRleCk7CisKKyAgICAgICAgLy8gRklYTUU6IEZpcmUgZGlzY29ubmVj
dGVkIGV2ZW50IHRvIGFsbCBwYWdlcyB3aXRoIGxpc3RlbmVycy4KKyAgICB9Cit9CisKK3ZvaWQg
R2FtZXBhZE1hbmFnZXI6OnBsYXRmb3JtR2FtZXBhZElucHV0QWN0aXZpdHkoKQoreworICAgIG1h
a2VHYW1lcGFkc1Zpc2liaWxlVG9CbGluZE5hdmlnYXRvcnMoKTsKK30KKwordm9pZCBHYW1lcGFk
TWFuYWdlcjo6bWFrZUdhbWVwYWRzVmlzaWJpbGVUb0JsaW5kTmF2aWdhdG9ycygpCit7CisgICAg
Zm9yIChhdXRvJiBuYXZpZ2F0b3IgOiBtX2dhbWVwYWRCbGluZE5hdmlnYXRvcnMpIHsKKyAgICAg
ICAgLy8gRklYTUU6IEhlcmUgd2Ugbm90aWZ5IGEgYmxpbmQgTmF2aWdhdG9yIG9mIGVhY2ggZXhp
c3RpbmcgZ2FtZXBhZC4KKyAgICAgICAgLy8gQnV0IHdlIGFsc28gbmVlZCB0byBmaXJlIHRoZSBj
b25uZWN0ZWQgZXZlbnQgdG8gaXRzIGNvcnJlc3BvbmRpbmcgRE9NV2luZG93IG9iamVjdHMuCisg
ICAgICAgIGNvbnN0IFZlY3RvcjxQbGF0Zm9ybUdhbWVwYWQqPiYgcGxhdGZvcm1HYW1lcGFkcyA9
IEdhbWVwYWRQcm92aWRlcjo6c2hhcmVkKCkucGxhdGZvcm1HYW1lcGFkcygpOworICAgICAgICBm
b3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcGxhdGZvcm1HYW1lcGFkcy5zaXplKCk7ICsraSkgewor
ICAgICAgICAgICAgaWYgKHBsYXRmb3JtR2FtZXBhZHNbaV0pCisgICAgICAgICAgICAgICAgbmF2
aWdhdG9yLT5nYW1lcGFkQ29ubmVjdGVkKGkpOworICAgICAgICB9CisgICAgfQogCi0gICAgZm9y
IChhdXRvJiBuYXZpZ2F0b3IgOiBtX25hdmlnYXRvcnMpCi0gICAgICAgIG5hdmlnYXRvci0+Z2Ft
ZXBhZERpc2Nvbm5lY3RlZChpbmRleCk7CisgICAgbV9nYW1lcGFkQmxpbmROYXZpZ2F0b3JzLmNs
ZWFyKCk7CiB9CiAKIHZvaWQgR2FtZXBhZE1hbmFnZXI6OnJlZ2lzdGVyTmF2aWdhdG9yKE5hdmln
YXRvckdhbWVwYWQqIG5hdmlnYXRvcikKQEAgLTY4LDYgKzk0LDcgQEAgdm9pZCBHYW1lcGFkTWFu
YWdlcjo6cmVnaXN0ZXJOYXZpZ2F0b3IoTmF2aWdhdG9yR2FtZXBhZCogbmF2aWdhdG9yKQogCiAg
ICAgQVNTRVJUKCFtX25hdmlnYXRvcnMuY29udGFpbnMobmF2aWdhdG9yKSk7CiAgICAgbV9uYXZp
Z2F0b3JzLmFkZChuYXZpZ2F0b3IpOworICAgIG1fZ2FtZXBhZEJsaW5kTmF2aWdhdG9ycy5hZGQo
bmF2aWdhdG9yKTsKIAogICAgIC8vIEZJWE1FOiBNb25pdG9yaW5nIGdhbWVwYWRzIHdpbGwgYWxz
byBiZSByZWxpYW50IG9uIHdoZXRoZXIgb3Igbm90IHRoZXJlIGFyZSBhbnkKICAgICAvLyBjb25u
ZWN0ZWQvZGlzY29ubmVjdGVkIGV2ZW50IGxpc3RlbmVycy4KQEAgLTg0LDYgKzExMSw3IEBAIHZv
aWQgR2FtZXBhZE1hbmFnZXI6OnVucmVnaXN0ZXJOYXZpZ2F0b3IoTmF2aWdhdG9yR2FtZXBhZCog
bmF2aWdhdG9yKQogCiAgICAgQVNTRVJUKG1fbmF2aWdhdG9ycy5jb250YWlucyhuYXZpZ2F0b3Ip
KTsKICAgICBtX25hdmlnYXRvcnMucmVtb3ZlKG5hdmlnYXRvcik7CisgICAgbV9nYW1lcGFkQmxp
bmROYXZpZ2F0b3JzLnJlbW92ZShuYXZpZ2F0b3IpOwogCiAgICAgLy8gRklYTUU6IE1vbml0b3Jp
bmcgZ2FtZXBhZHMgd2lsbCBhbHNvIGJlIHJlbGlhbnQgb24gd2hldGhlciBvciBub3QgdGhlcmUg
YXJlIGFueQogICAgIC8vIGNvbm5lY3RlZC9kaXNjb25uZWN0ZWQgZXZlbnQgbGlzdGVuZXJzLgpk
aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nYW1lcGFkL0dhbWVwYWRNYW5hZ2Vy
LmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVwYWQvR2FtZXBhZE1hbmFnZXIuaAppbmRl
eCBiYmZjN2I3Li5jZTJmZDRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dh
bWVwYWQvR2FtZXBhZE1hbmFnZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dhbWVw
YWQvR2FtZXBhZE1hbmFnZXIuaApAQCAtNDYsNiArNDYsNyBAQCBwdWJsaWM6CiAKICAgICB2aXJ0
dWFsIHZvaWQgcGxhdGZvcm1HYW1lcGFkQ29ubmVjdGVkKHVuc2lnbmVkIGluZGV4KSBvdmVycmlk
ZSBmaW5hbDsKICAgICB2aXJ0dWFsIHZvaWQgcGxhdGZvcm1HYW1lcGFkRGlzY29ubmVjdGVkKHVu
c2lnbmVkIGluZGV4KSBvdmVycmlkZSBmaW5hbDsKKyAgICB2aXJ0dWFsIHZvaWQgcGxhdGZvcm1H
YW1lcGFkSW5wdXRBY3Rpdml0eSgpIG92ZXJyaWRlIGZpbmFsOwogCiAgICAgdm9pZCByZWdpc3Rl
ck5hdmlnYXRvcihOYXZpZ2F0b3JHYW1lcGFkKik7CiAgICAgdm9pZCB1bnJlZ2lzdGVyTmF2aWdh
dG9yKE5hdmlnYXRvckdhbWVwYWQqKTsKQEAgLTUzLDcgKzU0LDEwIEBAIHB1YmxpYzoKIHByaXZh
dGU6CiAgICAgR2FtZXBhZE1hbmFnZXIoKTsKIAorICAgIHZvaWQgbWFrZUdhbWVwYWRzVmlzaWJp
bGVUb0JsaW5kTmF2aWdhdG9ycygpOworCiAgICAgSGFzaFNldDxOYXZpZ2F0b3JHYW1lcGFkKj4g
bV9uYXZpZ2F0b3JzOworICAgIEhhc2hTZXQ8TmF2aWdhdG9yR2FtZXBhZCo+IG1fZ2FtZXBhZEJs
aW5kTmF2aWdhdG9yczsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0dhbWVwYWRQcm92aWRlckNsaWVudC5oIGIvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vR2FtZXBhZFByb3ZpZGVyQ2xpZW50LmgKaW5kZXggNWM3OWQzMC4u
MDgxMGEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vR2FtZXBhZFByb3Zp
ZGVyQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vR2FtZXBhZFByb3ZpZGVy
Q2xpZW50LmgKQEAgLTM2LDYgKzM2LDcgQEAgcHVibGljOgogCiAgICAgdmlydHVhbCB2b2lkIHBs
YXRmb3JtR2FtZXBhZENvbm5lY3RlZCh1bnNpZ25lZCBpbmRleCkgPSAwOwogICAgIHZpcnR1YWwg
dm9pZCBwbGF0Zm9ybUdhbWVwYWREaXNjb25uZWN0ZWQodW5zaWduZWQgaW5kZXgpID0gMDsKKyAg
ICB2aXJ0dWFsIHZvaWQgcGxhdGZvcm1HYW1lcGFkSW5wdXRBY3Rpdml0eSgpID0gMDsKIH07CiAK
IH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm
b3JtL21hYy9ISURHYW1lcGFkUHJvdmlkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
bWFjL0hJREdhbWVwYWRQcm92aWRlci5jcHAKaW5kZXggZDlkN2E5YS4uZGRmN2MzMiAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWRQcm92aWRlci5jcHAK
KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hJREdhbWVwYWRQcm92aWRlci5jcHAK
QEAgLTM1LDYgKzM1LDcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGNvbnN0IGRv
dWJsZSBDb25uZWN0aW9uRGVsYXlJbnRlcnZhbCA9IDAuNTsKK3N0YXRpYyBjb25zdCBkb3VibGUg
SW5wdXROb3RpZmljYXRpb25EZWxheSA9IDAuMDU7CiAKIHN0YXRpYyBSZXRhaW5QdHI8Q0ZEaWN0
aW9uYXJ5UmVmPiBkZXZpY2VNYXRjaGluZ0RpY3Rpb25hcnkodWludDMyX3QgdXNhZ2VQYWdlLCB1
aW50MzJfdCB1c2FnZSkKIHsKQEAgLTgxLDYgKzgyLDcgQEAgSElER2FtZXBhZFByb3ZpZGVyJiBI
SURHYW1lcGFkUHJvdmlkZXI6OnNoYXJlZCgpCiBISURHYW1lcGFkUHJvdmlkZXI6OkhJREdhbWVw
YWRQcm92aWRlcigpCiAgICAgOiBtX3Nob3VsZERpc3BhdGNoQ2FsbGJhY2tzKGZhbHNlKQogICAg
ICwgbV9jb25uZWN0aW9uRGVsYXlUaW1lcih0aGlzLCAmSElER2FtZXBhZFByb3ZpZGVyOjpjb25u
ZWN0aW9uRGVsYXlUaW1lckZpcmVkKQorICAgICwgbV9pbnB1dE5vdGlmaWNhdGlvblRpbWVyKHRo
aXMsICZISURHYW1lcGFkUHJvdmlkZXI6OmlucHV0Tm90aWZpY2F0aW9uVGltZXJGaXJlZCkKIHsK
ICAgICBtX21hbmFnZXIgPSBhZG9wdENGKElPSElETWFuYWdlckNyZWF0ZShrQ0ZBbGxvY2F0b3JE
ZWZhdWx0LCBrSU9ISURPcHRpb25zVHlwZU5vbmUpKTsKIApAQCAtMjA4LDYgKzIxMCwxOCBAQCB2
b2lkIEhJREdhbWVwYWRQcm92aWRlcjo6dmFsdWVzQ2hhbmdlZChJT0hJRFZhbHVlUmVmIHZhbHVl
KQogICAgICAgICByZXR1cm47CiAKICAgICBnYW1lcGFkLT52YWx1ZUNoYW5nZWQodmFsdWUpOwor
CisgICAgaWYgKCFtX2lucHV0Tm90aWZpY2F0aW9uVGltZXIuaXNBY3RpdmUoKSkKKyAgICAgICAg
bV9pbnB1dE5vdGlmaWNhdGlvblRpbWVyLnN0YXJ0T25lU2hvdChJbnB1dE5vdGlmaWNhdGlvbkRl
bGF5KTsKK30KKwordm9pZCBISURHYW1lcGFkUHJvdmlkZXI6OmlucHV0Tm90aWZpY2F0aW9uVGlt
ZXJGaXJlZChUaW1lcjxISURHYW1lcGFkUHJvdmlkZXI+JikKK3sKKyAgICBpZiAoIW1fc2hvdWxk
RGlzcGF0Y2hDYWxsYmFja3MpCisgICAgICAgIHJldHVybjsKKworICAgIGZvciAoYXV0byYgY2xp
ZW50IDogbV9jbGllbnRzKQorICAgICAgICBjbGllbnQtPnBsYXRmb3JtR2FtZXBhZElucHV0QWN0
aXZpdHkoKTsKIH0KIAogc3RkOjpwYWlyPHN0ZDo6dW5pcXVlX3B0cjxISURHYW1lcGFkPiwgdW5z
aWduZWQ+ICBISURHYW1lcGFkUHJvdmlkZXI6OnJlbW92ZUdhbWVwYWRGb3JEZXZpY2UoSU9ISURE
ZXZpY2VSZWYgZGV2aWNlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj
L0hJREdhbWVwYWRQcm92aWRlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0hJREdh
bWVwYWRQcm92aWRlci5oCmluZGV4IDcyNGVlY2UuLjRjM2QxNjIgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9ISURHYW1lcGFkUHJvdmlkZXIuaAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9tYWMvSElER2FtZXBhZFByb3ZpZGVyLmgKQEAgLTY1LDYgKzY1LDcg
QEAgcHJpdmF0ZToKICAgICB2b2lkIGNsb3NlQW5kVW5zY2hlZHVsZU1hbmFnZXIoKTsKIAogICAg
IHZvaWQgY29ubmVjdGlvbkRlbGF5VGltZXJGaXJlZChUaW1lcjxISURHYW1lcGFkUHJvdmlkZXI+
Jik7CisgICAgdm9pZCBpbnB1dE5vdGlmaWNhdGlvblRpbWVyRmlyZWQoVGltZXI8SElER2FtZXBh
ZFByb3ZpZGVyPiYpOwogCiAgICAgdW5zaWduZWQgaW5kZXhGb3JOZXdseUNvbm5lY3RlZERldmlj
ZSgpOwogCkBAIC03Nyw2ICs3OCw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX3Nob3VsZERpc3Bh
dGNoQ2FsbGJhY2tzOwogCiAgICAgVGltZXI8SElER2FtZXBhZFByb3ZpZGVyPiBtX2Nvbm5lY3Rp
b25EZWxheVRpbWVyOworICAgIFRpbWVyPEhJREdhbWVwYWRQcm92aWRlcj4gbV9pbnB1dE5vdGlm
aWNhdGlvblRpbWVyOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=
</data>
<flag name="review"
          id="258493"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>