133150 2014-05-21 01:58:59 -0700 REGRESSION transform-origin doesn't take zoom into account correctly for SVG content 2024-09-17 06:39:50 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 194903 https://bugs.webkit.org/show_bug.cgi?id=258615 http://jsfiddle.net/cpkSp/ P2 Normal --- 1 krit webkit-unassigned ahmad.saleem792 fotis.papadogeorgopoulos fujii govett zimmermann oldest_to_newest 1010723 0 krit 2014-05-21 01:58:59 -0700 In the following fiddle, the transform-origin doesn't apply the value of the zoom property (or CMD+/CMD-) correctly. It seems that the origin stays at the same position as without zoom. Note: it works correctly in Safari 7. I don't know the regression window yet. Must be a problem in 2013 or earlier though. http://jsfiddle.net/cpkSp/ 1010724 1 krit 2014-05-21 02:02:17 -0700 Additional information: This problem just occurs for percentage values. Pixel values are scaled correctly. Which, on the other hand, doesn't work correctly in Safari 7. 1923857 2 ahmad.saleem792 2023-01-07 15:26:25 -0800 It is still happening in Safari 16.2 & STP160 using JSFiddle from Comment 0 and it is fixed in following commit by Blink: Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=174907 WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGGraphicsElement.cpp#98 There are fixes in LBSE so I don't know whether it is already fixed in LBSE or not? Appreciate if @Nikolaz can confirm. Thanks! 1955294 3 ahmad.saleem792 2023-05-14 03:32:44 -0700 (In reply to Ahmad Saleem from comment #2) > It is still happening in Safari 16.2 & STP160 using JSFiddle from Comment 0 > and it is fixed in following commit by Blink: > > Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=174907 > > WebKit Source - > https://searchfox.org/wubkat/source/Source/WebCore/svg/SVGGraphicsElement. > cpp#98 > > There are fixes in LBSE so I don't know whether it is already fixed in LBSE > or not? Appreciate if @Nikolaz can confirm. Thanks! I applied this locally and this does fix the attached test case but the attached testcase with the commit does not work. 2035588 4 ahmad.saleem792 2024-05-15 11:34:26 -0700 Blink Commit (from GitHub Repo - Chromium) - https://github.com/chromium/chromium/commit/56ca23de0ae12871406e53753d71c2237551ac24 2035659 5 ahmad.saleem792 2024-05-15 16:11:14 -0700 // Honor any of the transform-related CSS properties if set. if (hasSpecifiedTransform || (style && (style->translate() || style->scale() || style->rotate()))) { TransformationMatrix transform; float zoom = style->usedZoom(); // CSS transforms operate with pre-scaled lengths. To make this work with SVG // (which applies the zoom factor globally, at the root level) we // // * pre-scale the bounding box (to bring it into the same space as the other CSS values) // * invert the zoom factor (to effectively compute the CSS transform under a 1.0 zoom) // // Note: objectBoundingBox is an emptyRect for elements like pattern or clipPath. // See the "Object bounding box units" section of http://dev.w3.org/csswg/css3-transforms/ if (zoom != 1) { FloatRect scaledBBox = renderer->transformReferenceBoxRect(); scaledBBox.scale(zoom); transform.scale(1 / zoom); style->applyTransform(transform, TransformOperationData(scaledBBox, renderer.get())); transform.scale(zoom); } else style->applyTransform(transform, TransformOperationData(renderer->transformReferenceBoxRect(), renderer.get())); ___ This compiles and fix attach test case. 2060587 6 govett 2024-09-16 16:13:33 -0700 Just ran into this too. Ahmad, did you submit a PR with your patch? 2060592 7 fujii 2024-09-16 16:40:03 -0700 281265@main fixed the problem. 2060597 8 fujii 2024-09-16 16:47:41 -0700 *** This bug has been marked as a duplicate of bug 194903 *** 2060621 9 govett 2024-09-16 17:35:47 -0700 Oh thanks! I can verify that it is fixed in the latest Safari tech preview. 2060758 10 ahmad.saleem792 2024-09-17 06:39:50 -0700 (In reply to Devon Govett from comment #9) > Oh thanks! I can verify that it is fixed in the latest Safari tech preview. I think Fuji fixed it and you should test on Safari Technology Preview. Only bit missing would be SVG text but I haven't test it yet.