131831 2014-04-17 17:31:10 -0700 [EFL][WK2] Changing page zoom factor does not work correctly if fixed layout is used. 2017-03-11 10:32:31 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 126022 131962 1 enmi.lee enmi.lee bunhere cdumez commit-queue gyuyoung.kim gyuyoung.kim hh.kaka lucas.de.marchi man.zhong mcatanzaro sergio oldest_to_newest 1001769 0 enmi.lee 2014-04-17 17:31:10 -0700 We can test changing page zoom factor with fixed layout using MiniBrowser as follow option. > MiniBrowser -L 1 But it does not work correctly - page is not zoomed correctly. It's caused by fitting logic of PageViewportController. solution: 1. set user interaction if page zoom is changed. 2. use content size which does not apply page zoom factor. 1001774 1 229601 enmi.lee 2014-04-17 17:41:06 -0700 Created attachment 229601 Patch 1005320 2 229601 gyuyoung.kim 2014-04-30 00:40:35 -0700 Comment on attachment 229601 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229601&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:246 > + impl->pageViewportController().setHadUserInteraction(true); I don't think we have to set "true" whenever ewk_view_page_zoom_set() is called. Shouldn't we call it only one time ? 1005341 3 229601 enmi.lee 2014-04-30 03:46:55 -0700 Comment on attachment 229601 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229601&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:246 >> + impl->pageViewportController().setHadUserInteraction(true); > > I don't think we have to set "true" whenever ewk_view_page_zoom_set() is called. Shouldn't we call it only one time ? we can check hadUserInteraction value and set true only if it is false. I will update patch. 1005344 4 229601 gyuyoung.kim 2014-04-30 04:12:23 -0700 Comment on attachment 229601 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229601&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:3055 > + // We have to find better solution. Eunmi, as you know, this looks one of workaround solutions. I'm also investigating how to solve this problem fundamentally. If you have spare time with your nice condition, please take a look fundamental problem. 1005345 5 229601 gyuyoung.kim 2014-04-30 04:14:46 -0700 Comment on attachment 229601 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229601&action=review >> Source/WebKit2/UIProcess/WebPageProxy.cpp:3055 >> + // We have to find better solution. > > Eunmi, as you know, this looks one of workaround solutions. I'm also investigating how to solve this problem fundamentally. If you have spare time with your nice condition, please take a look fundamental problem. One more comment: I also think that page zoom on fixed layout should work same as "fixed layout is off". 1005347 6 229601 gyuyoung.kim 2014-04-30 04:25:57 -0700 Comment on attachment 229601 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=229601&action=review >>> Source/WebKit2/UIProcess/WebPageProxy.cpp:3055 >>> + // We have to find better solution. >> >> Eunmi, as you know, this looks one of workaround solutions. I'm also investigating how to solve this problem fundamentally. If you have spare time with your nice condition, please take a look fundamental problem. > > One more comment: I also think that page zoom on fixed layout should work same as "fixed layout is off". Second comment: RenderView::viewWidth() and RenderView::viewHeight() value have been affected by on/off of fixedlayout. When fixed layout is on, with/height look be multiplied by pageZoomFactor. If we don't apply effectiveZoom(), when the fixed layout is enabled without this patch, page zoom works as it is off. int RenderView::viewWidth() const { int width = 0; if (!shouldUsePrintingLayout()) { width = frameView().layoutWidth(); width = frameView().useFixedLayout() ? ceilf(style().effectiveZoom() * float(width)) : width; } ... } RenderView::viewWidth() http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderView.cpp#L1109 1005681 7 230568 enmi.lee 2014-05-01 00:08:53 -0700 Created attachment 230568 Patch 1007936 8 230568 gyuyoung.kim 2014-05-09 03:36:06 -0700 Comment on attachment 230568 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230568&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:3119 > + newSize.scale(1 / m_pageZoomFactor); As mentioned in comment #6, RenderView::viewWidth/Height() multiplies the pageZoomFactor(= effectiveZoom()) with width/height when fixed layout is enabled. So, I think we need to check if the calculation logic is correct from EFL port perspective. I think this patch looks a workaround patch. I'd like to clear r?,cq? until finishing the investigation. 1286185 9 mcatanzaro 2017-03-11 10:32:31 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 229601 2014-04-17 17:41:06 -0700 2014-05-01 00:08:43 -0700 Patch bug-131831-20140418094047.patch text/plain 2835 enmi.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3MjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjRhNzBkZmVjNjNlYzM1 MTNmYTk3NjJlOTNjMzFhZWY1OWQwMjkxNC4uYWExOGZlZmU5OTdkMjQ4OTI5NWUwYTE4ZjQ4ZWFj MTJiMWMxYTk1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA0LTE3ICBFdW5t aSBMZWUgIDxldW5taTE1LmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIENo YW5naW5nIHBhZ2Ugem9vbSBmYWN0b3IgZG9lcyBub3Qgd29yayBjb3JyZWN0bHkgaWYgZml4ZWQg bGF5b3V0IGlzIHVzZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzE4MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2luZyBwYWdlIHpvb20gZmFjdG9yIGRvZXMgbm90IHdvcmsgY29ycmVjdGx5 IHdpdGgKKyAgICAgICAgUGFnZVZpZXdwb3J0Q29udHJvbGxlcidzIGZpdHRpbmcgbG9naWMuCisg ICAgICAgIFNvIHdlIG5lZWQgdG8gc2V0IGNvcnJlY3QgdmFsdWVzIHRvIHRoZSBQYWdlVmlld3Bv cnRDb250cm9sZXIuCisKKyAgICAgICAgU2V0IHVzZXIgaW50ZXJhY3Rpb24gdmFsdWUgdG8gdHJ1 ZSB3aGVuIHBhZ2Ugem9vbSBmYWN0b3IgaXMgY2hhbmdlZCBieQorICAgICAgICBBUEkgdG8gcHJl dmVudCB0byBmaXR0aW5nIHdoZW4gY3VycmVudCBwYWdlIGlzIGZpdHRlZCB0byB0aGUgdmlldyB3 aWR0aC4KKyAgICAgICAgVXNlIGNvbnRlbnQgc2l6ZSB3aGljaCBkb2VzIG5vdCBhcHBseSBwYWdl IHpvb20gZmFjdG9yIHRvIHByZXZlbnQgdG8KKyAgICAgICAgZml0dGluZyB3aGVuIGNvbnRlbnQg c2l6ZSBpcyBzbWFsbGVyIHRoZW4gdmlldyB3aWR0aC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X3BhZ2Vfem9vbV9zZXQpOgor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlUHJveHk6OmRpZENoYW5nZUNvbnRlbnRTaXplKToKKwogMjAxNC0wNC0xMyAgQW5keSBF c3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW1F1aWNrTG9va10gTW92ZSBmaWxl IHN5c3RlbS1yZWxhdGVkIGNvZGUgaW50byBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCA4NmNjNmIzMTU5ZDEyM2E0NWRkOGM1ZDJm NjlmOTllNWNiZmNkNmQ1Li5iNDJkOGUyOTE4ZWU3MDM0MzVkZDEyNjc0ZjJhOWMwMmMwOWFiYTg5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBA IC0yNDMsNiArMjQzLDcgQEAgRWluYV9Cb29sIGV3a192aWV3X3BhZ2Vfem9vbV9zZXQoRXZhc19P YmplY3QqIGV3a1ZpZXcsIGRvdWJsZSB6b29tRmFjdG9yKQogICAgIEVXS19WSUVXX0lNUExfR0VU X09SX1JFVFVSTihld2tWaWV3LCBpbXBsLCBmYWxzZSk7CiAKICAgICBXS1BhZ2VTZXRQYWdlWm9v bUZhY3RvcihpbXBsLT53a1BhZ2UoKSwgem9vbUZhY3Rvcik7CisgICAgaW1wbC0+cGFnZVZpZXdw b3J0Q29udHJvbGxlcigpLnNldEhhZFVzZXJJbnRlcmFjdGlvbih0cnVlKTsKIAogICAgIHJldHVy biB0cnVlOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRl eCAzY2M3MTA1ZGIxMDEzZDFjZDc5M2MyNjA3YzNiMGIyZDU5OTE5MTE0Li42NDI1NjU3NWM0M2Q0 ZGU1ZGQyOWE0ZmEwYTEwODFhMjgzMzJlNmUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcApAQCAtMzA0OSw3ICszMDQ5LDE0IEBAIHZvaWQgV2ViUGFnZVByb3h5 OjpoYW5kbGVEb3dubG9hZFJlcXVlc3QoRG93bmxvYWRQcm94eSogZG93bmxvYWQpCiAjaWYgUExB VEZPUk0oRUZMKQogdm9pZCBXZWJQYWdlUHJveHk6OmRpZENoYW5nZUNvbnRlbnRTaXplKGNvbnN0 IEludFNpemUmIHNpemUpCiB7Ci0gICAgbV9wYWdlQ2xpZW50LmRpZENoYW5nZUNvbnRlbnRTaXpl KHNpemUpOworICAgIC8vIEZJWE1FOiBJZiBmaXhlZCBsYXlvdXQgaXMgdXNlZCwgY29udGVudCBz aXplIGlzIG11bHRpcGxpZWQgd2l0aCBwYWdlWm9vbUZhY3RvciwKKyAgICAvLyBidXQgd2Ugd2Fu dCB0byBnZXQgY29udGVudCBzaXplIHdoaWNoIGRvZXMgbm90IGFwcGx5IHBhZ2Vab29tRmFjdG9y IGhlcmUsCisgICAgLy8gc28gZGl2aWRlIGNvbnRlbnQgc2l6ZSB3aXRoIHBhZ2Vab29tRmFjdG9y IGFnYWluLgorICAgIC8vIFdlIGhhdmUgdG8gZmluZCBiZXR0ZXIgc29sdXRpb24uCisgICAgSW50 U2l6ZSBuZXdTaXplID0gc2l6ZTsKKyAgICBpZiAobV91c2VGaXhlZExheW91dCkKKyAgICAgICAg bmV3U2l6ZS5zY2FsZSgxIC8gbV9wYWdlWm9vbUZhY3Rvcik7CisgICAgbV9wYWdlQ2xpZW50LmRp ZENoYW5nZUNvbnRlbnRTaXplKG5ld1NpemUpOwogfQogI2VuZGlmCiAK 230568 2014-05-01 00:08:53 -0700 2014-05-09 03:36:05 -0700 Patch bug-131831-20140501160829.patch text/plain 2911 enmi.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTY3OTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2Q1YjAzNDY5ZWI2Yjc1 YjE2ODFlMjFhMGFhYjYxOWE0Nzg5MWI4Ny4uZWY1ZThhNjY5YThhZTkyODNmOWEzMTA4M2U0YTYw YjM4MDNjNWI3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA1LTAxICBFdW5t aSBMZWUgIDxldW5taTE1LmxlZUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIENo YW5naW5nIHBhZ2Ugem9vbSBmYWN0b3IgZG9lcyBub3Qgd29yayBjb3JyZWN0bHkgaWYgZml4ZWQg bGF5b3V0IGlzIHVzZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzE4MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDaGFuZ2luZyBwYWdlIHpvb20gZmFjdG9yIGRvZXMgbm90IHdvcmsgY29ycmVjdGx5 IHdpdGgKKyAgICAgICAgUGFnZVZpZXdwb3J0Q29udHJvbGxlcidzIGZpdHRpbmcgbG9naWMuCisg ICAgICAgIFNvIHdlIG5lZWQgdG8gc2V0IGNvcnJlY3QgdmFsdWVzIHRvIHRoZSBQYWdlVmlld3Bv cnRDb250cm9sZXIuCisKKyAgICAgICAgU2V0IHVzZXIgaW50ZXJhY3Rpb24gdmFsdWUgdG8gdHJ1 ZSB3aGVuIHBhZ2Ugem9vbSBmYWN0b3IgaXMgY2hhbmdlZCBieQorICAgICAgICBBUEkgdG8gcHJl dmVudCB0byBmaXR0aW5nIHdoZW4gY3VycmVudCBwYWdlIGlzIGZpdHRlZCB0byB0aGUgdmlldyB3 aWR0aC4KKyAgICAgICAgVXNlIGNvbnRlbnQgc2l6ZSB3aGljaCBkb2VzIG5vdCBhcHBseSBwYWdl IHpvb20gZmFjdG9yIHRvIHByZXZlbnQgdG8KKyAgICAgICAgZml0dGluZyB3aGVuIGNvbnRlbnQg c2l6ZSBpcyBzbWFsbGVyIHRoZW4gdmlldyB3aWR0aC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKGV3a192aWV3X3BhZ2Vfem9vbV9zZXQpOgor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJQYWdlUHJveHk6OmRpZENoYW5nZUNvbnRlbnRTaXplKToKKwogMjAxNC0wNC0zMCAgTWFudWVs IFJlZ28gQ2FzYXNub3ZhcyAgPHJlZ29AaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQg TGF5b3V0XSBFbmFibGUgcnVudGltZSBmZWF0dXJlIGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAppbmRleCBlZmY2NmMzN2RlOWRjNjUx Y2IyMTc5NTNjODY5NmY4MGY4Y2VjN2M4Li5hYjdmYmNmMDQ5MmQzOTczZGY4ZWM3M2NkOGVhYmQ4 NWFjMzVmOTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3Zp ZXcuY3BwCkBAIC0yMzIsNiArMjMyLDggQEAgRWluYV9Cb29sIGV3a192aWV3X3BhZ2Vfem9vbV9z ZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGRvdWJsZSB6b29tRmFjdG9yKQogICAgIEVXS19WSUVX X0lNUExfR0VUX09SX1JFVFVSTihld2tWaWV3LCBpbXBsLCBmYWxzZSk7CiAKICAgICBXS1BhZ2VT ZXRQYWdlWm9vbUZhY3RvcihpbXBsLT53a1BhZ2UoKSwgem9vbUZhY3Rvcik7CisgICAgaWYgKCFp bXBsLT5wYWdlVmlld3BvcnRDb250cm9sbGVyKCkuaGFkVXNlckludGVyYWN0aW9uKCkpCisgICAg ICAgIGltcGwtPnBhZ2VWaWV3cG9ydENvbnRyb2xsZXIoKS5zZXRIYWRVc2VySW50ZXJhY3Rpb24o dHJ1ZSk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHAKaW5kZXggNWMyYjlmYzM2NmJhYjJiM2IyM2RmZjE5ODk1Y2Q4NTU5NDMz ZTRjYy4uMjkwNDY1ODAwOGYwNDc1MDQ5MWU2ZjcxNDE3NDUxYzdiZjdiOGU3YSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTMxMTAsNyArMzExMCwxNCBA QCB2b2lkIFdlYlBhZ2VQcm94eTo6aGFuZGxlRG93bmxvYWRSZXF1ZXN0KERvd25sb2FkUHJveHkq IGRvd25sb2FkKQogI2lmIFBMQVRGT1JNKEVGTCkKIHZvaWQgV2ViUGFnZVByb3h5OjpkaWRDaGFu Z2VDb250ZW50U2l6ZShjb25zdCBJbnRTaXplJiBzaXplKQogewotICAgIG1fcGFnZUNsaWVudC5k aWRDaGFuZ2VDb250ZW50U2l6ZShzaXplKTsKKyAgICAvLyBGSVhNRTogSWYgZml4ZWQgbGF5b3V0 IGlzIHVzZWQsIGNvbnRlbnQgc2l6ZSBpcyBtdWx0aXBsaWVkIHdpdGggcGFnZVpvb21GYWN0b3Is CisgICAgLy8gYnV0IHdlIHdhbnQgdG8gZ2V0IGNvbnRlbnQgc2l6ZSB3aGljaCBkb2VzIG5vdCBh cHBseSBwYWdlWm9vbUZhY3RvciBoZXJlLAorICAgIC8vIHNvIGRpdmlkZSBjb250ZW50IHNpemUg d2l0aCBwYWdlWm9vbUZhY3RvciBhZ2Fpbi4KKyAgICAvLyBXZSBoYXZlIHRvIGZpbmQgYmV0dGVy IHNvbHV0aW9uLgorICAgIEludFNpemUgbmV3U2l6ZSA9IHNpemU7CisgICAgaWYgKG1fdXNlRml4 ZWRMYXlvdXQpCisgICAgICAgIG5ld1NpemUuc2NhbGUoMSAvIG1fcGFnZVpvb21GYWN0b3IpOwor ICAgIG1fcGFnZUNsaWVudC5kaWRDaGFuZ2VDb250ZW50U2l6ZShuZXdTaXplKTsKIH0KICNlbmRp ZgogCg==