131035 2014-04-01 07:17:15 -0700 [CSS Regions] Simplify the RenderFlowThread state pusher 2014-04-01 22:37:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 57312 1 abucur abucur commit-queue esprehn+autocc glenn kondapallykalyan WebkitBugTracker oldest_to_newest 996257 0 abucur 2014-04-01 07:17:15 -0700 The state pusher for render flow threads is used sub optimally, before the view pushes the layout state so the two are desynchronised. Create a patch to correct this. 996263 1 228285 abucur 2014-04-01 07:29:41 -0700 Created attachment 228285 Patch 996392 2 228285 hyatt 2014-04-01 12:45:32 -0700 Comment on attachment 228285 Patch r=me 996589 3 228285 commit-queue 2014-04-01 22:37:20 -0700 Comment on attachment 228285 Patch Clearing flags on attachment: 228285 Committed r166631: <http://trac.webkit.org/changeset/166631> 996590 4 commit-queue 2014-04-01 22:37:24 -0700 All reviewed patches have been landed. Closing bug. 228285 2014-04-01 07:29:41 -0700 2014-04-01 22:37:20 -0700 Patch bug-131035-20140401172920.patch text/plain 5969 abucur U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWUxOTU2MjQ3MTU4NmZm YWYyZDZlNGM4Nzg2ZjUzNTkyMmE2ZTI3YS4uMDM3NzRmYjhiZjQxNGRiODM1NDBmZmEzMzdmZWE0 NTMzZjI5MDFiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA0LTAxICBBbmRy ZWkgQnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgUmVnaW9uc10gU2lt cGxpZnkgdGhlIFJlbmRlckZsb3dUaHJlYWQgc3RhdGUgcHVzaGVyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzEwMzUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgUmVuZGVyRmxvd1RocmVhZCBzdGF0 ZSBwdXNoZXIgaXMgZGVzeW5jaHJvbml6ZWQgZnJvbSB0aGUgUmVuZGVyVmlldyBsYXlvdXQgc3Rh dGUgcHVzaGVyCisgICAgICAgIGJ5IG9uZSByZW5kZXJlci4gVGhpcyBwYXRjaCBmaXhlcyB0aGUg YW5vbWFseSBieSBjb3JyZWN0bHkgb3JkZXJpbmcgdGhlIHB1c2ggYW5kIHBvcCBvcGVyYXRpb25z CisgICAgICAgIGJldHdlZW4gdGhlIHR3byBzeXN0ZW1zLgorCisgICAgICAgIFRlc3RzOiBubyBm dW5jdGlvbmFsIGNoYW5nZSwgbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlckZsb3dUaHJlYWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxvd1RocmVhZDo6 cHVzaEZsb3dUaHJlYWRMYXlvdXRTdGF0ZSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbG93 VGhyZWFkOjpwb3BGbG93VGhyZWFkTGF5b3V0U3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyRmxvd1RocmVhZDo6b2Zmc2V0RnJvbUxvZ2ljYWxUb3BPZkZpcnN0UmVnaW9uKToKKyAgICAg ICAgKiByZW5kZXJpbmcvUmVuZGVyVmlldy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJW aWV3OjpwdXNoTGF5b3V0U3RhdGUpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3Lmg6 CisKIDIwMTQtMDQtMDEgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBTdWJwaXhlbCByZW5kZXJpbmc6IFRyYW5zaXRpb24gY2xhc3MgSW1hZ2UgKGFuZCBpdHMgZGVw ZW5kZW5jaWVzKSBmcm9tIGludCB0byBmbG9hdCB0byBlbmFibGUgc3VicGl4ZWwgcG9zaXRpb25l ZC9zaXplZCBpbWFnZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRmxvd1RocmVhZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1Ro cmVhZC5jcHAKaW5kZXggMWRmMjZiMDVmYjgzMGQ3NGE4NDUzNDkxMmE5NjZkYmMxYzNkYWE2NC4u NWI0ZGM3MWVmN2JjMjA0YzExOWQzNGZmZTBkZTVjZWQ4YjRjYmI2YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcApAQCAtMTE0NCw2ICsxMTQ0LDgg QEAgY29uc3QgUmVuZGVyQm94KiBSZW5kZXJGbG93VGhyZWFkOjpjdXJyZW50QWN0aXZlUmVuZGVy Qm94KCkgY29uc3QKIAogdm9pZCBSZW5kZXJGbG93VGhyZWFkOjpwdXNoRmxvd1RocmVhZExheW91 dFN0YXRlKGNvbnN0IFJlbmRlck9iamVjdCYgb2JqZWN0KQogeworICAgIG1fYWN0aXZlT2JqZWN0 c1N0YWNrLmFkZCgmb2JqZWN0KTsKKwogICAgIGlmIChjb25zdCBSZW5kZXJCb3gqIGN1cnJlbnRC b3hEZXNjZW5kYW50ID0gY3VycmVudEFjdGl2ZVJlbmRlckJveCgpKSB7CiAgICAgICAgIExheW91 dFN0YXRlKiBsYXlvdXRTdGF0ZSA9IGN1cnJlbnRCb3hEZXNjZW5kYW50LT52aWV3KCkubGF5b3V0 U3RhdGUoKTsKICAgICAgICAgaWYgKGxheW91dFN0YXRlICYmIGxheW91dFN0YXRlLT5pc1BhZ2lu YXRlZCgpKSB7CkBAIC0xMTUyLDE5ICsxMTU0LDE3IEBAIHZvaWQgUmVuZGVyRmxvd1RocmVhZDo6 cHVzaEZsb3dUaHJlYWRMYXlvdXRTdGF0ZShjb25zdCBSZW5kZXJPYmplY3QmIG9iamVjdCkKICAg ICAgICAgICAgIHNldE9mZnNldEZyb21Mb2dpY2FsVG9wT2ZGaXJzdFJlZ2lvbihjdXJyZW50Qm94 RGVzY2VuZGFudCwgY3VycmVudEJveERlc2NlbmRhbnQtPmlzSG9yaXpvbnRhbFdyaXRpbmdNb2Rl KCkgPyBvZmZzZXREZWx0YS5oZWlnaHQoKSA6IG9mZnNldERlbHRhLndpZHRoKCkpOwogICAgICAg ICB9CiAgICAgfQotCi0gICAgbV9hY3RpdmVPYmplY3RzU3RhY2suYWRkKCZvYmplY3QpOwogfQog CiB2b2lkIFJlbmRlckZsb3dUaHJlYWQ6OnBvcEZsb3dUaHJlYWRMYXlvdXRTdGF0ZSgpCiB7Ci0g ICAgbV9hY3RpdmVPYmplY3RzU3RhY2sucmVtb3ZlTGFzdCgpOwotCiAgICAgaWYgKGNvbnN0IFJl bmRlckJveCogY3VycmVudEJveERlc2NlbmRhbnQgPSBjdXJyZW50QWN0aXZlUmVuZGVyQm94KCkp IHsKICAgICAgICAgTGF5b3V0U3RhdGUqIGxheW91dFN0YXRlID0gY3VycmVudEJveERlc2NlbmRh bnQtPnZpZXcoKS5sYXlvdXRTdGF0ZSgpOwogICAgICAgICBpZiAobGF5b3V0U3RhdGUgJiYgbGF5 b3V0U3RhdGUtPmlzUGFnaW5hdGVkKCkpCiAgICAgICAgICAgICBjbGVhck9mZnNldEZyb21Mb2dp Y2FsVG9wT2ZGaXJzdFJlZ2lvbihjdXJyZW50Qm94RGVzY2VuZGFudCk7CiAgICAgfQorCisgICAg bV9hY3RpdmVPYmplY3RzU3RhY2sucmVtb3ZlTGFzdCgpOwogfQogCiBMYXlvdXRVbml0IFJlbmRl ckZsb3dUaHJlYWQ6Om9mZnNldEZyb21Mb2dpY2FsVG9wT2ZGaXJzdFJlZ2lvbihjb25zdCBSZW5k ZXJCbG9jayogY3VycmVudEJsb2NrKSBjb25zdApAQCAtMTE3NCwxNiArMTE3NCw2IEBAIExheW91 dFVuaXQgUmVuZGVyRmxvd1RocmVhZDo6b2Zmc2V0RnJvbUxvZ2ljYWxUb3BPZkZpcnN0UmVnaW9u KGNvbnN0IFJlbmRlckJsb2NrCiAgICAgaWYgKGhhc0NhY2hlZE9mZnNldEZyb21Mb2dpY2FsVG9w T2ZGaXJzdFJlZ2lvbihjdXJyZW50QmxvY2spKQogICAgICAgICByZXR1cm4gY2FjaGVkT2Zmc2V0 RnJvbUxvZ2ljYWxUb3BPZkZpcnN0UmVnaW9uKGN1cnJlbnRCbG9jayk7CiAKLSAgICAvLyBJZiBp dCdzIHRoZSBjdXJyZW50IGJveCBiZWluZyBsYWlkIG91dCwgdXNlIHRoZSBsYXlvdXQgc3RhdGUu Ci0gICAgY29uc3QgUmVuZGVyQm94KiBjdXJyZW50Qm94RGVzY2VuZGFudCA9IGN1cnJlbnRBY3Rp dmVSZW5kZXJCb3goKTsKLSAgICBpZiAoY3VycmVudEJsb2NrID09IGN1cnJlbnRCb3hEZXNjZW5k YW50KSB7Ci0gICAgICAgIExheW91dFN0YXRlKiBsYXlvdXRTdGF0ZSA9IHZpZXcoKS5sYXlvdXRT dGF0ZSgpOwotICAgICAgICBBU1NFUlQobGF5b3V0U3RhdGUtPm1fcmVuZGVyZXIgPT0gY3VycmVu dEJsb2NrKTsKLSAgICAgICAgQVNTRVJUKGxheW91dFN0YXRlICYmIGxheW91dFN0YXRlLT5pc1Bh Z2luYXRlZCgpKTsKLSAgICAgICAgTGF5b3V0U2l6ZSBvZmZzZXREZWx0YSA9IGxheW91dFN0YXRl LT5tX2xheW91dE9mZnNldCAtIGxheW91dFN0YXRlLT5tX3BhZ2VPZmZzZXQ7Ci0gICAgICAgIHJl dHVybiBjdXJyZW50Qm94RGVzY2VuZGFudC0+aXNIb3Jpem9udGFsV3JpdGluZ01vZGUoKSA/IG9m ZnNldERlbHRhLmhlaWdodCgpIDogb2Zmc2V0RGVsdGEud2lkdGgoKTsKLSAgICB9Ci0KICAgICAv LyBBcyBhIGxhc3QgcmVzb3J0LCB0YWtlIHRoZSBzbG93IHBhdGguCiAgICAgTGF5b3V0UmVjdCBi bG9ja1JlY3QoMCwgMCwgY3VycmVudEJsb2NrLT53aWR0aCgpLCBjdXJyZW50QmxvY2stPmhlaWdo dCgpKTsKICAgICB3aGlsZSAoY3VycmVudEJsb2NrICYmICFjdXJyZW50QmxvY2stPmlzUmVuZGVy Rmxvd1RocmVhZCgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKaW5k ZXggZDU1NmE1NWI5MThjODIwYTc4ZDUxYjg4MDcwOGIyNThkOTU4Nzc2YS4uYTE3NDE5ODZkZTdl ZDk3MWFmZTRmYTg1ZmNlYjQ0ZjBlMzg5NWZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJWaWV3LmNwcApAQCAtMTAxOSw4ICsxMDE5LDggQEAgdm9pZCBSZW5kZXJWaWV3OjpwdXNo TGF5b3V0U3RhdGUoUmVuZGVyT2JqZWN0JiByb290KQogICAgIEFTU0VSVChtX2xheW91dFN0YXRl RGlzYWJsZUNvdW50ID09IDApOwogICAgIEFTU0VSVChtX2xheW91dFN0YXRlID09IDApOwogCi0g ICAgcHVzaExheW91dFN0YXRlRm9yQ3VycmVudEZsb3dUaHJlYWQocm9vdCk7CiAgICAgbV9sYXlv dXRTdGF0ZSA9IHN0ZDo6bWFrZV91bmlxdWU8TGF5b3V0U3RhdGU+KHJvb3QpOworICAgIHB1c2hM YXlvdXRTdGF0ZUZvckN1cnJlbnRGbG93VGhyZWFkKHJvb3QpOwogfQogCiBib29sIFJlbmRlclZp ZXc6OnNob3VsZERpc2FibGVMYXlvdXRTdGF0ZUZvclN1YnRyZWUoUmVuZGVyT2JqZWN0KiByZW5k ZXJlcikgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJW aWV3LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oCmluZGV4IGI3YmYx MWJmMmQ4ZTIwZWQ4Mjc1N2Y4Yzk1MjAwMDUyMjY1YTU3MGYuLjIyOTkzMjM3ODM0MDY4NGRjNDU0 MzNkZWE2MDFjM2FmYjkxMTQwMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJWaWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcu aApAQCAtMjUzLDggKzI1Myw4IEBAIHByaXZhdGU6CiAgICAgICAgIC8vIFdlIHB1c2ggTGF5b3V0 U3RhdGUgZXZlbiBpZiBsYXlvdXRTdGF0ZSBpcyBkaXNhYmxlZCBiZWNhdXNlIGl0IHN0b3JlcyBs YXlvdXREZWx0YSB0b28uCiAgICAgICAgIGlmICghZG9pbmdGdWxsUmVwYWludCgpIHx8IG1fbGF5 b3V0U3RhdGUtPmlzUGFnaW5hdGVkKCkgfHwgcmVuZGVyZXIuaGFzQ29sdW1ucygpIHx8IHJlbmRl cmVyLmZsb3dUaHJlYWRDb250YWluaW5nQmxvY2soKQogICAgICAgICAgICAgfHwgbV9sYXlvdXRT dGF0ZS0+bGluZUdyaWQoKSB8fCAocmVuZGVyZXIuc3R5bGUoKS5saW5lR3JpZCgpICE9IFJlbmRl clN0eWxlOjppbml0aWFsTGluZUdyaWQoKSAmJiByZW5kZXJlci5pc1JlbmRlckJsb2NrRmxvdygp KSkgewotICAgICAgICAgICAgcHVzaExheW91dFN0YXRlRm9yQ3VycmVudEZsb3dUaHJlYWQocmVu ZGVyZXIpOwogICAgICAgICAgICAgbV9sYXlvdXRTdGF0ZSA9IHN0ZDo6bWFrZV91bmlxdWU8TGF5 b3V0U3RhdGU+KHN0ZDo6bW92ZShtX2xheW91dFN0YXRlKSwgJnJlbmRlcmVyLCBvZmZzZXQsIHBh Z2VIZWlnaHQsIHBhZ2VIZWlnaHRDaGFuZ2VkLCBjb2xJbmZvKTsKKyAgICAgICAgICAgIHB1c2hM YXlvdXRTdGF0ZUZvckN1cnJlbnRGbG93VGhyZWFkKHJlbmRlcmVyKTsKICAgICAgICAgICAgIHJl dHVybiB0cnVlOwogICAgICAgICB9CiAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTI2Miw4ICsy NjIsOCBAQCBwcml2YXRlOgogCiAgICAgdm9pZCBwb3BMYXlvdXRTdGF0ZSgpCiAgICAgewotICAg ICAgICBtX2xheW91dFN0YXRlID0gc3RkOjptb3ZlKG1fbGF5b3V0U3RhdGUtPm1fbmV4dCk7CiAg ICAgICAgIHBvcExheW91dFN0YXRlRm9yQ3VycmVudEZsb3dUaHJlYWQoKTsKKyAgICAgICAgbV9s YXlvdXRTdGF0ZSA9IHN0ZDo6bW92ZShtX2xheW91dFN0YXRlLT5tX25leHQpOwogICAgIH0KIAog ICAgIC8vIFN1c3BlbmRzIHRoZSBMYXlvdXRTdGF0ZSBvcHRpbWl6YXRpb24uIFVzZWQgdW5kZXIg dHJhbnNmb3JtcyB0aGF0IGNhbm5vdCBiZSByZXByZXNlbnRlZCBieQo=