130402 2014-03-18 09:58:48 -0700 Removing MediaStreamVector typedef 2014-05-19 09:08:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124288 1 thiago.lacerda thiago.lacerda commit-queue eric.carlson glenn hta jer.noble philipj sergio tommyw oldest_to_newest 991701 0 thiago.lacerda 2014-03-18 09:58:48 -0700 As did in r158480 for MediaStreamTrackVector and MediaStreamSourceVector. Those typedefs just compromises the code readability. 991703 1 227063 thiago.lacerda 2014-03-18 10:06:30 -0700 Created attachment 227063 Patch 991803 2 227063 commit-queue 2014-03-18 12:48:24 -0700 Comment on attachment 227063 Patch Clearing flags on attachment: 227063 Committed r165834: <http://trac.webkit.org/changeset/165834> 991804 3 commit-queue 2014-03-18 12:48:28 -0700 All reviewed patches have been landed. Closing bug. 992354 4 227063 darin 2014-03-19 18:42:34 -0700 Comment on attachment 227063 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227063&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:520 > - for (MediaStreamVector::iterator iter = m_localStreams.begin(); iter != m_localStreams.end(); ++iter) { > + for (auto iter = m_localStreams.begin(); iter != m_localStreams.end(); ++iter) { > if ((*iter)->id() == streamId) > return iter->get(); > } When you touch a loop like this one it’s best to make it a modern C++ loop too: for (auto& stream : m_localStreams) { if (stream->id() == streamId) return stream->get(); } Isn’t that better? 992492 5 thiago.lacerda 2014-03-20 06:42:34 -0700 (In reply to comment #4) > (From update of attachment 227063 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227063&action=review > > > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:520 > > - for (MediaStreamVector::iterator iter = m_localStreams.begin(); iter != m_localStreams.end(); ++iter) { > > + for (auto iter = m_localStreams.begin(); iter != m_localStreams.end(); ++iter) { > > if ((*iter)->id() == streamId) > > return iter->get(); > > } > > When you touch a loop like this one it’s best to make it a modern C++ loop too: > > for (auto& stream : m_localStreams) { > if (stream->id() == streamId) > return stream->get(); > } > > Isn’t that better? Indeed Darin, I will do that next time. Thanks 227063 2014-03-18 10:06:30 -0700 2014-03-19 18:42:34 -0700 Patch bug-130402-20140318140607.patch text/plain 4443 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1ODE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYThlNDFlN2I1ZTc2NDUy NDQyNmY3Nzc5M2QxMDc1YjE1Y2M1MWQyYi4uNzFhM2Q3OTViMGFiM2ExZjYxYzRlY2Y0MDYxOGE1 ZDExNWJjZDIzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTAzLTE4ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFJlbW92aW5nIE1lZGlhU3RyZWFtVmVjdG9yIHR5cGVkZWYKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzMDQwMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9N ZWRpYVN0cmVhbS5oOgorICAgICAgICAqIE1vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5l Y3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UlRDUGVlckNvbm5lY3Rpb246OmdldExvY2Fs U3RyZWFtcyk6CisgICAgICAgIChXZWJDb3JlOjpSVENQZWVyQ29ubmVjdGlvbjo6Z2V0UmVtb3Rl U3RyZWFtcyk6CisgICAgICAgIChXZWJDb3JlOjpSVENQZWVyQ29ubmVjdGlvbjo6Z2V0U3RyZWFt QnlJZCk6CisgICAgICAgIChXZWJDb3JlOjpSVENQZWVyQ29ubmVjdGlvbjo6aGFzTG9jYWxTdHJl YW1XaXRoVHJhY2tJZCk6CisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29u bmVjdGlvbi5oOgorCiAyMDE0LTAzLTE4ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZXNvdXJjZUxvYWRlclNvdXAuY3BwIHdhcyBhZGRl ZCBieSBtaXN0YWtlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3Ry ZWFtL01lZGlhU3RyZWFtLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL01l ZGlhU3RyZWFtLmgKaW5kZXggMTc5MWMyNDkwNjRlMDk2YmU5YTBkMjFlNGY2ZjFkMmU4NTFlZThm Yy4uNTE4NWZlOThlYjY1MWQ4ZjhjNjU5YzkxYTMxY2Q3Mzc5ZjVjNmY2ZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9NZWRpYVN0cmVhbS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vTWVkaWFTdHJlYW0uaApAQCAtMTMxLDgg KzEzMSw2IEBAIHByaXZhdGU6CiAgICAgVmVjdG9yPE9ic2VydmVyKj4gbV9vYnNlcnZlcnM7CiB9 OwogCi10eXBlZGVmIFZlY3RvcjxSZWZQdHI8TWVkaWFTdHJlYW0+PiBNZWRpYVN0cmVhbVZlY3Rv cjsKLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5BQkxFKE1FRElBX1NU UkVBTSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRD UGVlckNvbm5lY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9S VENQZWVyQ29ubmVjdGlvbi5jcHAKaW5kZXggNDM4MWE3MWRiNjE0NmM0ZGJlZWUyODQxZTQyNjAy ZDI0ZWM4NzgwNS4uN2EzZTFjNTFlYTEzOGUxYWU0N2E5MTkxMDBjNmY4NGIzNTM2NTZiMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVj dGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVy Q29ubmVjdGlvbi5jcHAKQEAgLTUwMiwyNCArNTAyLDI0IEBAIFJUQ0NvbmZpZ3VyYXRpb24qIFJU Q1BlZXJDb25uZWN0aW9uOjpnZXRDb25maWd1cmF0aW9uKCkgY29uc3QKICAgICByZXR1cm4gbV9j b25maWd1cmF0aW9uLmdldCgpOwogfQogCi1NZWRpYVN0cmVhbVZlY3RvciBSVENQZWVyQ29ubmVj dGlvbjo6Z2V0TG9jYWxTdHJlYW1zKCkgY29uc3QKK1ZlY3RvcjxSZWZQdHI8TWVkaWFTdHJlYW0+ PiBSVENQZWVyQ29ubmVjdGlvbjo6Z2V0TG9jYWxTdHJlYW1zKCkgY29uc3QKIHsKICAgICByZXR1 cm4gbV9sb2NhbFN0cmVhbXM7CiB9CiAKLU1lZGlhU3RyZWFtVmVjdG9yIFJUQ1BlZXJDb25uZWN0 aW9uOjpnZXRSZW1vdGVTdHJlYW1zKCkgY29uc3QKK1ZlY3RvcjxSZWZQdHI8TWVkaWFTdHJlYW0+ PiBSVENQZWVyQ29ubmVjdGlvbjo6Z2V0UmVtb3RlU3RyZWFtcygpIGNvbnN0CiB7CiAgICAgcmV0 dXJuIG1fcmVtb3RlU3RyZWFtczsKIH0KIAogTWVkaWFTdHJlYW0qIFJUQ1BlZXJDb25uZWN0aW9u OjpnZXRTdHJlYW1CeUlkKGNvbnN0IFN0cmluZyYgc3RyZWFtSWQpCiB7Ci0gICAgZm9yIChNZWRp YVN0cmVhbVZlY3Rvcjo6aXRlcmF0b3IgaXRlciA9IG1fbG9jYWxTdHJlYW1zLmJlZ2luKCk7IGl0 ZXIgIT0gbV9sb2NhbFN0cmVhbXMuZW5kKCk7ICsraXRlcikgeworICAgIGZvciAoYXV0byBpdGVy ID0gbV9sb2NhbFN0cmVhbXMuYmVnaW4oKTsgaXRlciAhPSBtX2xvY2FsU3RyZWFtcy5lbmQoKTsg KytpdGVyKSB7CiAgICAgICAgIGlmICgoKml0ZXIpLT5pZCgpID09IHN0cmVhbUlkKQogICAgICAg ICAgICAgcmV0dXJuIGl0ZXItPmdldCgpOwogICAgIH0KIAotICAgIGZvciAoTWVkaWFTdHJlYW1W ZWN0b3I6Oml0ZXJhdG9yIGl0ZXIgPSBtX3JlbW90ZVN0cmVhbXMuYmVnaW4oKTsgaXRlciAhPSBt X3JlbW90ZVN0cmVhbXMuZW5kKCk7ICsraXRlcikgeworICAgIGZvciAoYXV0byBpdGVyID0gbV9y ZW1vdGVTdHJlYW1zLmJlZ2luKCk7IGl0ZXIgIT0gbV9yZW1vdGVTdHJlYW1zLmVuZCgpOyArK2l0 ZXIpIHsKICAgICAgICAgaWYgKCgqaXRlciktPmlkKCkgPT0gc3RyZWFtSWQpCiAgICAgICAgICAg ICByZXR1cm4gaXRlci0+Z2V0KCk7CiAgICAgfQpAQCAtNTUxLDcgKzU1MSw3IEBAIFBhc3NSZWZQ dHI8UlRDRGF0YUNoYW5uZWw+IFJUQ1BlZXJDb25uZWN0aW9uOjpjcmVhdGVEYXRhQ2hhbm5lbChT dHJpbmcgbGFiZWwsIGNvCiAKIGJvb2wgUlRDUGVlckNvbm5lY3Rpb246Omhhc0xvY2FsU3RyZWFt V2l0aFRyYWNrSWQoY29uc3QgU3RyaW5nJiB0cmFja0lkKQogewotICAgIGZvciAoTWVkaWFTdHJl YW1WZWN0b3I6Oml0ZXJhdG9yIGl0ZXIgPSBtX2xvY2FsU3RyZWFtcy5iZWdpbigpOyBpdGVyICE9 IG1fbG9jYWxTdHJlYW1zLmVuZCgpOyArK2l0ZXIpIHsKKyAgICBmb3IgKGF1dG8gaXRlciA9IG1f bG9jYWxTdHJlYW1zLmJlZ2luKCk7IGl0ZXIgIT0gbV9sb2NhbFN0cmVhbXMuZW5kKCk7ICsraXRl cikgewogICAgICAgICBpZiAoKCppdGVyKS0+Z2V0VHJhY2tCeUlkKHRyYWNrSWQpKQogICAgICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5oCmluZGV4IGVjZDE2YTJmMzc0ZDRk MGQxYjYxMzhlOGRhZWNhMjE4ZjAyMzY5MDQuLmJhOGU3YWU3NTI0MDNkZjcyNmRlYmVhMjhiYTc1 YWFjNDFjZmIwNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJl YW0vUlRDUGVlckNvbm5lY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmgKQEAgLTg1LDkgKzg1LDkgQEAgcHVibGljOgogCiAg ICAgUlRDQ29uZmlndXJhdGlvbiogZ2V0Q29uZmlndXJhdGlvbigpIGNvbnN0OwogCi0gICAgTWVk aWFTdHJlYW1WZWN0b3IgZ2V0TG9jYWxTdHJlYW1zKCkgY29uc3Q7CisgICAgVmVjdG9yPFJlZlB0 cjxNZWRpYVN0cmVhbT4+IGdldExvY2FsU3RyZWFtcygpIGNvbnN0OwogCi0gICAgTWVkaWFTdHJl YW1WZWN0b3IgZ2V0UmVtb3RlU3RyZWFtcygpIGNvbnN0OworICAgIFZlY3RvcjxSZWZQdHI8TWVk aWFTdHJlYW0+PiBnZXRSZW1vdGVTdHJlYW1zKCkgY29uc3Q7CiAKICAgICBNZWRpYVN0cmVhbSog Z2V0U3RyZWFtQnlJZChjb25zdCBTdHJpbmcmIHN0cmVhbUlkKTsKIApAQCAtMTU3LDggKzE1Nyw4 IEBAIHByaXZhdGU6CiAgICAgSWNlR2F0aGVyaW5nU3RhdGUgbV9pY2VHYXRoZXJpbmdTdGF0ZTsK ICAgICBJY2VDb25uZWN0aW9uU3RhdGUgbV9pY2VDb25uZWN0aW9uU3RhdGU7CiAKLSAgICBNZWRp YVN0cmVhbVZlY3RvciBtX2xvY2FsU3RyZWFtczsKLSAgICBNZWRpYVN0cmVhbVZlY3RvciBtX3Jl bW90ZVN0cmVhbXM7CisgICAgVmVjdG9yPFJlZlB0cjxNZWRpYVN0cmVhbT4+IG1fbG9jYWxTdHJl YW1zOworICAgIFZlY3RvcjxSZWZQdHI8TWVkaWFTdHJlYW0+PiBtX3JlbW90ZVN0cmVhbXM7CiAK ICAgICBWZWN0b3I8UmVmUHRyPFJUQ0RhdGFDaGFubmVsPj4gbV9kYXRhQ2hhbm5lbHM7CiAK