129894 2014-03-07 11:17:21 -0800 [WebRTC] Throw SYNTAX_ERROR when maxRetransmits and maxRetransmitTime are both set in RTCDataChannelInit 2014-05-19 09:08:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124288 1 thiago.lacerda thiago.lacerda commit-queue eric.carlson glenn hta jer.noble philipj sergio tommyw oldest_to_newest 988231 0 thiago.lacerda 2014-03-07 11:17:21 -0800 Throw SYNTAX_ERROR when maxRetransmits and maxRetransmitTime are both set in RTCDataChannelInit 988237 1 226141 thiago.lacerda 2014-03-07 11:23:41 -0800 Created attachment 226141 Patch 988483 2 226141 commit-queue 2014-03-07 19:30:37 -0800 Comment on attachment 226141 Patch Clearing flags on attachment: 226141 Committed r165321: <http://trac.webkit.org/changeset/165321> 988484 3 commit-queue 2014-03-07 19:30:40 -0800 All reviewed patches have been landed. Closing bug. 226141 2014-03-07 11:23:41 -0800 2014-03-07 19:30:37 -0800 Patch bug-129894-20140307162339.patch text/plain 4982 thiago.lacerda U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1MjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2I0NTdkNjY5ZmQ0YmIz Mjk3NjIzZjc1YzVjOWRlZGViYWI2Zjk2OS4uNTVkNDMyNzZhM2Q3YWE5NDFmNDMwNTdjMzAyNTkz OTliYjZiNDliZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAzLTA3ICBUaGlh Z28gZGUgQmFycm9zIExhY2VyZGEgIDx0aGlhZ28ubGFjZXJkYUBvcGVuYm9zc2Eub3JnPgorCisg ICAgICAgIFtXZWJSVENdIFRocm93IFNZTlRBWF9FUlJPUiB3aGVuIG1heFJldHJhbnNtaXRzIGFu ZCBtYXhSZXRyYW5zbWl0VGltZSBhcmUgYm90aCBzZXQgaW4gUlRDRGF0YUNoYW5uZWxJbml0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4OTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeGlzdGluZyB0 ZXN0IHdhcyB1cGRhdGVkLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENEYXRh Q2hhbm5lbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSVENEYXRhQ2hhbm5lbDo6Y3JlYXRlKToK KwogMjAxNC0wMy0wNyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmVtb3ZlIG5vbi13b3JraW5nIG9wdGltaXphdGlvbiB0aGF0IHdhcyBhdHRlbXB0ZWQgb24gaU9T IG9ubHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRD RGF0YUNoYW5uZWwuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENE YXRhQ2hhbm5lbC5jcHAKaW5kZXggNGU4NzZiYjdlMjQwZjllNzExNGMzYThlYzNhM2FkZmM4NzQy ODRlNy4uYjQzMTRkYzZmMGUzZDJhOTEyNTIzZWYwM2EzYTViYzRhZDQ2OWRhMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENEYXRhQ2hhbm5lbC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9SVENEYXRhQ2hhbm5lbC5j cHAKQEAgLTU3LDEzICs1NywyNCBAQCBzdGF0aWMgY29uc3QgQXRvbWljU3RyaW5nJiBhcnJheWJ1 ZmZlcktleXdvcmQoKQogUGFzc1JlZlB0cjxSVENEYXRhQ2hhbm5lbD4gUlRDRGF0YUNoYW5uZWw6 OmNyZWF0ZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBSVENQZWVyQ29ubmVjdGlv bkhhbmRsZXIqIHBlZXJDb25uZWN0aW9uSGFuZGxlciwgY29uc3QgU3RyaW5nJiBsYWJlbCwgY29u c3QgRGljdGlvbmFyeSYgb3B0aW9ucywgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CiAgICAgUlRDRGF0 YUNoYW5uZWxJbml0IGluaXREYXRhOworICAgIFN0cmluZyBtYXhSZXRyYW5zbWl0c1N0cjsKKyAg ICBTdHJpbmcgbWF4UmV0cmFuc21pdFRpbWVTdHI7CiAgICAgb3B0aW9ucy5nZXQoIm9yZGVyZWQi LCBpbml0RGF0YS5vcmRlcmVkKTsKICAgICBvcHRpb25zLmdldCgibmVnb3RpYXRlZCIsIGluaXRE YXRhLm5lZ290aWF0ZWQpOwogICAgIG9wdGlvbnMuZ2V0KCJpZCIsIGluaXREYXRhLmlkKTsKLSAg ICBvcHRpb25zLmdldCgibWF4UmV0cmFuc21pdHMiLCBpbml0RGF0YS5tYXhSZXRyYW5zbWl0cyk7 Ci0gICAgb3B0aW9ucy5nZXQoIm1heFJldHJhbnNtaXRUaW1lIiwgaW5pdERhdGEubWF4UmV0cmFu c21pdFRpbWUpOworICAgIG9wdGlvbnMuZ2V0KCJtYXhSZXRyYW5zbWl0cyIsIG1heFJldHJhbnNt aXRzU3RyKTsKKyAgICBvcHRpb25zLmdldCgibWF4UmV0cmFuc21pdFRpbWUiLCBtYXhSZXRyYW5z bWl0VGltZVN0cik7CiAgICAgb3B0aW9ucy5nZXQoInByb3RvY29sIiwgaW5pdERhdGEucHJvdG9j b2wpOwogCisgICAgYm9vbCBtYXhSZXRyYW5zbWl0c0NvbnZlcnNpb247CisgICAgYm9vbCBtYXhS ZXRyYW5zbWl0VGltZUNvbnZlcnNpb247CisgICAgaW5pdERhdGEubWF4UmV0cmFuc21pdHMgPSBt YXhSZXRyYW5zbWl0c1N0ci50b1VJbnRTdHJpY3QoJm1heFJldHJhbnNtaXRzQ29udmVyc2lvbik7 CisgICAgaW5pdERhdGEubWF4UmV0cmFuc21pdFRpbWUgPSBtYXhSZXRyYW5zbWl0VGltZVN0ci50 b1VJbnRTdHJpY3QoJm1heFJldHJhbnNtaXRUaW1lQ29udmVyc2lvbik7CisgICAgaWYgKG1heFJl dHJhbnNtaXRzQ29udmVyc2lvbiAmJiBtYXhSZXRyYW5zbWl0VGltZUNvbnZlcnNpb24pIHsKKyAg ICAgICAgZWMgPSBTWU5UQVhfRVJSOworICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICB9CisK ICAgICBzdGQ6OnVuaXF1ZV9wdHI8UlRDRGF0YUNoYW5uZWxIYW5kbGVyPiBoYW5kbGVyID0gcGVl ckNvbm5lY3Rpb25IYW5kbGVyLT5jcmVhdGVEYXRhQ2hhbm5lbChsYWJlbCwgaW5pdERhdGEpOwog ICAgIGlmICghaGFuZGxlcikgewogICAgICAgICBlYyA9IE5PVF9TVVBQT1JURURfRVJSOwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IDI5N2Y0MGU2ZTNjNzQ4NWY1Mjc0NDlmNzE1MTUzZDBkYWMzZjVhYTIuLmJiNjllYjk0MTk4 YWNmNjUwMjY2MGE0N2FhZmU3MWI5YWIwNmJmZjMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAx NC0wMy0wNyAgVGhpYWdvIGRlIEJhcnJvcyBMYWNlcmRhICA8dGhpYWdvLmxhY2VyZGFAb3BlbmJv c3NhLm9yZz4KKworICAgICAgICBbV2ViUlRDXSBUaHJvdyBTWU5UQVhfRVJST1Igd2hlbiBtYXhS ZXRyYW5zbWl0cyBhbmQgbWF4UmV0cmFuc21pdFRpbWUgYXJlIGJvdGggc2V0IGluIFJUQ0RhdGFD aGFubmVsSW5pdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI5ODk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBmYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWRhdGFjaGFubmVsLWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWRh dGFjaGFubmVsLmh0bWw6CisKIDIwMTQtMDMtMDcgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2Eg IDxtLnBha3VsYUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIEVGTCBnYXJkZW5p bmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5l Y3Rpb24tZGF0YWNoYW5uZWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0 cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1kYXRhY2hhbm5lbC1leHBlY3RlZC50eHQKaW5kZXggZTVl NjliNzIxZTczMThlYTdhOWRiMDJkZTg1YTQwNTM3YTkzOTNmZS4uMzZjNjQ4NDhmNGE3NzFiN2Zl Y2VjN2UzOWYxYTc1N2E3NmU1OTU3MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRp YXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1kYXRhY2hhbm5lbC1leHBlY3RlZC50eHQKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1kYXRhY2hhbm5l bC1leHBlY3RlZC50eHQKQEAgLTMsNiArMyw3IEBAIFRlc3RzIFJUQ0RhdGFDaGFubmVsLgogT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCiAKK1BBU1MgZGMgPSBwYy5jcmVhdGVEYXRhQ2hhbm5l bCgibGFiZWwiLCB7bWF4UmV0cmFuc21pdFRpbWU6MCwgbWF4UmV0cmFuc21pdHM6MH0pOyB0aHJl dyBleGNlcHRpb24gRXJyb3I6IFN5bnRheEVycm9yOiBET00gRXhjZXB0aW9uIDEyLgogUEFTUyBk YyA9IHBjLmNyZWF0ZURhdGFDaGFubmVsKCJsYWJlbDEiKTsgZGlkIG5vdCB0aHJvdyBleGNlcHRp b24uCiBQQVNTIGRjID0gcGMuY3JlYXRlRGF0YUNoYW5uZWwoImxhYmVsMiIsIHt9KTsgZGlkIG5v dCB0aHJvdyBleGNlcHRpb24uCiBQQVNTIGRjID0gcGMuY3JlYXRlRGF0YUNoYW5uZWwoImxhYmVs MyIsIHtvcmRlcmVkOnRydWV9KTsgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLWRhdGFjaGFu bmVsLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9u LWRhdGFjaGFubmVsLmh0bWwKaW5kZXggOGI2ZGEwNmI5NWVhZWIxNjhiNmJkZWQ0NWQ5NmE0ZDcw NjIwZjY2MS4uODgxYTg5ZGMwZThlMTJiMDZjYTYxY2E5ODYyYTJkZjlkMTQ2NTMzNiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi1kYXRh Y2hhbm5lbC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbWVkaWFzdHJlYW0vUlRDUGVlckNv bm5lY3Rpb24tZGF0YWNoYW5uZWwuaHRtbApAQCAtODIsNiArODIsNyBAQAogICAgICAgICAgICAg fQogCiAgICAgICAgICAgICBwYyA9IG5ldyB3ZWJraXRSVENQZWVyQ29ubmVjdGlvbih7aWNlU2Vy dmVyczpbe3VybHM6J3N0dW46Zm9vLmNvbSd9XX0pOworICAgICAgICAgICAgc2hvdWxkVGhyb3co J2RjID0gcGMuY3JlYXRlRGF0YUNoYW5uZWwoImxhYmVsIiwge21heFJldHJhbnNtaXRUaW1lOjAs IG1heFJldHJhbnNtaXRzOjB9KTsnKTsKICAgICAgICAgICAgIHNob3VsZE5vdFRocm93KCdkYyA9 IHBjLmNyZWF0ZURhdGFDaGFubmVsKCJsYWJlbDEiKTsnKTsKICAgICAgICAgICAgIHNob3VsZE5v dFRocm93KCdkYyA9IHBjLmNyZWF0ZURhdGFDaGFubmVsKCJsYWJlbDIiLCB7fSk7Jyk7CiAgICAg ICAgICAgICBzaG91bGROb3RUaHJvdygnZGMgPSBwYy5jcmVhdGVEYXRhQ2hhbm5lbCgibGFiZWwz Iiwge29yZGVyZWQ6dHJ1ZX0pOycpOwo=