129816 2014-03-06 12:36:10 -0800 [CSS Shapes] CRASH with calc() value args in inset round 2014-04-03 15:15:47 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Major --- 98664 1 rhauck bjonesbe bjonesbe commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard zoltan oldest_to_newest 987817 0 rhauck 2014-03-06 12:36:10 -0800 The attached test has two examples of a shape defined by inset(10x round XXX) where XXX is one or two calc() values. These cause an immediate crash. Note: This uses testharness.js and the relative path in the test assumes the test is run from LayoutTests/fast/shapes/parsing 987818 1 226028 rhauck 2014-03-06 12:36:33 -0800 Created attachment 226028 Test case for bug 996946 2 228451 bjonesbe 2014-04-02 18:12:52 -0700 Created attachment 228451 Patch 996959 3 zoltan 2014-04-02 19:51:31 -0700 Looks good to me, thanks Bem! 997196 4 228451 kling 2014-04-03 09:33:56 -0700 Comment on attachment 228451 Patch r=me. Thanks to Zoltan for looking as well! 997203 5 228451 commit-queue 2014-04-03 09:49:00 -0700 Comment on attachment 228451 Patch Clearing flags on attachment: 228451 Committed r166726: <http://trac.webkit.org/changeset/166726> 997204 6 commit-queue 2014-04-03 09:49:05 -0700 All reviewed patches have been landed. Closing bug. 997327 7 ddkilzer 2014-04-03 15:15:47 -0700 <rdar://problem/16517722> 226028 2014-03-06 12:36:33 -0800 2014-03-06 12:36:33 -0800 Test case for bug parsing-shape-outside-inset-round.html text/html 1820 rhauck PCFET0NUWVBFIGh0bWw+CjxodG1sPgogICAgPGhlYWQ+CiAgICAgICAgPHNjcmlwdCBzcmM9Ii4u Ly4uLy4uL3Jlc291cmNlcy90ZXN0aGFybmVzcy5qcyI+PC9zY3JpcHQ+CiAgICAgICAgPHNjcmlw dCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy90ZXN0aGFybmVzc3JlcG9ydC5qcyI+PC9zY3JpcHQ+ CiAgICA8L2hlYWQ+CiAgICA8Ym9keT4KICAgICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNj cmlwdCI+CiAgICAgICAgICAgIC8vIFt0ZXN0IHZhbHVlLCBleHBlY3RlZCBwcm9wZXJ0eSB2YWx1 ZSwgZXhwZWN0ZWQgY29tcHV0ZWQgc3R5bGVdCiAgICAgICAgICAgIHZhciBpbnNldF9yb3VuZF9j YWxjX3Rlc3RzID0gWwogICAgICAgICAgICAgICAgWydpbnNldCgxMHB4IHJvdW5kIGNhbGMoMTBp bikpJywgCiAgICAgICAgICAgICAgICAgJ2luc2V0KDEwcHggcm91bmQgY2FsYygxMGluKSBjYWxj KDEwaW4pIGNhbGMoMTBpbikgY2FsYygxMCkgLyBjYWxjKDEwaW4pIGNhbGMoMTBpbikgY2FsYygx MGluKSBjYWxjKDEwKSknLCAKICAgICAgICAgICAgICAgICAnaW5zZXQoMTBweCByb3VuZCBjYWxj KDk2MHB4KSBjYWxjKDk2MHB4KSBjYWxjKDk2MHB4KSBjYWxjKDk2MHB4KSAvIGNhbGMoOTYwcHgp IGNhbGMoOTYwcHgpIGNhbGMoOTYwcHgpIGNhbGMoOTYwcHgpKSddLAogICAgICAgICAgICAgICAg IAogICAgICAgICAgICAgICAgWydpbnNldCgxMHB4IHJvdW5kIGNhbGMoMTBpbikgY2FsYygyaW4g KiA1aW4pKScsIAogICAgICAgICAgICAgICAgICdpbnNldCgxMHB4IHJvdW5kIGNhbGMoMTBpbikg Y2FsYygxMGluKSBjYWxjKDEwaW4pIGNhbGMoMTApIC8gY2FsYygxMGluKSBjYWxjKDEwaW4pIGNh bGMoMTBpbikgY2FsYygxMCkpJywgCiAgICAgICAgICAgICAgICAgJ2luc2V0KDEwcHggcm91bmQg Y2FsYyg5NjBweCkgY2FsYyg5NjBweCkgY2FsYyg5NjBweCkgY2FsYyg5NjBweCkgLyBjYWxjKDk2 MHB4KSBjYWxjKDk2MHB4KSBjYWxjKDk2MHB4KSBjYWxjKDk2MHB4KSknXSwKICAgICAgICAgICAg XQogICAgICAgICAgICBpbnNldF9yb3VuZF9jYWxjX3Rlc3RzLmZvckVhY2goZnVuY3Rpb24gKHRl c3RDYXNlKSB7CiAgICAgICAgICAgICAgICB0ZXN0KGZ1bmN0aW9uKCkgewogICAgICAgICAgICAg ICAgICAgIHZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKICAgICAgICAg ICAgICAgICAgICBkaXYuc3R5bGUuc2V0UHJvcGVydHkoJy13ZWJraXQtc2hhcGUtb3V0c2lkZScs IHRlc3RDYXNlWzBdKTsKICAgICAgICAgICAgICAgICAgICBjb25zb2xlLmxvZyh0ZXN0Q2FzZVsw XSk7CiAgICAgICAgICAgICAgICAgICAgdmFyIGlubGluZUFjdHVhbCA9IGRpdi5zdHlsZS5nZXRQ cm9wZXJ0eVZhbHVlKCctd2Via2l0LXNoYXBlLW91dHNpZGUnKTsKICAgICAgICAgICAgICAgICAg ICBhc3NlcnRfZXF1YWxzKGlubGluZUFjdHVhbCwgdGVzdENhc2VbMV0pOwogICAgICAgICAgICAg ICAgICAgIHZhciBjb21wdXRlZFN0eWxlID0gZ2V0Q29tcHV0ZWRTdHlsZShkaXYpOwogICAgICAg ICAgICAgICAgICAgIHZhciBjb21wdXRlZEFjdHVhbCA9IGNvbXB1dGVkU3R5bGUuZ2V0UHJvcGVy dHlWYWx1ZSgnLXdlYmtpdC1zaGFwZS1vdXRzaWRlJyk7CiAgICAgICAgICAgICAgICAgICAgYXNz ZXJ0X2VxdWFscyhjb21wdXRlZEFjdHVhbCwgdGVzdENhc2VbMl0pOwogICAgICAgICAgICAgICAg ICAgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQoZGl2KTsKICAgICAgICAgICAgICAgfSk7IAog ICAgICAgICAgICB9KTsKICAgICAgICA8L3NjcmlwdD4KICAgIDwvYm9keT4KPC9odG1sPgo= 228451 2014-04-02 18:12:52 -0700 2014-04-03 09:48:59 -0700 Patch bug-129816-20140402181453.patch text/plain 4807 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTY2NjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODcwZjJiNDM3YmQ5N2Q1 NTcyYzUxN2JjMTg2YjI4NTM2NzE5NGNkMi4uMGEyZWEzMjFiMzdlMDYyYTM5N2Q2MjY2OTZiMDg0 YzUxMzQ0MDliMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTA0LTAyICBCZW0g Sm9uZXMtQmV5ICA8YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFtDU1MgU2hhcGVzXSBD UkFTSCB3aXRoIGNhbGMoKSB2YWx1ZSBhcmdzIGluIGluc2V0IHJvdW5kCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjk4MTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY29kZSB0byBwYXJzZSB0aGUg aW5zZXQgcm91bmRlZCBjb3JuZXJzIHdhcyBhZGRpbmcgdGhlIHBhcnNlcgorICAgICAgICB2YWx1 ZSBhcmd1bWVudHMgdG8gYSB0ZW1wb3JhcnkgQ1NTUGFyc2VyVmFsdWVMaXN0LiBVbmZvcnR1bmF0 ZWx5LAorICAgICAgICBDU1NQYXJzZXJWYWx1ZUxpc3QgZXhwZWN0cyB0byBvd24gdGhlIHZhbHVl cyBpdCBjb250YWlucywgYW5kIGl0IGZyZWVzCisgICAgICAgIHRoZSB2YWx1ZXMgaXQgY29udGFp bnMgd2hlbiB0aGUgbGlzdCBpcyBkZXN0cm95ZWQuIFRoaXMgd2FzIGEgcHJvYmxlbQorICAgICAg ICBiZWNhdXNlIHRoZSB2YWx1ZXMgYXJlIG93bmVkIGJ5IHRoZSBDU1NQYXJzZXJWYWx1ZUxpc3Qg cGFzc2VkIGluIHRvCisgICAgICAgIHBhcnNlSW5zZXRSb3VuZGVkQ29ybmVycywgYW5kIHRodXMg dGhlIGNhbGMncyBhcmd1bWVudCBsaXN0IHdvdWxkIGdldAorICAgICAgICBkb3VibGUgZnJlZWQs IHJlc3VsdGluZyBpbiBhIGNyYXNoLiBUaGlzIHBhdGNoIGZpeGVzIHRoaXMgYnkgdXNpbmcgYQor ICAgICAgICBWZWN0b3IgdG8gaG9sZCB0aGUgcG9pbnRlcnMgaW5zdGVhZC4KKworICAgICAgICBU ZXN0OiBmYXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWluc2V0 LXJvdW5kLWNhbGMtY3Jhc2guaHRtbAorCisgICAgICAgICogY3NzL0NTU1BhcnNlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlSW5zZXRSb3VuZGVkQ29ybmVycyk6CisK IDIwMTQtMDQtMDEgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIExv YWQgTWVkaWEgQ29udHJvbHMganMvY3NzIGZyb20gYnVuZGxlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwCmluZGV4IDFiM2VjMmE5NDAwMzFmMmY3NDBhMjYyZDBmNGI4ZmUyOTRjN2YzY2UuLmY4NjIw YjU0ZjU2ODA3YzZkMjU5YTU2MGM2YzA2NjgyY2FhZjk3MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJz ZXIuY3BwCkBAIC01MzQxLDEzICs1MzQxLDEzIEBAIFBhc3NSZWZQdHI8Q1NTQmFzaWNTaGFwZT4g Q1NTUGFyc2VyOjpwYXJzZUluc2V0Um91bmRlZENvcm5lcnMoUGFzc1JlZlB0cjxDU1NCYXNpCiAg ICAgaWYgKCFhcmd1bWVudCkKICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAKLSAgICBzdGQ6OnVu aXF1ZV9wdHI8Q1NTUGFyc2VyVmFsdWVMaXN0PiByYWRpdXNBcmd1bWVudHMobmV3IENTU1BhcnNl clZhbHVlTGlzdCk7CisgICAgVmVjdG9yPENTU1BhcnNlclZhbHVlKj4gcmFkaXVzQXJndW1lbnRz OwogICAgIHdoaWxlIChhcmd1bWVudCkgewotICAgICAgICByYWRpdXNBcmd1bWVudHMtPmFkZFZh bHVlKCphcmd1bWVudCk7CisgICAgICAgIHJhZGl1c0FyZ3VtZW50cy5hcHBlbmQoYXJndW1lbnQp OwogICAgICAgICBhcmd1bWVudCA9IGFyZ3MtPm5leHQoKTsKICAgICB9CiAKLSAgICB1bnNpZ25l ZCBudW0gPSByYWRpdXNBcmd1bWVudHMtPnNpemUoKTsKKyAgICB1bnNpZ25lZCBudW0gPSByYWRp dXNBcmd1bWVudHMuc2l6ZSgpOwogICAgIGlmICghbnVtIHx8IG51bSA+IDkpCiAgICAgICAgIHJl dHVybiBudWxscHRyOwogCkBAIC01MzU1LDcgKzUzNTUsNyBAQCBQYXNzUmVmUHRyPENTU0Jhc2lj U2hhcGU+IENTU1BhcnNlcjo6cGFyc2VJbnNldFJvdW5kZWRDb3JuZXJzKFBhc3NSZWZQdHI8Q1NT QmFzaQogCiAgICAgdW5zaWduZWQgaW5kZXhBZnRlclNsYXNoID0gMDsKICAgICBmb3IgKHVuc2ln bmVkIGkgPSAwOyBpIDwgbnVtOyArK2kpIHsKLSAgICAgICAgQ1NTUGFyc2VyVmFsdWUqIHZhbHVl ID0gcmFkaXVzQXJndW1lbnRzLT52YWx1ZUF0KGkpOworICAgICAgICBDU1NQYXJzZXJWYWx1ZSog dmFsdWUgPSByYWRpdXNBcmd1bWVudHMuYXQoaSk7CiAgICAgICAgIGlmICh2YWx1ZS0+dW5pdCA9 PSBDU1NQYXJzZXJWYWx1ZTo6T3BlcmF0b3IpIHsKICAgICAgICAgICAgIGlmICh2YWx1ZS0+aVZh bHVlICE9ICcvJykKICAgICAgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0ZTE0 Y2ZmMDZjZWE5MThmZDIzNDRkZDBiODZiYjY0MWQ5MzU5ZWRkLi42NWM1MmM1M2RjNTAxZGZlOGUw MzY4MGVmMGEyMGUxM2MyMmU3MjMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDQtMDIg IEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CisKKyAgICAgICAgW0NTUyBTaGFw ZXNdIENSQVNIIHdpdGggY2FsYygpIHZhbHVlIGFyZ3MgaW4gaW5zZXQgcm91bmQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyOTgxNgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbXBsZSB0ZXN0IHRvIG1h a2Ugc3VyZSB0aGF0IHVzaW5nIGNhbGMgaW4gdGhlIHJvdW5kIGFyZ3VtZW50IG9mIGFuCisgICAg ICAgIGluc2V0IGRvZXNuJ3QgY2F1c2UgYSBjcmFzaC4KKworICAgICAgICAqIGZhc3Qvc2hhcGVz L3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtaW5zZXQtcm91bmQtY2FsYy1jcmFz aC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvc2hhcGVzL3NoYXBlLW91dHNp ZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtaW5zZXQtcm91bmQtY2FsYy1jcmFzaC5odG1sOiBBZGRl ZC4KKwogMjAxNC0wNC0wMiAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgog CiAgICAgICAgIEFYOiBJbXByb3ZlIEFSSUEgbGl2ZSByZWdpb24gcmVsaWFiaWxpdHkgYnkgc2Vu ZGluZyBub3RpZmljYXRpb25zIHdoZW4gbGl2ZSByZWdpb25zIGFyZSBjcmVhdGVkL3Nob3duIGFu ZCBoaWRkZW4vZGVzdHJveWVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9z aGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWluc2V0LXJvdW5kLWNhbGMtY3Jhc2gt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9h dHMvc2hhcGUtb3V0c2lkZS1pbnNldC1yb3VuZC1jYWxjLWNyYXNoLWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi5kMzgwZmJmNzZlMWE4YjVkODVhYWFiODQyNWU3NDZlZmJiNjUxNzhmCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMv c2hhcGUtb3V0c2lkZS1pbnNldC1yb3VuZC1jYWxjLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDIgQEAKK1RoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4KKwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUt b3V0c2lkZS1pbnNldC1yb3VuZC1jYWxjLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3No YXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWluc2V0LXJvdW5kLWNhbGMt Y3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wNzFlMGVlMWVhM2ViYzlmNWUyNGUxYTVhNDY1N2IyZTA4 MDFkYzRjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUt b3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1pbnNldC1yb3VuZC1jYWxjLWNyYXNoLmh0bWwK QEAgLTAsMCArMSwxNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8c3R5bGU+Cisg ICAgICAgIGRpdiB7CisgICAgICAgICAgICAtd2Via2l0LXNoYXBlLW91dHNpZGU6IGluc2V0KDEw cHggcm91bmQgY2FsYygxMGluKSk7CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIDxib2R5 PgorICAgICAgICBUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXNuJ3QgY3Jhc2guCisgICAgICAg IDxkaXY+PC9kaXY+CisgICAgPC9ib2R5PgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlmICh3aW5k b3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpCisgICAg PC9zY3JpcHQ+Cis8L2h0bWw+Cg==