129706 2014-03-04 14:29:53 -0800 [CSS Shapes] Remove CSSBoxType member from BasicShape and CSSBasicShape 2014-04-05 01:23:06 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124173 1 betravis zoltan commit-queue esprehn+autocc glenn gyuyoung.kim kondapallykalyan macpherson menard zoltan oldest_to_newest 986981 0 betravis 2014-03-04 14:29:53 -0800 The LayoutBox has been moved up to ShapeValue and is no longer needed in the BasicShape classes. 997775 1 228640 zoltan 2014-04-04 18:06:16 -0700 Created attachment 228640 Patch 997855 2 228640 kling 2014-04-05 00:52:24 -0700 Comment on attachment 228640 Patch r=me 997860 3 228640 commit-queue 2014-04-05 01:23:01 -0700 Comment on attachment 228640 Patch Clearing flags on attachment: 228640 Committed r166830: <http://trac.webkit.org/changeset/166830> 997861 4 commit-queue 2014-04-05 01:23:06 -0700 All reviewed patches have been landed. Closing bug. 228640 2014-04-04 18:06:16 -0700 2014-04-05 01:23:01 -0700 Patch removeCSSBoxTypeFromBasicShapes.patch text/plain 3427 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MjAwYTA0Li5hY2ViNjY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTQtMDQtMDQgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NTUyBTaGFwZXNdIFJlbW92ZSBDU1NCb3hUeXBlIG1lbWJlciBmcm9tIEJhc2ljU2hh cGUgYW5kIENTU0Jhc2ljU2hhcGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEyOTcwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoZSBDU1NCb3hUeXBlIGhhcyBiZWVuIG1vdmVkIHVwIHRvIFNoYXBlVmFs dWUgYW5kIGlzIG5vIGxvbmdlciBuZWVkZWQgaW4gdGhlIEJhc2ljU2hhcGUgY2xhc3Nlcy4KKwor ICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGNz cy9CYXNpY1NoYXBlRnVuY3Rpb25zLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnZhbHVlRm9yQmFz aWNTaGFwZSk6CisgICAgICAgIChXZWJDb3JlOjpiYXNpY1NoYXBlRm9yVmFsdWUpOgorICAgICAg ICAqIHJlbmRlcmluZy9zdHlsZS9CYXNpY1NoYXBlcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpC YXNpY1NoYXBlOjpjYW5CbGVuZCk6CisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL0Jhc2ljU2hh cGVzLmg6CisgICAgICAgIChXZWJDb3JlOjpCYXNpY1NoYXBlOjpyZWZlcmVuY2VCb3gpOiBEZWxl dGVkLgorICAgICAgICAoV2ViQ29yZTo6QmFzaWNTaGFwZTo6c2V0UmVmZXJlbmNlQm94KTogRGVs ZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkJhc2ljU2hhcGU6OkJhc2ljU2hhcGUpOiBEZWxldGVk LgorCiAyMDE0LTA0LTA0ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgog CiAgICAgICAgIFVwZ3JhZGUgdG8gU2VsZWN0b3JGYWlsc0FsbFNpYmxpbmdzIHdoZW4gQ2hpbGQg c2VsZWN0b3IgaXMgZmFpbGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0Jhc2lj U2hhcGVGdW5jdGlvbnMuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0Jhc2ljU2hhcGVGdW5jdGlv bnMuY3BwCmluZGV4IDYzMzkzNjAuLjg5MDUyODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9CYXNpY1NoYXBlRnVuY3Rpb25zLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQmFz aWNTaGFwZUZ1bmN0aW9ucy5jcHAKQEAgLTEyNCw5ICsxMjQsNiBAQCBQYXNzUmVmUHRyPENTU1Zh bHVlPiB2YWx1ZUZvckJhc2ljU2hhcGUoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxlLCBjb25zdCBC YXNpY1NoYQogICAgICAgICBicmVhazsKICAgICB9CiAKLSAgICBpZiAoYmFzaWNTaGFwZS0+cmVm ZXJlbmNlQm94KCkgIT0gQm94TWlzc2luZykKLSAgICAgICAgYmFzaWNTaGFwZVZhbHVlLT5zZXRS ZWZlcmVuY2VCb3gocG9vbC5jcmVhdGVWYWx1ZShiYXNpY1NoYXBlLT5yZWZlcmVuY2VCb3goKSkp OwotCiAgICAgcmV0dXJuIHBvb2wuY3JlYXRlVmFsdWUoYmFzaWNTaGFwZVZhbHVlLnJlbGVhc2Uo KSk7CiB9CiAKQEAgLTI2NCw5ICsyNjEsNiBAQCBQYXNzUmVmUHRyPEJhc2ljU2hhcGU+IGJhc2lj U2hhcGVGb3JWYWx1ZShjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUsIGNvbnN0IFJlbmRlcgogICAg ICAgICBicmVhazsKICAgICB9CiAKLSAgICBpZiAoYmFzaWNTaGFwZVZhbHVlLT5yZWZlcmVuY2VC b3goKSkKLSAgICAgICAgYmFzaWNTaGFwZS0+c2V0UmVmZXJlbmNlQm94KENTU0JveFR5cGUoKmJh c2ljU2hhcGVWYWx1ZS0+cmVmZXJlbmNlQm94KCkpKTsKLQogICAgIHJldHVybiBiYXNpY1NoYXBl LnJlbGVhc2UoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0 eWxlL0Jhc2ljU2hhcGVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9CYXNp Y1NoYXBlcy5jcHAKaW5kZXggZDJhMGM0ZC4uMWVjYjJlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL3N0eWxlL0Jhc2ljU2hhcGVzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvQmFzaWNTaGFwZXMuY3BwCkBAIC02NCwxMCArNjQsNiBAQCBib29s IEJhc2ljU2hhcGU6OmNhbkJsZW5kKGNvbnN0IEJhc2ljU2hhcGUqIG90aGVyKSBjb25zdAogICAg IGlmICh0eXBlKCkgIT0gb3RoZXItPnR5cGUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0g ICAgLy8gQm90aCBzaGFwZXMgbXVzdCB1c2UgdGhlIHNhbWUgcmVmZXJlbmNlIGJveC4KLSAgICBp ZiAocmVmZXJlbmNlQm94KCkgIT0gb3RoZXItPnJlZmVyZW5jZUJveCgpKQotICAgICAgICByZXR1 cm4gZmFsc2U7Ci0KICAgICAvLyBKdXN0IHBvbHlnb25zIHdpdGggc2FtZSBudW1iZXIgb2YgdmVy dGljZXMgY2FuIGJlIGFuaW1hdGVkLgogICAgIGlmICh0eXBlKCkgPT0gQmFzaWNTaGFwZTo6QmFz aWNTaGFwZVBvbHlnb25UeXBlCiAgICAgICAgICYmIChzdGF0aWNfY2FzdDxjb25zdCBCYXNpY1No YXBlUG9seWdvbio+KHRoaXMpLT52YWx1ZXMoKS5zaXplKCkgIT0gc3RhdGljX2Nhc3Q8Y29uc3Qg QmFzaWNTaGFwZVBvbHlnb24qPihvdGhlciktPnZhbHVlcygpLnNpemUoKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL0Jhc2ljU2hhcGVzLmggYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvQmFzaWNTaGFwZXMuaAppbmRleCBmMmFiNGJkLi44ZTE4ZjQ2 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvQmFzaWNTaGFwZXMu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvQmFzaWNTaGFwZXMuaApAQCAt NjIsMTggKzYyLDYgQEAgcHVibGljOgogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxCYXNpY1NoYXBl PiBibGVuZChjb25zdCBCYXNpY1NoYXBlKiwgZG91YmxlKSBjb25zdCA9IDA7CiAKICAgICB2aXJ0 dWFsIFR5cGUgdHlwZSgpIGNvbnN0ID0gMDsKLQotICAgIENTU0JveFR5cGUgcmVmZXJlbmNlQm94 KCkgY29uc3QgeyByZXR1cm4gbV9yZWZlcmVuY2VCb3g7IH0KLSAgICB2b2lkIHNldFJlZmVyZW5j ZUJveChDU1NCb3hUeXBlIHJlZmVyZW5jZUJveCkgeyBtX3JlZmVyZW5jZUJveCA9IHJlZmVyZW5j ZUJveDsgfQotCi1wcm90ZWN0ZWQ6Ci0gICAgQmFzaWNTaGFwZSgpCi0gICAgICAgIDogbV9yZWZl cmVuY2VCb3goQm94TWlzc2luZykKLSAgICB7Ci0gICAgfQotCi1wcml2YXRlOgotICAgIENTU0Jv eFR5cGUgbV9yZWZlcmVuY2VCb3g7CiB9OwogCiBjbGFzcyBCYXNpY1NoYXBlQ2VudGVyQ29vcmRp bmF0ZSB7Cg==