128953 2014-02-17 22:02:23 -0800 TextFieldInputType::handleBeforeTextInsertedEvent shouldn't use plainText 2014-02-18 15:59:05 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127832 1 rniwa rniwa ap darin enrica kling koivisto oldest_to_newest 981789 0 rniwa 2014-02-17 22:02:23 -0800 Right now TextFieldInputType::handleBeforeTextInsertedEvent uses plainText, which triggers a synchronous layout. We shouldn't use that. Also, plainText uses render text, etc... to obtain text may collapse some whitespaces which may or may not affect the result numGraphemeClusters returns. Instead, use cached selection start & selection end to subtract the part of the inner text that has been selected. 981790 1 224471 rniwa 2014-02-17 22:04:04 -0800 Created attachment 224471 Fixes the bug 982152 2 rniwa 2014-02-18 15:59:05 -0800 Committed r164329: <http://trac.webkit.org/changeset/164329> 224471 2014-02-17 22:04:04 -0800 2014-02-18 15:00:26 -0800 Fixes the bug bug-128953-20140217220420.patch text/plain 2477 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDI3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAyLTE3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFRleHRGaWVsZElucHV0VHlwZTo6 aGFuZGxlQmVmb3JlVGV4dEluc2VydGVkRXZlbnQgc2hvdWxkbid0IHVzZSBwbGFpblRleHQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyODk1MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHVzZSBG cmFtZVNlbGVjdGlvbidzIHRvTm9ybWFsaXplZFJhbmdlIGFuZCBwbGFpblRleHQuIEluc3RlYWQs IHVzZSB0aGUgY2FjaGVkIHNlbGVjdGlvbiBzdGFydCBhbmQgc2VsZWN0aW9uCisgICAgICAgIGVu ZCB0byBleHRyYWN0IHRoZSBzZWxlY3RlZCB0ZXh0LgorCisgICAgICAgICogaHRtbC9UZXh0Rmll bGRJbnB1dFR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VGV4dEZpZWxkSW5wdXRUeXBlOjpo YW5kbGVCZWZvcmVUZXh0SW5zZXJ0ZWRFdmVudCk6CisKIDIwMTQtMDItMTcgIFJpY2t5IE1vbmRl bGxvICA8cm1vbmRlbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBFeHBvc2UgYSB3YXkgdG8gY2xl YXIgY29va2llcyBtb2RpZmllZCBhZnRlciBhIGdpdmVuIGRhdGUKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9odG1sL1RleHRGaWVsZElucHV0VHlwZS5jcHAJKHJldmlzaW9uIDE2NDI3MikKKysrIFNv dXJjZS9XZWJDb3JlL2h0bWwvVGV4dEZpZWxkSW5wdXRUeXBlLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMzc0LDE0ICszNzQsMTkgQEAgdm9pZCBUZXh0RmllbGRJbnB1dFR5cGU6OmhhbmRsZUJlZm9y ZVRleAogICAgIC8vIFdlIHVzZSBSZW5kZXJUZXh0Q29udHJvbFNpbmdsZUxpbmU6OnRleHQoKSBp bnN0ZWFkIG9mIElucHV0RWxlbWVudDo6dmFsdWUoKQogICAgIC8vIGJlY2F1c2UgdGhleSBjYW4g YmUgbWlzbWF0Y2hlZCBieSBzYW5pdGl6ZVZhbHVlKCkgaW4KICAgICAvLyBIVE1MSW5wdXRFbGVt ZW50OjpzdWJ0cmVlSGFzQ2hhbmdlZCgpIGluIHNvbWUgY2FzZXMuCi0gICAgdW5zaWduZWQgb2xk TGVuZ3RoID0gbnVtR3JhcGhlbWVDbHVzdGVycyhlbGVtZW50KCkuaW5uZXJUZXh0VmFsdWUoKSk7 CisgICAgU3RyaW5nIGlubmVyVGV4dCA9IGVsZW1lbnQoKS5pbm5lclRleHRWYWx1ZSgpOworICAg IHVuc2lnbmVkIG9sZExlbmd0aCA9IG51bUdyYXBoZW1lQ2x1c3RlcnMoaW5uZXJUZXh0KTsKIAog ICAgIC8vIHNlbGVjdGlvbkxlbmd0aCByZXByZXNlbnRzIHRoZSBzZWxlY3Rpb24gbGVuZ3RoIG9m IHRoaXMgdGV4dCBmaWVsZCB0byBiZQogICAgIC8vIHJlbW92ZWQgYnkgdGhpcyBpbnNlcnRpb24u CiAgICAgLy8gSWYgdGhlIHRleHQgZmllbGQgaGFzIG5vIGZvY3VzLCB3ZSBkb24ndCBuZWVkIHRv IHRha2UgYWNjb3VudCBvZiB0aGUKICAgICAvLyBzZWxlY3Rpb24gbGVuZ3RoLiBUaGUgc2VsZWN0 aW9uIGlzIHRoZSBzb3VyY2Ugb2YgdGV4dCBkcmFnLWFuZC1kcm9wIGluCiAgICAgLy8gdGhhdCBj YXNlLCBhbmQgbm90aGluZyBpbiB0aGUgdGV4dCBmaWVsZCB3aWxsIGJlIHJlbW92ZWQuCi0gICAg dW5zaWduZWQgc2VsZWN0aW9uTGVuZ3RoID0gZWxlbWVudCgpLmZvY3VzZWQoKSA/IG51bUdyYXBo ZW1lQ2x1c3RlcnMocGxhaW5UZXh0KGVsZW1lbnQoKS5kb2N1bWVudCgpLmZyYW1lKCktPnNlbGVj dGlvbigpLnNlbGVjdGlvbigpLnRvTm9ybWFsaXplZFJhbmdlKCkuZ2V0KCkpKSA6IDA7CisgICAg dW5zaWduZWQgc2VsZWN0aW9uTGVuZ3RoID0gMDsKKyAgICBpZiAoZWxlbWVudCgpLmZvY3VzZWQo KSkgeworICAgICAgICBBU1NFUlQoZW5jbG9zaW5nVGV4dEZvcm1Db250cm9sKGVsZW1lbnQoKS5k b2N1bWVudCgpLmZyYW1lKCktPnNlbGVjdGlvbigpLnNlbGVjdGlvbigpLnN0YXJ0KCkpID09ICZl bGVtZW50KCkpOworICAgICAgICBzZWxlY3Rpb25MZW5ndGggPSBudW1HcmFwaGVtZUNsdXN0ZXJz KGlubmVyVGV4dC5zdWJzdHJpbmcoZWxlbWVudCgpLnNlbGVjdGlvblN0YXJ0KCksIGVsZW1lbnQo KS5zZWxlY3Rpb25FbmQoKSkpOworICAgIH0KICAgICBBU1NFUlQob2xkTGVuZ3RoID49IHNlbGVj dGlvbkxlbmd0aCk7CiAKICAgICAvLyBTZWxlY3RlZCBjaGFyYWN0ZXJzIHdpbGwgYmUgcmVtb3Zl ZCBieSB0aGUgbmV4dCB0ZXh0IGV2ZW50Lgo=