128951 2014-02-17 21:16:00 -0800 FrameSelection::textWasReplaced and setSelectedRange shouldn't trigger synchronous layout 2014-02-18 14:30:02 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127832 1 rniwa rniwa commit-queue oldest_to_newest 981780 0 rniwa 2014-02-17 21:16:00 -0800 FrameSelection::textWasReplaced and FrameSelection::setSelectedRange triggers superflous synchronous layout. We shouldn't do that. 981781 1 224466 rniwa 2014-02-17 21:21:10 -0800 Created attachment 224466 Cleanup 982111 2 224466 commit-queue 2014-02-18 14:30:00 -0800 Comment on attachment 224466 Cleanup Clearing flags on attachment: 224466 Committed r164319: <http://trac.webkit.org/changeset/164319> 982112 3 commit-queue 2014-02-18 14:30:02 -0800 All reviewed patches have been landed. Closing bug. 224466 2014-02-17 21:21:10 -0800 2014-02-18 14:30:00 -0800 Cleanup bug-128951-20140217212127.patch text/plain 2744 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDI3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAyLTE3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEZyYW1lU2VsZWN0aW9uOjp0ZXh0 V2FzUmVwbGFjZWQgYW5kIHNldFNlbGVjdGVkUmFuZ2Ugc2hvdWxkbid0IHRyaWdnZXIgc3luY2hy b25vdXMgbGF5b3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjg5NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDbGVhbnVwLgorCisgICAgICAgICogZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGcmFtZVNlbGVjdGlvbjo6dGV4dFdhc1JlcGxhY2VkKTogRG9uJ3Qg Y2FsbCB1cGRhdGVMYXlvdXQuIEl0J3MgdG90YWxseSB1bm5lY2Vzc2FyaWx5LgorICAgICAgICAo V2ViQ29yZTo6RnJhbWVTZWxlY3Rpb246OnNldFNlbGVjdGVkUmFuZ2UpOiBEaXR0by4gQWxzbyBy ZW1vdmVkIHRoZSBjb2RlIHRvIHNldCBhZmZpbml0eSBvbmx5IHdoZW4KKyAgICAgICAgcmFuZ2Ug aXMgY29sbGFwc2VkIHNpbmNlIFZpc2libGVTZWxlY3Rpb246OnZhbGlkYXRlIGFscmVhZHkgZG9l cyB0aGlzLgorCiAyMDE0LTAyLTE3ICBSaWNreSBNb25kZWxsbyAgPHJtb25kZWxsb0BhcHBsZS5j b20+CiAKICAgICAgICAgRXhwb3NlIGEgd2F5IHRvIGNsZWFyIGNvb2tpZXMgbW9kaWZpZWQgYWZ0 ZXIgYSBnaXZlbiBkYXRlCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0 aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0 aW9uLmNwcAkocmV2aXNpb24gMTY0MjY5KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFt ZVNlbGVjdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxMyw3ICs1MTMsNiBAQCB2b2lkIEZy YW1lU2VsZWN0aW9uOjp0ZXh0V2FzUmVwbGFjZWQoQ2hhCiAgICAgICAgIGVsc2UKICAgICAgICAg ICAgIG5ld1NlbGVjdGlvbi5zZXRXaXRob3V0VmFsaWRhdGlvbihzdGFydCwgZW5kKTsKIAotICAg ICAgICBtX2ZyYW1lLT5kb2N1bWVudCgpLT51cGRhdGVMYXlvdXQoKTsKICAgICAgICAgc2V0U2Vs ZWN0aW9uKG5ld1NlbGVjdGlvbiwgRG9Ob3RTZXRGb2N1cyk7CiAgICAgfQogfQpAQCAtMTY5OCwy NSArMTY5NywxNSBAQCBib29sIEZyYW1lU2VsZWN0aW9uOjpzZXRTZWxlY3RlZFJhbmdlKFJhCiAg ICAgICAgIHJldHVybiBmYWxzZTsKICAgICBBU1NFUlQoJnJhbmdlLT5zdGFydENvbnRhaW5lcigp LT5kb2N1bWVudCgpID09ICZyYW5nZS0+ZW5kQ29udGFpbmVyKCktPmRvY3VtZW50KCkpOwogCi0g ICAgbV9mcmFtZS0+ZG9jdW1lbnQoKS0+dXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hl ZXRzKCk7Ci0KLSAgICAvLyBOb24tY29sbGFwc2VkIHJhbmdlcyBhcmUgbm90IGFsbG93ZWQgdG8g c3RhcnQgYXQgdGhlIGVuZCBvZiBhIGxpbmUgdGhhdCBpcyB3cmFwcGVkLAotICAgIC8vIHRoZXkg c3RhcnQgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUgbmV4dCBsaW5lIGluc3RlYWQKLSAgICBFeGNl cHRpb25Db2RlIGVjID0gMDsKLSAgICBib29sIGNvbGxhcHNlZCA9IHJhbmdlLT5jb2xsYXBzZWQo ZWMpOwotICAgIGlmIChlYykKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIFZpc2libGVTZWxl Y3Rpb24gbmV3U2VsZWN0aW9uKHJhbmdlLCBhZmZpbml0eSk7CiAKLSAgICAvLyBGSVhNRTogQ2Fu IHdlIHByb3ZpZGUgZXh0ZW50QWZmaW5pdHk/Ci0gICAgVmlzaWJsZVBvc2l0aW9uIHZpc2libGVT dGFydChyYW5nZS0+c3RhcnRQb3NpdGlvbigpLCBjb2xsYXBzZWQgPyBhZmZpbml0eSA6IERPV05T VFJFQU0pOwotICAgIFZpc2libGVQb3NpdGlvbiB2aXNpYmxlRW5kKHJhbmdlLT5lbmRQb3NpdGlv bigpLCBTRUxfREVGQVVMVF9BRkZJTklUWSk7CiAjaWYgUExBVEZPUk0oSU9TKQotICAgIGlmIChy YW5nZS0+c3RhcnRDb250YWluZXIoKSAmJiB2aXNpYmxlU3RhcnQuaXNOdWxsKCkpCi0gICAgICAg IHJldHVybiBmYWxzZTsKLSAgICBpZiAocmFuZ2UtPmVuZENvbnRhaW5lcigpICYmIHZpc2libGVF bmQuaXNOdWxsKCkpCisgICAgLy8gRklYTUU6IFdoeSBkbyB3ZSBuZWVkIHRoaXMgY2hlY2sgb25s eSBpbiBpT1M/CisgICAgaWYgKHJhbmdlLT5zdGFydENvbnRhaW5lcigpICYmIHJhbmdlLT5lbmRD b250YWluZXIoKSAmJiBuZXdTZWxlY3Rpb24uaXNOdWxsKCkpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKICNlbmRpZgotICAgIHNldFNlbGVjdGlvbihWaXNpYmxlU2VsZWN0aW9uKHZpc2libGVTdGFy dCwgdmlzaWJsZUVuZCksIENsZWFyVHlwaW5nU3R5bGUgfCAoY2xvc2VUeXBpbmcgPyBDbG9zZVR5 cGluZyA6IDApKTsKKworICAgIHNldFNlbGVjdGlvbihuZXdTZWxlY3Rpb24sIENsZWFyVHlwaW5n U3R5bGUgfCAoY2xvc2VUeXBpbmcgPyBDbG9zZVR5cGluZyA6IDApKTsKICAgICByZXR1cm4gdHJ1 ZTsKIH0KIAo=