128881 2014-02-15 20:19:18 -0800 setSelectionRange shouldn't directly instantiate VisibleSelection 2014-02-16 13:55:13 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127832 1 rniwa rniwa commit-queue oldest_to_newest 981251 0 rniwa 2014-02-15 20:19:18 -0800 This triggers synchronous layout. 981252 1 rniwa 2014-02-15 20:20:05 -0800 The scope of this bug is to encapsulate the instantiation of VisibleSelection into FrameSelection so that we may optimize them away later. 981253 2 224313 rniwa 2014-02-15 20:22:30 -0800 Created attachment 224313 Fixes the bug 981289 3 224313 kling 2014-02-16 13:24:27 -0800 Comment on attachment 224313 Fixes the bug r=me 981292 4 224313 commit-queue 2014-02-16 13:55:11 -0800 Comment on attachment 224313 Fixes the bug Clearing flags on attachment: 224313 Committed r164194: <http://trac.webkit.org/changeset/164194> 981293 5 commit-queue 2014-02-16 13:55:13 -0800 All reviewed patches have been landed. Closing bug. 224313 2014-02-15 20:22:30 -0800 2014-02-16 13:55:11 -0800 Fixes the bug bug-128881-20140215202237.patch text/plain 4309 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDE4OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAyLTE1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIHNldFNlbGVjdGlvblJhbmdlIHNo b3VsZG4ndCBkaXJlY3RseSBpbnN0YW50aWF0ZSBWaXNpYmxlU2VsZWN0aW9uCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg4ODEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIG5ldyB2ZXJzaW9u IG9mIG1vdmVUbyBmb3Igc2V0U2VsZWN0aW9uUmFuZ2UuCisKKyAgICAgICAgKiBlZGl0aW5nL0Zy YW1lU2VsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uOjptb3Zl VG8pOiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmg6CisgICAgICAg ICogaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6c2V0U2VsZWN0aW9uUmFuZ2UpOiBVc2UgdGhl IG5ld2x5IGFkZGVkIEZyYW1lU2VsZWN0aW9uOjptb3ZlVG8KKyAgICAgICAgaW5zdGVhZCBvZiBt YW51YWxseSBpbnN0YW50aWF0aW5nIFZpc2libGVTZWxlY3Rpb24gaGVyZS4KKwogMjAxNC0wMi0x NSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBET01TZWxlY3Rp b24gc2hvdWxkbid0IGluc3RhbnRpYXRlIFZpc2libGVTZWxlY3Rpb24gZXZlcnl3aGVyZQpJbmRl eDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5jcHAJKHJldmlzaW9uIDE2 NDE4NikKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNjQsNiArMTY0LDEyIEBAIHZvaWQgRnJhbWVTZWxlY3Rpb246Om1vdmVU byhjb25zdCBQb3NpdGkKICAgICBzZXRTZWxlY3Rpb24oVmlzaWJsZVNlbGVjdGlvbihiYXNlLCBl eHRlbnQsIGFmZmluaXR5LCBzZWxlY3Rpb25IYXNEaXJlY3Rpb24pLCBkZWZhdWx0U2V0U2VsZWN0 aW9uT3B0aW9ucyh1c2VyVHJpZ2dlcmVkKSk7CiB9CiAKK3ZvaWQgRnJhbWVTZWxlY3Rpb246Om1v dmVUbyhjb25zdCBQb3NpdGlvbiYgYmFzZSwgY29uc3QgUG9zaXRpb24mIGV4dGVudCwgYm9vbCBz ZWxlY3Rpb25IYXNEaXJlY3Rpb24sIGJvb2wgc2hvdWxkU2V0Rm9jdXMpCit7CisgICAgc2V0U2Vs ZWN0aW9uKFZpc2libGVTZWxlY3Rpb24oYmFzZSwgZXh0ZW50LCBET1dOU1RSRUFNLCBzZWxlY3Rp b25IYXNEaXJlY3Rpb24pLAorICAgICAgICBkZWZhdWx0U2V0U2VsZWN0aW9uT3B0aW9ucygpIHwg KHNob3VsZFNldEZvY3VzID8gMCA6IERvTm90U2V0Rm9jdXMpKTsKK30KKwogdm9pZCBEcmFnQ2Fy ZXRDb250cm9sbGVyOjpzZXRDYXJldFBvc2l0aW9uKGNvbnN0IFZpc2libGVQb3NpdGlvbiYgcG9z aXRpb24pCiB7CiAgICAgaWYgKE5vZGUqIG5vZGUgPSBtX3Bvc2l0aW9uLmRlZXBFcXVpdmFsZW50 KCkuZGVwcmVjYXRlZE5vZGUoKSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVT ZWxlY3Rpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2Vs ZWN0aW9uLmgJKHJldmlzaW9uIDE2NDE4NikKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJh bWVTZWxlY3Rpb24uaAkod29ya2luZyBjb3B5KQpAQCAtMTQwLDYgKzE0MCw3IEBAIHB1YmxpYzoK ICAgICB2b2lkIG1vdmVUbyhjb25zdCBWaXNpYmxlUG9zaXRpb24mLCBjb25zdCBWaXNpYmxlUG9z aXRpb24mLCBFVXNlclRyaWdnZXJlZCA9IE5vdFVzZXJUcmlnZ2VyZWQpOwogICAgIHZvaWQgbW92 ZVRvKGNvbnN0IFBvc2l0aW9uJiwgRUFmZmluaXR5LCBFVXNlclRyaWdnZXJlZCA9IE5vdFVzZXJU cmlnZ2VyZWQpOwogICAgIHZvaWQgbW92ZVRvKGNvbnN0IFBvc2l0aW9uJiwgY29uc3QgUG9zaXRp b24mLCBFQWZmaW5pdHksIEVVc2VyVHJpZ2dlcmVkID0gTm90VXNlclRyaWdnZXJlZCk7CisgICAg dm9pZCBtb3ZlVG8oY29uc3QgUG9zaXRpb24mLCBjb25zdCBQb3NpdGlvbiYsIGJvb2wgc2VsZWN0 aW9uSGFzRGlyZWN0aW9uLCBib29sIHNob3VsZFNldEZvY3VzKTsKIAogICAgIGNvbnN0IFZpc2li bGVTZWxlY3Rpb24mIHNlbGVjdGlvbigpIGNvbnN0IHsgcmV0dXJuIG1fc2VsZWN0aW9uOyB9CiAg ICAgdm9pZCBzZXRTZWxlY3Rpb24oY29uc3QgVmlzaWJsZVNlbGVjdGlvbiYsIFNldFNlbGVjdGlv bk9wdGlvbnMgPSBkZWZhdWx0U2V0U2VsZWN0aW9uT3B0aW9ucygpLCBDdXJzb3JBbGlnbk9uU2Ny b2xsID0gQWxpZ25DdXJzb3JPblNjcm9sbElmTmVlZGVkLCBUZXh0R3JhbnVsYXJpdHkgPSBDaGFy YWN0ZXJHcmFudWxhcml0eSk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9y bUNvbnRyb2xFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50LmNwcAkocmV2aXNpb24gMTY0MTgzKQorKysgU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTMwNiwyMSArMzA2LDE2IEBAIHZvaWQgSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6 OnNldFNlbGUKICAgICBQb3NpdGlvbiBlbmRQb3NpdGlvbjsKICAgICBpZiAoc3RhcnQgPT0gZW5k KQogICAgICAgICBlbmRQb3NpdGlvbiA9IHN0YXJ0UG9zaXRpb247Ci0gICAgZWxzZQotICAgICAg ICBlbmRQb3NpdGlvbiA9IHBvc2l0aW9uRm9ySW5kZXgoaW5uZXJUZXh0LCBlbmQpOworICAgIGVs c2UgeworICAgICAgICBpZiAoZGlyZWN0aW9uID09IFNlbGVjdGlvbkhhc0JhY2t3YXJkRGlyZWN0 aW9uKSB7CisgICAgICAgICAgICBlbmRQb3NpdGlvbiA9IHN0YXJ0UG9zaXRpb247CisgICAgICAg ICAgICBzdGFydFBvc2l0aW9uID0gcG9zaXRpb25Gb3JJbmRleChpbm5lclRleHQsIGVuZCk7Cisg ICAgICAgIH0gZWxzZQorICAgICAgICAgICAgZW5kUG9zaXRpb24gPSBwb3NpdGlvbkZvckluZGV4 KGlubmVyVGV4dCwgZW5kKTsKKyAgICB9CiAKLSAgICBWaXNpYmxlU2VsZWN0aW9uIG5ld1NlbGVj dGlvbjsKLSAgICBpZiAoZGlyZWN0aW9uID09IFNlbGVjdGlvbkhhc0JhY2t3YXJkRGlyZWN0aW9u KQotICAgICAgICBuZXdTZWxlY3Rpb24gPSBWaXNpYmxlU2VsZWN0aW9uKGVuZFBvc2l0aW9uLCBz dGFydFBvc2l0aW9uKTsKLSAgICBlbHNlCi0gICAgICAgIG5ld1NlbGVjdGlvbiA9IFZpc2libGVT ZWxlY3Rpb24oc3RhcnRQb3NpdGlvbiwgZW5kUG9zaXRpb24pOwotICAgIG5ld1NlbGVjdGlvbi5z ZXRJc0RpcmVjdGlvbmFsKGRpcmVjdGlvbiAhPSBTZWxlY3Rpb25IYXNOb0RpcmVjdGlvbik7Ci0K LSAgICBGcmFtZVNlbGVjdGlvbjo6U2V0U2VsZWN0aW9uT3B0aW9ucyBvcHRpb25zID0gRnJhbWVT ZWxlY3Rpb246OmRlZmF1bHRTZXRTZWxlY3Rpb25PcHRpb25zKCk7Ci0gICAgaWYgKGhhc0ZvY3Vz KQotICAgICAgICBvcHRpb25zIHw9IEZyYW1lU2VsZWN0aW9uOjpEb05vdFNldEZvY3VzOwogICAg IGlmIChGcmFtZSogZnJhbWUgPSBkb2N1bWVudCgpLmZyYW1lKCkpCi0gICAgICAgIGZyYW1lLT5z ZWxlY3Rpb24oKS5zZXRTZWxlY3Rpb24obmV3U2VsZWN0aW9uLCBvcHRpb25zKTsKKyAgICAgICAg ZnJhbWUtPnNlbGVjdGlvbigpLm1vdmVUbyhzdGFydFBvc2l0aW9uLCBlbmRQb3NpdGlvbiwgZGly ZWN0aW9uICE9IFNlbGVjdGlvbkhhc05vRGlyZWN0aW9uLCAhaGFzRm9jdXMpOwogfQogCiBpbnQg SFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OmluZGV4Rm9yVmlzaWJsZVBvc2l0aW9uKGNvbnN0 IFZpc2libGVQb3NpdGlvbiYgcG9zaXRpb24pIGNvbnN0Cg==