128878 2014-02-15 18:43:46 -0800 Remove unused arguments from moveTo(Range*) 2014-02-15 19:02:06 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127832 1 rniwa rniwa benjamin darin kling koivisto oldest_to_newest 981224 0 rniwa 2014-02-15 18:43:46 -0800 The second and the third argument of moveTo(Range*, ...) don't seem to be used anywhere. Just get rid of them. 981227 1 224304 rniwa 2014-02-15 18:44:38 -0800 Created attachment 224304 Cleanup 981231 2 224304 koivisto 2014-02-15 18:58:03 -0800 Comment on attachment 224304 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=224304&action=review > Source/WebCore/editing/FrameSelection.cpp:155 > +void FrameSelection::moveTo(const Range *r) you could fix the coding style for Range since you are here 981235 3 rniwa 2014-02-15 19:02:06 -0800 Committed r164186: <http://trac.webkit.org/changeset/164186> 224304 2014-02-15 18:44:38 -0800 2014-02-15 18:58:03 -0800 Cleanup bug-128878-20140215184445.patch text/plain 3627 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDE4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE0LTAyLTE1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgYXJndW1l bnRzIGZyb20gbW92ZVRvKFJhbmdlKikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyODg3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIENsZWFudXAuCisKKyAgICAgICAgKiBiaW5kaW5ncy9vYmpjL0RPTVVJ S2l0RXh0ZW5zaW9ucy5tbToKKyAgICAgICAgKC1bRE9NUmFuZ2UgbW92ZTppbkRpcmVjdGlvbjpd KToKKyAgICAgICAgKC1bRE9NUmFuZ2UgZXh0ZW5kOmluRGlyZWN0aW9uOl0pOgorICAgICAgICAq IGVkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVTZWxl Y3Rpb246Om1vdmVUbyk6CisgICAgICAgICogZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5oOgorCiAy MDE0LTAyLTE1ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgY2hlY2tlZCBjYXN0cyBmb3IgRXZlbnQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9vYmpjL0RPTVVJS2l0RXh0ZW5zaW9ucy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9vYmpjL0RPTVVJS2l0RXh0ZW5zaW9ucy5tbQkocmV2aXNpb24gMTY0MTgzKQor KysgU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvb2JqYy9ET01VSUtpdEV4dGVuc2lvbnMubW0JKHdv cmtpbmcgY29weSkKQEAgLTk0LDcgKzk0LDcgQEAgLSAodm9pZCltb3ZlOihVSW50MzIpYW1vdW50 IGluRGlyZWN0aW9uOgogewogICAgIFJhbmdlICpyYW5nZSA9IGNvcmUoc2VsZik7CiAgICAgRnJh bWVTZWxlY3Rpb24gZnJhbWVTZWxlY3Rpb247Ci0gICAgZnJhbWVTZWxlY3Rpb24ubW92ZVRvKHJh bmdlLCBET1dOU1RSRUFNKTsKKyAgICBmcmFtZVNlbGVjdGlvbi5tb3ZlVG8ocmFuZ2UpOwogICAg IAogICAgIFRleHRHcmFudWxhcml0eSBncmFudWxhcml0eSA9IENoYXJhY3RlckdyYW51bGFyaXR5 OwogICAgIC8vIFVudGlsIFdlYktpdCBzdXBwb3J0cyB2ZXJ0aWNhbCBsYXlvdXQsICJkb3duIiBp cyBlcXVpdmFsZW50IHRvICJmb3J3YXJkIGJ5IGEgbGluZSIgYW5kCkBAIC0xMjEsNyArMTIxLDcg QEAgLSAodm9pZClleHRlbmQ6KFVJbnQzMilhbW91bnQgaW5EaXJlY3RpbwogewogICAgIFJhbmdl ICpyYW5nZSA9IGNvcmUoc2VsZik7CiAgICAgRnJhbWVTZWxlY3Rpb24gZnJhbWVTZWxlY3Rpb247 Ci0gICAgZnJhbWVTZWxlY3Rpb24ubW92ZVRvKHJhbmdlLCBET1dOU1RSRUFNKTsKKyAgICBmcmFt ZVNlbGVjdGlvbi5tb3ZlVG8ocmFuZ2UpOwogICAgIAogICAgIGZvciAoVUludDMyIGkgPSAwOyBp IDwgYW1vdW50OyBpKyspCiAgICAgICAgIGZyYW1lU2VsZWN0aW9uLm1vZGlmeShGcmFtZVNlbGVj dGlvbjo6QWx0ZXJhdGlvbkV4dGVuZCwgKFNlbGVjdGlvbkRpcmVjdGlvbilkaXJlY3Rpb24sIENo YXJhY3RlckdyYW51bGFyaXR5KTsgICAgCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0Zy YW1lU2VsZWN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0Zy YW1lU2VsZWN0aW9uLmNwcAkocmV2aXNpb24gMTY0MTgzKQorKysgU291cmNlL1dlYkNvcmUvZWRp dGluZy9GcmFtZVNlbGVjdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1MiwxMCArMTUyLDEw IEBAIHZvaWQgRnJhbWVTZWxlY3Rpb246Om1vdmVUbyhjb25zdCBQb3NpdGkKICAgICBzZXRTZWxl Y3Rpb24oVmlzaWJsZVNlbGVjdGlvbihwb3MsIGFmZmluaXR5LCBtX3NlbGVjdGlvbi5pc0RpcmVj dGlvbmFsKCkpLCBkZWZhdWx0U2V0U2VsZWN0aW9uT3B0aW9ucyh1c2VyVHJpZ2dlcmVkKSk7CiB9 CiAKLXZvaWQgRnJhbWVTZWxlY3Rpb246Om1vdmVUbyhjb25zdCBSYW5nZSAqciwgRUFmZmluaXR5 IGFmZmluaXR5LCBFVXNlclRyaWdnZXJlZCB1c2VyVHJpZ2dlcmVkKQordm9pZCBGcmFtZVNlbGVj dGlvbjo6bW92ZVRvKGNvbnN0IFJhbmdlICpyKQogewotICAgIFZpc2libGVTZWxlY3Rpb24gc2Vs ZWN0aW9uID0gciA/IFZpc2libGVTZWxlY3Rpb24oci0+c3RhcnRQb3NpdGlvbigpLCByLT5lbmRQ b3NpdGlvbigpLCBhZmZpbml0eSkgOiBWaXNpYmxlU2VsZWN0aW9uKFBvc2l0aW9uKCksIFBvc2l0 aW9uKCksIGFmZmluaXR5KTsKLSAgICBzZXRTZWxlY3Rpb24oc2VsZWN0aW9uLCBkZWZhdWx0U2V0 U2VsZWN0aW9uT3B0aW9ucyh1c2VyVHJpZ2dlcmVkKSk7CisgICAgVmlzaWJsZVNlbGVjdGlvbiBz ZWxlY3Rpb24gPSByID8gVmlzaWJsZVNlbGVjdGlvbihyLT5zdGFydFBvc2l0aW9uKCksIHItPmVu ZFBvc2l0aW9uKCkpIDogVmlzaWJsZVNlbGVjdGlvbigpOworICAgIHNldFNlbGVjdGlvbihzZWxl Y3Rpb24pOwogfQogCiB2b2lkIEZyYW1lU2VsZWN0aW9uOjptb3ZlVG8oY29uc3QgUG9zaXRpb24g JmJhc2UsIGNvbnN0IFBvc2l0aW9uICZleHRlbnQsIEVBZmZpbml0eSBhZmZpbml0eSwgRVVzZXJU cmlnZ2VyZWQgdXNlclRyaWdnZXJlZCkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJh bWVTZWxlY3Rpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1l U2VsZWN0aW9uLmgJKHJldmlzaW9uIDE2NDE4MykKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RnJhbWVTZWxlY3Rpb24uaAkod29ya2luZyBjb3B5KQpAQCAtMTM1LDcgKzEzNSw3IEBAIHB1Ymxp YzoKIAogICAgIEVsZW1lbnQqIHJvb3RFZGl0YWJsZUVsZW1lbnRPckRvY3VtZW50RWxlbWVudCgp IGNvbnN0OwogICAgICAKLSAgICB2b2lkIG1vdmVUbyhjb25zdCBSYW5nZSosIEVBZmZpbml0eSwg RVVzZXJUcmlnZ2VyZWQgPSBOb3RVc2VyVHJpZ2dlcmVkKTsKKyAgICB2b2lkIG1vdmVUbyhjb25z dCBSYW5nZSopOwogICAgIHZvaWQgbW92ZVRvKGNvbnN0IFZpc2libGVQb3NpdGlvbiYsIEVVc2Vy VHJpZ2dlcmVkID0gTm90VXNlclRyaWdnZXJlZCwgQ3Vyc29yQWxpZ25PblNjcm9sbCA9IEFsaWdu Q3Vyc29yT25TY3JvbGxJZk5lZWRlZCk7CiAgICAgdm9pZCBtb3ZlVG8oY29uc3QgVmlzaWJsZVBv c2l0aW9uJiwgY29uc3QgVmlzaWJsZVBvc2l0aW9uJiwgRVVzZXJUcmlnZ2VyZWQgPSBOb3RVc2Vy VHJpZ2dlcmVkKTsKICAgICB2b2lkIG1vdmVUbyhjb25zdCBQb3NpdGlvbiYsIEVBZmZpbml0eSwg RVVzZXJUcmlnZ2VyZWQgPSBOb3RVc2VyVHJpZ2dlcmVkKTsK