128804 2014-02-14 01:02:31 -0800 setSelectionRange shouldn't trigger a synchronous layout to check focusability when text field is already focused 2014-02-14 20:48:12 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 127832 1 rniwa rniwa barraclough benjamin commit-queue darin enrica kling koivisto oldest_to_newest 980690 0 rniwa 2014-02-14 01:02:31 -0800 HTMLTextFormControl::setSelectionRange doesn't need to trigger a synchronous layout if the text field is already focused since we don't need to call hasVisibleTextArea in that case, which depends on the dimension of RenderBox. 980691 1 rniwa 2014-02-14 01:04:03 -0800 We can get rid of synchronous layout completely once we fix webkit.org/b/38696 as I've outlined in https://lists.webkit.org/pipermail/webkit-dev/2014-February/026235.html but we can fix this one first in order to resolve the bug 128797 since we don't call setSelectionRange in setValue when the text field is not focused. 980713 2 224186 rniwa 2014-02-14 02:37:05 -0800 Created attachment 224186 Fixes the bug 980714 3 commit-queue 2014-02-14 02:38:14 -0800 Attachment 224186 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:19: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 980925 4 224186 rniwa 2014-02-14 12:55:05 -0800 Comment on attachment 224186 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=224186&action=review > Source/WebCore/ChangeLog:19 > + already. Also pass in DoNotSetFocus option to setSelection since we already have the focus in that case. Odd. I thought I removed this tab character before uploading it :/ 980997 5 224186 enrica 2014-02-14 14:29:48 -0800 Comment on attachment 224186 Fixes the bug Looks good. 981085 6 rniwa 2014-02-14 20:48:12 -0800 Committed r164156: <http://trac.webkit.org/changeset/164156> 224186 2014-02-14 02:37:05 -0800 2014-02-14 14:29:48 -0800 Fixes the bug bug-128804-20140214023705.patch text/plain 5684 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2NDA5NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTAyLTE0ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIHNldFNlbGVjdGlvblJhbmdlIHNo b3VsZG4ndCB0cmlnZ2VyIGEgc3luY2hyb25vdXMgbGF5b3V0IHRvIGNoZWNrIGZvY3VzYWJpbGl0 eSB3aGVuIHRleHQgZmllbGQgaXMgYWxyZWFkeSBmb2N1c2VkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjg4MDQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCB0cmlnZ2VyIGEgc3luY2hyb25vdXMg bGF5b3V0IGF0IHRoZSBiZWdpbm5pbmcgb2Ygc2V0U2VsZWN0aW9uUmFuZ2UgaWYgdGhlIGVsZW1l bnQgaXMgYWxyZWFkeSBmb2N1c2VkCisgICAgICAgIHNpbmNlIHdlIGRvbid0IGhhdmUgdG8gY2hl Y2sgdGhlIHNpemUgb2YgcmVuZGVyIGJveCBpbiB0aGF0IGNhc2UuCisKKyAgICAgICAgV2Ugc2hv dWxkIGJlIGFibGUgdG8gZ2V0IHJpZCBvZiB0aGlzIHN5bmNocm9ub3VzIGxheW91dCBlbnRpcmVs eSBvbmNlIHdlIGZpeCBodHRwczovL3dlYmtpdC5vcmcvYi8xMjg3OTcKKyAgICAgICAgYnV0IHRo YXQncyBzb21ld2hhdCByaXNreSBiZWhhdmlvcmFsIGNoYW5nZSBzbyB3ZSdsbCBkbyB0aGF0IGlu IGEgc2VwYXJhdGUgcGF0Y2guCisKKyAgICAgICAgKiBlZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lU2VsZWN0aW9uOjpzZWxlY3RBbGwpOiBGaXhlZCB0 aGUgYnVnIHdoZXJlIHNlbGVjdEFsbCBzZWxlY3RzIHRoZSBlbnRpcmUgZG9jdW1lbnQgZXZlbiBp ZiB0aGUgdGV4dAorICAgICAgICBmb3JtIGNvbnRvbCBpcyBmb2N1c2VkIGlmIHRoZSBzZWxlY3Rp b24gaXMgbm9uZSAoaS5lLiBub3QgYW5jaG9yZWQgdG8gYW55IG5vZGUpLgorICAgICAgICAqIGh0 bWwvSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRN TFRleHRGb3JtQ29udHJvbEVsZW1lbnQ6OnNldFNlbGVjdGlvblJhbmdlKTogT25seSB1cGRhdGUg dGhlIGxheW91dCBpZiB0aGUgZWxlbWVudCBpcyBub3QgZm9jdXNlZAorCWFscmVhZHkuIEFsc28g cGFzcyBpbiBEb05vdFNldEZvY3VzIG9wdGlvbiB0byBzZXRTZWxlY3Rpb24gc2luY2Ugd2UgYWxy ZWFkeSBoYXZlIHRoZSBmb2N1cyBpbiB0aGF0IGNhc2UuCisKIDIwMTQtMDItMTMgIEJ5dW5nc2Vv biBTaGluICA8c3VuLnNoaW5AbGdlLmNvbT4KIAogICAgICAgICBbTVNFXSBNb3ZlIFB1YmxpY1VS TE1hbmFnZXIgc2h1dGRvd24gbG9naWMgc28gQWN0aXZlRE9NT2JqZWN0cyBhc3NvY2lhdGVkIHdp dGggcHVibGljIFVSTHMgd29uJ3QgbGVhay4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RnJhbWVTZWxlY3Rpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcv RnJhbWVTZWxlY3Rpb24uY3BwCShyZXZpc2lvbiAxNjQwOTQpCisrKyBTb3VyY2UvV2ViQ29yZS9l ZGl0aW5nL0ZyYW1lU2VsZWN0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTYwNCw3ICsxNjA0 LDggQEAgdm9pZCBGcmFtZVNlbGVjdGlvbjo6c2VsZWN0QWxsKCkKIHsKICAgICBEb2N1bWVudCog ZG9jdW1lbnQgPSBtX2ZyYW1lLT5kb2N1bWVudCgpOwogCi0gICAgaWYgKGRvY3VtZW50LT5mb2N1 c2VkRWxlbWVudCgpICYmIGRvY3VtZW50LT5mb2N1c2VkRWxlbWVudCgpLT5oYXNUYWdOYW1lKHNl bGVjdFRhZykpIHsKKyAgICBFbGVtZW50KiBmb2N1c2VkRWxlbWVudCA9IGRvY3VtZW50LT5mb2N1 c2VkRWxlbWVudCgpOworICAgIGlmIChmb2N1c2VkRWxlbWVudCAmJiBmb2N1c2VkRWxlbWVudC0+ aGFzVGFnTmFtZShzZWxlY3RUYWcpKSB7CiAgICAgICAgIEhUTUxTZWxlY3RFbGVtZW50KiBzZWxl Y3RFbGVtZW50ID0gdG9IVE1MU2VsZWN0RWxlbWVudChkb2N1bWVudC0+Zm9jdXNlZEVsZW1lbnQo KSk7CiAgICAgICAgIGlmIChzZWxlY3RFbGVtZW50LT5jYW5TZWxlY3RBbGwoKSkgewogICAgICAg ICAgICAgc2VsZWN0RWxlbWVudC0+c2VsZWN0QWxsKCk7CkBAIC0xNjIxLDcgKzE2MjIsMTUgQEAg dm9pZCBGcmFtZVNlbGVjdGlvbjo6c2VsZWN0QWxsKCkKICAgICAgICAgZWxzZQogICAgICAgICAg ICAgc2VsZWN0U3RhcnRUYXJnZXQgPSByb290LmdldCgpOwogICAgIH0gZWxzZSB7Ci0gICAgICAg IHJvb3QgPSBtX3NlbGVjdGlvbi5ub25Cb3VuZGFyeVNoYWRvd1RyZWVSb290Tm9kZSgpOworICAg ICAgICBpZiAobV9zZWxlY3Rpb24uaXNOb25lKCkgJiYgZm9jdXNlZEVsZW1lbnQpIHsKKyAgICAg ICAgICAgIGlmIChmb2N1c2VkRWxlbWVudC0+aXNUZXh0Rm9ybUNvbnRyb2woKSkgeworICAgICAg ICAgICAgICAgIHRvSFRNTFRleHRGb3JtQ29udHJvbEVsZW1lbnQoZm9jdXNlZEVsZW1lbnQpLT5z ZWxlY3QoKTsKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICB9CisgICAgICAg ICAgICByb290ID0gZm9jdXNlZEVsZW1lbnQtPm5vbkJvdW5kYXJ5U2hhZG93VHJlZVJvb3ROb2Rl KCk7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgcm9vdCA9IG1fc2VsZWN0aW9uLm5vbkJv dW5kYXJ5U2hhZG93VHJlZVJvb3ROb2RlKCk7CisKICAgICAgICAgaWYgKHJvb3QpCiAgICAgICAg ICAgICBzZWxlY3RTdGFydFRhcmdldCA9IHJvb3QtPnNoYWRvd0hvc3QoKTsKICAgICAgICAgZWxz ZSB7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50 LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxUZXh0Rm9ybUNvbnRy b2xFbGVtZW50LmNwcAkocmV2aXNpb24gMTY0MDk0KQorKysgU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MVGV4dEZvcm1Db250cm9sRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxMywxMSAr MjEzLDYgQEAgdm9pZCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVudDo6ZGlzcGF0YwogICAgIHNl dENoYW5nZWRTaW5jZUxhc3RGb3JtQ29udHJvbENoYW5nZUV2ZW50KGZhbHNlKTsKIH0KIAotc3Rh dGljIGlubGluZSBib29sIGhhc1Zpc2libGVUZXh0QXJlYShSZW5kZXJFbGVtZW50JiB0ZXh0Q29u dHJvbCwgVGV4dENvbnRyb2xJbm5lclRleHRFbGVtZW50KiBpbm5lclRleHQpCi17Ci0gICAgcmV0 dXJuIHRleHRDb250cm9sLnN0eWxlKCkudmlzaWJpbGl0eSgpICE9IEhJRERFTiAmJiBpbm5lclRl eHQgJiYgaW5uZXJUZXh0LT5yZW5kZXJlcigpICYmIGlubmVyVGV4dC0+cmVuZGVyQm94KCktPmhl aWdodCgpOwotfQotCiB2b2lkIEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjpzZXRSYW5nZVRl eHQoY29uc3QgU3RyaW5nJiByZXBsYWNlbWVudCwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7CiAgICAg c2V0UmFuZ2VUZXh0KHJlcGxhY2VtZW50LCBzZWxlY3Rpb25TdGFydCgpLCBzZWxlY3Rpb25FbmQo KSwgU3RyaW5nKCksIGVjKTsKQEAgLTI5MCwxOSArMjg1LDI1IEBAIHZvaWQgSFRNTFRleHRGb3Jt Q29udHJvbEVsZW1lbnQ6OnNldFNlbGUKIAogdm9pZCBIVE1MVGV4dEZvcm1Db250cm9sRWxlbWVu dDo6c2V0U2VsZWN0aW9uUmFuZ2UoaW50IHN0YXJ0LCBpbnQgZW5kLCBUZXh0RmllbGRTZWxlY3Rp b25EaXJlY3Rpb24gZGlyZWN0aW9uKQogewotICAgIGRvY3VtZW50KCkudXBkYXRlTGF5b3V0SWdu b3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7Ci0KLSAgICBpZiAoIXJlbmRlcmVyKCkgfHwgIXJlbmRl cmVyKCktPmlzVGV4dENvbnRyb2woKSkKKyAgICBpZiAoIWlzVGV4dEZvcm1Db250cm9sKCkpCiAg ICAgICAgIHJldHVybjsKIAogICAgIGVuZCA9IHN0ZDo6bWF4KGVuZCwgMCk7CiAgICAgc3RhcnQg PSBzdGQ6Om1pbihzdGQ6Om1heChzdGFydCwgMCksIGVuZCk7CiAKICAgICBUZXh0Q29udHJvbElu bmVyVGV4dEVsZW1lbnQqIGlubmVyVGV4dCA9IGlubmVyVGV4dEVsZW1lbnQoKTsKLSAgICBpZiAo IWhhc1Zpc2libGVUZXh0QXJlYSgqcmVuZGVyZXIoKSwgaW5uZXJUZXh0KSkgewotICAgICAgICBj YWNoZVNlbGVjdGlvbihzdGFydCwgZW5kLCBkaXJlY3Rpb24pOwotICAgICAgICByZXR1cm47Cisg ICAgYm9vbCBoYXNGb2N1cyA9IGRvY3VtZW50KCkuZm9jdXNlZEVsZW1lbnQoKSA9PSB0aGlzOwor ICAgIGlmICghaGFzRm9jdXMgJiYgaW5uZXJUZXh0KSB7CisgICAgICAgIC8vIEZJWE1FOiBSZW1v dmluZyB0aGlzIHN5bmNocm9ub3VzIGxheW91dCByZXF1aXJlcyBmaXhpbmcgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzEyODc5Nz4KKyAgICAgICAgZG9jdW1lbnQoKS51cGRhdGVMYXlvdXRJZ25vcmVQ ZW5kaW5nU3R5bGVzaGVldHMoKTsKKyAgICAgICAgaWYgKFJlbmRlckVsZW1lbnQqIHJlbmRlcmVy VGV4dENvbnRyb2wgPSByZW5kZXJlcigpKSB7CisgICAgICAgICAgICBpZiAocmVuZGVyZXJUZXh0 Q29udHJvbC0+c3R5bGUoKS52aXNpYmlsaXR5KCkgPT0gSElEREVOIHx8ICFpbm5lclRleHQtPnJl bmRlckJveCgpLT5oZWlnaHQoKSkgeworICAgICAgICAgICAgICAgIGNhY2hlU2VsZWN0aW9uKHN0 YXJ0LCBlbmQsIGRpcmVjdGlvbik7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAg ICAgfQorICAgICAgICB9CiAgICAgfQorCiAgICAgUG9zaXRpb24gc3RhcnRQb3NpdGlvbiA9IHBv c2l0aW9uRm9ySW5kZXgoaW5uZXJUZXh0LCBzdGFydCk7CiAgICAgUG9zaXRpb24gZW5kUG9zaXRp b247CiAgICAgaWYgKHN0YXJ0ID09IGVuZCkKQEAgLTMxNyw4ICszMTgsMTEgQEAgdm9pZCBIVE1M VGV4dEZvcm1Db250cm9sRWxlbWVudDo6c2V0U2VsZQogICAgICAgICBuZXdTZWxlY3Rpb24gPSBW aXNpYmxlU2VsZWN0aW9uKHN0YXJ0UG9zaXRpb24sIGVuZFBvc2l0aW9uKTsKICAgICBuZXdTZWxl Y3Rpb24uc2V0SXNEaXJlY3Rpb25hbChkaXJlY3Rpb24gIT0gU2VsZWN0aW9uSGFzTm9EaXJlY3Rp b24pOwogCisgICAgRnJhbWVTZWxlY3Rpb246OlNldFNlbGVjdGlvbk9wdGlvbnMgb3B0aW9ucyA9 IEZyYW1lU2VsZWN0aW9uOjpkZWZhdWx0U2V0U2VsZWN0aW9uT3B0aW9ucygpOworICAgIGlmICho YXNGb2N1cykKKyAgICAgICAgb3B0aW9ucyB8PSBGcmFtZVNlbGVjdGlvbjo6RG9Ob3RTZXRGb2N1 czsKICAgICBpZiAoRnJhbWUqIGZyYW1lID0gZG9jdW1lbnQoKS5mcmFtZSgpKQotICAgICAgICBm cmFtZS0+c2VsZWN0aW9uKCkuc2V0U2VsZWN0aW9uKG5ld1NlbGVjdGlvbik7CisgICAgICAgIGZy YW1lLT5zZWxlY3Rpb24oKS5zZXRTZWxlY3Rpb24obmV3U2VsZWN0aW9uLCBvcHRpb25zKTsKIH0K IAogaW50IEhUTUxUZXh0Rm9ybUNvbnRyb2xFbGVtZW50OjppbmRleEZvclZpc2libGVQb3NpdGlv bihjb25zdCBWaXNpYmxlUG9zaXRpb24mIHBvc2l0aW9uKSBjb25zdAo=