128434 2014-02-07 19:08:59 -0800 [GTK] [CMake] JavaScriptCore crashes in JSC::eval 2014-02-17 16:25:52 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128807 127777 1 mrobinson mrobinson bunhere commit-queue gyuyoung.kim ossy rakuco sergio zherczeg oldest_to_newest 978256 0 mrobinson 2014-02-07 19:08:59 -0800 Looks like we need to extend a fix from other ports. 978259 1 223541 mrobinson 2014-02-07 19:12:51 -0800 Created attachment 223541 Patch 978260 2 mrobinson 2014-02-07 19:15:18 -0800 Zoltan, do you mind reviewing this one? 978482 3 223541 gyuyoung.kim 2014-02-08 18:53:24 -0800 Comment on attachment 223541 Patch efl ews look like wrong alarm. rs=me. 980597 4 223541 mrobinson 2014-02-13 19:30:39 -0800 Comment on attachment 223541 Patch Landed in http://trac.webkit.org/changeset/164090 . 980660 5 223541 ossy 2014-02-13 23:29:17 -0800 Comment on attachment 223541 Patch EWS doesn't lie ... It broke the EFL build as the EWS noticed. I think the fno-maybe-uninitialized option was overwritten. 980747 6 ossy 2014-02-14 04:12:19 -0800 build log: /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Source/JavaScriptCore/runtime/JSArray.cpp: In member function ‘void JSC::JSArray::copyToArguments(JSC::ExecState*, JSC::CallFrame*, uint32_t)’: /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Source/JavaScriptCore/runtime/JSArray.cpp:1543:6: error: ‘value.JSC::JSValue::u.JSC::EncodedValueDescriptor::asInt64’ may be used uninitialized in this function [-Werror=uninitialized] /mnt/buildbot/efl-linux-slave-1/efl-linux-64-release-wk1/build/Source/JavaScriptCore/runtime/JSArray.cpp:1543:6: error: ‘value.JSC::JSValue::u.JSC::EncodedValueDescriptor::asInt64’ may be used uninitialized in this function [-Werror=uninitialized] cc1plus: all warnings being treated as errors The problem was caused by the -fno-tree-dce option. Unfortunately this error message isn't so useful because of inline functions. (line 1543 is the first line of the copyToArguments() function) I played a little bit with this function and it seems the problem is near here: https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/runtime/JSArray.cpp#L1598 With commenting out this line, build works, so the build failure occured in this line. But unfortunately I have no idea how can it be uninitialized. 981276 7 224319 mrobinson 2014-02-16 09:09:05 -0800 Created attachment 224319 Patch 981277 8 mrobinson 2014-02-16 09:11:18 -0800 Okay. I reworked the patch to only apply to the GTK+ port. Thanks for the cleanup Ossy. 981278 9 mrobinson 2014-02-16 09:11:18 -0800 Okay. I reworked the patch to only apply to the GTK+ port. Thanks for the cleanup Ossy. 981485 10 224319 ossy 2014-02-17 08:54:47 -0800 Comment on attachment 224319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=224319&action=review > ChangeLog:9 > + * Source/cmake/OptionsGTK.cmake: Add -fno-omit-frame-pointer to all ports as well > + as -fno-tree-dce, like it is used in the autotools build. -fno-tree-dce is GTK only now, please fix the comment before landing. 981701 11 mrobinson 2014-02-17 16:25:52 -0800 Committed r164257: <http://trac.webkit.org/changeset/164257> 223541 2014-02-07 19:12:51 -0800 2014-02-16 09:09:01 -0800 Patch bug-128434-20140207191251.patch text/plain 2548 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDRhNGMyNmY2MzNmNmI1YmY0NGU1Y2ExYzFlYWFmZWFmNjg3M2ExYzYuLjgwMmM2NzIzNjNlMzNm YTZhZDJlN2NhNTM2ODFmMzIwYjg5NWYyNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0xOSw2ICsxOSwxMiBAQCBlbHNlICgpCiAgICAgc2V0KENPREVfR0VORVJBVE9SX1BSRVBST0NF U1NPUl9XSVRIX0xJTkVNQVJLRVJTICIke0NNQUtFX0NYWF9DT01QSUxFUn0gLUUgLXggYysrIikK IGVuZGlmICgpCiAKKyMgUHVzaCBvZiByYnAgaXMgbmVlZGVkIGFmdGVyIEpTQyBKSVQgdXNlcyBD U3RhY2suIFNlZSBodHRwOi8vd2tidWcuY29tLzEyNzc3Ny4KK2lmIChDTUFLRV9DT01QSUxFUl9J U19HTlVDQyBBTkQgVU5JWCBBTkQgTk9UIEFQUExFKQorICAgIHNldChDTUFLRV9DX0ZMQUdTX1JF TEVBU0UgIi1mbm8tb21pdC1mcmFtZS1wb2ludGVyIC1mbm8tdHJlZS1kY2UgJHtDTUFLRV9DX0ZM QUdTX1JFTEVBU0V9IikKKyAgICBzZXQoQ01BS0VfQ1hYX0ZMQUdTX1JFTEVBU0UgIi1mbm8tb21p dC1mcmFtZS1wb2ludGVyIC1mbm8tdHJlZS1kY2UgJHtDTUFLRV9DWFhfRkxBR1NfUkVMRUFTRX0i KQorZW5kaWYgKCkKKwogc2V0X3Byb3BlcnR5KEdMT0JBTCBQUk9QRVJUWSBVU0VfRk9MREVSUyBP TikKIAogaWYgKENNQUtFX0NPTVBJTEVSX0lTX0dOVUNYWCBPUiAiJHtDTUFLRV9DWFhfQ09NUElM RVJfSUR9IiBTVFJFUVVBTCAiQ2xhbmciKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlv bnNFZmwuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQppbmRleCA4NWU1NjY1 ZDE2ZWU1Y2ZjYzA2YmI5OWY2YzUxYzgwOTk1NzQwMTZjLi5mNjNjMjNiNTdjYTA3Yjk1NzNmZjRh YzljMDJlMDBmZWY4ZjhjMjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5j bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZQpAQCAtMjYyLDEzICsyNjIs NiBAQCBpZiAoQ01BS0VfQ09NUElMRVJfSVNfR05VQ0MgQU5EIFVOSVggQU5EIE5PVCBBUFBMRSkK ICAgICBzZXQoQ01BS0VfU0hBUkVEX0xJTktFUl9GTEFHU19SRUxFQVNFICItV2wsLS1nYy1zZWN0 aW9ucyAke0NNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1NfUkVMRUFTRX0iKQogZW5kaWYgKCkKIAot IyBwdXNoIG9mIHJicCBpcyBuZWVkZWQgYWZ0ZXIgSlNDIEpJVCB1c2VzIENTdGFjawotaWYgKENN QUtFX0NPTVBJTEVSX0lTX0dOVUNDIEFORCBVTklYIEFORCBOT1QgQVBQTEUpCi0gICAgc2V0KENN QUtFX0NfRkxBR1NfUkVMRUFTRSAiLWZuby1vbWl0LWZyYW1lLXBvaW50ZXIgJHtDTUFLRV9DX0ZM QUdTX1JFTEVBU0V9IikKLSAgICBzZXQoQ01BS0VfQ1hYX0ZMQUdTX1JFTEVBU0UgIi1mbm8tb21p dC1mcmFtZS1wb2ludGVyICR7Q01BS0VfQ1hYX0ZMQUdTX1JFTEVBU0V9IikKLWVuZGlmICgpCi0K LQogaWYgKEVOQUJMRV9TUEVMTENIRUNLKQogICAgIGZpbmRfcGFja2FnZShFbmNoYW50IFJFUVVJ UkVEKQogZW5kaWYgKCkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5 NmQwNWM5ZTk3ZWIzYmEzZWY3NzhhNGJkMzgxMjZiZmUwZTY2YmMyLi5mYzA5ZTc4NWZjOTYzNDQ0 ZDdjMTBjYjIyMzc0MGM3OTRmMTU5Njg3IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTQtMDItMDcgIE1hcnRpbiBSb2JpbnNvbiAgPG1y b2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFtDTWFrZV0gSmF2YVNjcmlwdENv cmUgY3Jhc2hlcyBpbiBKU0M6OmV2YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyODQzNAorCisgICAgICAgIEV4dGVuZCBhIGZpeCBmb3IgRUZMIHRv IGFsbCBwb3J0cyB0aGF0IHVzZSBHQ0MuIEFsc28gaW5jbHVkZSBmdXJ0aGVyIGZpeGVzCisgICAg ICAgIHRoYXQgd2VyZSBhcHBsaWVkIG9ubHkgdG8gdGhlIGF1dG90b29scyBidWlsZC4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFr ZS9PcHRpb25zQ29tbW9uLmNtYWtlOiBBZGQgLWZuby1vbWl0LWZyYW1lLXBvaW50ZXIgdG8gYWxs IHBvcnRzIGFzIHdlbGwKKyAgICAgICAgYXMgLWZuby10cmVlLWRjZSwgd2hpY2ggaXMgbmVjZXNz YXJ5IGZvciBHVEsrLgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOiBU aGUgR0NDIGZsYWcgYWRkaXRpb25zIGFyZSBub3cgaW4gdGhlIGNvbW1vbiBvcHRpb25zIGZpbGUu CisKIDIwMTQtMDItMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAog ICAgICAgICBbaU9TXSBtYWtlIHNob3VsZCBidWlsZCBXZWJLaXQyCg== 224319 2014-02-16 09:09:05 -0800 2014-02-17 08:54:47 -0800 Patch bug-128434-20140216090904.patch text/plain 1671 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMTY0MTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDg3Mjcy NTM0MWFhZTJiYzU5MWY3NDEwNGIxZDMxMGE1YWM0OGQ0YWIuLjhiYzE5YzRkYzU2NjQ3Njk0NTgz ZTAyMDgyNjg1NWIxNTdlOWQwY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0yNjYsNiArMjY2 LDEyIEBAIHNldChGT1JXQVJESU5HX0hFQURFUlNfV0VCS0lUMkdUS19ESVIgJHtGT1JXQVJESU5H X0hFQURFUlNfRElSfS93ZWJraXQyZ3RrKQogc2V0KEZPUldBUkRJTkdfSEVBREVSU19XRUJLSVQy R1RLX0VYVEVOU0lPTl9ESVIgJHtGT1JXQVJESU5HX0hFQURFUlNfRElSfS93ZWJraXQyZ3RrLXdl YmV4dGVuc2lvbikKIHNldChTSE9VTERfSU5TVEFMTF9KU19TSEVMTCBPTikKIAorIyBQdXNoIG9m IHJicCBpcyBuZWVkZWQgYWZ0ZXIgSlNDIEpJVCB1c2VzIENTdGFjay4gU2VlIGh0dHA6Ly93a2J1 Zy5jb20vMTI3Nzc3LgoraWYgKENNQUtFX0NPTVBJTEVSX0lTX0dOVUNDIEFORCBVTklYIEFORCBO T1QgQVBQTEUpCisgICAgc2V0KENNQUtFX0NfRkxBR1NfUkVMRUFTRSAiLWZuby1vbWl0LWZyYW1l LXBvaW50ZXIgLWZuby10cmVlLWRjZSAke0NNQUtFX0NfRkxBR1NfUkVMRUFTRX0iKQorICAgIHNl dChDTUFLRV9DWFhfRkxBR1NfUkVMRUFTRSAiLWZuby1vbWl0LWZyYW1lLXBvaW50ZXIgLWZuby10 cmVlLWRjZSAke0NNQUtFX0NYWF9GTEFHU19SRUxFQVNFfSIpCitlbmRpZiAoKQorCiAjIEFkZCBh IHR5cGVsaWIgZmlsZSB0byB0aGUgbGlzdCBvZiBhbGwgdHlwZWxpYiBkZXBlbmRlbmNpZXMuIFRo aXMgbWFrZXMgaXQgZWFzeSB0bwogIyBleHBvc2UgYSAnZ2lyJyB0YXJnZXQgd2l0aCBhbGwgZ29i amVjdC1pbnRyb3NwZWN0aW9uIGZpbGVzLgogbWFjcm8oQUREX1RZUEVMSUIgdHlwZWxpYikKZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzMTMzMTk0NTg3MWI5N2ZhYzI2 ZGRkZThmNmMyZTM2NzRlMWEyZTIyLi4xM2UxNzMwZGQ0ZTYyMzc3NjcwMGM3Mjg2MWY1Yzg5Zjli MmE4ZmM2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMTQtMDItMTYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFtDTWFrZV0gSmF2YVNjcmlwdENvcmUgY3Jhc2hlcyBpbiBKU0M6 OmV2YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy ODQzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6IEFkZCAtZm5vLW9taXQtZnJhbWUtcG9pbnRl ciB0byBhbGwgcG9ydHMgYXMgd2VsbAorICAgICAgICBhcyAtZm5vLXRyZWUtZGNlLCBsaWtlIGl0 IGlzIHVzZWQgaW4gdGhlIGF1dG90b29scyBidWlsZC4KKwogMjAxNC0wMi0xNCAgQ29tbWl0IFF1 ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjE2NDA5MC4K