<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>127920</bug_id>
          
          <creation_ts>2014-01-30 10:29:15 -0800</creation_ts>
          <short_desc>[CSS Shapes] Simplify BasicShapeInset::path</short_desc>
          <delta_ts>2014-02-07 09:37:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>124173</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Zoltan Horvath">zoltan</reporter>
          <assigned_to name="Zoltan Horvath">zoltan</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>glenn</cc>
    
    <cc>kondapallykalyan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>973804</commentid>
    <comment_count>0</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2014-01-30 10:29:15 -0800</bug_when>
    <thetext>I introduced a new static helper function called floatSizeForLengthSize in order to simplify BasicShapeInset::path method.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>973806</commentid>
    <comment_count>1</comment_count>
      <attachid>222683</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2014-01-30 10:31:22 -0800</bug_when>
    <thetext>Created attachment 222683
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976759</commentid>
    <comment_count>2</comment_count>
      <attachid>222683</attachid>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2014-02-05 09:01:30 -0800</bug_when>
    <thetext>Comment on attachment 222683
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976769</commentid>
    <comment_count>3</comment_count>
      <attachid>222683</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-02-05 09:30:08 -0800</bug_when>
    <thetext>Comment on attachment 222683
Patch

Clearing flags on attachment: 222683

Committed r163451: &lt;http://trac.webkit.org/changeset/163451&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>976770</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-02-05 09:30:10 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>222683</attachid>
            <date>2014-01-30 10:31:22 -0800</date>
            <delta_ts>2014-02-05 09:30:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>pathsimple.patch</filename>
            <type>text/plain</type>
            <size>2965</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA5MTNmMTg4Li42MmZiNDllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg
QEAKKzIwMTQtMDEtMzAgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg
ICAgICAgW0NTUyBTaGFwZXNdIFNpbXBsaWZ5IEJhc2ljU2hhcGVJbnNldDo6cGF0aAorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3OTIwCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBpbnRyb2R1Y2VkIGEg
bmV3IHN0YXRpYyBoZWxwZXIgZnVuY3Rpb24gY2FsbGVkIGZsb2F0U2l6ZUZvckxlbmd0aFNpemUK
KyAgICAgICAgaW4gb3JkZXIgdG8gc2ltcGxpZnkgQmFzaWNTaGFwZUluc2V0OjpwYXRoIG1ldGhv
ZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAg
ICAqIHJlbmRlcmluZy9zdHlsZS9CYXNpY1NoYXBlcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpm
bG9hdFNpemVGb3JMZW5ndGhTaXplKTogTmV3IGhlbHBlciBmdW5jdGlvbi4KKyAgICAgICAgKFdl
YkNvcmU6OkJhc2ljU2hhcGVJbnNldDo6cGF0aCk6CisKIDIwMTQtMDEtMzAgIEFudHRpIEtvaXZp
c3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYlBhZ2U6OmRldGVybWluZVByaW1h
cnlTbmFwc2hvdHRlZFBsdWdJbiBpcyBzbG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y
ZW5kZXJpbmcvc3R5bGUvQmFzaWNTaGFwZXMuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n
L3N0eWxlL0Jhc2ljU2hhcGVzLmNwcAppbmRleCBhNWZhYTFiLi5kZGRiZTM3IDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvQmFzaWNTaGFwZXMuY3BwCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9CYXNpY1NoYXBlcy5jcHAKQEAgLTM0NCw2ICsz
NDQsMTIgQEAgUGFzc1JlZlB0cjxCYXNpY1NoYXBlPiBCYXNpY1NoYXBlSW5zZXRSZWN0YW5nbGU6
OmJsZW5kKGNvbnN0IEJhc2ljU2hhcGUqIG90aGVyLAogICAgIHJldHVybiByZXN1bHQucmVsZWFz
ZSgpOwogfQogCitzdGF0aWMgRmxvYXRTaXplIGZsb2F0U2l6ZUZvckxlbmd0aFNpemUoY29uc3Qg
TGVuZ3RoU2l6ZSYgbGVuZ3RoU2l6ZSwgY29uc3QgRmxvYXRSZWN0JiBib3VuZGluZ0JveCkKK3sK
KyAgICByZXR1cm4gRmxvYXRTaXplKGZsb2F0VmFsdWVGb3JMZW5ndGgobGVuZ3RoU2l6ZS53aWR0
aCgpLCBib3VuZGluZ0JveC53aWR0aCgpKSwKKyAgICAgICAgZmxvYXRWYWx1ZUZvckxlbmd0aChs
ZW5ndGhTaXplLmhlaWdodCgpLCBib3VuZGluZ0JveC5oZWlnaHQoKSkpOworfQorCiB2b2lkIEJh
c2ljU2hhcGVJbnNldDo6cGF0aChQYXRoJiBwYXRoLCBjb25zdCBGbG9hdFJlY3QmIGJvdW5kaW5n
Qm94KQogewogICAgIEFTU0VSVChwYXRoLmlzRW1wdHkoKSk7CkBAIC0zNTYsMjIgKzM2MiwxMCBA
QCB2b2lkIEJhc2ljU2hhcGVJbnNldDo6cGF0aChQYXRoJiBwYXRoLCBjb25zdCBGbG9hdFJlY3Qm
IGJvdW5kaW5nQm94KQogICAgICAgICAgICAgc3RkOjptYXg8ZmxvYXQ+KGJvdW5kaW5nQm94Lndp
ZHRoKCkgLSBsZWZ0IC0gZmxvYXRWYWx1ZUZvckxlbmd0aChtX3JpZ2h0LCBib3VuZGluZ0JveC53
aWR0aCgpKSwgMCksCiAgICAgICAgICAgICBzdGQ6Om1heDxmbG9hdD4oYm91bmRpbmdCb3guaGVp
Z2h0KCkgLSB0b3AgLSBmbG9hdFZhbHVlRm9yTGVuZ3RoKG1fYm90dG9tLCBib3VuZGluZ0JveC5o
ZWlnaHQoKSksIDApCiAgICAgICAgICksCi0gICAgICAgIEZsb2F0U2l6ZSgKLSAgICAgICAgICAg
IGZsb2F0VmFsdWVGb3JMZW5ndGgobV90b3BMZWZ0UmFkaXVzLndpZHRoKCksIGJvdW5kaW5nQm94
LndpZHRoKCkpLAotICAgICAgICAgICAgZmxvYXRWYWx1ZUZvckxlbmd0aChtX3RvcExlZnRSYWRp
dXMuaGVpZ2h0KCksIGJvdW5kaW5nQm94LmhlaWdodCgpKQotICAgICAgICApLAotICAgICAgICBG
bG9hdFNpemUoCi0gICAgICAgICAgICBmbG9hdFZhbHVlRm9yTGVuZ3RoKG1fdG9wUmlnaHRSYWRp
dXMud2lkdGgoKSwgYm91bmRpbmdCb3gud2lkdGgoKSksCi0gICAgICAgICAgICBmbG9hdFZhbHVl
Rm9yTGVuZ3RoKG1fdG9wUmlnaHRSYWRpdXMuaGVpZ2h0KCksIGJvdW5kaW5nQm94LmhlaWdodCgp
KQotICAgICAgICApLAotICAgICAgICBGbG9hdFNpemUoCi0gICAgICAgICAgICBmbG9hdFZhbHVl
Rm9yTGVuZ3RoKG1fYm90dG9tTGVmdFJhZGl1cy53aWR0aCgpLCBib3VuZGluZ0JveC53aWR0aCgp
KSwKLSAgICAgICAgICAgIGZsb2F0VmFsdWVGb3JMZW5ndGgobV9ib3R0b21MZWZ0UmFkaXVzLmhl
aWdodCgpLCBib3VuZGluZ0JveC5oZWlnaHQoKSkKLSAgICAgICAgKSwKLSAgICAgICAgRmxvYXRT
aXplKAotICAgICAgICAgICAgZmxvYXRWYWx1ZUZvckxlbmd0aChtX2JvdHRvbVJpZ2h0UmFkaXVz
LndpZHRoKCksIGJvdW5kaW5nQm94LndpZHRoKCkpLAotICAgICAgICAgICAgZmxvYXRWYWx1ZUZv
ckxlbmd0aChtX2JvdHRvbVJpZ2h0UmFkaXVzLmhlaWdodCgpLCBib3VuZGluZ0JveC5oZWlnaHQo
KSkKLSAgICAgICAgKQorICAgICAgICBmbG9hdFNpemVGb3JMZW5ndGhTaXplKG1fdG9wTGVmdFJh
ZGl1cywgYm91bmRpbmdCb3gpLAorICAgICAgICBmbG9hdFNpemVGb3JMZW5ndGhTaXplKG1fdG9w
UmlnaHRSYWRpdXMsIGJvdW5kaW5nQm94KSwKKyAgICAgICAgZmxvYXRTaXplRm9yTGVuZ3RoU2l6
ZShtX2JvdHRvbUxlZnRSYWRpdXMsIGJvdW5kaW5nQm94KSwKKyAgICAgICAgZmxvYXRTaXplRm9y
TGVuZ3RoU2l6ZShtX2JvdHRvbVJpZ2h0UmFkaXVzLCBib3VuZGluZ0JveCkKICAgICApOwogfQog
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>