127841 2014-01-29 09:48:50 -0800 [CSS Shapes] Simplify CSSBasicShapeInset::cssText 2014-02-07 09:38:16 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124173 1 zoltan zoltan commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 973391 0 zoltan 2014-01-29 09:48:50 -0800 I introduced the updateCornerRadiusWidthAndHeight helper function, which makes the code of cssText method clearer. 973393 1 222578 zoltan 2014-01-29 09:50:57 -0800 Created attachment 222578 Patch 976758 2 222578 hyatt 2014-02-05 09:01:06 -0800 Comment on attachment 222578 Patch r=me 976771 3 222578 commit-queue 2014-02-05 09:31:13 -0800 Comment on attachment 222578 Patch Clearing flags on attachment: 222578 Committed r163452: <http://trac.webkit.org/changeset/163452> 976772 4 commit-queue 2014-02-05 09:31:15 -0800 All reviewed patches have been landed. Closing bug. 222578 2014-01-29 09:50:57 -0800 2014-02-05 09:31:13 -0800 Patch csstext.patch text/plain 3782 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlOTM2N2I5Li5lOGJjMTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTQtMDEtMjkgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NTUyBTaGFwZXNdIFNpbXBsaWZ5IENTU0Jhc2ljU2hhcGVJbnNldDo6Y3NzVGV4dAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI3ODQxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBpbnRyb2R1 Y2VkIHRoZSB1cGRhdGVDb3JuZXJSYWRpdXNXaWR0aEFuZEhlaWdodCBoZWxwZXIgZnVuY3Rpb24s IHdoaWNoIG1ha2VzIHRoZSBjb2RlIG9mIGNzc1RleHQgbWV0aG9kIGNsZWFyZXIuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBjc3MvQ1NT QmFzaWNTaGFwZXMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6dXBkYXRlQ29ybmVyUmFkaXVzV2lk dGhBbmRIZWlnaHQpOiBBZGQgaGVscGVyIGZ1bmN0aW9uLgorICAgICAgICAoV2ViQ29yZTo6Q1NT QmFzaWNTaGFwZUluc2V0Ojpjc3NUZXh0KToKKwogMjAxNC0wMS0yOCAgSmVyIE5vYmxlICA8amVy Lm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBIYW5kbGUgTlNVUkxBdXRoZW50aWNh dGlvbk1ldGhvZFNlcnZlclRydXN0IGNoYWxsZW5nZXMgZnJvbSAtcmVzb3VyY2VMb2FkZXI6c2hv dWxkV2FpdEZvclJlc3BvbnNlVG9BdXRoZW50aWNhdGlvbkNoYWxsZW5nZToKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NCYXNpY1NoYXBlcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTQmFzaWNTaGFwZXMuY3BwCmluZGV4IGMzNmY0M2UuLjJkMWIyMjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NCYXNpY1NoYXBlcy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU0Jhc2ljU2hhcGVzLmNwcApAQCAtNDYwLDQ2ICs0NjAsMzIgQEAgc3RhdGljIFN0 cmluZyBidWlsZEluc2V0U3RyaW5nKGNvbnN0IFN0cmluZyYgdG9wLCBjb25zdCBTdHJpbmcmIHJp Z2h0LCBjb25zdCBTdHIKICAgICByZXR1cm4gcmVzdWx0LnRvU3RyaW5nKCk7CiB9CiAKK3N0YXRp YyBpbmxpbmUgdm9pZCB1cGRhdGVDb3JuZXJSYWRpdXNXaWR0aEFuZEhlaWdodChDU1NQcmltaXRp dmVWYWx1ZSogY29ybmVyLCBTdHJpbmcmIHdpZHRoLCBTdHJpbmcmIGhlaWdodCkKK3sKKyAgICBp ZiAoIWNvcm5lcikKKyAgICAgICAgcmV0dXJuOworCisgICAgUGFpciogcmFkaXVzID0gY29ybmVy LT5nZXRQYWlyVmFsdWUoKTsKKyAgICB3aWR0aCA9IHJhZGl1cy0+Zmlyc3QoKSA/IHJhZGl1cy0+ Zmlyc3QoKS0+Y3NzVGV4dCgpIDogU3RyaW5nKCIwIik7CisgICAgaWYgKHJhZGl1cy0+c2Vjb25k KCkpCisgICAgICAgIGhlaWdodCA9IHJhZGl1cy0+c2Vjb25kKCktPmNzc1RleHQoKTsKK30KKwog U3RyaW5nIENTU0Jhc2ljU2hhcGVJbnNldDo6Y3NzVGV4dCgpIGNvbnN0CiB7CiAgICAgU3RyaW5n IHRvcExlZnRSYWRpdXNXaWR0aDsKICAgICBTdHJpbmcgdG9wTGVmdFJhZGl1c0hlaWdodDsKLSAg ICBpZiAodG9wTGVmdFJhZGl1cygpKSB7Ci0gICAgICAgIFBhaXIqIHRvcExlZnRSYWRpdXMgPSBt X3RvcExlZnRSYWRpdXMtPmdldFBhaXJWYWx1ZSgpOwotICAgICAgICB0b3BMZWZ0UmFkaXVzV2lk dGggPSB0b3BMZWZ0UmFkaXVzLT5maXJzdCgpID8gdG9wTGVmdFJhZGl1cy0+Zmlyc3QoKS0+Y3Nz VGV4dCgpIDogU3RyaW5nKCIwIik7Ci0gICAgICAgIGlmICh0b3BMZWZ0UmFkaXVzLT5zZWNvbmQo KSkKLSAgICAgICAgICAgIHRvcExlZnRSYWRpdXNIZWlnaHQgPSB0b3BMZWZ0UmFkaXVzLT5zZWNv bmQoKS0+Y3NzVGV4dCgpOwotICAgIH0KLQogICAgIFN0cmluZyB0b3BSaWdodFJhZGl1c1dpZHRo OwogICAgIFN0cmluZyB0b3BSaWdodFJhZGl1c0hlaWdodDsKLSAgICBpZiAodG9wUmlnaHRSYWRp dXMoKSkgewotICAgICAgICBQYWlyKiB0b3BSaWdodFJhZGl1cyA9IG1fdG9wUmlnaHRSYWRpdXMt PmdldFBhaXJWYWx1ZSgpOwotICAgICAgICBpZiAodG9wUmlnaHRSYWRpdXMtPmZpcnN0KCkpCi0g ICAgICAgICAgICB0b3BSaWdodFJhZGl1c1dpZHRoID0gdG9wUmlnaHRSYWRpdXMtPmZpcnN0KCkt PmNzc1RleHQoKTsKLSAgICAgICAgaWYgKHRvcFJpZ2h0UmFkaXVzLT5zZWNvbmQoKSkKLSAgICAg ICAgICAgIHRvcFJpZ2h0UmFkaXVzSGVpZ2h0ID0gdG9wUmlnaHRSYWRpdXMtPnNlY29uZCgpLT5j c3NUZXh0KCk7Ci0gICAgfQotCiAgICAgU3RyaW5nIGJvdHRvbVJpZ2h0UmFkaXVzV2lkdGg7CiAg ICAgU3RyaW5nIGJvdHRvbVJpZ2h0UmFkaXVzSGVpZ2h0OwotICAgIGlmIChib3R0b21SaWdodFJh ZGl1cygpKSB7Ci0gICAgICAgIFBhaXIqIGJvdHRvbVJpZ2h0UmFkaXVzID0gbV9ib3R0b21SaWdo dFJhZGl1cy0+Z2V0UGFpclZhbHVlKCk7Ci0gICAgICAgIGlmIChib3R0b21SaWdodFJhZGl1cy0+ Zmlyc3QoKSkKLSAgICAgICAgICAgIGJvdHRvbVJpZ2h0UmFkaXVzV2lkdGggPSBib3R0b21SaWdo dFJhZGl1cy0+Zmlyc3QoKS0+Y3NzVGV4dCgpOwotICAgICAgICBpZiAoYm90dG9tUmlnaHRSYWRp dXMtPnNlY29uZCgpKQotICAgICAgICAgICAgYm90dG9tUmlnaHRSYWRpdXNIZWlnaHQgPSBib3R0 b21SaWdodFJhZGl1cy0+c2Vjb25kKCktPmNzc1RleHQoKTsKLSAgICB9Ci0KICAgICBTdHJpbmcg Ym90dG9tTGVmdFJhZGl1c1dpZHRoOwogICAgIFN0cmluZyBib3R0b21MZWZ0UmFkaXVzSGVpZ2h0 OwotICAgIGlmIChib3R0b21MZWZ0UmFkaXVzKCkpIHsKLSAgICAgICAgUGFpciogYm90dG9tTGVm dFJhZGl1cyA9IG1fYm90dG9tTGVmdFJhZGl1cy0+Z2V0UGFpclZhbHVlKCk7Ci0gICAgICAgIGlm IChib3R0b21MZWZ0UmFkaXVzLT5maXJzdCgpKQotICAgICAgICAgICAgYm90dG9tTGVmdFJhZGl1 c1dpZHRoID0gYm90dG9tTGVmdFJhZGl1cy0+Zmlyc3QoKS0+Y3NzVGV4dCgpOwotICAgICAgICBp ZiAoYm90dG9tTGVmdFJhZGl1cy0+c2Vjb25kKCkpCi0gICAgICAgICAgICBib3R0b21MZWZ0UmFk aXVzSGVpZ2h0ID0gYm90dG9tTGVmdFJhZGl1cy0+c2Vjb25kKCktPmNzc1RleHQoKTsKLSAgICB9 CisKKyAgICB1cGRhdGVDb3JuZXJSYWRpdXNXaWR0aEFuZEhlaWdodCh0b3BMZWZ0UmFkaXVzKCks IHRvcExlZnRSYWRpdXNXaWR0aCwgdG9wTGVmdFJhZGl1c0hlaWdodCk7CisgICAgdXBkYXRlQ29y bmVyUmFkaXVzV2lkdGhBbmRIZWlnaHQodG9wUmlnaHRSYWRpdXMoKSwgdG9wUmlnaHRSYWRpdXNX aWR0aCwgdG9wUmlnaHRSYWRpdXNIZWlnaHQpOworICAgIHVwZGF0ZUNvcm5lclJhZGl1c1dpZHRo QW5kSGVpZ2h0KGJvdHRvbVJpZ2h0UmFkaXVzKCksIGJvdHRvbVJpZ2h0UmFkaXVzV2lkdGgsIGJv dHRvbVJpZ2h0UmFkaXVzSGVpZ2h0KTsKKyAgICB1cGRhdGVDb3JuZXJSYWRpdXNXaWR0aEFuZEhl aWdodChib3R0b21MZWZ0UmFkaXVzKCksIGJvdHRvbUxlZnRSYWRpdXNXaWR0aCwgYm90dG9tTGVm dFJhZGl1c0hlaWdodCk7CiAKICAgICByZXR1cm4gYnVpbGRJbnNldFN0cmluZyhtX3RvcCA/IG1f dG9wLT5jc3NUZXh0KCkgOiBTdHJpbmcoKSwKICAgICAgICAgbV9yaWdodCA/IG1fcmlnaHQtPmNz c1RleHQoKSA6IFN0cmluZygpLAo=