127704 2014-01-27 13:27:44 -0800 [CSS Shapes] Remove restriction of negative values for inset parameters 2014-02-07 09:41:10 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124173 1 zoltan zoltan commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 972538 0 zoltan 2014-01-27 13:27:44 -0800 The latest version of CSS Shapes [1] specification doesn't contain any restriction of using negative values for the inset size, so I removed the restriction from the code and added tests for them. [1] http://www.w3.org/TR/css-shapes/ 972541 1 222350 zoltan 2014-01-27 13:34:16 -0800 Created attachment 222350 Patch 972592 2 222350 commit-queue 2014-01-27 14:59:22 -0800 Comment on attachment 222350 Patch Clearing flags on attachment: 222350 Committed r162871: <http://trac.webkit.org/changeset/162871> 972593 3 commit-queue 2014-01-27 14:59:24 -0800 All reviewed patches have been landed. Closing bug. 222350 2014-01-27 13:34:16 -0800 2014-01-27 14:59:22 -0800 Patch insetnegative.patch text/plain 7126 zoltan ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxOGNkMmI2Li5kMjAwYTIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTQtMDEt MjcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBT aGFwZXNdIFJlbW92ZSByZXN0cmljdGlvbiBvZiBuZWdhdGl2ZSB2YWx1ZXMgZm9yIGluc2V0IHBh cmFtZXRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNzcwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLWxlbmd0aHMtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIGZhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy1zaGFwZS1sZW5ndGhzLmh0 bWw6CisKIDIwMTQtMDEtMjcgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4K IAogICAgICAgICBUeXBvIGZpeCBhZnRlciByMTYyODM4LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLWxlbmd0aHMtZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLWxlbmd0aHMt ZXhwZWN0ZWQudHh0CmluZGV4IGYyNWE0NTUuLmVhZTRlZGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy1zaGFwZS1sZW5ndGhzLWV4cGVjdGVkLnR4 dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctc2hhcGUtbGVu Z3Rocy1leHBlY3RlZC50eHQKQEAgLTEwLDYgKzEwLDEwIEBAIFBBU1MgZ2V0U3R5bGVWYWx1ZSgi LXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiY2lyY2xlKC0uNXB4LCArLjVweCwgLjVweCkiKSBpcyAi Y2lyCiBQQVNTIGdldFN0eWxlVmFsdWUoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwgInJlY3Rhbmds ZSgxY20sIDFtbSwgMWluLCAxcHgsIDFwdCwgMXBjKSIpIGlzICJyZWN0YW5nbGUoMWNtLCAxbW0s IDFpbiwgMXB4LCAxcHQsIDFwYykiCiBQQVNTIGdldFN0eWxlVmFsdWUoIi13ZWJraXQtc2hhcGUt aW5zaWRlIiwgImluc2V0LXJlY3RhbmdsZSgxY20sIDFtbSwgMWluLCAxcHgsIDFwdCwgMXBjKSIp IGlzICJpbnNldC1yZWN0YW5nbGUoMWNtLCAxbW0sIDFpbiwgMXB4LCAxcHQsIDFwYykiCiBQQVNT IGdldFN0eWxlVmFsdWUoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImluc2V0KDFjbSAxbW0gMWlu IDFweCByb3VuZCAxcHQgMXBjKSIpIGlzICJpbnNldCgxY20gMW1tIDFpbiAxcHggcm91bmQgMXB0 IDFwYyAxcHQgMXBjIC8gMXB0IDFwYyAxcHQgMXBjKSIKK1BBU1MgZ2V0U3R5bGVWYWx1ZSgiLXdl YmtpdC1zaGFwZS1pbnNpZGUiLCAiaW5zZXQoLTFweCAxcHggMXB4IDFweCByb3VuZCAxcHggMXB4 IDFweCAxcHgpIikgaXMgImluc2V0KC0xcHggMXB4IDFweCAxcHggcm91bmQgMXB4IDFweCAxcHgg MXB4IC8gMXB4IDFweCAxcHggMXB4KSIKK1BBU1MgZ2V0U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFw ZS1pbnNpZGUiLCAiaW5zZXQoMXB4IC0xcHggMXB4IDFweCByb3VuZCAxcHggMXB4IDFweCAxcHgp IikgaXMgImluc2V0KDFweCAtMXB4IDFweCAxcHggcm91bmQgMXB4IDFweCAxcHggMXB4IC8gMXB4 IDFweCAxcHggMXB4KSIKK1BBU1MgZ2V0U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUi LCAiaW5zZXQoMXB4IDFweCAtMXB4IDFweCByb3VuZCAxcHggMXB4IDFweCAxcHgpIikgaXMgImlu c2V0KDFweCAxcHggLTFweCAxcHggcm91bmQgMXB4IDFweCAxcHggMXB4IC8gMXB4IDFweCAxcHgg MXB4KSIKK1BBU1MgZ2V0U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiaW5zZXQo MXB4IDFweCAxcHggLTFweCByb3VuZCAxcHggMXB4IDFweCAxcHgpIikgaXMgImluc2V0KDFweCAx cHggMXB4IC0xcHggcm91bmQgMXB4IDFweCAxcHggMXB4IC8gMXB4IDFweCAxcHggMXB4KSIKIFBB U1MgZ2V0U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiY2lyY2xlKC0xZW0sICsx ZW0sIDFlbSkiKSBpcyAiY2lyY2xlKC0xZW0sIDFlbSwgMWVtKSIKIFBBU1MgZ2V0U3R5bGVWYWx1 ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiY2lyY2xlKC0xLjVlbSwgKzEuNWVtLCAxLjVlbSki KSBpcyAiY2lyY2xlKC0xLjVlbSwgMS41ZW0sIDEuNWVtKSIKIFBBU1MgZ2V0U3R5bGVWYWx1ZSgi LXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiY2lyY2xlKC0uNWVtLCArLjVlbSwgLjVlbSkiKSBpcyAi Y2lyY2xlKC0wLjVlbSwgMC41ZW0sIDAuNWVtKSIKQEAgLTcxLDE0ICs3NSw2IEBAIFBBU1MgZ2V0 U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiaW5zZXQtcmVjdGFuZ2xlKDFjbSwg MW1tLCAtMWluLCAxcHgsCiBQQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFw ZS1pbnNpZGUiLCAiaW5zZXQtcmVjdGFuZ2xlKDFjbSwgMW1tLCAtMWluLCAxcHgsIDFwdCwgMXBj KSIpIGlzICJub25lIgogUEFTUyBnZXRTdHlsZVZhbHVlKCItd2Via2l0LXNoYXBlLWluc2lkZSIs ICJpbnNldC1yZWN0YW5nbGUoMWNtLCAxbW0sIDFpbiwgLTFweCwgMXB0LCAxcGMpIikgaXMgbnVs bAogUEFTUyBnZXRDb21wdXRlZFN0eWxlVmFsdWUoIi13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImlu c2V0LXJlY3RhbmdsZSgxY20sIDFtbSwgMWluLCAtMXB4LCAxcHQsIDFwYykiKSBpcyAibm9uZSIK LVBBU1MgZ2V0U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiaW5zZXQoLTFjbSAx bW0gMWluIDFweCkiKSBpcyBudWxsCi1QQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtp dC1zaGFwZS1pbnNpZGUiLCAiaW5zZXQoLTFjbSAxbW0gMWluIDFweCkiKSBpcyAibm9uZSIKLVBB U1MgZ2V0U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiaW5zZXQoMWNtIC0xbW0g MWluIDFweCkiKSBpcyBudWxsCi1QQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtpdC1z aGFwZS1pbnNpZGUiLCAiaW5zZXQoMWNtIC0xbW0gMWluIDFweCkiKSBpcyAibm9uZSIKLVBBU1Mg Z2V0U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiaW5zZXQoMWNtIDFtbSAtMWlu IDFweCkiKSBpcyBudWxsCi1QQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFw ZS1pbnNpZGUiLCAiaW5zZXQoMWNtIDFtbSAtMWluIDFweCkiKSBpcyAibm9uZSIKLVBBU1MgZ2V0 U3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1pbnNpZGUiLCAiaW5zZXQoMWNtIDFtbSAxaW4gLTFw eCkiKSBpcyBudWxsCi1QQVNTIGdldENvbXB1dGVkU3R5bGVWYWx1ZSgiLXdlYmtpdC1zaGFwZS1p bnNpZGUiLCAiaW5zZXQoMWNtIDFtbSAxaW4gLTFweCkiKSBpcyAibm9uZSIKIFBBU1Mgc3VjY2Vz c2Z1bGx5UGFyc2VkIGlzIHRydWUKIAogVEVTVCBDT01QTEVURQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9zaGFwZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLWxlbmd0aHMuaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3BhcnNpbmcvcGFyc2luZy1zaGFwZS1sZW5ndGhzLmh0bWwK aW5kZXggMmMxYWI4Zi4uYjczZDQ4MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFw ZXMvcGFyc2luZy9wYXJzaW5nLXNoYXBlLWxlbmd0aHMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L3NoYXBlcy9wYXJzaW5nL3BhcnNpbmctc2hhcGUtbGVuZ3Rocy5odG1sCkBAIC00NCw2ICs0 NCwxMCBAQCB0ZXN0U3R5bGVWYWx1ZSgiY2lyY2xlKC0uNXB4LCArLjVweCwgLjVweCkiLCAiY2ly Y2xlKC0wLjVweCwgMC41cHgsIDAuNXB4KSIpOwogdGVzdFN0eWxlVmFsdWUoInJlY3RhbmdsZSgx Y20sIDFtbSwgMWluLCAxcHgsIDFwdCwgMXBjKSIsICJyZWN0YW5nbGUoMWNtLCAxbW0sIDFpbiwg MXB4LCAxcHQsIDFwYykiKTsKIHRlc3RTdHlsZVZhbHVlKCJpbnNldC1yZWN0YW5nbGUoMWNtLCAx bW0sIDFpbiwgMXB4LCAxcHQsIDFwYykiLCAiaW5zZXQtcmVjdGFuZ2xlKDFjbSwgMW1tLCAxaW4s IDFweCwgMXB0LCAxcGMpIik7CiB0ZXN0U3R5bGVWYWx1ZSgiaW5zZXQoMWNtIDFtbSAxaW4gMXB4 IHJvdW5kIDFwdCAxcGMpIiwgImluc2V0KDFjbSAxbW0gMWluIDFweCByb3VuZCAxcHQgMXBjIDFw dCAxcGMgLyAxcHQgMXBjIDFwdCAxcGMpIik7Cit0ZXN0U3R5bGVWYWx1ZSgiaW5zZXQoLTFweCAx cHggMXB4IDFweCByb3VuZCAxcHggMXB4IDFweCAxcHgpIiwgImluc2V0KC0xcHggMXB4IDFweCAx cHggcm91bmQgMXB4IDFweCAxcHggMXB4IC8gMXB4IDFweCAxcHggMXB4KSIpOwordGVzdFN0eWxl VmFsdWUoImluc2V0KDFweCAtMXB4IDFweCAxcHggcm91bmQgMXB4IDFweCAxcHggMXB4KSIsICJp bnNldCgxcHggLTFweCAxcHggMXB4IHJvdW5kIDFweCAxcHggMXB4IDFweCAvIDFweCAxcHggMXB4 IDFweCkiKTsKK3Rlc3RTdHlsZVZhbHVlKCJpbnNldCgxcHggMXB4IC0xcHggMXB4IHJvdW5kIDFw eCAxcHggMXB4IDFweCkiLCAiaW5zZXQoMXB4IDFweCAtMXB4IDFweCByb3VuZCAxcHggMXB4IDFw eCAxcHggLyAxcHggMXB4IDFweCAxcHgpIik7Cit0ZXN0U3R5bGVWYWx1ZSgiaW5zZXQoMXB4IDFw eCAxcHggLTFweCByb3VuZCAxcHggMXB4IDFweCAxcHgpIiwgImluc2V0KDFweCAxcHggMXB4IC0x cHggcm91bmQgMXB4IDFweCAxcHggMXB4IC8gMXB4IDFweCAxcHggMXB4KSIpOwogCiAvLyBmb250 LXJlbGF0aXZlIGxlbmd0aHMgLSBudW1iZXIgc2VyaWFsaXphdGlvbiwgdW5pdHMsIHJlc29sdXRp b24KIHRlc3RTdHlsZVZhbHVlKCJjaXJjbGUoLTFlbSwgKzFlbSwgMWVtKSIsICJjaXJjbGUoLTFl bSwgMWVtLCAxZW0pIik7CkBAIC0xMDcsMTIgKzExMSw2IEBAIHRlc3RJbnZhbGlkVmFsdWUoIi13 ZWJraXQtc2hhcGUtaW5zaWRlIiwgImluc2V0LXJlY3RhbmdsZSgxY20sIC0xbW0sIDFpbiwgMXB4 LCAxCiB0ZXN0SW52YWxpZFZhbHVlKCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJpbnNldC1yZWN0 YW5nbGUoMWNtLCAxbW0sIC0xaW4sIDFweCwgMXB0LCAxcGMpIik7CiB0ZXN0SW52YWxpZFZhbHVl KCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJpbnNldC1yZWN0YW5nbGUoMWNtLCAxbW0sIDFpbiwg LTFweCwgMXB0LCAxcGMpIik7CiAKLS8vIHJlamVjdCBuZWdhdGl2ZSB0b3AsIHJpZ2h0LCBib3R0 b20sIGFuZCBsZWZ0Ci10ZXN0SW52YWxpZFZhbHVlKCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJp bnNldCgtMWNtIDFtbSAxaW4gMXB4KSIpOwotdGVzdEludmFsaWRWYWx1ZSgiLXdlYmtpdC1zaGFw ZS1pbnNpZGUiLCAiaW5zZXQoMWNtIC0xbW0gMWluIDFweCkiKTsKLXRlc3RJbnZhbGlkVmFsdWUo Ii13ZWJraXQtc2hhcGUtaW5zaWRlIiwgImluc2V0KDFjbSAxbW0gLTFpbiAxcHgpIik7Ci10ZXN0 SW52YWxpZFZhbHVlKCItd2Via2l0LXNoYXBlLWluc2lkZSIsICJpbnNldCgxY20gMW1tIDFpbiAt MXB4KSIpOwotCiA8L3NjcmlwdD4KIDxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KIDwvYm9keT4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmOWQ3MTA4Li44 MDQyOTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDEtMjcgIFpvbHRhbiBI b3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW0NTUyBTaGFwZXNdIFJlbW92 ZSByZXN0cmljdGlvbiBvZiBuZWdhdGl2ZSB2YWx1ZXMgZm9yIGluc2V0IHBhcmFtZXRlcnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNzcwNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBsYXRlc3Qg dmVyc2lvbiBvZiBDU1MgU2hhcGVzIChodHRwOi8vd3d3LnczLm9yZy9UUi9jc3Mtc2hhcGVzLykg c3BlY2lmaWNhdGlvbgorICAgICAgICBkb2Vzbid0IGNvbnRhaW4gYW55IHJlc3RyaWN0aW9uIG9m IHVzaW5nIG5lZ2F0aXZlIHZhbHVlcyBmb3IgdGhlIGluc2V0IHNpemluZy4KKyAgICAgICAgSSBy ZW1vdmVkIHRoZSByZXN0cmljdGlvbiBmcm9tIHRoZSBjb2RlIGFuZCBhZGRlZCB0ZXN0aW5nIGZv ciB0aGVtLgorCisgICAgICAgIEV4aXN0aW5nIHRlc3RzIGhhdmUgYmVlbiBleHRlbmRlZCB3aXRo IHRoZSBuZXcgY2FzZXMuCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VCYXNpY1NoYXBlSW5zZXQpOgorCiAyMDE0LTAxLTI3 ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICAqIFdlYkNvcmUu ZXhwLmluOiBBZGQgZXhwb3J0IG5lZWRlZCBmb3IgaU9TLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cAppbmRleCBiNmU1NjkzLi5iYmU4NmYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAt NTM5Myw3ICs1MzkzLDcgQEAgUGFzc1JlZlB0cjxDU1NCYXNpY1NoYXBlPiBDU1NQYXJzZXI6OnBh cnNlQmFzaWNTaGFwZUluc2V0KENTU1BhcnNlclZhbHVlTGlzdCogYXIKICAgICAgICAgICAgIHJl dHVybiBudWxscHRyOwogICAgICAgICB9CiAKLSAgICAgICAgVW5pdHMgdW5pdEZsYWdzID0gRkxl bmd0aCB8IEZQZXJjZW50fCBGTm9uTmVnOworICAgICAgICBVbml0cyB1bml0RmxhZ3MgPSBGTGVu Z3RoIHwgRlBlcmNlbnQ7CiAgICAgICAgIGlmICghdmFsaWRVbml0KGFyZ3VtZW50LCB1bml0Rmxh Z3MpIHx8IGFyZ3VtZW50TnVtYmVyID4gMykKICAgICAgICAgICAgIHJldHVybiBudWxscHRyOwog Cg==