127651 2014-01-26 07:23:06 -0800 [GTK] Web Inspector doesn't work with network process enabled 2014-02-27 03:25:06 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 108832 1 cgarcia webkit-unassigned andersca aperez dpino gustavo svillar oldest_to_newest 972189 0 cgarcia 2014-01-26 07:23:06 -0800 Nothing happens when inspecting an element in MiniBrowser and unit tests time out. ../../Tools/Scripts/run-gtk-tests --verbose --no-xvfb Programs/TestWebKitAPI/WebKit2Gtk/TestInspector*** TEST: Programs/TestWebKitAPI/WebKit2Gtk/TestInspector... (pid=7928) /webkit2/WebKitWebInspector/default: OK /webkit2/WebKitWebInspector/manual-attach-detach: OK /webkit2/WebKitWebInspector/custom-container-destroyed: OK PASS: Programs/TestWebKitAPI/WebKit2Gtk/TestInspector $ WEBKIT_USE_NETWORK_PROCESS=1 ../../Tools/Scripts/run-gtk-tests --verbose --no-xvfb Programs/TestWebKitAPI/WebKit2Gtk/TestInspector TEST: Programs/TestWebKitAPI/WebKit2Gtk/TestInspector... (pid=7832) /webkit2/WebKitWebInspector/default: OK TEST: Programs/TestWebKitAPI/WebKit2Gtk/TestInspector: TIMEOUT 972369 1 cgarcia 2014-01-27 02:24:34 -0800 It doesn't always happen, sometimes it works perfectly so it looks like a race condition somewhere. I've debugged this for a while and I've noticed that when it doesn't work some resources are not loaded, for example InspectorJSBackendCommands.js and InspectorWebBackendCommands.js. Those are inserted in the document by LoadInspectorBackendCommands.js which is always loaded. 985089 2 225351 cgarcia 2014-02-27 02:48:23 -0800 Created attachment 225351 Patch 985091 3 225351 svillar 2014-02-27 03:15:20 -0800 Comment on attachment 225351 Patch Awesome find! 985095 4 cgarcia 2014-02-27 03:25:06 -0800 Committed r164787: <http://trac.webkit.org/changeset/164787> 225351 2014-02-27 02:48:23 -0800 2014-02-27 03:15:19 -0800 Patch wk2-inspector-network-process.diff text/plain 2331 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NTY1MmJmLi4yYjk0ODFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTQtMDItMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdlYiBJbnNwZWN0b3IgZG9lc24ndCB3b3JrIHdpdGggbmV0d29y ayBwcm9jZXNzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNzY1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgdGhlIHdlYiBpbnNwZWN0b3IgbG9hZHMgc28g bWFueSByZXNvdXJjZXMsCisgICAgICAgIHRoYXQgd2hlbiB1c2luZyB0aGUgbmV0d29yayBwcm9j ZXNzLCBhIGxvdCBvZiBJUEMgdHJhZmZpYyBpcworICAgICAgICBnZW5lcmF0ZWQgY2F1c2luZyB0 aGUgc2VuZCBidWZmZXIgb2YgdGhlIHNvY2tldCB0byBiZSBmdWxsLiBXaGVuCisgICAgICAgIHRo YXQgaGFwcGVucyBzZW5kbXNnKCkgZmFpbHMgd2l0aCBFQUdBSU4sIGJlY2F1c2Ugd2UgYXJlIHVz aW5nIG5vbgorICAgICAgICBibG9ja2luZyBzb2NrZXRzLCBhbmQgd2UgYXJlIG5vdCBoYW5kbGlu ZyBuZWl0aGVyIEVBR0FJTiBub3IKKyAgICAgICAgRVdPVUxEQkxPQ0sgZXJyb3JzICh3ZSBkbyB3 aGVuIHJlYWRpbmcgZnJvbSB0aGUgc29ja2V0LCB0aG91Z2gpLgorCisgICAgICAgICogUGxhdGZv cm0vSVBDL3VuaXgvQ29ubmVjdGlvblVuaXguY3BwOgorICAgICAgICAoSVBDOjpDb25uZWN0aW9u OjpyZWFkeVJlYWRIYW5kbGVyKTogQWRkIGEgbG9nIG1lc3NhZ2UgdG8ga25vdworICAgICAgICB3 aGVuIHJlYWRpbmcgZnJvbSB0aGUgc29ja2V0IGZhaWxzIGZvciBhbnkgdW5oYW5kbGVkIGVycm9y LgorICAgICAgICAoSVBDOjpDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlKTogSGFuZGxl IEVBR0FJTiBhbmQKKyAgICAgICAgRVdPVUxEQkxPQ0sgZXJyb3JzIHRvIHRyeSBhZ2FpbiBpbiB0 aG9zZSBjYXNlcy4gQWxzbyBhZGQgYSBsb2cKKyAgICAgICAgbWVzc2FnZSBmb3IgdW5oYW5kbGVk IGVycm9ycy4KKwogMjAxNC0wMi0yNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVtb3ZlIHVubmVlZGVkIG1ldGhvZCB3ZWJraXRX ZWJWaWV3QmFzZVJlcXVlc3RFeGl0RnVsbFNjcmVlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlvblVuaXguY3BwIGIvU291cmNlL1dlYktpdDIv UGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlvblVuaXguY3BwCmluZGV4IDU1Y2E5NGYuLmE1NGNh ZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rp b25Vbml4LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9Db25uZWN0 aW9uVW5peC5jcHAKQEAgLTM1Nyw2ICszNTcsNyBAQCB2b2lkIENvbm5lY3Rpb246OnJlYWR5UmVh ZEhhbmRsZXIoKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICAgICAgLy8gRklY TUU6IEhhbmRsZSBvdGhlciBlcnJvcnMgaGVyZT8KKyAgICAgICAgICAgIFdURkxvZ0Fsd2F5cygi RXJyb3IgcmVjZWl2aW5nIElQQyBtZXNzYWdlOiAlcyIsIHN0cmVycm9yKGVycm5vKSk7CiAgICAg ICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIApAQCAtNTIxLDggKzUyMiwxMSBAQCBib29sIENv bm5lY3Rpb246OnNlbmRPdXRnb2luZ01lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPE1lc3NhZ2VFbmNv ZGVyPiBlbmNvZGVyKQogCiAgICAgaW50IGJ5dGVzU2VudCA9IDA7CiAgICAgd2hpbGUgKChieXRl c1NlbnQgPSBzZW5kbXNnKG1fc29ja2V0RGVzY3JpcHRvciwgJm1lc3NhZ2UsIDApKSA9PSAtMSkg ewotICAgICAgICBpZiAoZXJybm8gIT0gRUlOVFIpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgIGlmIChlcnJubyA9PSBFSU5UUiB8fCBlcnJubyA9PSBFQUdBSU4gfHwgZXJybm8g PT0gRVdPVUxEQkxPQ0spCisgICAgICAgICAgICBjb250aW51ZTsKKworICAgICAgICBXVEZMb2dB bHdheXMoIkVycm9yIHNlbmRpbmcgSVBDIG1lc3NhZ2U6ICVzIiwgc3RyZXJyb3IoZXJybm8pKTsK KyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KICAgICByZXR1cm4gdHJ1ZTsKIH0K